Re: svn commit: r186131 - head/usr.sbin/sysinstall
On Mon, 2008-12-15 at 10:50 -0500, Ken Smith wrote: > On Mon, 2008-12-15 at 15:46 +, Ken Smith wrote: > > Author: kensmith > > Date: Mon Dec 15 15:46:56 2008 > > New Revision: 186131 > > URL: http://svn.freebsd.org/changeset/base/186131 > > > > Log: > > Don't tell the user to remove the media until its actually possible for > > them to remove the media. CDs need to be unmounted before they can be > > removed. > > > > I could have sworn I saw a PR complaining about this a couple months ago > (the PR itself was much older) because that's what reminded me this was > a "problem". I stopped expecting to be able to remove the media before > the reboot started a long time ago... Anyway, I can't seem to find the > PR now. If it does exist and if anyone somehow manages to trip across > it could you assign it to me so I can close it please? It's part of PR bin/29893. The PR contains lots of small bugs with sysinstall, most of which look like they are fixed. It's already assigned to you. Gavin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r186131 - head/usr.sbin/sysinstall
On Mon, Dec 15, 2008 at 1:50 PM, Ken Smith wrote: > On Mon, 2008-12-15 at 15:46 +, Ken Smith wrote: >> Author: kensmith >> Date: Mon Dec 15 15:46:56 2008 >> New Revision: 186131 >> URL: http://svn.freebsd.org/changeset/base/186131 >> >> Log: >> Don't tell the user to remove the media until its actually possible for >> them to remove the media. CDs need to be unmounted before they can be >> removed. >> > > I could have sworn I saw a PR complaining about this a couple months ago > (the PR itself was much older) because that's what reminded me this was > a "problem". I stopped expecting to be able to remove the media before > the reboot started a long time ago... Anyway, I can't seem to find the > PR now. If it does exist and if anyone somehow manages to trip across > it could you assign it to me so I can close it please? Isn't it bin/122522? It is already assigned to you. :-) -- cd /usr/ports/sysutils/life make clean ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r186131 - head/usr.sbin/sysinstall
On Mon, 2008-12-15 at 15:46 +, Ken Smith wrote: > Author: kensmith > Date: Mon Dec 15 15:46:56 2008 > New Revision: 186131 > URL: http://svn.freebsd.org/changeset/base/186131 > > Log: > Don't tell the user to remove the media until its actually possible for > them to remove the media. CDs need to be unmounted before they can be > removed. > I could have sworn I saw a PR complaining about this a couple months ago (the PR itself was much older) because that's what reminded me this was a "problem". I stopped expecting to be able to remove the media before the reboot started a long time ago... Anyway, I can't seem to find the PR now. If it does exist and if anyone somehow manages to trip across it could you assign it to me so I can close it please? -- Ken Smith - From there to here, from here to | kensm...@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r186131 - head/usr.sbin/sysinstall
Author: kensmith
Date: Mon Dec 15 15:46:56 2008
New Revision: 186131
URL: http://svn.freebsd.org/changeset/base/186131
Log:
Don't tell the user to remove the media until its actually possible for
them to remove the media. CDs need to be unmounted before they can be
removed.
Modified:
head/usr.sbin/sysinstall/main.c
head/usr.sbin/sysinstall/system.c
Modified: head/usr.sbin/sysinstall/main.c
==
--- head/usr.sbin/sysinstall/main.c Mon Dec 15 15:42:24 2008
(r186130)
+++ head/usr.sbin/sysinstall/main.c Mon Dec 15 15:46:56 2008
(r186131)
@@ -201,8 +201,7 @@ main(int argc, char **argv)
#if defined(__sparc64__)
|| !msgNoYes("Are you sure you wish to exit? The system will
halt.")
#else
- || !msgNoYes("Are you sure you wish to exit? The system will
reboot\n"
-"(be sure to remove any floppies/CDs/DVDs from the
drives).")
+ || !msgNoYes("Are you sure you wish to exit? The system will
reboot.")
#endif
)
break;
Modified: head/usr.sbin/sysinstall/system.c
==
--- head/usr.sbin/sysinstall/system.c Mon Dec 15 15:42:24 2008
(r186130)
+++ head/usr.sbin/sysinstall/system.c Mon Dec 15 15:46:56 2008
(r186131)
@@ -235,8 +235,13 @@ void
systemShutdown(int status)
{
/* If some media is open, close it down */
-if (status >=0)
- mediaClose();
+if (status >=0) {
+ if (mediaDevice != NULL && mediaDevice->type == DEVICE_TYPE_CDROM) {
+ mediaClose();
+ msgConfirm("Be sure to remove the media from the drive.");
+ } else
+ mediaClose();
+}
/* write out any changes to rc.conf .. */
configRC_conf();
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
