Re: svn commit: r205070 - stable/8/lib/libc/stdio

2010-03-12 Thread Oliver Pinter 
this commit for 7-STABLE?

On 3/12/10, Jaakko Heinonen j...@freebsd.org wrote:
 Author: jh
 Date: Fri Mar 12 06:56:51 2010
 New Revision: 205070
 URL: http://svn.freebsd.org/changeset/base/205070

 Log:
   MFC r204447:

   In _gettemp(), check that the length of the path doesn't exceed
   MAXPATHLEN. Otherwise the path name (or part of it) may not fit to
   carrybuf causing a buffer overflow.

   PR: bin/140228

 Modified:
   stable/8/lib/libc/stdio/mktemp.c
 Directory Properties:
   stable/8/lib/libc/   (props changed)
   stable/8/lib/libc/stdtime/   (props changed)

 Modified: stable/8/lib/libc/stdio/mktemp.c
 ==
 --- stable/8/lib/libc/stdio/mktemp.c  Fri Mar 12 06:31:19 2010
 (r205069)
 +++ stable/8/lib/libc/stdio/mktemp.c  Fri Mar 12 06:56:51 2010
 (r205070)
 @@ -116,6 +116,10 @@ _gettemp(path, doopen, domkdir, slen)

   for (trv = path; *trv != '\0'; ++trv)
   ;
 + if (trv - path = MAXPATHLEN) {
 + errno = ENAMETOOLONG;
 + return (0);
 + }
   trv -= slen;
   suffp = trv;
   --trv;
 ___
 svn-src-sta...@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-stable
 To unsubscribe, send any mail to svn-src-stable-unsubscr...@freebsd.org

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r205070 - stable/8/lib/libc/stdio

2010-03-12 Thread Jaakko Heinonen 
On 2010-03-12, Oliver Pinter wrote:
 this commit for 7-STABLE?

I will commit it to stable/7 sooner or later.

-- 
Jaakko
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

svn commit: r205070 - stable/8/lib/libc/stdio

2010-03-11 Thread Jaakko Heinonen 
Author: jh
Date: Fri Mar 12 06:56:51 2010
New Revision: 205070
URL: http://svn.freebsd.org/changeset/base/205070

Log:
  MFC r204447:
  
  In _gettemp(), check that the length of the path doesn't exceed
  MAXPATHLEN. Otherwise the path name (or part of it) may not fit to
  carrybuf causing a buffer overflow.
  
  PR:   bin/140228

Modified:
  stable/8/lib/libc/stdio/mktemp.c
Directory Properties:
  stable/8/lib/libc/   (props changed)
  stable/8/lib/libc/stdtime/   (props changed)

Modified: stable/8/lib/libc/stdio/mktemp.c
==
--- stable/8/lib/libc/stdio/mktemp.cFri Mar 12 06:31:19 2010
(r205069)
+++ stable/8/lib/libc/stdio/mktemp.cFri Mar 12 06:56:51 2010
(r205070)
@@ -116,6 +116,10 @@ _gettemp(path, doopen, domkdir, slen)
 
for (trv = path; *trv != '\0'; ++trv)
;
+   if (trv - path = MAXPATHLEN) {
+   errno = ENAMETOOLONG;
+   return (0);
+   }
trv -= slen;
suffp = trv;
--trv;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org