Re: svn commit: r243130 - head/etc/root

2012-11-18 Thread Ulrich Spörlein
On Fri, 2012-11-16 at 04:25:35 +, Eitan Adler wrote:
 Author: eadler
 Date: Fri Nov 16 04:25:35 2012
 New Revision: 243130
 URL: http://svnweb.freebsd.org/changeset/base/243130
 
 Log:
   dot.login is supposed to be for bourne shell, not csh
   
   Pointyhat to: me
   Approved by: cperciva (implicit)
 
 Modified:
   head/etc/root/dot.login
 
 Modified: head/etc/root/dot.login
 ==
 --- head/etc/root/dot.login   Fri Nov 16 03:33:34 2012(r243129)
 +++ head/etc/root/dot.login   Fri Nov 16 04:25:35 2012(r243130)
 @@ -6,4 +6,4 @@
  #
  
  # Uncomment to display a random cookie each login:
 -# if ( -x /usr/games/fortune ) /usr/games/fortune -s
 +# [ -x /usr/games/fortune ]  /usr/games/fortune -s

Please add || true to that line, so that when it is enabled and
/usr/games/fortune doesn't exist or is not executable, the shell startup
doesn't return with $? set to something non-zero.

This is especially annoying if you have $? somewhere in your prompt.

Thanks
Uli
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r243130 - head/etc/root

2012-11-16 Thread Eitan Adler
On 16 November 2012 01:04, Jan Beich jbe...@tormail.org wrote:
 Eitan Adler ead...@freebsd.org writes:

 Author: eadler
 Date: Fri Nov 16 04:25:35 2012
 New Revision: 243130
 URL: http://svnweb.freebsd.org/changeset/base/243130

 Log:
   dot.login is supposed to be for bourne shell, not csh

 Can you explain better or point to the reference? sh(1) mentions
 ~/.profile while csh(1) mentions ~/.login for commands executed
 once per login.

ugh. I was really tired when looking at this. I was right the first
time.  Sorry for the noise.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


svn commit: r243130 - head/etc/root

2012-11-15 Thread Eitan Adler
Author: eadler
Date: Fri Nov 16 04:25:35 2012
New Revision: 243130
URL: http://svnweb.freebsd.org/changeset/base/243130

Log:
  dot.login is supposed to be for bourne shell, not csh
  
  Pointyhat to: me
  Approved by: cperciva (implicit)

Modified:
  head/etc/root/dot.login

Modified: head/etc/root/dot.login
==
--- head/etc/root/dot.login Fri Nov 16 03:33:34 2012(r243129)
+++ head/etc/root/dot.login Fri Nov 16 04:25:35 2012(r243130)
@@ -6,4 +6,4 @@
 #
 
 # Uncomment to display a random cookie each login:
-# if ( -x /usr/games/fortune ) /usr/games/fortune -s
+# [ -x /usr/games/fortune ]  /usr/games/fortune -s
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r243130 - head/etc/root

2012-11-15 Thread Jan Beich
Eitan Adler ead...@freebsd.org writes:

 Author: eadler
 Date: Fri Nov 16 04:25:35 2012
 New Revision: 243130
 URL: http://svnweb.freebsd.org/changeset/base/243130

 Log:
   dot.login is supposed to be for bourne shell, not csh

Can you explain better or point to the reference? sh(1) mentions
~/.profile while csh(1) mentions ~/.login for commands executed
once per login.

Besides, dot.login is not installed WITHOUT_TCSH.

  # /usr/src/etc/Makefile
  .if ${MK_TCSH} != no
  cd ${.CURDIR}/root; \
  ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \
  dot.cshrc ${DESTDIR}/root/.cshrc; \
  ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \
  dot.login ${DESTDIR}/root/.login; \
  rm -f ${DESTDIR}/.cshrc; \
  ln ${DESTDIR}/root/.cshrc ${DESTDIR}/.cshrc
  .endif

   
   Pointyhat to: me
   Approved by: cperciva (implicit)

 Modified:
   head/etc/root/dot.login

 Modified: head/etc/root/dot.login
 ==
 --- head/etc/root/dot.login   Fri Nov 16 03:33:34 2012(r243129)
 +++ head/etc/root/dot.login   Fri Nov 16 04:25:35 2012(r243130)
 @@ -6,4 +6,4 @@
  #
  
  # Uncomment to display a random cookie each login:
 -# if ( -x /usr/games/fortune ) /usr/games/fortune -s
 +# [ -x /usr/games/fortune ]  /usr/games/fortune -s
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org