Re: svn commit: r263355 - stable/9/sys/kern

2014-03-27 Thread Alexey Dokuchaev
On Thu, Mar 27, 2014 at 02:11:55PM +0200, Konstantin Belousov wrote:
> On Thu, Mar 27, 2014 at 09:40:03AM +, Alexey Dokuchaev wrote:
> > On Wed, Mar 19, 2014 at 12:57:13PM +, Konstantin Belousov wrote:
> > > New Revision: 263355
> > > URL: http://svnweb.freebsd.org/changeset/base/263355
> > > 
> > > Log:
> > >   MFC r263079:
> > >   The auio structure is only initialized when the vnode is symlink,
> > >   avoid reading from it otherwise.
> > 
> > Is it applicable to stable/8, and if yes, can it be MFCed?  Thanks,
> 
> This is purely cosmetic commit.  Why do you insist on merging ?

I am not insisting. ;-)  I thought it was more than purely cosmetic, but
then again, I did not study the code thoroughly enough.

Sorry for the noise.  My reason in that stable/8 is going to be EOLed
sooner or later, yet I'm not willing to move from it since 9.x/10.x do
not bring anything important for me except the bloat, and 8.x works
perfectly fine.  That said, I'm trying to get seemingly important bug
fixes MFCed, albeit sometimes I overestimate their importance and/or
relevance.

./danfe
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r263355 - stable/9/sys/kern

2014-03-27 Thread Konstantin Belousov
On Thu, Mar 27, 2014 at 09:40:03AM +, Alexey Dokuchaev wrote:
> On Wed, Mar 19, 2014 at 12:57:13PM +, Konstantin Belousov wrote:
> > New Revision: 263355
> > URL: http://svnweb.freebsd.org/changeset/base/263355
> > 
> > Log:
> >   MFC r263079:
> >   The auio structure is only initialized when the vnode is symlink,
> >   avoid reading from it otherwise.
> 
> Is it applicable to stable/8, and if yes, can it be MFCed?  Thanks,

This is purely cosmetic commit.  Why do you insist on merging ?


pgptjdo4h8ZQz.pgp
Description: PGP signature


Re: svn commit: r263355 - stable/9/sys/kern

2014-03-27 Thread Alexey Dokuchaev
On Wed, Mar 19, 2014 at 12:57:13PM +, Konstantin Belousov wrote:
> New Revision: 263355
> URL: http://svnweb.freebsd.org/changeset/base/263355
> 
> Log:
>   MFC r263079:
>   The auio structure is only initialized when the vnode is symlink,
>   avoid reading from it otherwise.

Is it applicable to stable/8, and if yes, can it be MFCed?  Thanks,

./danfe
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r263355 - stable/9/sys/kern

2014-03-19 Thread Konstantin Belousov
Author: kib
Date: Wed Mar 19 12:57:13 2014
New Revision: 263355
URL: http://svnweb.freebsd.org/changeset/base/263355

Log:
  MFC r263079:
  The auio structure is only initialized when the vnode is symlink,
  avoid reading from it otherwise.

Modified:
  stable/9/sys/kern/vfs_syscalls.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/kern/vfs_syscalls.c
==
--- stable/9/sys/kern/vfs_syscalls.cWed Mar 19 12:55:57 2014
(r263354)
+++ stable/9/sys/kern/vfs_syscalls.cWed Mar 19 12:57:13 2014
(r263355)
@@ -2719,10 +2719,10 @@ kern_readlinkat(struct thread *td, int f
auio.uio_td = td;
auio.uio_resid = count;
error = VOP_READLINK(vp, &auio, td->td_ucred);
+   td->td_retval[0] = count - auio.uio_resid;
}
vput(vp);
VFS_UNLOCK_GIANT(vfslocked);
-   td->td_retval[0] = count - auio.uio_resid;
return (error);
 }
 
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"