Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target

[yaneurabeya]

On Aug 4, 2014, at 10:24 AM, Garrett Cooper  wrote:

> Hi Bruce!
> 
> On Aug 4, 2014, at 2:23 AM, Bruce Evans  wrote:
> 
>> On Mon, 4 Aug 2014, Garrett Cooper wrote:
> 
> ...
> 
>> I hope this fixes the error found by "make checkdpadd".  -L is too hard
>> for the current "make checkdpadd" to handle.  Old aout versions worked
>> better using linker support.  They also found the correct dependencies
>> (on shared libraries for shared linkage, not the pseudo-dependenci on
>> the hard-coded static librar for shared linkage).
> 
> Thank you for the reminder about that make target :).

And this still fails make checkdpadd :(...

>> "make checkdpadd" currently finds broken 143 makefiles with inconsistent
>> DPADD.  62 of them are for clang.  Most of these misuse DPADD for
>> headers.  The next largest source of errors is libtermcapw.  LIBTERMCAPW
>> is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
>> LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
>> DPADD were unnecessary with the old aout versions.
> 
> I’ll file bugs for any issues I find and work with maintainers to fix the 
> issues. I’m not sure if you’re on Phabricator, but I’d be happy to add you to 
> the reviews if you would like.

I filed bugs for the bulk majority of the issues I found with make checkdpadd.

Thanks!
-Garrett


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target

[Garrett Cooper]

Hi Bruce!

On Aug 4, 2014, at 2:23 AM, Bruce Evans  wrote:

> On Mon, 4 Aug 2014, Garrett Cooper wrote:

...

> I hope this fixes the error found by "make checkdpadd".  -L is too hard
> for the current "make checkdpadd" to handle.  Old aout versions worked
> better using linker support.  They also found the correct dependencies
> (on shared libraries for shared linkage, not the pseudo-dependenci on
> the hard-coded static librar for shared linkage).

Thank you for the reminder about that make target :).

> "make checkdpadd" currently finds broken 143 makefiles with inconsistent
> DPADD.  62 of them are for clang.  Most of these misuse DPADD for
> headers.  The next largest source of errors is libtermcapw.  LIBTERMCAPW
> is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
> LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
> DPADD were unnecessary with the old aout versions.

I’ll file bugs for any issues I find and work with maintainers to fix the 
issues. I’m not sure if you’re on Phabricator, but I’d be happy to add you to 
the reviews if you would like.
Thanks!
-Garrett


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target

[Bruce Evans]

On Mon, 4 Aug 2014, Garrett Cooper wrote:


Log:
 Move a -L argument from LDADD to LDFLAGS

 Phabric: D525 (part of a larger patch)

 Reviewed by: jmmv
 Approved by: jmmv (co-mentor)

Modified:
 head/libexec/rtld-elf/tests/target/Makefile

Modified: head/libexec/rtld-elf/tests/target/Makefile
==
--- head/libexec/rtld-elf/tests/target/Makefile Mon Aug  4 05:46:10 2014
(r269504)
+++ head/libexec/rtld-elf/tests/target/Makefile Mon Aug  4 05:49:13 2014
(r269505)
@@ -6,7 +6,9 @@ PROG=   target
BINDIR= ${TESTSBASE}${TESTSDIR}/libexec/rtld-elf

CFLAGS+=-I${.CURDIR}/../libpythagoras
-LDADD= -L${.OBJDIR}/../libpythagoras -lpythagoras
+
+LDFLAGS+=  -L${.OBJDIR}/../libpythagoras
+LDADD= -lpythagoras

MAN=


I hope this fixes the error found by "make checkdpadd".  -L is too hard
for the current "make checkdpadd" to handle.  Old aout versions worked
better using linker support.  They also found the correct dependencies
(on shared libraries for shared linkage, not the pseudo-dependenci on
the hard-coded static librar for shared linkage).

"make checkdpadd" currently finds broken 143 makefiles with inconsistent
DPADD.  62 of them are for clang.  Most of these misuse DPADD for
headers.  The next largest source of errors is libtermcapw.  LIBTERMCAPW
is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
DPADD were unnecessary with the old aout versions.

Bruce
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r269505 - head/libexec/rtld-elf/tests/target

[Garrett Cooper]

Author: ngie
Date: Mon Aug  4 05:49:13 2014
New Revision: 269505
URL: http://svnweb.freebsd.org/changeset/base/269505

Log:
  Move a -L argument from LDADD to LDFLAGS
  
  Phabric: D525 (part of a larger patch)
  
  Reviewed by: jmmv
  Approved by: jmmv (co-mentor)

Modified:
  head/libexec/rtld-elf/tests/target/Makefile

Modified: head/libexec/rtld-elf/tests/target/Makefile
==
--- head/libexec/rtld-elf/tests/target/Makefile Mon Aug  4 05:46:10 2014
(r269504)
+++ head/libexec/rtld-elf/tests/target/Makefile Mon Aug  4 05:49:13 2014
(r269505)
@@ -6,7 +6,9 @@ PROG=   target
 BINDIR=${TESTSBASE}${TESTSDIR}/libexec/rtld-elf
 
 CFLAGS+=   -I${.CURDIR}/../libpythagoras
-LDADD= -L${.OBJDIR}/../libpythagoras -lpythagoras
+
+LDFLAGS+=  -L${.OBJDIR}/../libpythagoras
+LDADD= -lpythagoras
 
 MAN=
 
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"