Re: svn commit: r286410 - in head: etc etc/rc.d sys/dev/ath sys/dev/ath/ath_rate/sample sys/dev/bwi sys/dev/bwn sys/dev/if_ndis sys/dev/ipw sys/dev/iwi sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/ral
Hi, Since I'm on holidays, and I really don't have time to tidy up after this commit: * everyone can commit to the wireless stuff to get this fixed up and working; * if hostap mode stays broken for more than 4 days, I'm going to back all the changes out. (And yes, gleb did run this stuff by me a few times and I'm okay with the general theory of this, but we'll see how it pans out. I'm totally fine with completely rolling it back if it's a failed experiment.) -adrian ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r286410 - in head: etc etc/rc.d sys/dev/ath sys/dev/ath/ath_rate/sample sys/dev/bwi sys/dev/bwn sys/dev/if_ndis sys/dev/ipw sys/dev/iwi sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/ral
Gleb, At least for ath(4), TDMA doesn't work, ATH_DEBUG doesn't work, IFF_DUMPPKTS() has an extra brace, and that's what I found in the last 15 minutes of this, compiling one of the many MIPS kernels that we have in -HEAD for hardware that people are using. I left this up to you to run to completion, and a single 'make universe' would've found these issues. Instead, head is actively broken leading into a weekend. There's at least one report of a hostapd problem, which indicates that hostapd didn't get enough testing. I don't know if adhoc or monitor mode got tested. I understand if mesh/tdma weren't tested - I'm slowly chipping away at those. I've just reverted the work. Let's get all the debug stuff more thoroughly tested and get more exposure before we try to land this again. If there are any follow up issues with the reversion then please poke me and I'll get it tested. Thanks, -adrian On 7 August 2015 at 16:49, Adrian Chadd adrian.ch...@gmail.com wrote: Hi, Since I'm on holidays, and I really don't have time to tidy up after this commit: * everyone can commit to the wireless stuff to get this fixed up and working; * if hostap mode stays broken for more than 4 days, I'm going to back all the changes out. (And yes, gleb did run this stuff by me a few times and I'm okay with the general theory of this, but we'll see how it pans out. I'm totally fine with completely rolling it back if it's a failed experiment.) -adrian ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r286410 - in head: etc etc/rc.d sys/dev/ath sys/dev/ath/ath_rate/sample sys/dev/bwi sys/dev/bwn sys/dev/if_ndis sys/dev/ipw sys/dev/iwi sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/ral
On 07 Aug 2015, at 11:43 , Gleb Smirnoff gleb...@freebsd.org wrote: Author: glebius Date: Fri Aug 7 11:43:14 2015 New Revision: 286410 URL: https://svnweb.freebsd.org/changeset/base/286410 At least ath is still not compiling. Just to give you a short selection of what I am seeing. I would have expected a change like this to pass universe before commit .. sparc64.LINT /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath.c: In function 'ath_intr': /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath.c:2106: error: 'ifp' undeclared (first use in this function) /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath.c:2106: error: (Each undeclared identifier is reported only once /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath.c:2106: error: for each function it appears in.) bmake: stopped in /scratch/tmp/bz/head.svn/sys/modules/ath /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath_tdma.c: In function 'ath_tdma_config': /scratch/tmp/bz/head.svn/sys/modules/ath/../../dev/ath/if_ath_tdma.c:253: error: ‘struct ath_softc' has no member named 'sc_ifp' mips.AP135 /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c: In function 'ath_resume': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:1901: error: 'ifp' undeclared (first use in this function) /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:1901: error: (Each undeclared identifier is reported only once /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:1901: error: for each function it appears in.) /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c: In function 'ath_intr': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:2106: error: 'ifp' undeclared (first use in this function) /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c: In function 'ath_init': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:2428: error: 'ifp' undeclared (first use in this function) /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c: In function 'ath_tx_processq': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath.c:4571: error: 'struct ath_softc' has no member named 'sc_ifp' --- if_ath.o --- *** [if_ath.o] Error code 1 bmake: stopped in /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/AP135 /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c: In function 'ath_tx_normal_setup': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:1789: error: expected ')' before 'ieee80211_dump_pkt' /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:1838: error: expected expression before '}' token cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:1546: warning: unused variable 'ah' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c: In function 'ath_tx_raw_start': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2207: error: expected ')' before 'ieee80211_dump_pkt' /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2328: error: expected expression before '}' token /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2090: warning: unused variable 'queue_to_head' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2085: warning: unused variable 'ds' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2077: warning: unused variable 'vap' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2076: warning: unused variable 'ah' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:2075: warning: unused variable 'ic' [-Wunused-variable] /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c: In function 'ath_tx_tid_drain_print': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:3804: error: expected ')' before 'ieee80211_dump_pkt' /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tx.c:3807: error: expected expression before '}' token --- if_ath_tx.o --- *** [if_ath_tx.o] Error code 1 bmake: stopped in /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/AP135 /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tdma.c: In function 'ath_tdma_config': /scratch/tmp/bz/head.svn/sys/dev/ath/if_ath_tdma.c:253: error: 'struct ath_softc' has no member named 'sc_ifp' --- if_ath_tdma.o --- ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r286410 - in head: etc etc/rc.d sys/dev/ath sys/dev/ath/ath_rate/sample sys/dev/bwi sys/dev/bwn sys/dev/if_ndis sys/dev/ipw sys/dev/iwi sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/ral ...
Author: glebius Date: Fri Aug 7 11:43:14 2015 New Revision: 286410 URL: https://svnweb.freebsd.org/changeset/base/286410 Log: Change KPI of how device drivers that provide wireless connectivity interact with the net80211 stack. Historical background: originally wireless devices created an interface, just like Ethernet devices do. Name of an interface matched the name of the driver that created. Later, wlan(4) layer was introduced, and the wlanX interfaces become the actual interface, leaving original ones as a parent interface of wlanX. Kernelwise, the KPI between net80211 layer and a driver became a mix of methods that pass a pointer to struct ifnet as identifier and methods that pass pointer to struct ieee80211com. From user point of view, the parent interface just hangs on in the ifconfig list, and user can't do anything useful with it. Now, the struct ifnet goes away. The struct ieee80211com is the only KPI between a device driver and net80211. Details: - The struct ieee80211com is embedded into drivers softc. - Packets are sent via new ic_transmit method, which is very much like the previous if_transmit. - Bringing parent up/down is done via new ic_parent method, which notifies driver about any changes: number of wlan(4) interfaces, number of them in promisc or allmulti state. - Device specific ioctls (if any) are received on new ic_ioctl method. - Packets/errors accounting are done by the stack. In certain cases, when driver experiences errors and can not attribute them to any specific interface, driver updates ic_oerrors or ic_ierrors counters. Details on interface configuration with new world order: - A sequence of commands needed to bring up wireless DOESNT change. - /etc/rc.conf parameters DON'T change. - List of devices that can be used to create wlan(4) interfaces is now provided by net.wlan.devices sysctl. Most drivers in this change were converted by me, except of wpi(4), that was done by Andriy Voskoboinyk. Big thanks to Kevin Lo for testing changes to at least 8 drivers. Thanks to Olivier Cochard, gjb@, mmoll@, op@ and lev@, who also participated in testing. Details here: https://wiki.freebsd.org/projects/ifnet/net80211 Still, drivers: ndis, wtap, mwl, ipw, bwn, wi, upgt, uath were not tested. Changes to mwl, ipw, bwn, wi, upgt are trivial and chances of problems are low. The wtap wasn't compilable even before this change. But the ndis driver is complex, and it is likely to be broken with this commit. Help with testing and debugging it is appreciated. Differential Revision:D2655, D2740 Sponsored by: Nginx, Inc. Sponsored by: Netflix Modified: head/etc/network.subr head/etc/rc.d/netif head/sys/dev/ath/ath_rate/sample/sample.c head/sys/dev/ath/ath_rate/sample/sample.h head/sys/dev/ath/if_ath.c head/sys/dev/ath/if_ath_beacon.c head/sys/dev/ath/if_ath_debug.h head/sys/dev/ath/if_ath_keycache.c head/sys/dev/ath/if_ath_misc.h head/sys/dev/ath/if_ath_rx.c head/sys/dev/ath/if_ath_rx_edma.c head/sys/dev/ath/if_ath_sysctl.c head/sys/dev/ath/if_ath_tdma.c head/sys/dev/ath/if_ath_tx.c head/sys/dev/ath/if_ath_tx_edma.c head/sys/dev/ath/if_athvar.h head/sys/dev/bwi/bwimac.c head/sys/dev/bwi/bwiphy.c head/sys/dev/bwi/bwirf.c head/sys/dev/bwi/if_bwi.c head/sys/dev/bwi/if_bwivar.h head/sys/dev/bwn/if_bwn.c head/sys/dev/bwn/if_bwnvar.h head/sys/dev/if_ndis/if_ndis.c head/sys/dev/if_ndis/if_ndisvar.h head/sys/dev/ipw/if_ipw.c head/sys/dev/ipw/if_ipwvar.h head/sys/dev/iwi/if_iwi.c head/sys/dev/iwi/if_iwivar.h head/sys/dev/iwn/if_iwn.c head/sys/dev/iwn/if_iwnvar.h head/sys/dev/malo/if_malo.c head/sys/dev/malo/if_malo.h head/sys/dev/mwl/if_mwl.c head/sys/dev/mwl/if_mwl_pci.c head/sys/dev/mwl/if_mwlvar.h head/sys/dev/ral/if_ral_pci.c head/sys/dev/ral/rt2560.c head/sys/dev/ral/rt2560var.h head/sys/dev/ral/rt2661.c head/sys/dev/ral/rt2661var.h head/sys/dev/ral/rt2860.c head/sys/dev/ral/rt2860var.h head/sys/dev/usb/wlan/if_rsu.c head/sys/dev/usb/wlan/if_rsureg.h head/sys/dev/usb/wlan/if_rum.c head/sys/dev/usb/wlan/if_rumvar.h head/sys/dev/usb/wlan/if_run.c head/sys/dev/usb/wlan/if_runvar.h head/sys/dev/usb/wlan/if_uath.c head/sys/dev/usb/wlan/if_uathvar.h head/sys/dev/usb/wlan/if_upgt.c head/sys/dev/usb/wlan/if_upgtvar.h head/sys/dev/usb/wlan/if_ural.c head/sys/dev/usb/wlan/if_uralvar.h head/sys/dev/usb/wlan/if_urtw.c head/sys/dev/usb/wlan/if_urtwn.c head/sys/dev/usb/wlan/if_urtwnreg.h head/sys/dev/usb/wlan/if_urtwvar.h head/sys/dev/usb/wlan/if_zyd.c head/sys/dev/usb/wlan/if_zydreg.h head/sys/dev/wi/if_wi.c head/sys/dev/wi/if_wi_pccard.c head/sys/dev/wi/if_wi_pci.c head/sys/dev/wi/if_wivar.h head/sys/dev/wpi/if_wpi.c head/sys/dev/wpi/if_wpivar.h head/sys/dev/wtap/if_wtap.c head/sys/dev/wtap/if_wtapvar.h head/sys/net80211/ieee80211.c
