Re: svn commit: r289728 - head

[Julian Elischer]

On 10/22/15 9:45 AM, Alexander Kabaev wrote:

On Thu, 22 Oct 2015 01:32:11 + (UTC)
Ed Maste  wrote:


Author: emaste
Date: Thu Oct 22 01:32:11 2015
New Revision: 289728
URL: https://svnweb.freebsd.org/changeset/base/289728

Log:
   Warn that NOCLEAN is deprecated - use NO_CLEAN instead
   
   NO_CLEAN has been the correct spelling for over a decade.


Modified:
   head/Makefile.inc1

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Thu Oct 22 01:04:31 2015
(r289727) +++ head/Makefile.inc1Thu Oct 22 01:32:11
2015(r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
  .endif# !empty(SUBDIR_OVERRIDE)
  
  .if defined(NOCLEAN)

+.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
  NO_CLEAN= ${NOCLEAN}
  .endif
  .if defined(NO_CLEANDIR)


For some definition of 'correct'. It definitely is not for those who
have -DNOCLEAN wired into their finger memory and above mentioned
decade did not help with that any.

I think some of the common spellings were left as is in great NO_
revolution for a reason and I see no reason why the sudden itch to
change that.


I can never remember what the right way for WITHXXX WITH_XXX DO_XXX   
NO_XXX  NOXXX  etc. is..  I go look for examples every time.



___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r289728 - head

[Ed Maste]

Author: emaste
Date: Thu Oct 22 01:32:11 2015
New Revision: 289728
URL: https://svnweb.freebsd.org/changeset/base/289728

Log:
  Warn that NOCLEAN is deprecated - use NO_CLEAN instead
  
  NO_CLEAN has been the correct spelling for over a decade.

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Thu Oct 22 01:04:31 2015(r289727)
+++ head/Makefile.inc1  Thu Oct 22 01:32:11 2015(r289728)
@@ -128,6 +128,7 @@ SUBDIR+=etc
 .endif # !empty(SUBDIR_OVERRIDE)
 
 .if defined(NOCLEAN)
+.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
 NO_CLEAN=  ${NOCLEAN}
 .endif
 .if defined(NO_CLEANDIR)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r289728 - head

[Alexander Kabaev]

On Thu, 22 Oct 2015 01:32:11 + (UTC)
Ed Maste  wrote:

> Author: emaste
> Date: Thu Oct 22 01:32:11 2015
> New Revision: 289728
> URL: https://svnweb.freebsd.org/changeset/base/289728
> 
> Log:
>   Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>   
>   NO_CLEAN has been the correct spelling for over a decade.
> 
> Modified:
>   head/Makefile.inc1
> 
> Modified: head/Makefile.inc1
> ==
> --- head/Makefile.inc1Thu Oct 22 01:04:31 2015
> (r289727) +++ head/Makefile.inc1  Thu Oct 22 01:32:11
> 2015  (r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>  .endif   # !empty(SUBDIR_OVERRIDE)
>  
>  .if defined(NOCLEAN)
> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>  NO_CLEAN=${NOCLEAN}
>  .endif
>  .if defined(NO_CLEANDIR)


For some definition of 'correct'. It definitely is not for those who
have -DNOCLEAN wired into their finger memory and above mentioned
decade did not help with that any.

I think some of the common spellings were left as is in great NO_
revolution for a reason and I see no reason why the sudden itch to
change that.

-- 
Alexander Kabaev


pgp68o2od3uyS.pgp
Description: OpenPGP digital signature

Re: svn commit: r289728 - head

[Bryan Drewery]

On 10/21/2015 6:45 PM, Alexander Kabaev wrote:
> On Thu, 22 Oct 2015 01:32:11 + (UTC)
> Ed Maste  wrote:
> 
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>>
>> Log:
>>   Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>>   
>>   NO_CLEAN has been the correct spelling for over a decade.
>>
>> Modified:
>>   head/Makefile.inc1
>>
>> Modified: head/Makefile.inc1
>> ==
>> --- head/Makefile.inc1   Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1 Thu Oct 22 01:32:11
>> 2015 (r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>>  .endif  # !empty(SUBDIR_OVERRIDE)
>>  
>>  .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>>  NO_CLEAN=   ${NOCLEAN}
>>  .endif
>>  .if defined(NO_CLEANDIR)
> 
> 
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
> 
> I think some of the common spellings were left as is in great NO_
> revolution for a reason and I see no reason why the sudden itch to
> change that.
> 

I almost argued against this before it went in but I felt I had outspent
my negative credits for the week on gdb->lldb and login(1) and stayed
out of it.

I've always been confused on the "correct" spelling and usually go open
the file to see which is supported. I do see both being suggested often
though and see that at work our build configuration does use -DNOCLEAN
too (not my change). This is something that doesn't seem worth hassling
people over.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r289728 - head

[Ed Maste]

On 22 October 2015 at 01:59, Bryan Drewery  wrote:
>
> I've always been confused on the "correct" spelling and usually go open
> the file to see which is supported.

That's why I added it, to avoid developers having to go spelunking in
search of the "correct" spelling. I'll track down mentions of NOCLEAN
in our docs etc., and see what other reports come out as a result of
this warning.

If it turns out to be an annoyance I'm happy to revert and add a
comment instead, but would like to leave it for a while.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r289728 - head

[Bryan Drewery]

On 10/21/2015 7:08 PM, Ed Maste wrote:
> On 22 October 2015 at 01:59, Bryan Drewery  wrote:
>>
>> I've always been confused on the "correct" spelling and usually go open
>> the file to see which is supported.
> 
> That's why I added it, to avoid developers having to go spelunking in
> search of the "correct" spelling. I'll track down mentions of NOCLEAN
> in our docs etc., and see what other reports come out as a result of
> this warning.
> 
> If it turns out to be an annoyance I'm happy to revert and add a
> comment instead, but would like to leave it for a while.
> 

Sounds reasonable.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r289728 - head

[Warner Losh]

> On Oct 21, 2015, at 7:45 PM, Alexander Kabaev  wrote:
> 
> On Thu, 22 Oct 2015 01:32:11 + (UTC)
> Ed Maste  wrote:
> 
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>> 
>> Log:
>>  Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>> 
>>  NO_CLEAN has been the correct spelling for over a decade.
>> 
>> Modified:
>>  head/Makefile.inc1
>> 
>> Modified: head/Makefile.inc1
>> ==
>> --- head/Makefile.inc1   Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1 Thu Oct 22 01:32:11
>> 2015 (r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>> .endif   # !empty(SUBDIR_OVERRIDE)
>> 
>> .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>> NO_CLEAN=${NOCLEAN}
>> .endif
>> .if defined(NO_CLEANDIR)
> 
> 
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
> 
> I think some of the common spellings were left as is in great NO_
> revolution for a reason and I see no reason why the sudden itch to
> change that.

There’s no sudden itch. We’ve been scratching at the NO_ irritants
in the tree regularly for years, and more regularly in the past year. I
eliminated a boatload of them 9 months ago. More will go away.

Warner


signature.asc
Description: Message signed with OpenPGP using GPGMail