Re: svn commit: r296476 - head/sys/netinet/tcp_stacks

[Glen Barber]

On Tue, Mar 08, 2016 at 12:16:34AM +, Randall Stewart wrote:
> Author: rrs
> Date: Tue Mar  8 00:16:34 2016
> New Revision: 296476
> URL: https://svnweb.freebsd.org/changeset/base/296476
> 
> Log:
>   Fix a sneaky bug where we were missing an extern
>   to get the rxt threshold.. and thus created our own defaulted to 0 :-(
>   

This appears to break gcc build.

 cc1: warnings being treated as errors
 /usr/src/sys/modules/tcp/fastpath/../../../netinet/tcp_stacks/fastpath.c:127: 
warning: redundant redeclaration of 'tcprexmtthresh' [-Wredundant-decls]
 /usr/src/sys/netinet/cc/cc.h:60: warning: previous declaration of 
'tcprexmtthresh' was here
 --- fastpath.o ---
 *** [fastpath.o] Error code 1

Glen



signature.asc
Description: PGP signature

svn commit: r296476 - head/sys/netinet/tcp_stacks

[Randall Stewart]

Author: rrs
Date: Tue Mar  8 00:16:34 2016
New Revision: 296476
URL: https://svnweb.freebsd.org/changeset/base/296476

Log:
  Fix a sneaky bug where we were missing an extern
  to get the rxt threshold.. and thus created our own defaulted to 0 :-(
  
  Sponsored by: Netflix Inc

Modified:
  head/sys/netinet/tcp_stacks/fastpath.c

Modified: head/sys/netinet/tcp_stacks/fastpath.c
==
--- head/sys/netinet/tcp_stacks/fastpath.c  Tue Mar  8 00:14:14 2016
(r296475)
+++ head/sys/netinet/tcp_stacks/fastpath.c  Tue Mar  8 00:16:34 2016
(r296476)
@@ -124,7 +124,7 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
-const int tcprexmtthresh;
+extern const int tcprexmtthresh;
 
 VNET_DECLARE(int, tcp_autorcvbuf_inc);
 #defineV_tcp_autorcvbuf_incVNET(tcp_autorcvbuf_inc)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"