Author: truckman
Date: Thu May 12 08:55:57 2016
New Revision: 299525
URL: https://svnweb.freebsd.org/changeset/base/299525
Log:
Use strlcpy() instead of strncpy() when copying date and subj
to ensure that these are properly NUL terminated since they
are passed to printf().
Reported by: Coverity
CID: 974770
MFH: 1 week
Modified:
head/usr.bin/msgs/msgs.c
Modified: head/usr.bin/msgs/msgs.c
==============================================================================
--- head/usr.bin/msgs/msgs.c Thu May 12 08:41:22 2016 (r299524)
+++ head/usr.bin/msgs/msgs.c Thu May 12 08:55:57 2016 (r299525)
@@ -855,7 +855,7 @@ gfrsub(FILE *infile)
}
*ptr = '\0';
if (*(in = nxtfld(in)))
- strncpy(date, in, sizeof date);
+ strlcpy(date, in, sizeof date);
else {
date[0] = '\n';
date[1] = '\0';
@@ -886,7 +886,7 @@ gfrsub(FILE *infile)
if (!seensubj && strncmp(inbuf, "Subj", 4)==0) {
seensubj = YES;
frompos = ftello(infile);
- strncpy(subj, nxtfld(inbuf), sizeof subj);
+ strlcpy(subj, nxtfld(inbuf), sizeof subj);
}
}
if (!blankline)
@@ -899,7 +899,7 @@ gfrsub(FILE *infile)
/*
* for possible use with Mail
*/
- strncpy(subj, "(No Subject)\n", sizeof subj);
+ strlcpy(subj, "(No Subject)\n", sizeof subj);
}
static char *
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
