Re: svn commit: r300999 - in head: include lib/libc/db/man
2016-05-30 19:55 GMT+02:00 Pedro Giffuni: > IMHO, just before a new release is the perfect time to break the ABI, and > POSIX > is a good reason to do it. I thought about it a bit more and switching this over to size_t will only cause breakage on 64-bit big endian platforms. On 32-bit systems this would have no effect. On 64-bit little endian systems, we'd still load the bottom four bytes, which is all right. We could use symbol versioning to deal with this, but I don't think it's worth the effort. I've sent out a code review to both of you: https://reviews.freebsd.org/D6660 If anyone wants to share their thoughts on the proposed change, feel free to leave a comment. I'll hold off for a couple of days before submitting. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r300999 - in head: include lib/libc/db/man
On 30/05/2016 11:52, Ed Schouten wrote: Author: ed Date: Mon May 30 16:52:23 2016 New Revision: 300999 URL: https://svnweb.freebsd.org/changeset/base/300999 Log: Let dbm's datum::dptr use the right type. According to POSIX, it should use void *, not char *. Unfortunately, the dsize field also has the wrong type. It should be size_t. I'm not going to change that, as that will break the ABI. IMHO, just before a new release is the perfect time to break the ABI, and POSIX is a good reason to do it. Pedro. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r300999 - in head: include lib/libc/db/man
Author: ed Date: Mon May 30 16:52:23 2016 New Revision: 300999 URL: https://svnweb.freebsd.org/changeset/base/300999 Log: Let dbm's datum::dptr use the right type. According to POSIX, it should use void *, not char *. Unfortunately, the dsize field also has the wrong type. It should be size_t. I'm not going to change that, as that will break the ABI. Reviewed by: pfg Differential Revision:https://reviews.freebsd.org/D6647 Modified: head/include/ndbm.h head/lib/libc/db/man/dbm.3 Modified: head/include/ndbm.h == --- head/include/ndbm.h Mon May 30 16:26:34 2016(r300998) +++ head/include/ndbm.h Mon May 30 16:52:23 2016(r300999) @@ -52,7 +52,7 @@ #defineDBM_SUFFIX ".db" typedef struct { - char *dptr; + void *dptr; int dsize; } datum; Modified: head/lib/libc/db/man/dbm.3 == --- head/lib/libc/db/man/dbm.3 Mon May 30 16:26:34 2016(r300998) +++ head/lib/libc/db/man/dbm.3 Mon May 30 16:52:23 2016(r300999) @@ -15,7 +15,7 @@ .\" .\" $FreeBSD$ .\" -.Dd February 19, 2015 +.Dd May 30, 2016 .Dt DBM 3 .Os .Sh NAME @@ -66,7 +66,7 @@ is declared in .In ndbm.h : .Bd -literal typedef struct { - char *dptr; + void *dptr; int dsize; } datum; .Ed ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"