Re: svn commit: r312780 - head/contrib/ipfilter/tools

[Cy Schubert]

In message <20170126144726.u1...@besplex.bde.org>, Bruce Evans writes:
> On Wed, 25 Jan 2017, Cy Schubert wrote:
> 
> > Log:
> >  Remove extraneous blank line.
> >
> >  MFC after: 2 weeks
> >  X-MFC with:r312777
> >
> > Modified:
> >  head/contrib/ipfilter/tools/ipf.c
> >
> > Modified: head/contrib/ipfilter/tools/ipf.c
> > ===
> ===
> > --- head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:06 2017
>   (r312779)
> > +++ head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:23 2017
>   (r312780)
> > @@ -409,7 +409,6 @@ static void flushfilter(arg, filter)
> > closedevice();
> > return;
> > }
> > -
> > else if (strchr(arg, 'i') || strchr(arg, 'I'))
> > fl = FR_INQUE;
> > else if (strchr(arg, 'o') || strchr(arg, 'O'))
> 
> Now it has 1 extra instead of 2 extra.
> 
> Most code in ipfilter, and all in the old version of this file, uses the
> normal KNF style of cuddling elses.

I suppose I should compress it one more. I'll do that after the change 
window I'm working on tonight (if it's not too late and I'm not too tired).

Thanks for your input Bruce.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r312780 - head/contrib/ipfilter/tools

[Bruce Evans]

On Wed, 25 Jan 2017, Cy Schubert wrote:


Log:
 Remove extraneous blank line.

 MFC after: 2 weeks
 X-MFC with:r312777

Modified:
 head/contrib/ipfilter/tools/ipf.c

Modified: head/contrib/ipfilter/tools/ipf.c
==
--- head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:06 2017
(r312779)
+++ head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:23 2017
(r312780)
@@ -409,7 +409,6 @@ static void flushfilter(arg, filter)
closedevice();
return;
}
-
else if (strchr(arg, 'i') || strchr(arg, 'I'))
fl = FR_INQUE;
else if (strchr(arg, 'o') || strchr(arg, 'O'))


Now it has 1 extra instead of 2 extra.

Most code in ipfilter, and all in the old version of this file, uses the
normal KNF style of cuddling elses.

Bruce
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r312780 - head/contrib/ipfilter/tools

[Cy Schubert]

Author: cy
Date: Wed Jan 25 20:59:23 2017
New Revision: 312780
URL: https://svnweb.freebsd.org/changeset/base/312780

Log:
  Remove extraneous blank line.
  
  MFC after:2 weeks
  X-MFC with:   r312777

Modified:
  head/contrib/ipfilter/tools/ipf.c

Modified: head/contrib/ipfilter/tools/ipf.c
==
--- head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:06 2017
(r312779)
+++ head/contrib/ipfilter/tools/ipf.c   Wed Jan 25 20:59:23 2017
(r312780)
@@ -409,7 +409,6 @@ static void flushfilter(arg, filter)
closedevice();
return;
}
-
else if (strchr(arg, 'i') || strchr(arg, 'I'))
fl = FR_INQUE;
else if (strchr(arg, 'o') || strchr(arg, 'O'))
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"