Re: svn commit: r314145 - in head/sys/dev/vxge: . vxgehal
On 02/23/17 13:16, John Baldwin wrote: On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote: Author: pfg Date: Thu Feb 23 16:10:15 2017 New Revision: 314145 URL: https://svnweb.freebsd.org/changeset/base/314145 Log: dev/vxe: double assignments. Fix some suspicious code, likely caused by excessive copy-pasting. Found with: coccinelle (da.cocci) MFC after:2 weeks Modified: head/sys/dev/vxge/vxge.c head/sys/dev/vxge/vxgehal/vxgehal-config.c Modified: head/sys/dev/vxge/vxge.c == --- head/sys/dev/vxge/vxge.cThu Feb 23 16:07:45 2017(r314144) +++ head/sys/dev/vxge/vxge.cThu Feb 23 16:10:15 2017(r314145) @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev) vpath->rx_ticks = ticks; vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; - vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; + vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; Probably use VXGE_DEFAULT_TI_RTIMER_VAL instead of TI? Good catch, fixed as r314158. Thanks! Pedro. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r314145 - in head/sys/dev/vxge: . vxgehal
On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Feb 23 16:10:15 2017 > New Revision: 314145 > URL: https://svnweb.freebsd.org/changeset/base/314145 > > Log: > dev/vxe: double assignments. > > Fix some suspicious code, likely caused by excessive copy-pasting. > > Found with: coccinelle (da.cocci) > MFC after: 2 weeks > > Modified: > head/sys/dev/vxge/vxge.c > head/sys/dev/vxge/vxgehal/vxgehal-config.c > > Modified: head/sys/dev/vxge/vxge.c > == > --- head/sys/dev/vxge/vxge.c Thu Feb 23 16:07:45 2017(r314144) > +++ head/sys/dev/vxge/vxge.c Thu Feb 23 16:10:15 2017(r314145) > @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev) > vpath->rx_ticks = ticks; > > vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; > - vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; > + vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; Probably use VXGE_DEFAULT_TI_RTIMER_VAL instead of TI? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r314145 - in head/sys/dev/vxge: . vxgehal
Author: pfg Date: Thu Feb 23 16:10:15 2017 New Revision: 314145 URL: https://svnweb.freebsd.org/changeset/base/314145 Log: dev/vxe: double assignments. Fix some suspicious code, likely caused by excessive copy-pasting. Found with: coccinelle (da.cocci) MFC after:2 weeks Modified: head/sys/dev/vxge/vxge.c head/sys/dev/vxge/vxgehal/vxgehal-config.c Modified: head/sys/dev/vxge/vxge.c == --- head/sys/dev/vxge/vxge.cThu Feb 23 16:07:45 2017(r314144) +++ head/sys/dev/vxge/vxge.cThu Feb 23 16:10:15 2017(r314145) @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev) vpath->rx_ticks = ticks; vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; - vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; + vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; vpath->tx_intr_coalesce = vdev->config.intr_coalesce; vpath->rx_intr_coalesce = vdev->config.intr_coalesce; Modified: head/sys/dev/vxge/vxgehal/vxgehal-config.c == --- head/sys/dev/vxge/vxgehal/vxgehal-config.c Thu Feb 23 16:07:45 2017 (r314144) +++ head/sys/dev/vxge/vxgehal/vxgehal-config.c Thu Feb 23 16:10:15 2017 (r314145) @@ -2312,9 +2312,6 @@ vxge_hal_device_config_default_get( port_config->host_chosen_aggr = VXGE_HAL_LAG_PORT_HOST_CHOSEN_AGGR_DEFAULT; - port_config->host_chosen_aggr = - VXGE_HAL_LAG_PORT_HOST_CHOSEN_AGGR_DEFAULT; - port_config->discard_unknown_slow_proto = VXGE_HAL_LAG_PORT_DISCARD_UNKNOWN_SLOW_PROTO_DEFAULT; @@ -2348,9 +2345,6 @@ vxge_hal_device_config_default_get( port_config->actor_distributing = VXGE_HAL_LAG_PORT_ACTOR_DISTRIBUTING_DEFAULT; - port_config->actor_distributing = - VXGE_HAL_LAG_PORT_ACTOR_DISTRIBUTING_DEFAULT; - port_config->actor_defaulted = VXGE_HAL_LAG_PORT_ACTOR_DEFAULTED_DEFAULT; @@ -2387,9 +2381,6 @@ vxge_hal_device_config_default_get( port_config->partner_distributing = VXGE_HAL_LAG_PORT_PARTNER_DISTRIBUTING_DEFAULT; - port_config->partner_distributing = - VXGE_HAL_LAG_PORT_PARTNER_DISTRIBUTING_DEFAULT; - port_config->partner_defaulted = VXGE_HAL_LAG_PORT_PARTNER_DEFAULTED_DEFAULT; ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
