Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

This fixes the amd64 LINT build error, but not the others. I'm looking at
fixing the others now.

On Tue, May 2, 2017 at 3:58 PM Eric Joyner  wrote:

> I fixed the netmap build for amd64 at least with r317711. I'm running a
> tinderbox build on it now, though, so I'll see if that fixes it.
>
> On Fri, Apr 28, 2017 at 1:40 PM Eric Joyner  wrote:
>
>> I notified Jeb (the original patch submitter) about that netmap symbol
>> issue, but we've both been distracted with other development. I'll work on
>> updating it.
>>
>> - Eric
>>
>> On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper 
>> wrote:
>>
>>> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste  wrote:
>>> > On 15 March 2017 at 17:20, Eric Joyner  wrote:
>>> >> Author: erj
>>> >> Date: Wed Mar 15 21:20:17 2017
>>> >> New Revision: 315333
>>> >> URL: https://svnweb.freebsd.org/changeset/base/315333
>>> >>
>>> >> Log:
>>> >>   ixgbe(4): Update to 3.2.11-k
>>> >
>>> > This broke tinderbox on many architectures:
>>> >
>>> > ia64 GENERIC and powerpc GENERIC64:
>>> >
>>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
>>> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
>>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
>>> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]
>>> >
>>> > sparc64 LINT:
>>> >
>>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
>>> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
>>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
>>> > previous declaration of 'ix_crcstrip' was here
>>> >
>>> > amd64 LINT:
>>> >
>>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
>>> > multiple definition of `ixgbe_netmap_attach'
>>> >
>>> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
>>> > first defined here
>>>
>>> Hi Ed,
>>>
>>> It has to do with netmap(4) refactoring on head not being backported,
>>> in combination with ixgbe/ix being MFCed in a refactored state back to
>>> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on
>>> ^/stable/10 -- I tried starting this work and failed because I lacked
>>> the hardware to test this out with).
>>>
>>> This has been known to be broken for almost two months -- a surgical
>>> fix should probably be applied to do what's required to make the
>>> symbol appear in the appropriate places, since this basically was a
>>> direct commit to ^/stable/10 in some regards.
>>>
>>> Thanks,
>>> -Ngie
>>>
>>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

I fixed the netmap build for amd64 at least with r317711. I'm running a
tinderbox build on it now, though, so I'll see if that fixes it.

On Fri, Apr 28, 2017 at 1:40 PM Eric Joyner  wrote:

> I notified Jeb (the original patch submitter) about that netmap symbol
> issue, but we've both been distracted with other development. I'll work on
> updating it.
>
> - Eric
>
> On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper  wrote:
>
>> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste  wrote:
>> > On 15 March 2017 at 17:20, Eric Joyner  wrote:
>> >> Author: erj
>> >> Date: Wed Mar 15 21:20:17 2017
>> >> New Revision: 315333
>> >> URL: https://svnweb.freebsd.org/changeset/base/315333
>> >>
>> >> Log:
>> >>   ixgbe(4): Update to 3.2.11-k
>> >
>> > This broke tinderbox on many architectures:
>> >
>> > ia64 GENERIC and powerpc GENERIC64:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
>> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
>> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]
>> >
>> > sparc64 LINT:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
>> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
>> > previous declaration of 'ix_crcstrip' was here
>> >
>> > amd64 LINT:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
>> > multiple definition of `ixgbe_netmap_attach'
>> >
>> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
>> > first defined here
>>
>> Hi Ed,
>>
>> It has to do with netmap(4) refactoring on head not being backported,
>> in combination with ixgbe/ix being MFCed in a refactored state back to
>> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on
>> ^/stable/10 -- I tried starting this work and failed because I lacked
>> the hardware to test this out with).
>>
>> This has been known to be broken for almost two months -- a surgical
>> fix should probably be applied to do what's required to make the
>> symbol appear in the appropriate places, since this basically was a
>> direct commit to ^/stable/10 in some regards.
>>
>> Thanks,
>> -Ngie
>>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

I notified Jeb (the original patch submitter) about that netmap symbol
issue, but we've both been distracted with other development. I'll work on
updating it.

- Eric

On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper  wrote:

> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste  wrote:
> > On 15 March 2017 at 17:20, Eric Joyner  wrote:
> >> Author: erj
> >> Date: Wed Mar 15 21:20:17 2017
> >> New Revision: 315333
> >> URL: https://svnweb.freebsd.org/changeset/base/315333
> >>
> >> Log:
> >>   ixgbe(4): Update to 3.2.11-k
> >
> > This broke tinderbox on many architectures:
> >
> > ia64 GENERIC and powerpc GENERIC64:
> >
> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]
> >
> > sparc64 LINT:
> >
> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
> > previous declaration of 'ix_crcstrip' was here
> >
> > amd64 LINT:
> >
> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
> > multiple definition of `ixgbe_netmap_attach'
> >
> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
> > first defined here
>
> Hi Ed,
>
> It has to do with netmap(4) refactoring on head not being backported,
> in combination with ixgbe/ix being MFCed in a refactored state back to
> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on
> ^/stable/10 -- I tried starting this work and failed because I lacked
> the hardware to test this out with).
>
> This has been known to be broken for almost two months -- a surgical
> fix should probably be applied to do what's required to make the
> symbol appear in the appropriate places, since this basically was a
> direct commit to ^/stable/10 in some regards.
>
> Thanks,
> -Ngie
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Ngie Cooper]

On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste  wrote:
> On 15 March 2017 at 17:20, Eric Joyner  wrote:
>> Author: erj
>> Date: Wed Mar 15 21:20:17 2017
>> New Revision: 315333
>> URL: https://svnweb.freebsd.org/changeset/base/315333
>>
>> Log:
>>   ixgbe(4): Update to 3.2.11-k
>
> This broke tinderbox on many architectures:
>
> ia64 GENERIC and powerpc GENERIC64:
>
> /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
> previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
> /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
> previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]
>
> sparc64 LINT:
>
> /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
> redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
> /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
> previous declaration of 'ix_crcstrip' was here
>
> amd64 LINT:
>
> /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
> multiple definition of `ixgbe_netmap_attach'
> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
> first defined here

Hi Ed,

It has to do with netmap(4) refactoring on head not being backported,
in combination with ixgbe/ix being MFCed in a refactored state back to
^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on
^/stable/10 -- I tried starting this work and failed because I lacked
the hardware to test this out with).

This has been known to be broken for almost two months -- a surgical
fix should probably be applied to do what's required to make the
symbol appear in the appropriate places, since this basically was a
direct commit to ^/stable/10 in some regards.

Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Ed Maste]

On 15 March 2017 at 17:20, Eric Joyner  wrote:
> Author: erj
> Date: Wed Mar 15 21:20:17 2017
> New Revision: 315333
> URL: https://svnweb.freebsd.org/changeset/base/315333
>
> Log:
>   ixgbe(4): Update to 3.2.11-k

This broke tinderbox on many architectures:

ia64 GENERIC and powerpc GENERIC64:

/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]

sparc64 LINT:

/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
previous declaration of 'ix_crcstrip' was here

amd64 LINT:

/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
multiple definition of `ixgbe_netmap_attach'
ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
first defined here
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Cy Schubert]

In message 
, Eric Joyner writes:
> --94eb2c18d092e83944054adda9b6
> Content-Type: text/plain; charset=UTF-8
> 
> Ngie,
> 
> It looks like what's in the commit is using an older version of netmap, so
> I think we're okay on that. I think the naming conflict may be due to
> splitting the ixgbe_netmap.c file into ixgbe_netmap.c & ixv_netmap.c, and
> not having the functions in ixv_netmap.c be renamed.
> 
> I don't think the PCI_IOV stuff should be left in there. At least from what
> I gathered in D4767, it's probably abandoned in 10.
> 
> Cy,
> 
> Are you using special options in your kernel config file? "device ixgbe"
> works for me, so I want to assume you have "device netmap" in your config
> file, unless you're missing INET and/or INET6.
> 
> On Thu, Mar 16, 2017 at 10:00 AM Ngie Cooper  wrote:
> 
> >
> > On Mar 16, 2017, at 09:29, Eric Joyner  wrote:
> >
> > I'm looking at this now.
> >
> > Cy, in your case it sounds like the "device ixgbe" option is broken. I'll
> > work on getting that to build again.

I don't specify ix or ixgbe. Just a module build. I disconnected it to 
allow the build to finish.

> >
> > The LINT build error looks like a netmap linking issue (probably due to
> > Jeb moving/copying netmap stuff into the driver folder), so that'll be fun
> > to root cause.
> >
> >
> > Hi Eric,
> > One sandtrap to be aware of is r307394 (and corresponding commits)
> > not being MFCed, along with a host of PCI-IOV, etc changes not being easily
> > backportable.
> > If you can, look for commits from me in the r29 series citing
> > ix_crcstrip (it was a backport from bz@ to unbreak LINT on head that also
> > fixed stable/10).
> > Thanks!
> > -Ngie
> >
> > On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert 
> > wrote:
> >
> > In message <62c8a9fd-1ee0-4def-a28a-843dbbb49...@gmail.com>, "Ngie Cooper
> > (yane
> > urabeya)" writes:
> > >
> > > --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5
> > > Content-Transfer-Encoding: quoted-printable
> > > Content-Type: text/plain;
> > >   charset=us-ascii
> > >
> > >
> > > > On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> > > >=20
> > > > Author: erj
> > > > Date: Wed Mar 15 21:20:17 2017
> > > > New Revision: 315333
> > > > URL: https://svnweb.freebsd.org/changeset/base/315333
> > > >=20
> > > > Log:
> > > >  ixgbe(4): Update to 3.2.11-k
> > > >=20
> > > >  Includes:
> > > >=20
> > > >  1. Support for X553 (Denverton) Ethernet devices.
> > > >  2. Initialization code refactoring.
> > > >  3. ixgbe-specific netmap code moved to ixgbe folder
> > > > (but not removed from dev/netmap/).
> > > >  4. VF driver full split. Some cleanup can be had due to redundant =
> > > code,
> > > > but this split goes inline with the refactoring.
> > > >=20
> > > >  NOTE: This is a direct commit to stable/10. Newer branches will =
> > > receive an
> > > >  iflib-converted version of ixgbe, with these updates included, =
> > > instead.
> > > >=20
> > > >  Differential Revision: https://reviews.freebsd.org/D9310
> > > >  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
> > > >  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
> > > >  Sponsored by:  Intel Corporation
> > >
> > > Hi Eric,
> > >   This commit broke amd64/LINT, further (there are other issues =
> > > preventing it from passing): =
> > > https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .
> >
> > It also broke buildkernel while building the ixgbe module in my
> > stable10/amd64 VM.
> >
> >
> > --
> > Cheers,
> > Cy Schubert 
> > FreeBSD UNIX:     Web:  http://www.FreeBSD.org
> >
> > The need of the many outweighs the greed of the few.
> >
> >
> >


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

I think I've got the i386 error fixed in r315434; I have Jeb looking at
fixing the netmap issue.

On Thu, Mar 16, 2017 at 1:52 PM Ryan Stone  wrote:

> On Thu, Mar 16, 2017 at 2:59 PM, Eric Joyner  wrote:
>
> I don't think the PCI_IOV stuff should be left in there. At least from
> what I gathered in D4767, it's probably abandoned in 10.
>
>
> It shouldn't hurt to leave it in, though.  It should all be compiled under
> #ifdef PCI_IOV and just be compiled out safely.
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Ryan Stone]

On Thu, Mar 16, 2017 at 2:59 PM, Eric Joyner  wrote:

> I don't think the PCI_IOV stuff should be left in there. At least from
> what I gathered in D4767, it's probably abandoned in 10.
>

It shouldn't hurt to leave it in, though.  It should all be compiled under
#ifdef PCI_IOV and just be compiled out safely.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Peter Jeremy]

On 2017-Mar-15 21:20:17 +, Eric Joyner  wrote:
>Author: erj
>Date: Wed Mar 15 21:20:17 2017
>New Revision: 315333
>URL: https://svnweb.freebsd.org/changeset/base/315333
>
>Log:
>  ixgbe(4): Update to 3.2.11-k

I'll add that this broke the ixv compile on my i386 VM:
===> ixv (all)
cc  -O2 -pipe  -DSMP -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE 
-nostdinc  -I/usr/src/sys/modules/ixv/../../dev/ixgbe 
-DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/GENERIC/opt_global.h 
-I. -I@ -I@/contrib/altq -fno-common -g -I/usr/obj/usr/src/sys/GENERIC  
-mno-aes -mno-avx -mno-mmx -mno-sse -msoft-float -ffreestanding 
-fstack-protector -gdwarf-2 -std=iso9899:1999 -Qunused-arguments  
-fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes 
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef 
-Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs 
-fdiagnostics-show-option  -Wno-error-tautological-compare 
-Wno-error-empty-body  -Wno-error-parentheses-equality 
-Wno-error-unused-function-c 
/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c -o if_ixv.o
/usr/src/sys/modules/ixv/../../dev/ixgbe/if_ixv.c:2292:3: error: incompatible 
pointer types initializing 'uint64_t *' (aka 'unsigned long long *') with an 
expression of type 'unsigned long *' [-Werror,-Wincompatible-pointer-types]
SYSCTL_ADD_UQUAD(ctx, queue_list, OID_AUTO, "no_tx_dma_setup",
^~
@/sys/sysctl.h:413:12: note: expanded from macro 'SYSCTL_ADD_UQUAD'
uint64_t *__ptr = (ptr);\
  ^   ~
1 error generated.

-- 
Peter Jeremy


signature.asc
Description: PGP signature

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

Ngie,

It looks like what's in the commit is using an older version of netmap, so
I think we're okay on that. I think the naming conflict may be due to
splitting the ixgbe_netmap.c file into ixgbe_netmap.c & ixv_netmap.c, and
not having the functions in ixv_netmap.c be renamed.

I don't think the PCI_IOV stuff should be left in there. At least from what
I gathered in D4767, it's probably abandoned in 10.

Cy,

Are you using special options in your kernel config file? "device ixgbe"
works for me, so I want to assume you have "device netmap" in your config
file, unless you're missing INET and/or INET6.

On Thu, Mar 16, 2017 at 10:00 AM Ngie Cooper  wrote:

>
> On Mar 16, 2017, at 09:29, Eric Joyner  wrote:
>
> I'm looking at this now.
>
> Cy, in your case it sounds like the "device ixgbe" option is broken. I'll
> work on getting that to build again.
>
> The LINT build error looks like a netmap linking issue (probably due to
> Jeb moving/copying netmap stuff into the driver folder), so that'll be fun
> to root cause.
>
>
> Hi Eric,
> One sandtrap to be aware of is r307394 (and corresponding commits)
> not being MFCed, along with a host of PCI-IOV, etc changes not being easily
> backportable.
> If you can, look for commits from me in the r29 series citing
> ix_crcstrip (it was a backport from bz@ to unbreak LINT on head that also
> fixed stable/10).
> Thanks!
> -Ngie
>
> On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert 
> wrote:
>
> In message <62c8a9fd-1ee0-4def-a28a-843dbbb49...@gmail.com>, "Ngie Cooper
> (yane
> urabeya)" writes:
> >
> > --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5
> > Content-Transfer-Encoding: quoted-printable
> > Content-Type: text/plain;
> >   charset=us-ascii
> >
> >
> > > On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> > >=20
> > > Author: erj
> > > Date: Wed Mar 15 21:20:17 2017
> > > New Revision: 315333
> > > URL: https://svnweb.freebsd.org/changeset/base/315333
> > >=20
> > > Log:
> > >  ixgbe(4): Update to 3.2.11-k
> > >=20
> > >  Includes:
> > >=20
> > >  1. Support for X553 (Denverton) Ethernet devices.
> > >  2. Initialization code refactoring.
> > >  3. ixgbe-specific netmap code moved to ixgbe folder
> > > (but not removed from dev/netmap/).
> > >  4. VF driver full split. Some cleanup can be had due to redundant =
> > code,
> > > but this split goes inline with the refactoring.
> > >=20
> > >  NOTE: This is a direct commit to stable/10. Newer branches will =
> > receive an
> > >  iflib-converted version of ixgbe, with these updates included, =
> > instead.
> > >=20
> > >  Differential Revision: https://reviews.freebsd.org/D9310
> > >  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
> > >  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
> > >  Sponsored by:  Intel Corporation
> >
> > Hi Eric,
> >   This commit broke amd64/LINT, further (there are other issues =
> > preventing it from passing): =
> > https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .
>
> It also broke buildkernel while building the ixgbe module in my
> stable10/amd64 VM.
>
>
> --
> Cheers,
> Cy Schubert 
> FreeBSD UNIX:     Web:  http://www.FreeBSD.org
>
> The need of the many outweighs the greed of the few.
>
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

I'm looking at this now.

Cy, in your case it sounds like the "device ixgbe" option is broken. I'll
work on getting that to build again.

The LINT build error looks like a netmap linking issue (probably due to Jeb
moving/copying netmap stuff into the driver folder), so that'll be fun to
root cause.

- Eric

On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert 
wrote:

In message <62c8a9fd-1ee0-4def-a28a-843dbbb49...@gmail.com>, "Ngie Cooper
(yane
urabeya)" writes:
>
> --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5
> Content-Transfer-Encoding: quoted-printable
> Content-Type: text/plain;
>   charset=us-ascii
>
>
> > On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> >=20
> > Author: erj
> > Date: Wed Mar 15 21:20:17 2017
> > New Revision: 315333
> > URL: https://svnweb.freebsd.org/changeset/base/315333
> >=20
> > Log:
> >  ixgbe(4): Update to 3.2.11-k
> >=20
> >  Includes:
> >=20
> >  1. Support for X553 (Denverton) Ethernet devices.
> >  2. Initialization code refactoring.
> >  3. ixgbe-specific netmap code moved to ixgbe folder
> > (but not removed from dev/netmap/).
> >  4. VF driver full split. Some cleanup can be had due to redundant =
> code,
> > but this split goes inline with the refactoring.
> >=20
> >  NOTE: This is a direct commit to stable/10. Newer branches will =
> receive an
> >  iflib-converted version of ixgbe, with these updates included, =
> instead.
> >=20
> >  Differential Revision: https://reviews.freebsd.org/D9310
> >  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
> >  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
> >  Sponsored by:  Intel Corporation
>
> Hi Eric,
>   This commit broke amd64/LINT, further (there are other issues =
> preventing it from passing): =
> https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .

It also broke buildkernel while building the ixgbe module in my
stable10/amd64 VM.


--
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Ngie Cooper]

> On Mar 16, 2017, at 09:29, Eric Joyner  wrote:
> 
> I'm looking at this now.
> 
> Cy, in your case it sounds like the "device ixgbe" option is broken. I'll 
> work on getting that to build again.
> 
> The LINT build error looks like a netmap linking issue (probably due to Jeb 
> moving/copying netmap stuff into the driver folder), so that'll be fun to 
> root cause.

Hi Eric,
One sandtrap to be aware of is r307394 (and corresponding commits) not 
being MFCed, along with a host of PCI-IOV, etc changes not being easily 
backportable.
If you can, look for commits from me in the r29 series citing 
ix_crcstrip (it was a backport from bz@ to unbreak LINT on head that also fixed 
stable/10).
Thanks!
-Ngie

> On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert  wrote:
> In message <62c8a9fd-1ee0-4def-a28a-843dbbb49...@gmail.com>, "Ngie Cooper
> (yane
> urabeya)" writes:
> >
> > --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5
> > Content-Transfer-Encoding: quoted-printable
> > Content-Type: text/plain;
> >   charset=us-ascii
> >
> >
> > > On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> > >=20
> > > Author: erj
> > > Date: Wed Mar 15 21:20:17 2017
> > > New Revision: 315333
> > > URL: https://svnweb.freebsd.org/changeset/base/315333
> > >=20
> > > Log:
> > >  ixgbe(4): Update to 3.2.11-k
> > >=20
> > >  Includes:
> > >=20
> > >  1. Support for X553 (Denverton) Ethernet devices.
> > >  2. Initialization code refactoring.
> > >  3. ixgbe-specific netmap code moved to ixgbe folder
> > > (but not removed from dev/netmap/).
> > >  4. VF driver full split. Some cleanup can be had due to redundant =
> > code,
> > > but this split goes inline with the refactoring.
> > >=20
> > >  NOTE: This is a direct commit to stable/10. Newer branches will =
> > receive an
> > >  iflib-converted version of ixgbe, with these updates included, =
> > instead.
> > >=20
> > >  Differential Revision: https://reviews.freebsd.org/D9310
> > >  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
> > >  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
> > >  Sponsored by:  Intel Corporation
> >
> > Hi Eric,
> >   This commit broke amd64/LINT, further (there are other issues =
> > preventing it from passing): =
> > https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .
> 
> It also broke buildkernel while building the ixgbe module in my
> stable10/amd64 VM.
> 
> 
> --
> Cheers,
> Cy Schubert 
> FreeBSD UNIX:     Web:  http://www.FreeBSD.org
> 
> The need of the many outweighs the greed of the few.
> 
> 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Cy Schubert]

In message <62c8a9fd-1ee0-4def-a28a-843dbbb49...@gmail.com>, "Ngie Cooper 
(yane
urabeya)" writes:
> 
> --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5
> Content-Transfer-Encoding: quoted-printable
> Content-Type: text/plain;
>   charset=us-ascii
> 
> 
> > On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> >=20
> > Author: erj
> > Date: Wed Mar 15 21:20:17 2017
> > New Revision: 315333
> > URL: https://svnweb.freebsd.org/changeset/base/315333
> >=20
> > Log:
> >  ixgbe(4): Update to 3.2.11-k
> >=20
> >  Includes:
> >=20
> >  1. Support for X553 (Denverton) Ethernet devices.
> >  2. Initialization code refactoring.
> >  3. ixgbe-specific netmap code moved to ixgbe folder
> > (but not removed from dev/netmap/).
> >  4. VF driver full split. Some cleanup can be had due to redundant =
> code,
> > but this split goes inline with the refactoring.
> >=20
> >  NOTE: This is a direct commit to stable/10. Newer branches will =
> receive an
> >  iflib-converted version of ixgbe, with these updates included, =
> instead.
> >=20
> >  Differential Revision: https://reviews.freebsd.org/D9310
> >  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
> >  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
> >  Sponsored by:  Intel Corporation
> 
> Hi Eric,
>   This commit broke amd64/LINT, further (there are other issues =
> preventing it from passing): =
> https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .

It also broke buildkernel while building the ixgbe module in my 
stable10/amd64 VM.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Ngie Cooper (yaneurabeya)]

> On Mar 15, 2017, at 14:20, Eric Joyner  wrote:
> 
> Author: erj
> Date: Wed Mar 15 21:20:17 2017
> New Revision: 315333
> URL: https://svnweb.freebsd.org/changeset/base/315333
> 
> Log:
>  ixgbe(4): Update to 3.2.11-k
> 
>  Includes:
> 
>  1. Support for X553 (Denverton) Ethernet devices.
>  2. Initialization code refactoring.
>  3. ixgbe-specific netmap code moved to ixgbe folder
> (but not removed from dev/netmap/).
>  4. VF driver full split. Some cleanup can be had due to redundant code,
> but this split goes inline with the refactoring.
> 
>  NOTE: This is a direct commit to stable/10. Newer branches will receive an
>  iflib-converted version of ixgbe, with these updates included, instead.
> 
>  Differential Revision: https://reviews.freebsd.org/D9310
>  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
>  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
>  Sponsored by:Intel Corporation

Hi Eric,
This commit broke amd64/LINT, further (there are other issues 
preventing it from passing): 
https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console .
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv

[Eric Joyner]

Author: erj
Date: Wed Mar 15 21:20:17 2017
New Revision: 315333
URL: https://svnweb.freebsd.org/changeset/base/315333

Log:
  ixgbe(4): Update to 3.2.11-k
  
  Includes:
  
  1. Support for X553 (Denverton) Ethernet devices.
  2. Initialization code refactoring.
  3. ixgbe-specific netmap code moved to ixgbe folder
 (but not removed from dev/netmap/).
  4. VF driver full split. Some cleanup can be had due to redundant code,
 but this split goes inline with the refactoring.
  
  NOTE: This is a direct commit to stable/10. Newer branches will receive an
  iflib-converted version of ixgbe, with these updates included, instead.
  
  Differential Revision: https://reviews.freebsd.org/D9310
  Submitted by: Jeb Cramer (jeb.j.cra...@intel.com)
  Tested by: Jeffrey Pieper (jeffrey.e.pie...@intel.com)
  Sponsored by: Intel Corporation

Added:
  stable/10/sys/dev/ixgbe/if_bypass.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/if_fdir.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/if_sriov.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_bypass.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_fdir.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_features.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_netmap.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_netmap.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_rss.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixgbe_sriov.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_bypass.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_fdir.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_features.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_mbx.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_mbx.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_netmap.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_netmap.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_osdep.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_osdep.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_rss.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_sriov.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_txrx.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_type.h   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_vf.c   (contents, props changed)
  stable/10/sys/dev/ixgbe/ixv_vf.h   (contents, props changed)
Deleted:
  stable/10/sys/dev/ixgbe/ixgbe_vf.c
  stable/10/sys/dev/ixgbe/ixgbe_vf.h
Modified:
  stable/10/sys/conf/files
  stable/10/sys/dev/ixgbe/if_ix.c
  stable/10/sys/dev/ixgbe/if_ixv.c
  stable/10/sys/dev/ixgbe/ix_txrx.c
  stable/10/sys/dev/ixgbe/ixgbe.h
  stable/10/sys/dev/ixgbe/ixgbe_82598.c
  stable/10/sys/dev/ixgbe/ixgbe_82598.h
  stable/10/sys/dev/ixgbe/ixgbe_82599.c
  stable/10/sys/dev/ixgbe/ixgbe_82599.h
  stable/10/sys/dev/ixgbe/ixgbe_api.c
  stable/10/sys/dev/ixgbe/ixgbe_api.h
  stable/10/sys/dev/ixgbe/ixgbe_common.c
  stable/10/sys/dev/ixgbe/ixgbe_common.h
  stable/10/sys/dev/ixgbe/ixgbe_dcb.c
  stable/10/sys/dev/ixgbe/ixgbe_dcb.h
  stable/10/sys/dev/ixgbe/ixgbe_dcb_82598.c
  stable/10/sys/dev/ixgbe/ixgbe_dcb_82598.h
  stable/10/sys/dev/ixgbe/ixgbe_dcb_82599.c
  stable/10/sys/dev/ixgbe/ixgbe_dcb_82599.h
  stable/10/sys/dev/ixgbe/ixgbe_mbx.c
  stable/10/sys/dev/ixgbe/ixgbe_mbx.h
  stable/10/sys/dev/ixgbe/ixgbe_osdep.c
  stable/10/sys/dev/ixgbe/ixgbe_osdep.h
  stable/10/sys/dev/ixgbe/ixgbe_phy.c
  stable/10/sys/dev/ixgbe/ixgbe_phy.h
  stable/10/sys/dev/ixgbe/ixgbe_type.h
  stable/10/sys/dev/ixgbe/ixgbe_x540.c
  stable/10/sys/dev/ixgbe/ixgbe_x540.h
  stable/10/sys/dev/ixgbe/ixgbe_x550.c
  stable/10/sys/dev/ixgbe/ixgbe_x550.h
  stable/10/sys/modules/ix/Makefile
  stable/10/sys/modules/ixv/Makefile

Modified: stable/10/sys/conf/files
==
--- stable/10/sys/conf/filesWed Mar 15 21:17:45 2017(r315332)
+++ stable/10/sys/conf/filesWed Mar 15 21:20:17 2017(r315333)
@@ -1765,6 +1765,14 @@ dev/ixgbe/if_ixv.c   optional ixv inet | 
compile-with "${NORMAL_C} -I$S/dev/ixgbe -DSMP"
 dev/ixgbe/ix_txrx.coptional ix inet | ixv inet | ixgbe inet \
compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+dev/ixgbe/if_bypass.c  optional ix inet | ixv inet | ixgbe inet \
+   compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+dev/ixgbe/if_fdir.coptional ix inet | ixv inet | ixgbe inet \
+   compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+dev/ixgbe/if_sriov.c   optional ix inet | ixv inet | ixgbe inet \
+   compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+dev/ixgbe/ixgbe_netmap.c   optional ix inet | ixv inet | ixgbe inet \
+   compile-with "${NORMAL_C} -I$S/dev/ixgbe"
 dev/ixgbe/ixgbe_phy.c  optional ix inet | ixv inet | ixgbe inet \