Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Mariusz Zaborski]

On Wed, Nov 01, 2017 at 11:48:54AM +0100, Herbert J. Skuhra wrote:
> On Sat, 28 Oct 2017 21:23:57 +0200,
> Mariusz Zaborski  wrote:
> > 
> > Author: oshogbo
> > Date: Sat Oct 28 19:23:57 2017
> > New Revision: 325062
> > URL: https://svnweb.freebsd.org/changeset/base/325062
> > 
> > Log:
> >   Introduce caspermocks.
> >   
> >   The idea behinds mocks is that we don't need to ifdef a lot of code in
> >   tools itself but those defines are hidden in the casper library.
> >   Right now the mocks are implemented as define/inlines functions.
> >   There was a very long discussion how this should be implemented.
> >   This approach has some advantages like we don't need to link to any 
> > additional
> >   libraries. Unfortunately there are also some disadvantages for example it 
> > is
> >   easy to get library out of sync between two versions of functions or that 
> > we
> >   need extra define to compile program with casper support.
> >   This isn't an ideal solution but it's good enough for now and should 
> > simplify
> >   capsicumizing programs. This also doesn't close us any other ways to do 
> > those
> >   mocks and this should evolve in time.
> >   
> >   Discussed with:   pjd, emaste, ed, rwatson, bapt, cem, bdrewery
> >   Differential Revision:https://reviews.freebsd.org/D8753
> 
> Again, after this commit libcasper.so.0 is installed to /usr/lib and not
> /lib:
> 
> % ls -l /usr/lib/libcasper.so*
> lrwxr-xr-x  1 root  wheel 14 Oct 29 10:51 /usr/lib/libcasper.so -> 
> libcasper.so.0
> -r--r--r--  1 root  wheel  22424 Oct 29 10:51 /usr/lib/libcasper.so.0
> 
> But usr/lib/libcasper.so.0 is listed in ObsoleteFiles.inc:
> 
> % grep -B 2 libcasper.so /usr/src/ObsoleteFiles.inc
> # 20131202: libcapsicum and libcasper moved to /lib/
> OLD_LIBS+=usr/lib/libcapsicum.so.0
> OLD_LIBS+=usr/lib/libcasper.so.0
Thank you for reporting.
Should be fixed in the r325399.

Thanks,
-- 
Mariusz Zaborski
oshogbo//vx | http://oshogbo.vexillium.org
FreeBSD commiter| https://freebsd.org
Software developer  | http://wheelsystems.com
If it's not broken, let's fix it till it is!!1


signature.asc
Description: PGP signature

Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Herbert J. Skuhra]

On Sat, 28 Oct 2017 21:23:57 +0200,
Mariusz Zaborski  wrote:
> 
> Author: oshogbo
> Date: Sat Oct 28 19:23:57 2017
> New Revision: 325062
> URL: https://svnweb.freebsd.org/changeset/base/325062
> 
> Log:
>   Introduce caspermocks.
>   
>   The idea behinds mocks is that we don't need to ifdef a lot of code in
>   tools itself but those defines are hidden in the casper library.
>   Right now the mocks are implemented as define/inlines functions.
>   There was a very long discussion how this should be implemented.
>   This approach has some advantages like we don't need to link to any 
> additional
>   libraries. Unfortunately there are also some disadvantages for example it is
>   easy to get library out of sync between two versions of functions or that we
>   need extra define to compile program with casper support.
>   This isn't an ideal solution but it's good enough for now and should 
> simplify
>   capsicumizing programs. This also doesn't close us any other ways to do 
> those
>   mocks and this should evolve in time.
>   
>   Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery
>   Differential Revision:https://reviews.freebsd.org/D8753

Again, after this commit libcasper.so.0 is installed to /usr/lib and not
/lib:

% ls -l /usr/lib/libcasper.so*
lrwxr-xr-x  1 root  wheel 14 Oct 29 10:51 /usr/lib/libcasper.so -> 
libcasper.so.0
-r--r--r--  1 root  wheel  22424 Oct 29 10:51 /usr/lib/libcasper.so.0

But usr/lib/libcasper.so.0 is listed in ObsoleteFiles.inc:

% grep -B 2 libcasper.so /usr/src/ObsoleteFiles.inc
# 20131202: libcapsicum and libcasper moved to /lib/
OLD_LIBS+=usr/lib/libcapsicum.so.0
OLD_LIBS+=usr/lib/libcasper.so.0

Thanks.

--
Herbert
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Ngie Cooper (yaneurabeya)]

> On Oct 28, 2017, at 12:23, Mariusz Zaborski  wrote:
> 
> Author: oshogbo
> Date: Sat Oct 28 19:23:57 2017
> New Revision: 325062
> URL: https://svnweb.freebsd.org/changeset/base/325062
> 
> Log:
>  Introduce caspermocks.
> 
>  The idea behinds mocks is that we don't need to ifdef a lot of code in
>  tools itself but those defines are hidden in the casper library.
>  Right now the mocks are implemented as define/inlines functions.
>  There was a very long discussion how this should be implemented.
>  This approach has some advantages like we don't need to link to any 
> additional
>  libraries. Unfortunately there are also some disadvantages for example it is
>  easy to get library out of sync between two versions of functions or that we
>  need extra define to compile program with casper support.
>  This isn't an ideal solution but it's good enough for now and should simplify
>  capsicumizing programs. This also doesn't close us any other ways to do those
>  mocks and this should evolve in time.
> 
>  Discussed with:  pjd, emaste, ed, rwatson, bapt, cem, bdrewery
>  Differential Revision:https://reviews.freebsd.org/D8753

This change broke tinderbox/Jenkins for powerpc and sparc64: 
https://ci.freebsd.org/job/FreeBSD-head-powerpc-build/1865/console .
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Mariusz Zaborski]

On 29 October 2017 at 01:49, Conrad Meyer  wrote:
> Hi,
>
> On Sat, Oct 28, 2017 at 12:23 PM, Mariusz Zaborski  
> wrote:
>> Author: oshogbo
>> Date: Sat Oct 28 19:23:57 2017
>> New Revision: 325062
>> URL: https://svnweb.freebsd.org/changeset/base/325062
>>
>> Log:
>>   Introduce caspermocks.
>>
>>   The idea behinds mocks is that we don't need to ifdef a lot of code in
>>   tools itself but those defines are hidden in the casper library.
>>   Right now the mocks are implemented as define/inlines functions.
>>   There was a very long discussion how this should be implemented.
>>   This approach has some advantages like we don't need to link to any 
>> additional
>>   libraries. Unfortunately there are also some disadvantages for example it 
>> is
>>   easy to get library out of sync between two versions of functions or that 
>> we
>>   need extra define to compile program with casper support.
>>   This isn't an ideal solution but it's good enough for now and should 
>> simplify
>>   capsicumizing programs. This also doesn't close us any other ways to do 
>> those
>>   mocks and this should evolve in time.
>>
>>   Discussed with:   pjd, emaste, ed, rwatson, bapt, cem, bdrewery
>>   Differential Revision:https://reviews.freebsd.org/D8753
>
> It's worth pointing out "discussed with" here very much does not mean
> "approved by" — several of the people mentioned above raised concerns
> with this approach and only one person explicitly supported the
> change.

Sorry for my in precision,

Approved by:   pjd, emaste, ed, rwatson
Discussed with:   pjd, emaste, ed, rwatson, bapt, cem, bdrewery

Like I mention in a commit log there were some concerns. This is also
the reason why
I wouldn't commit it with only one 'go for it'.

Thanks,
Mariusz

>
> Best,
> Conrad
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Conrad Meyer]

Hi,

On Sat, Oct 28, 2017 at 12:23 PM, Mariusz Zaborski  wrote:
> Author: oshogbo
> Date: Sat Oct 28 19:23:57 2017
> New Revision: 325062
> URL: https://svnweb.freebsd.org/changeset/base/325062
>
> Log:
>   Introduce caspermocks.
>
>   The idea behinds mocks is that we don't need to ifdef a lot of code in
>   tools itself but those defines are hidden in the casper library.
>   Right now the mocks are implemented as define/inlines functions.
>   There was a very long discussion how this should be implemented.
>   This approach has some advantages like we don't need to link to any 
> additional
>   libraries. Unfortunately there are also some disadvantages for example it is
>   easy to get library out of sync between two versions of functions or that we
>   need extra define to compile program with casper support.
>   This isn't an ideal solution but it's good enough for now and should 
> simplify
>   capsicumizing programs. This also doesn't close us any other ways to do 
> those
>   mocks and this should evolve in time.
>
>   Discussed with:   pjd, emaste, ed, rwatson, bapt, cem, bdrewery
>   Differential Revision:https://reviews.freebsd.org/D8753

It's worth pointing out "discussed with" here very much does not mean
"approved by" — several of the people mentioned above raised concerns
with this approach and only one person explicitly supported the
change.

Best,
Conrad
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"