Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
On Fri, 2018-10-26 at 05:30 +0200, Jan Beich wrote: > > Your tone is not acceptable. Please try again, only this time with > the > > required level of professionalism. I'm not an idiot, and you will > treat me > > with respect. > > Apologies for the snide remark. I've expected someone with ports/ > commit bit to be a bit more careful. It isn't much of an appology if you use it as an opportunity to tack on another insult. -- Ian ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
On Thu, Oct 25, 2018 at 9:30 PM Jan Beich wrote: > Warner Losh writes: > > > On Wed, Oct 24, 2018 at 9:42 AM Jan Beich wrote: > > > >> Warner Losh writes: > >> > >> > Author: imp > >> > Date: Mon Oct 22 02:34:00 2018 > >> > New Revision: 339563 > >> > URL: https://svnweb.freebsd.org/changeset/base/339563 > >> > > >> > Log: > >> > Remove joy(4) driver. > >> > > >> > This driver was marked as gone in 12. We're at 13 now. Remove it. > >> > Data from nycbug's dmesg cache shows only one potential user, > >> > suggesting it never was used much. > >> > > >> > RelNotes: yes > >> > Differential Revision: https://reviews.freebsd.org/D17629 > >> > >> Breaking userland API but not bothering with an exp-run or bumping > >> __FreeBSD_version. > >> Is the following the pointy hat you were looking for? > >> > >> > >> > https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ > > > > > > Your tone is not acceptable. Please try again, only this time with the > > required level of professionalism. I'm not an idiot, and you will treat > me > > with respect. > > Apologies for the snide remark. I've expected someone with ports/ commit > bit > to be a bit more careful. > To be honest, I've never been burned before. It has been a learning lession. > > This driver was flagged for removal in 12 ages ago and the port failed to > > update to take that deprecation into account. > > Not sure what "ages ago" refers to when not even 1 year passed since > r328523. > Neither joy(4) manpage mentioned deprecation nor > __attribute__((deprecated)) > was used. Maintainers of consumers aren't necessarily joy(4) users. > But only joy(4) generates events and supports things described here. And joy(4) hasn't been relevant in this century. I thought this was totally safe. And I've not ever used / seen __attribute__((deprecated)). I will have to start using it. > Was joy(4) deprecation announced on the public mailing lists? For some > reason, > I can't easily find it in the archives. > I thought I had, but I'm not seeing it in my archives. > > You can use the bump to 130 as the version to fix it. I didn't bump > the > > revision because it wasn't needed. > > poudriere won't force rebuild everything if __FreeBSD_version doesn't > change. > Right. OK. I was not aware of that. > Expect silence from pkg-fallout@ until the next bump. > There was one earlier today. > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-amd64-default.log > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-amd64-default.log > > vs. > > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-armv6-default.log > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-armv6-default.log Yea, that's more extensive than I'd expected. > I posted a patch to the port that makes it compile for me to that thread. > > If there's confirmation that it works, i'll work with x...@freebsd.org to > > get it pushed in. Or just push it in myself since I'm on that list and > I'm > > a ports committer. > > https://codesearch.debian.net/search?q=sys/joystick.h could've been used > to guess a few consumers before pkg-fallout@ complains. > True. Most of them are bogus, but many are not. Given the number, I'm going to add sys/joystick.h back and bump the __FreeBSD_version and learn from my mistake. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
Warner Losh writes: > On Wed, Oct 24, 2018 at 9:42 AM Jan Beich wrote: > >> Warner Losh writes: >> >> > Author: imp >> > Date: Mon Oct 22 02:34:00 2018 >> > New Revision: 339563 >> > URL: https://svnweb.freebsd.org/changeset/base/339563 >> > >> > Log: >> > Remove joy(4) driver. >> > >> > This driver was marked as gone in 12. We're at 13 now. Remove it. >> > Data from nycbug's dmesg cache shows only one potential user, >> > suggesting it never was used much. >> > >> > RelNotes: yes >> > Differential Revision: https://reviews.freebsd.org/D17629 >> >> Breaking userland API but not bothering with an exp-run or bumping >> __FreeBSD_version. >> Is the following the pointy hat you were looking for? >> >> >> https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ > > > Your tone is not acceptable. Please try again, only this time with the > required level of professionalism. I'm not an idiot, and you will treat me > with respect. Apologies for the snide remark. I've expected someone with ports/ commit bit to be a bit more careful. > This driver was flagged for removal in 12 ages ago and the port failed to > update to take that deprecation into account. Not sure what "ages ago" refers to when not even 1 year passed since r328523. Neither joy(4) manpage mentioned deprecation nor __attribute__((deprecated)) was used. Maintainers of consumers aren't necessarily joy(4) users. Was joy(4) deprecation announced on the public mailing lists? For some reason, I can't easily find it in the archives. > You can use the bump to 130 as the version to fix it. I didn't bump the > revision because it wasn't needed. poudriere won't force rebuild everything if __FreeBSD_version doesn't change. Expect silence from pkg-fallout@ until the next bump. http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-amd64-default.log http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-amd64-default.log vs. http://beefy8.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-armv6-default.log http://beefy8.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-armv6-default.log > I posted a patch to the port that makes it compile for me to that thread. > If there's confirmation that it works, i'll work with x...@freebsd.org to > get it pushed in. Or just push it in myself since I'm on that list and I'm > a ports committer. https://codesearch.debian.net/search?q=sys/joystick.h could've been used to guess a few consumers before pkg-fallout@ complains. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
On Wed, Oct 24, 2018 at 2:36 PM Warner Losh wrote: > > > On Wed, Oct 24, 2018 at 9:42 AM Jan Beich wrote: > >> Warner Losh writes: >> >> > Author: imp >> > Date: Mon Oct 22 02:34:00 2018 >> > New Revision: 339563 >> > URL: https://svnweb.freebsd.org/changeset/base/339563 >> > >> > Log: >> > Remove joy(4) driver. >> > >> > This driver was marked as gone in 12. We're at 13 now. Remove it. >> > Data from nycbug's dmesg cache shows only one potential user, >> > suggesting it never was used much. >> > >> > RelNotes: yes >> > Differential Revision: https://reviews.freebsd.org/D17629 >> >> Breaking userland API but not bothering with an exp-run or bumping >> __FreeBSD_version. >> Is the following the pointy hat you were looking for? >> >> >> https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ > > > Your tone is not acceptable. Please try again, only this time with the > required level of professionalism. I'm not an idiot, and you will treat me > with respect. > > This driver was flagged for removal in 12 ages ago and the port failed to > update to take that deprecation into account. So this tone is out of line. > You can use the bump to 130 as the version to fix it. I didn't bump the > revision because it wasn't needed. > I posted a patch to the port that makes it compile for me to that thread. If there's confirmation that it works, i'll work with x...@freebsd.org to get it pushed in. Or just push it in myself since I'm on that list and I'm a ports committer. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
On Wed, Oct 24, 2018 at 9:42 AM Jan Beich wrote: > Warner Losh writes: > > > Author: imp > > Date: Mon Oct 22 02:34:00 2018 > > New Revision: 339563 > > URL: https://svnweb.freebsd.org/changeset/base/339563 > > > > Log: > > Remove joy(4) driver. > > > > This driver was marked as gone in 12. We're at 13 now. Remove it. > > Data from nycbug's dmesg cache shows only one potential user, > > suggesting it never was used much. > > > > RelNotes: yes > > Differential Revision: https://reviews.freebsd.org/D17629 > > Breaking userland API but not bothering with an exp-run or bumping > __FreeBSD_version. > Is the following the pointy hat you were looking for? > > > https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ Your tone is not acceptable. Please try again, only this time with the required level of professionalism. I'm not an idiot, and you will treat me with respect. This driver was flagged for removal in 12 ages ago and the port failed to update to take that deprecation into account. So this tone is out of line. You can use the bump to 130 as the version to fix it. I didn't bump the revision because it wasn't needed. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
On 10/24/18 8:42 AM, Jan Beich wrote: > Warner Losh writes: > >> Author: imp >> Date: Mon Oct 22 02:34:00 2018 >> New Revision: 339563 >> URL: https://svnweb.freebsd.org/changeset/base/339563 >> >> Log: >> Remove joy(4) driver. >> >> This driver was marked as gone in 12. We're at 13 now. Remove it. >> Data from nycbug's dmesg cache shows only one potential user, >> suggesting it never was used much. >> >> RelNotes: yes >> Differential Revision: https://reviews.freebsd.org/D17629 > > Breaking userland API but not bothering with an exp-run or bumping > __FreeBSD_version. > Is the following the pointy hat you were looking for? > > https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ Jan, While breaking the userland API isn't something we should do, your tone in this mail isn't helpful. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
Warner Losh writes: > Author: imp > Date: Mon Oct 22 02:34:00 2018 > New Revision: 339563 > URL: https://svnweb.freebsd.org/changeset/base/339563 > > Log: > Remove joy(4) driver. > > This driver was marked as gone in 12. We're at 13 now. Remove it. > Data from nycbug's dmesg cache shows only one potential user, > suggesting it never was used much. > > RelNotes: yes > Differential Revision: https://reviews.freebsd.org/D17629 Breaking userland API but not bothering with an exp-run or bumping __FreeBSD_version. Is the following the pointy hat you were looking for? https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys
Author: imp
Date: Mon Oct 22 02:34:00 2018
New Revision: 339563
URL: https://svnweb.freebsd.org/changeset/base/339563
Log:
Remove joy(4) driver.
This driver was marked as gone in 12. We're at 13 now. Remove it.
Data from nycbug's dmesg cache shows only one potential user,
suggesting it never was used much.
RelNotes: yes
Differential Revision: https://reviews.freebsd.org/D17629
Deleted:
head/share/man/man4/joy.4
head/sys/dev/joy/joy.c
head/sys/dev/joy/joy_isa.c
head/sys/dev/joy/joyvar.h
head/sys/modules/joy/Makefile
head/sys/sys/joystick.h
head/tools/kerneldoc/subsys/Doxyfile-dev_joy
Modified:
head/ObsoleteFiles.inc
head/share/man/man4/Makefile
head/sys/conf/NOTES
head/sys/conf/files
head/sys/modules/Makefile
Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc Mon Oct 22 02:28:18 2018(r339562)
+++ head/ObsoleteFiles.inc Mon Oct 22 02:34:00 2018(r339563)
@@ -38,6 +38,9 @@
# xargs -n1 | sort | uniq -d;
# done
+# 20181021: joy(4) removal
+OLD_FILES+=usr/share/man/man4/joy.4.gz
+OLD_FILES+=usr/include/sys/joystick.h
# 20181015: Stale libcasper(3) files following r329452
OLD_LIBS+=lib/casper/libcap_sysctl.so.0
OLD_LIBS+=lib/casper/libcap_grp.so.0
Modified: head/share/man/man4/Makefile
==
--- head/share/man/man4/MakefileMon Oct 22 02:28:18 2018
(r339562)
+++ head/share/man/man4/MakefileMon Oct 22 02:34:00 2018
(r339563)
@@ -243,7 +243,6 @@ MAN=aac.4 \
ixl.4 \
jedec_dimm.4 \
jme.4 \
- joy.4 \
kbdmux.4 \
keyboard.4 \
kld.4 \
Modified: head/sys/conf/NOTES
==
--- head/sys/conf/NOTES Mon Oct 22 02:28:18 2018(r339562)
+++ head/sys/conf/NOTES Mon Oct 22 02:34:00 2018(r339563)
@@ -2366,12 +2366,8 @@ options SND_OLDSTEREO
# Miscellaneous hardware:
#
# bktr: Brooktree bt848/848a/849a/878/879 video capture and TV Tuner board
-# joy: joystick (including IO DATA PCJOY PC Card joystick)
# cmx: OmniKey CardMan 4040 pccard smartcard reader
-device joy # PnP aware, hints for non-PnP only
-hint.joy.0.at="isa"
-hint.joy.0.port="0x201"
device cmx
#
Modified: head/sys/conf/files
==
--- head/sys/conf/files Mon Oct 22 02:28:18 2018(r339562)
+++ head/sys/conf/files Mon Oct 22 02:34:00 2018(r339563)
@@ -2311,8 +2311,6 @@ dev/ixgbe/ixgbe_dcb_82599.c optional ix inet | ixv
ine
compile-with "${NORMAL_C} -I$S/dev/ixgbe"
dev/jedec_dimm/jedec_dimm.coptional jedec_dimm smbus
dev/jme/if_jme.c optional jme pci
-dev/joy/joy.c optional joy
-dev/joy/joy_isa.c optional joy isa
dev/kbd/kbd.c optional atkbd | pckbd | sc | ukbd | vt
dev/kbdmux/kbdmux.coptional kbdmux
dev/ksyms/ksyms.c optional ksyms
Modified: head/sys/modules/Makefile
==
--- head/sys/modules/Makefile Mon Oct 22 02:28:18 2018(r339562)
+++ head/sys/modules/Makefile Mon Oct 22 02:34:00 2018(r339563)
@@ -208,7 +208,6 @@ SUBDIR= \
${_ixv} \
${_ixl} \
jme \
- joy \
kbdmux \
kgssapi \
kgssapi_krb5 \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
