Re: svn commit: r340294 - head/sys/compat/freebsd32
On Sat, Nov 10, 2018 at 12:18:13AM -0800, Eitan Adler wrote: > On Fri, 9 Nov 2018 at 10:19, Brooks Davis wrote: > > > > On Fri, Nov 09, 2018 at 06:03:01PM +, Brooks Davis wrote: > > > Author: brooks > > > Date: Fri Nov 9 18:03:01 2018 > > > New Revision: 340294 > > > URL: https://svnweb.freebsd.org/changeset/base/340294 > > > > > > Log: > > > Fix a number of bugs in freebsd32's capabilities.conf. > > > > > > Bugs range from failure to update after changing syscall implementaion > > > names to using the wrong name. Somewhat confusingly, the name in > > > capabilities.conf is exactly the string that appears in syscalls.master, > > > not the name with a COMPAT* prefix which is the actual function name. > > > > > > Found while making a change to use the default capabilities.conf. > > Is there any automated way to detect this in the future? Can we add > some test that detect non-existent syscalls or the like? https://reviews.freebsd.org/D17932 fixes most of this. It wouldn't be too hard to keep track of which syscalls were emitted and check that against the set from capabilities.conf. I'll keep that in mind. -- Brooks signature.asc Description: PGP signature
Re: svn commit: r340294 - head/sys/compat/freebsd32
On Fri, 9 Nov 2018 at 10:19, Brooks Davis wrote: > > On Fri, Nov 09, 2018 at 06:03:01PM +, Brooks Davis wrote: > > Author: brooks > > Date: Fri Nov 9 18:03:01 2018 > > New Revision: 340294 > > URL: https://svnweb.freebsd.org/changeset/base/340294 > > > > Log: > > Fix a number of bugs in freebsd32's capabilities.conf. > > > > Bugs range from failure to update after changing syscall implementaion > > names to using the wrong name. Somewhat confusingly, the name in > > capabilities.conf is exactly the string that appears in syscalls.master, > > not the name with a COMPAT* prefix which is the actual function name. > > > > Found while making a change to use the default capabilities.conf. Is there any automated way to detect this in the future? Can we add some test that detect non-existent syscalls or the like? -- Eitan Adler ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340294 - head/sys/compat/freebsd32
On Fri, Nov 09, 2018 at 06:03:01PM +, Brooks Davis wrote: > Author: brooks > Date: Fri Nov 9 18:03:01 2018 > New Revision: 340294 > URL: https://svnweb.freebsd.org/changeset/base/340294 > > Log: > Fix a number of bugs in freebsd32's capabilities.conf. > > Bugs range from failure to update after changing syscall implementaion > names to using the wrong name. Somewhat confusingly, the name in > capabilities.conf is exactly the string that appears in syscalls.master, > not the name with a COMPAT* prefix which is the actual function name. > > Found while making a change to use the default capabilities.conf. > > Fixes: r335177, r336980, r340272, r340274, others > Reviewed by:kib, emaste > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D17925 Arg, I forgot: MFC After: 3 days signature.asc Description: PGP signature
svn commit: r340294 - head/sys/compat/freebsd32
Author: brooks Date: Fri Nov 9 18:03:01 2018 New Revision: 340294 URL: https://svnweb.freebsd.org/changeset/base/340294 Log: Fix a number of bugs in freebsd32's capabilities.conf. Bugs range from failure to update after changing syscall implementaion names to using the wrong name. Somewhat confusingly, the name in capabilities.conf is exactly the string that appears in syscalls.master, not the name with a COMPAT* prefix which is the actual function name. Found while making a change to use the default capabilities.conf. Fixes:r335177, r336980, r340272, r340274, others Reviewed by: kib, emaste Sponsored by: DARPA, AFRL Differential Revision:https://reviews.freebsd.org/D17925 Modified: head/sys/compat/freebsd32/capabilities.conf Modified: head/sys/compat/freebsd32/capabilities.conf == --- head/sys/compat/freebsd32/capabilities.conf Fri Nov 9 18:02:39 2018 (r340293) +++ head/sys/compat/freebsd32/capabilities.conf Fri Nov 9 18:03:01 2018 (r340294) @@ -47,14 +47,14 @@ __mac_get_fd __mac_get_proc __mac_set_fd __mac_set_proc -freebsd32_sysctl -freebsd32_umtx_op +freebsd32___sysctl +freebsd32__umtx_op abort2 accept accept4 aio_cancel freebsd32_aio_error -aio_fsync +freebsd32_aio_fsync freebsd32_aio_read freebsd32_aio_return freebsd32_aio_suspend @@ -94,17 +94,18 @@ freebsd32_fexecve flock fork fpathconf -freebsd11_freebsd32_fstat -freebsd11_freebsd32_fstatat -freebsd11_freebsd32_getdirentries -freebsd11_freebsd32_fstatfs -freebsd11_freebsd32_mknodat -freebsd6_freebsd32_ftruncate -freebsd6_freebsd32_lseek -freebsd6_freebsd32_mmap -freebsd6_freebsd32_pread -freebsd6_freebsd32_pwrite freebsd32_fstat +freebsd32_fstatat +freebsd32_getdirentries +freebsd32_fstatfs +freebsd32_mknodat +freebsd32_ftruncate +freebsd32_lseek +freebsd32_mmap +mmap +freebsd32_pread +freebsd32_pwrite +freebsd32_fstat fstatfs fsync ftruncate @@ -115,7 +116,7 @@ getaudit getaudit_addr getauid freebsd32_getcontext -getdents +freebsd32_getdents freebsd32_getdirentries getdirentries getdomainname @@ -178,7 +179,7 @@ freebsd32_nanosleep ntp_gettime freebsd6_freebsd32_aio_read freebsd6_freebsd32_aio_write -obreak +break freebsd6_freebsd32_lio_listio chflagsat faccessat @@ -223,7 +224,7 @@ sched_get_priority_max sched_get_priority_min sched_getparam sched_getscheduler -sched_rr_get_interval +freebsd32_sched_rr_get_interval sched_setparam sched_setscheduler sched_yield @@ -260,11 +261,15 @@ freebsd32_sigaction freebsd32_sigaltstack freebsd32_sigblock freebsd32_sigpending +sigpending +freebsd32_sigprocmask sigprocmask +freebsd32_sigqueue sigqueue freebsd32_sigreturn freebsd32_sigsetmask -ofreebsd32_sigstack +freebsd32_sigstack +freebsd32_sigsuspend sigsuspend freebsd32_sigtimedwait freebsd32_sigvec ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
