Re: svn commit: r346318 - head/lib/libcasper/services/cap_fileargs

[Alexey Dokuchaev]

On Wed, Apr 17, 2019 at 04:31:30PM +, Ed Maste wrote:
> New Revision: 346318
> URL: https://svnweb.freebsd.org/changeset/base/346318
> 
> Log:
>   cap_fileargs: fix GCC build, don't shadow 'stat'
>   
> @@ -566,7 +566,7 @@ static int
>  fileargs_command_lstat(const nvlist_t *limits, nvlist_t *nvlin,
>  nvlist_t *nvlout)
>  {
> - int stat;
> + int error;
>   const char *name;
>   struct stat sb;
>  
> @@ -578,7 +578,7 @@ fileargs_command_lstat(const nvlist_t *limits, nvlist_
>  
>   name = nvlist_get_string(nvlin, "name");
>  
> - stat = lstat(name, );
> + error = lstat(name, );
>   if (stat < 0)
>   return (errno);

Looks like "if (stat < 0)" is wrong now.

./danfe


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346318 - head/lib/libcasper/services/cap_fileargs

[Ed Maste]

Author: emaste
Date: Wed Apr 17 16:31:30 2019
New Revision: 346318
URL: https://svnweb.freebsd.org/changeset/base/346318

Log:
  cap_fileargs: fix GCC build, don't shadow 'stat'
  
  Reported by:  ci.freebsd.org
  MFC after:3 weeks
  MFC with: r346315
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libcasper/services/cap_fileargs/cap_fileargs.c

Modified: head/lib/libcasper/services/cap_fileargs/cap_fileargs.c
==
--- head/lib/libcasper/services/cap_fileargs/cap_fileargs.c Wed Apr 17 
16:27:43 2019(r346317)
+++ head/lib/libcasper/services/cap_fileargs/cap_fileargs.c Wed Apr 17 
16:31:30 2019(r346318)
@@ -566,7 +566,7 @@ static int
 fileargs_command_lstat(const nvlist_t *limits, nvlist_t *nvlin,
 nvlist_t *nvlout)
 {
-   int stat;
+   int error;
const char *name;
struct stat sb;
 
@@ -578,7 +578,7 @@ fileargs_command_lstat(const nvlist_t *limits, nvlist_
 
name = nvlist_get_string(nvlin, "name");
 
-   stat = lstat(name, );
+   error = lstat(name, );
if (stat < 0)
return (errno);
 


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r346318 - head/lib/libcasper/services/cap_fileargs

[Alexey Dokuchaev]

On Wed, Apr 17, 2019 at 04:31:30PM +, Ed Maste wrote:
> New Revision: 346318
> URL: https://svnweb.freebsd.org/changeset/base/346318
> 
> Log:
>   cap_fileargs: fix GCC build, don't shadow 'stat'
>   
> @@ -566,7 +566,7 @@ static int
>  fileargs_command_lstat(const nvlist_t *limits, nvlist_t *nvlin,
>  nvlist_t *nvlout)
>  {
> - int stat;
> + int error;
>   const char *name;
>   struct stat sb;
>  
> @@ -578,7 +578,7 @@ fileargs_command_lstat(const nvlist_t *limits, nvlist_
>  
>   name = nvlist_get_string(nvlin, "name");
>  
> - stat = lstat(name, );
> + error = lstat(name, );
>   if (stat < 0)
>   return (errno);

Looks like "if (stat < 0)" is wrong now.

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346318 - head/lib/libcasper/services/cap_fileargs

[Ed Maste]

Author: emaste
Date: Wed Apr 17 16:31:30 2019
New Revision: 346318
URL: https://svnweb.freebsd.org/changeset/base/346318

Log:
  cap_fileargs: fix GCC build, don't shadow 'stat'
  
  Reported by:  ci.freebsd.org
  MFC after:3 weeks
  MFC with: r346315
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libcasper/services/cap_fileargs/cap_fileargs.c

Modified: head/lib/libcasper/services/cap_fileargs/cap_fileargs.c
==
--- head/lib/libcasper/services/cap_fileargs/cap_fileargs.c Wed Apr 17 
16:27:43 2019(r346317)
+++ head/lib/libcasper/services/cap_fileargs/cap_fileargs.c Wed Apr 17 
16:31:30 2019(r346318)
@@ -566,7 +566,7 @@ static int
 fileargs_command_lstat(const nvlist_t *limits, nvlist_t *nvlin,
 nvlist_t *nvlout)
 {
-   int stat;
+   int error;
const char *name;
struct stat sb;
 
@@ -578,7 +578,7 @@ fileargs_command_lstat(const nvlist_t *limits, nvlist_
 
name = nvlist_get_string(nvlin, "name");
 
-   stat = lstat(name, );
+   error = lstat(name, );
if (stat < 0)
return (errno);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"