Re: svn commit: r352914 - head/sys/compat/linux

2019-09-30 Thread Paweł Biernacki



> On 30 Sep 2019, at 21:05, Pawel Biernacki  wrote:
> 
> Author: kaktus
> Date: Mon Sep 30 19:05:14 2019
> New Revision: 352914
> URL: https://svnweb.freebsd.org/changeset/base/352914
> 
> Log:
>  linux_renameat2: don't add extra \n on error.
> 
>  linux_msg() already adds \n at the end of all messages.
> 
>  Reported by: emaste, kib (mentor), mjg (mentor)
>  Reviewed by: kib (mentor), mjg (mentor)

Should be:
Reviewed by:emaste, kib (mentor), mjg (mentor)
Approved by:kib (mentor), mjg (mentor)


>  Differential Revision:   https://reviews.freebsd.org/D21852
> 
> Modified:
>  head/sys/compat/linux/linux_file.c
> 
> Modified: head/sys/compat/linux/linux_file.c
> ==
> --- head/sys/compat/linux/linux_file.cMon Sep 30 19:03:43 2019
> (r352913)
> +++ head/sys/compat/linux/linux_file.cMon Sep 30 19:05:14 2019
> (r352914)
> @@ -704,7 +704,7 @@ linux_renameat2(struct thread *td, struct linux_rename
>   int error, olddfd, newdfd;
> 
>   if (args->flags != 0) {
> - linux_msg(td, "renameat2 unsupported flags 0x%x\n",
> + linux_msg(td, "renameat2 unsupported flags 0x%x",
>   args->flags);
>   return (EINVAL);
>   }

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r352914 - head/sys/compat/linux

2019-09-30 Thread Pawel Biernacki
Author: kaktus
Date: Mon Sep 30 19:05:14 2019
New Revision: 352914
URL: https://svnweb.freebsd.org/changeset/base/352914

Log:
  linux_renameat2: don't add extra \n on error.
  
  linux_msg() already adds \n at the end of all messages.
  
  Reported by:  emaste, kib (mentor), mjg (mentor)
  Reviewed by:  kib (mentor), mjg (mentor)
  Differential Revision:https://reviews.freebsd.org/D21852

Modified:
  head/sys/compat/linux/linux_file.c

Modified: head/sys/compat/linux/linux_file.c
==
--- head/sys/compat/linux/linux_file.c  Mon Sep 30 19:03:43 2019
(r352913)
+++ head/sys/compat/linux/linux_file.c  Mon Sep 30 19:05:14 2019
(r352914)
@@ -704,7 +704,7 @@ linux_renameat2(struct thread *td, struct linux_rename
int error, olddfd, newdfd;
 
if (args->flags != 0) {
-   linux_msg(td, "renameat2 unsupported flags 0x%x\n",
+   linux_msg(td, "renameat2 unsupported flags 0x%x",
args->flags);
return (EINVAL);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"