Re: svn commit: r243019 - head/sbin/route
On Wed, Nov 14, 2012 at 4:32 AM, Gleb Smirnoff gleb...@freebsd.org wrote: A Can the IN_CLASS[A-C]_NET... definitions go away as well? They are defines that don't generate any code. Also, on this mailing list I've promised once not to remove them :) I'm glad you remember :) Andre, they are used (for better or for worse) in a multi-site database synchronization protocol that currently works portably across operating systems. Removing them would change the semantics of that protocol in a subtle way that might introduce breakage. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r243019 - head/sbin/route
On Wed, Nov 14, 2012 at 11:27 AM, Eitan Adler ead...@freebsd.org wrote: On 14 November 2012 11:12, Ben Kaduk minimar...@gmail.com wrote: Andre, they are used (for better or for worse) in a multi-site database synchronization protocol that currently works portably across operating systems. Removing them would change the semantics of that protocol in a subtle way that might introduce breakage. Which one? OpenAFS. In particular, the logic to determine the sychronization site for the ubik databases uses classful addressing. -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r242934 - head/sys/dev/xen/netback
On Mon, Nov 12, 2012 at 5:28 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Mon Nov 12 22:28:32 2012 New Revision: 242934 URL: http://svnweb.freebsd.org/changeset/base/242934 Log: Redo r242889, now using the method from projects/amd64_xen_pv r240747. Reminded by: kib MFC after:3 days Modified: head/sys/dev/xen/netback/netback_unit_tests.c Modified: head/sys/dev/xen/netback/netback_unit_tests.c == --- head/sys/dev/xen/netback/netback_unit_tests.c Mon Nov 12 22:01:29 2012(r242933) +++ head/sys/dev/xen/netback/netback_unit_tests.c Mon Nov 12 22:28:32 2012(r242934) @@ -58,11 +58,11 @@ __FBSDID($FreeBSD$); #defineTOSTRING(x) STRINGIFY(x) /** - * Writes an error message to buffer if cond is false, and returns true - * iff the assertion failed. Note the implied parameters buffer and + * Writes an error message to buffer if cond is false + * Note the implied parameters buffer and At risk of being Bruce, aren't comments like this supposed to be complete sentences and end with a full stop? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r241933 - head/sys/conf
On Mon, Nov 12, 2012 at 7:47 PM, David O'Brien obr...@freebsd.org wrote: On Mon, Nov 12, 2012 at 04:29:07PM -0800, David O'Brien (@FreeBSD) wrote: $ diff -Bbw files.mips.r241680,sorted files.mips.r241933,sorted | egrep -v '^(\+|-|@@)' | wc -l 43 Sorry, should have better ensured all input lines appeared in the output. $ diff -u999 -Bbw files.mips.r241680,sorted files.mips.r241933,sorted | egrep -v '^(\+|-|@@)' | wc -l 61 Using your immediate r241936 follow on commit: $ diff -u999 -Bbw files.mips.r241680,sorted files.mips.r241936,sorted | egrep -v '^(\+|-|@@)' | wc -l 68 And by end of the day (r242031, all your commits to this file on the 23rd): $ diff -u999 -Bbw files.mips.r241680,sorted files.mips.r241986,sorted | egrep -v '^(\+|-|@@)' | wc -l My reading was that the idea was to start from scratch with a files.mips and get one that works for all configurations, instead of having a balkanized regime where each board (or nearly so) had its own files file. I don't see that there's a way for the traditional meaning of clean room for licensing concerns to apply here. -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens
On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Mon Oct 22 17:50:54 2012 New Revision: 241896 URL: http://svn.freebsd.org/changeset/base/241896 Log: Remove the support for using non-mpsafe filesystem modules. In particular, do not lock Giant conditionally when calling into the filesystem module, remove the VFS_LOCK_GIANT() and related macros. Stop handling buffers belonging to non-mpsafe filesystems. The VFS_VERSION is bumped to indicate the interface change which does not result in the interface signatures changes. Conducted and reviewed by:attilio Tested by:pho Sorry for late reply. % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 % @@ -144,15 +144,11 @@ % #define ISOPEN 0x0020 /* caller is opening; return a real vnode. */ % #define NOCROSSMOUNT0x0040 /* do not cross mount points */ % #define NOMACCHECK 0x0080 /* do not perform MAC checks */ % -#define MPSAFE 0x0100 /* namei() must acquire Giant if needed. */ It seems that removing the definition of MPSAFE causes out-of-tree filesystem modules to not build. Perhaps a definition can remain for some period to allow a smoother transition? Conditional on __FreeBSD_Version is the proper fix, of course, but takes longer to get everywhere. -Ben Kaduk % -#define GIANTHELD 0x0200 /* namei() is holding giant. */ % #define AUDITVNODE1 0x0400 /* audit the looked up vnode information */ % #define AUDITVNODE2 0x0800 /* audit the looked up vnode information */ % #define TRAILINGSLASH 0x1000 /* path ended in a slash */ % #define PARAMASK0x1e00 /* mask of parameter descriptors */ % % -#define NDHASGIANT(NDP) (((NDP)-ni_cnd.cn_flags GIANTHELD) != 0) % - % /* % * Initialization of a nameidata structure. % */ ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens
On Tue, Nov 6, 2012 at 5:53 PM, Attilio Rao atti...@freebsd.org wrote: On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk minimar...@gmail.com wrote: On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Hi Ben, no, ports/thirdy part should be adjusted on the -CURRENT ABI. Leaving MPSAFE would just leave confusion and a way to *not do* the conversion. Hi Attilio, I agree that port/thirdparty filesystems must be adjusted to the -current ABI. If the only change is ABI, not API, though, recompiling is sufficient; no code changes are needed. But the present state of affairs is that correct, working (MPSAFE) code is broken, and there was no possibility to make it correct for the new ABI prior to the ABI change. It seems rather inconsiderate of the users of -current (and we really want people to continue to run -current!) to gratuitously break the API (well, KPI) as well as KBI, when KPI change is not immediately necessary. I must tell the user to include #define MPSAFE (0) as a workaround until a patch can be committed to the port, let alone the upstream! The 10.0 release is a bit off, yet; can we not spare a few months for lag between KBI change and KPI change to allow third-parties who are paying attention to get a smooth transition? Rebuild the port is much easier than observe errors, dink around for a while investigating, patch the code, and rebuild the port. MPSAFE deorbit is a long-term project (which I am very happy to see happen; thank you both Attilio and Kostantin and all!), but this step seems rushed. Why must KPI change occur in lockstep with KBI change? -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens
I do not wish to belabor the point; we all have better things to do with our time. Hopefully this is my last message on the topic. On Tue, Nov 6, 2012 at 6:10 PM, Attilio Rao atti...@freebsd.org wrote: The point is that KPI/KBI of -CURRENT can change as long as __FreeBSD_version is bumped (and if you really want to know my opinion, I already see this as a forceful thing because it would not be necessary in my mind, but I second the will of the majority of developers). So, if the KPI/KBI changes all the thirdy part code, ports and everything else must adapt. Yes, everything must adapt to changes in -current. I am arguing that, if it is easy to do so, we should make the user experience for *ordinary users* running -current as nice as possible. If we do not have ordinary users running current, then our code does not get real-world testing until RC builds, or even the .0 release. I think it is well-accepted that we want to have the code in -current get real-world testing; making the user experience nicer helps this to happen. To me, it seems that the user experience is nicer if the KPI change is delayed from the KBI change. We have mechanisms in place that can enforce __FreeBSD_Version of kernel modules must match the version of the running kernel, so I do not see how this procedure would lead to silent binary incompatibility. MPSAFE flag is not any longer supported and code needs to be ported appropriately to -CURRENT interface. That is the present state of affairs, yes. I am asking only, think of the users; can we make things easier for them?. Maybe not in this case, but as something to keep in mind for the future. Thanks, Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample
On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd adr...@freebsd.org wrote: --- head/sys/dev/ath/ath_rate/sample/sample.c Tue Jul 31 23:54:15 2012 (r238961) +++ head/sys/dev/ath/ath_rate/sample/sample.c Wed Aug 1 00:18:02 2012 (r238962) @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_softc *sc, mrr = sc-sc_mrretry; /* XXX check HT protmode too */ - if (mrr (ic-ic_flags IEEE80211_F_USEPROT) !sc-sc_mrrprot) + if (mrr (ic-ic_flags IEEE80211_F_USEPROT !sc-sc_mrrprot)) mrr = 0; best_rix = pick_best_rate(an, rt, size_bin, !mrr); Logical '' evaluates left-to-right already, so I do not see that the current parentheses are needed? -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r232496 - head/share/man/man4
On Sun, Mar 4, 2012 at 2:32 PM, Eitan Adler ead...@freebsd.org wrote: On Sun, Mar 4, 2012 at 1:52 PM, John Baldwin j...@freebsd.org wrote: Can you do a forced commit to add a commit log of the actual change please? I don't know of any real way to do forced commits so does the following look acceptable? You should be able to start that commit with an interactive editor for the commit message, background the editor, revert the actual change, and then foreground the editor and finish the commit. I believe that's the current best practice for doing forced commits. -Ben %cat log Forced commit because I forgot my log message in r232496: Fix a variety of English language grammar issues and style nits %svn diff Index: share/man/man4/jme.4 === --- share/man/man4/jme.4 (revision 231896) +++ share/man/man4/jme.4 (working copy) Property changes on: share/man/man4/jme.4 ___ Added: forcecommit ## -0,0 +1 ## +1 \ No newline at end of property -- Eitan Adler Source Ports committer X11, Bugbusting teams ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r232473 - in head: share/mk sys/conf
On Sat, Mar 3, 2012 at 3:03 PM, Doug Barton do...@freebsd.org wrote: On 03/03/2012 10:58, Dimitry Andric wrote: However, since it is apparently an expected use case to build using old .mk files, Expected how? It shouldn't happen if you're building in /usr/src. Wouldn't it be better to track down the real bug? I, for one, am frequently building in /usr/ports. I have not checked, but I could very easily see that pulling the system .mk files from the installed locations and not the source tree. -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r232238 - in head: share/man/man4 sys/dev/e1000 sys/dev/ixgbe sys/dev/netmap sys/dev/re sys/net tools/tools/netmap
On Mon, Feb 27, 2012 at 2:05 PM, Luigi Rizzo lu...@freebsd.org wrote: Author: luigi Date: Mon Feb 27 19:05:01 2012 New Revision: 232238 URL: http://svn.freebsd.org/changeset/base/232238 Log: A bunch of netmap fixes: USERSPACE: 1. add support for devices with different number of rx and tx queues; 2. add better support for zero-copy operation, adding an extra field to the netmap ring to indicate how many buffers we have already processed but not yet released (with help from Eddie Kohler); 3. The two changes above unfortunately require an API change, so while at it add a version field and some spares to the ioctl() argument to help detect mismatches. Is it worth bumping __FreeBSD_version? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r230207 - in head/sys: netinet sys
On 1/19/12, Gleb Smirnoff gleb...@freebsd.org wrote:
On Thu, Jan 19, 2012 at 06:46:27PM +0200, Gleb Kurtsou wrote:
G It's not a big deal for me, I have no problem with replacing them on
G FreeBSD. FreeBSD is not even officially supported platform for the
G product and I build/test on FreeBSD solely for the purpose of avoiding
G linuxisms and platform specific behaviour. Let's hope it won't break for
G somebody else :)
I'm pretty sure it will not break anyone, except for people still living
in Internet with classdful addressing. Do you know any?
Not directly as classful addressing per se, but the interpretation of
an address as possibly-classful is encoded in the voting algorithm for
the ubik server elections that make our AFS distributed filesystem
work. We support having ubik servers on quite a few different OSes,
and we can only change the voting algorithm with an OpenAFS major
version number bump because of our interoperability guarantees.
I'm not willing to claim that removing classfull addressing will
preserve the voting algorithm without an in-depth review that I don't
have time to undertake.
When you removed ia_net{,mask} from struct in_ifaddr (with no
__FreeBSD_version bump! And then merged it to 9.0 during the RC
stage!), I had to scramble to keep net/openafs compiling and with the
same functionality. It turns out that there is another code path in
OpenAFS (used by e.g. Darwin) that instead uses the IN_CLASSA() family
of macros, so I could preserve compatibility. But if you go and
remove those too, I am screwed.
Please don't just assume that no one is using classful addressing and
remove things ahead of a reasonable deprecation schedule.
-Ben Kaduk
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm
On Sun, Jan 1, 2012 at 12:33 PM, Ulrich Spoerlein u...@freebsd.org wrote:
On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote:
On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein u...@freebsd.org wrote:
Modified: head/usr.sbin/cron/doc/CHANGES
==
--- head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:45:00 2011
(r228989)
+++ head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:58:14 2011
(r228990)
@@ -1,3 +1,6 @@
+$FreeBSD$
+
+
Vixie Cron Changes from V2 to V3
Paul Vixie
29-Dec-1993
@@ -20,7 +23,7 @@ be reread whenever it changes.
I also added a -e option to crontab(1). Nine people also sent me diffs
to add this option, but I had already implemented it on my own. I
actually
-released an interrim version (V2.2, I think) for limited testing, and got
a
+released an interim version (V2.2, I think) for limited testing, and got a
Should we really be in the business of modifying Vixie's changelog?
I'm replying here, but same goes for your comments on the other revision
(thanks for all those, btw).
Warning, rant ahead:
I can handle a rant :)
Our current SVN repo is in an inconsistent state thanks to the dubious
introduction of svn keywords. There are files in there, converted over
via cvs2svn and never touched since, but our presubmit checks want to
either see a $FreeBSD$ tag in modified files, or have fbsd:nokeywords
set. The latter is kinda a no-brainer for everything under contrib/ but
I'm struggling with what to do exactly for files that are non-contrib
and may or may not be non-code. Should the keywords be set on $subdir/*
or can I punch holes in the web of keywords as I see fit? (e.g.
$subdir/{README,CHANGES,foo.txt})
What's the point then anyway? SVN doesn't track files, but changesets.
Gah!
I guess I did assume that the $FreeBSD$ keyword was being added
because of the presubmit checks, but didn't actually say so. Sorry.
It definitely is a grey area in which I don't presume to have an
opinion, and I sympathize with your frustration.
Oh wait, this ain't about the $FreeBSD$ keyword, but the typo-fix? I'm
sure that Vixie won't mind and do believe that correctness of spelling
is a worthy goal as we always tout the quality of our documentation.
I can accept that argument -- I mostly wanted to make sure this wasn't
just a mechanical run aspell over everything or similar (though a
later change did reveal that to not be the case).
FWIW, I'm not going to touch stuff under contrib/, etc.
Sounds fine.
/*
- * Delete a rotated logfiles, when using clasic filenames.
+ * Delete a rotated logfiles, when using classic filenames.
a logfiles is inconsistent. Without looking up the implementation,
I'm going to guess that a rotated logfile is correct.
When proofreading the spell-checked output I focused too narrowly on
just the typo that I fixed so that other typos in the same line/sentence
mostly went unnoticed. Will do better in the next couple of commits.
It's easy to do -- I actually found myself also doing so a couple
times when going through these. (There were quite a number of them,
and thanks for going through them all by hand!)
-Ben Kaduk
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm
On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber g...@freebsd.org wrote: On Fri, Dec 30, 2011 at 07:54:44PM +, Alexey Dokuchaev wrote: On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote: On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein u...@freebsd.org wrote: - * is 11 bit wide that gives us upto 2048 chunks. + * is 11 bit wide that gives us up to 2048 chunks. Should be 11 bits, no? I'm not a native speaker, but I think 11 bit wide is correct here. I could have probably got into specifics, but simple googling for 16 ton shit dropped on me yielded 525M results, while the same phrase with tons only 18,9M. :-^ Considering the full context, maybe it would be better written as: rsp_cs is an 11 bit wide field that gives ... (I'm a native speaker, too.) Were I to seriously wordsmith the comment, I would make it: * The minimum L2CAP MTU is 43 bytes. That means we need * ceiling(65536 / 43) = 1525 chunks to transfer the maximum * packet size with minimum MTU. Since the rsp_cs field in * fd_idx_t is 11 bits wide, that allows up to 2048 chunks which * is more than sufficient. But it may not be worth worrying about it this much. -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm
== --- head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:45:00 2011 (r228989) +++ head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:58:14 2011 (r228990) @@ -1,3 +1,6 @@ +$FreeBSD$ + + Vixie Cron Changes from V2 to V3 Paul Vixie 29-Dec-1993 @@ -20,7 +23,7 @@ be reread whenever it changes. I also added a -e option to crontab(1). Nine people also sent me diffs to add this option, but I had already implemented it on my own. I actually -released an interrim version (V2.2, I think) for limited testing, and got a +released an interim version (V2.2, I think) for limited testing, and got a Should we really be in the business of modifying Vixie's changelog? chance to fix a bad security bug in the -e option thanks to XXX. The daemon used to be extraordinarily sloppy in its use of file descriptors. @@ -57,7 +60,7 @@ which explains why a lot of other people syslog even when they configured it that way :-). Steve Simmons told me first, though, so he gets the point. -An interrim version of the daemon tried to stat every file before +An interim version of the daemon tried to stat every file before executing it; this turned out to be a horribly bad idea since finding the name of a file from a shell command is a hard job (that's why we have shells, right?) I removed this bogus code. Dave Burgess gets the point. Modified: head/usr.sbin/newsyslog/newsyslog.c == --- head/usr.sbin/newsyslog/newsyslog.c Fri Dec 30 10:45:00 2011 (r228989) +++ head/usr.sbin/newsyslog/newsyslog.c Fri Dec 30 10:58:14 2011 (r228990) @@ -1597,7 +1597,7 @@ delete_oldest_timelog(const struct conf_ } /* - * Generate a log filename, when using clasic filenames. + * Generate a log filename, when using classic filenames. */ static void gen_clasiclog_fname(char *fname, size_t fname_sz, const char *archive_dir, @@ -1612,7 +1612,7 @@ gen_clasiclog_fname(char *fname, size_t } /* - * Delete a rotated logfiles, when using clasic filenames. + * Delete a rotated logfiles, when using classic filenames. a logfiles is inconsistent. Without looking up the implementation, I'm going to guess that a rotated logfile is correct. */ static void delete_clasiclog(const char *archive_dir, const char *namepart, int numlog_c) Modified: head/usr.sbin/ntp/doc/ntp.conf.5 == --- head/usr.sbin/ntp/doc/ntp.conf.5 Fri Dec 30 10:45:00 2011 (r228989) +++ head/usr.sbin/ntp/doc/ntp.conf.5 Fri Dec 30 10:58:14 2011 (r228990) @@ -783,7 +783,7 @@ The remaining files are necessary only f Autokey protocol. .Pp Certificates imported from OpenSSL or public certificate -authorities have certian limitations. *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** Hmm, that's unfortunate. Pulling out a svn client, it looks like: usr.sbin/pkg_install/lib/plist.c changes a misspelled form to the still-misspelled occurrance (not occurrence) Thanks for doing this cleanup along with the encoding cleanup! -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r228992 - in head/usr.bin: csup finger fstat indent ipcs lex limits locate/locate login mail make man ncplogin netstat pr rpcgen rpcinfo systat talk tip/tip top vgrind xlint/lint1 xlin
(r228992) @@ -1,3 +1,5 @@ +$FreeBSD$ + NEWS, CHANGES, NEW_FEATURES, all similar, I suppose. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r228571 - in head: . lib/libc/net sbin/ifconfig share/man/man4 sys/net sys/netinet sys/netinet6 sys/sys
+.\function against the source IP address in the ARP request to determine +.\which vhid should this request belong to. +.\If the corresponding CARP interface is in master state, the ARP request +.\will be replied, otherwise it will be ignored. +.\See the +.\.Sx EXAMPLES +.\section for a practical example of load balancing. +.\.Pp +.\The ARP load balancing has some limitations. +.\First, ARP balancing only works on the local network segment. +.\It cannot balance traffic that crosses a router, because the +.\router itself will always be balanced to the same virtual host. +.\Second, ARP load balancing can lead to asymmetric routing +.\of incoming and outgoing traffic, and thus combining it with +.\.Xr pfsync 4 +.\is dangerous, because this creates a race condition between +.\balanced routers and a host they are serving. +.\Imagine an incoming packet creating state on the first router, being +.\forwarded to its destination, and destination replying faster +.\than the state information is packed and synced with the second router. +.\If the reply would be load balanced to second router, it will be +.\dropped due to no state. .Sh STATE CHANGE NOTIFICATIONS Sometimes it is useful to get notified about .Nm Hi Gleb, Perhaps the man page portions that were commented out should just be removed entirely? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r227797 - head/share/mk
2011/11/22 Rui Paulo rpa...@freebsd.org: On 2011/11/22, at 21:33, Dag-Erling Smørgrav wrote: Rui Paulo rpa...@freebsd.org writes: With this change, I can no longer update a FreeBSD 9.0-current system from June 2010 to FreeBSD 10.0. I suspect I'm not the only one. Sorry, my mind reader is broken at the moment, so you'll have to provide more information than that. If I had more information, I would have provided it. I'm still diagnosing the problem someone else created. That is to say ... take a machine running 9-current from june 2010 which has no issues. Fetch a HEAD source tree and try the usual buildworld process, and watch it explode. Right? -Ben ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r227778 - head/sys/net
On Sun, Nov 20, 2011 at 11:17 PM, Lawrence Stewart lstew...@freebsd.org wrote: Author: lstewart Date: Mon Nov 21 04:17:24 2011 New Revision: 227778 URL: http://svn.freebsd.org/changeset/base/227778 Log: - When feed-forward clock support is compiled in, change the BPF header to contain both a regular timestamp obtained from the system clock and the current feed-forward ffcounter value. This enables new possibilities including Is it really necessary to make the ABI dependent on a kernel configuration option? This causes all sorts of headaches if loadable modules ever want to use that ABI, something that we just ran into with vm_page_t and friends and had a long thread on -current about. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r226635 - head/usr.bin/tar
On Sat, Oct 22, 2011 at 12:52 PM, Tim Kientzle kient...@freebsd.org wrote: Author: kientzle Date: Sat Oct 22 16:52:04 2011 New Revision: 226635 URL: http://svn.freebsd.org/changeset/base/226635 Log: Bring in the --gid --gname --uid and --uname implementation from libarchive.googlecode.com. MFC after: 3 days Thanks! (Your earlier mail was unclear whether you would actually get to it, so I had been planning to take a look, but hadn't had time, yet.) -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r224475 - head/usr.sbin/jail
On Thu, Jul 28, 2011 at 7:41 AM, Benedict Reuschling b...@freebsd.org wrote: Author: bcr (doc committer) Date: Thu Jul 28 11:41:55 2011 New Revision: 224475 URL: http://svn.freebsd.org/changeset/base/224475 Log: Add a section to the jail chapter that explains why it is not recommended to allow root users in the jail to access the host system. PR: docs/156853 Submitted by: crees Patch by: crees Approved by: re (kib) for BETA1 Modified: head/usr.sbin/jail/jail.8 Modified: head/usr.sbin/jail/jail.8 == --- head/usr.sbin/jail/jail.8 Thu Jul 28 10:16:30 2011 (r224474) +++ head/usr.sbin/jail/jail.8 Thu Jul 28 11:41:55 2011 (r224475) @@ -34,7 +34,7 @@ .\ .\ $FreeBSD$ .\ -.Dd July 23, 2011 +.Dd July 28, 2011 .Dt JAIL 8 .Os .Sh NAME @@ -914,3 +914,8 @@ directory that is moved out of the jail' access to the file space outside of the jail. It is recommended that directories always be copied, rather than moved, out of a jail. +.Pp +It is also not recommended that users allowed root in the jail be allowed +access to the host system. +For example, a root user in a jail can create a setuid root utility that +could be run in the host system to achieve elevated privileges. Per rwatson's comment on the other jail.8 thread we've got going, we might recommend that the separate file system for a jail might also be mounted nosuid, which would close off this class of attack. I don't have a good sense of whether suid applications are frequently useful/needed inside a jail, though. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r223722 - in head/sys: kern sys
On Sat, Jul 2, 2011 at 9:54 AM, Ed Schouten e...@freebsd.org wrote: Author: ed Date: Sat Jul 2 13:54:20 2011 New Revision: 223722 URL: http://svn.freebsd.org/changeset/base/223722 Log: Reintroduce the cioctl() hook in the TTY layer for digi(4). The cioctl() hook can be used by drivers to add ioctls to the *.init and *.lock devices. This commit breaks the ttydevsw ABI, since this Aren't __FreeBSD_version bumps cheap, these days? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r223380 - head/sys/dev/xl
On Tue, Jun 21, 2011 at 4:51 PM, Warner Losh i...@freebsd.org wrote: Author: imp Date: Tue Jun 21 20:51:09 2011 New Revision: 223380 URL: http://svn.freebsd.org/changeset/base/223380 --- head/sys/dev/xl/if_xl.c Tue Jun 21 20:50:55 2011 (r223379) +++ head/sys/dev/xl/if_xl.c Tue Jun 21 20:51:09 2011 (r223380) @@ -334,7 +334,7 @@ xl_dma_map_addr(void *arg, bus_dma_segme * only a finite amount of time to avoid getting caught in an * infinite loop. Normally this delay routine would be a macro, * but it isn't called during normal operation so we can afford - * to make it a function. + * to make it a function. Spress warning when card gone. ^^^u -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont
On Sat, Jun 18, 2011 at 9:56 AM, Ben Laurie b...@freebsd.org wrote:
Author: benl
Date: Sat Jun 18 13:56:33 2011
New Revision: 223262
URL: http://svn.freebsd.org/changeset/base/223262
Log:
Fix clang warnings.
Approved by: philip (mentor)
Modified: head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c
==
--- head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c Sat
Jun 18 13:54:36 2011 (r223261)
+++ head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c Sat
Jun 18 13:56:33 2011 (r223262)
@@ -45,6 +45,7 @@
#include assert.h
#include libgen.h
#include limits.h
+#include stdint.h
#include dt_impl.h
@@ -811,15 +812,14 @@ dt_basename(char *str)
ulong_t
dt_popc(ulong_t x)
{
-#ifdef _ILP32
+#if defined(_ILP32)
x = x - ((x 1) 0xUL);
x = (x 0xUL) + ((x 2) 0xUL);
x = (x + (x 4)) 0x0F0F0F0FUL;
x = x + (x 8);
x = x + (x 16);
return (x 0x3F);
-#endif
-#ifdef _LP64
+#elif defined(_LP64)
x = x - ((x 1) 0xULL);
x = (x 0xULL) + ((x 2) 0xULL);
x = (x + (x 4)) 0x0F0F0F0F0F0F0F0FULL;
@@ -827,6 +827,8 @@ dt_popc(ulong_t x)
x = x + (x 16);
x = x + (x 32);
return (x 0x7F);
+#else
+# warning need td_popc() implementation
We seem to still be in dt_popc(), here.
-Ben Kaduk
#endif
}
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r219573 - head/sbin/geom/class/part
On Sat, Mar 12, 2011 at 12:05 PM, Andrey V. Elsukov a...@freebsd.org wrote: Author: ae Date: Sat Mar 12 17:05:18 2011 New Revision: 219573 URL: http://svn.freebsd.org/changeset/base/219573 Log: Document GEOM_PART_EBR_COMPAT option. MFC after: 2 weeks Modified: head/sbin/geom/class/part/gpart.8 Modified: head/sbin/geom/class/part/gpart.8 == --- head/sbin/geom/class/part/gpart.8 Sat Mar 12 17:03:41 2011 (r219572) +++ head/sbin/geom/class/part/gpart.8 Sat Mar 12 17:05:18 2011 (r219573) @@ -24,7 +24,7 @@ .\ .\ $FreeBSD$ .\ -.Dd March 9, 2011 +.Dd March 12, 2011 .Dt GPART 8 .Os .Sh NAME @@ -38,6 +38,7 @@ lines in your kernel configuration file: .Cd options GEOM_PART_APM .Cd options GEOM_PART_BSD .Cd options GEOM_PART_EBR +.Cd options GEOM_PART_EBR_COMPAT .Cd options GEOM_PART_GPT .Cd options GEOM_PART_MBR .Cd options GEOM_PART_PC98 @@ -58,6 +59,11 @@ The option adds support for the Extended Boot Record (EBR), which is used to define a logical partition. The +.Dv GEOM_PART_EBR_COMPAT +option enables the backward compatibility for the partition names I think just enables backward compatibility is more standard English usage. Not knowing much about the EBR scheme, I would also guess that for partition names in the EBR scheme is what is intended here, but that would be something of a guess. +of the EBR scheme. Also it makes impossible any types of actions +with such partitions. Judging by, e.g. r216755 of g_part_ebr.c, it seems that the sense of impossible is reversed. I think It also allows such partitions to be modified might be what is intended? -Ben Kaduk +The .Dv GEOM_PART_GPT option adds support for the GUID Partition Table (GPT) found on Intel Itanium computers and Intel-based Macintosh computers. ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r217097 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include sun4v/include
On Fri, Jan 7, 2011 at 9:22 AM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Fri Jan 7 14:22:34 2011 New Revision: 217097 URL: http://svn.freebsd.org/changeset/base/217097 Log: Add AT_STACKPROT elf aux vector. Will be used to inform rtld about the initial stack protection set by the kernel image activator. == --- head/sys/amd64/include/elf.h Fri Jan 7 14:17:29 2011 (r217096) +++ head/sys/amd64/include/elf.h Fri Jan 7 14:22:34 2011 (r217097) @@ -94,8 +94,9 @@ __ElfType(Auxinfo); #define AT_NCPUS 19 /* Number of CPUs. */ #define AT_PAGESIZES 20 /* Pagesizes. */ #define AT_PAGESIZESLEN 21 /* Number of pagesizes. */ +#define AT_STACKPROT 23 /* Initial stack protection. */ -#define AT_COUNT 22 /* Count of defined aux entry types. */ +#define AT_COUNT 24 /* Count of defined aux entry types. */ Is there a reason to skip 22? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r216591 - head
On Mon, Dec 20, 2010 at 10:17 AM, Alexander Leidinger netch...@freebsd.org wrote: == --- head/UPDATING Mon Dec 20 14:54:24 2010 (r216590) +++ head/UPDATING Mon Dec 20 15:17:34 2010 (r216591) @@ -1136,8 +1136,8 @@ COMMON ITEMS: reboot in single user [3] mergemaster -p [5] make installworld - make delete-old mergemaster -i [4] + make delete-old [6] reboot There is of course the issue of when a file is erroneously listed in ObsoleteFiles.inc and deleted by delete-old. The previous order would have installworld come in and correct the error, but the current version leaves that file deleted. So there is something of a tradeoff. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r215176 - in head: . share/man/man9
On Fri, Nov 12, 2010 at 7:07 AM, Sergey Kandaurov pluk...@freebsd.org wrote: Author: pluknet Date: Fri Nov 12 12:07:36 2010 New Revision: 215176 URL: http://svn.freebsd.org/changeset/base/215176 Log: Stop documenting vgonel() after its converting to the static function: svn r147332 (by jeff): Don't make vgonel() globally visible. While here, specify the vnode locking scheme for vgone(). Thanks! (I was going to send a follow-up to -hackers in a few days, otherwise.) -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys
On Fri, Nov 12, 2010 at 8:02 AM, Luigi Rizzo lu...@freebsd.org wrote: Author: luigi Date: Fri Nov 12 13:02:26 2010 New Revision: 215178 URL: http://svn.freebsd.org/changeset/base/215178 This change adds a field to 'struct socket', but the struct is not part of any driver or userland-visible ABI so the change should be harmless. It changes the KBI, though. I maintain a third-party kernel module that uses sockets (it will hopefully hit the Ports Collection this week); since this addition is at the end of the struct, it is probable that this module will not need to be recompiled, but I haven't yet checked. That said, I hear __FreeBSD_version bumps are cheap. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r213643 - head/usr.bin/ar
On Sat, Oct 9, 2010 at 1:31 AM, Tim Kientzle kient...@freebsd.org wrote: Author: kientzle Date: Sat Oct 9 05:31:08 2010 New Revision: 213643 URL: http://svn.freebsd.org/changeset/base/213643 Log: Add -D (deterministic) option to ar. When set, it forces all timestamps and owners to zero and modes to 0644. Useful for producing libraries that are bitwise identical across multiple build runs. Thanks! Has anyone looked at the feasibility of setting AR?=ar -D in sys.mk? I will probably try this when I get my scratch box up again. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r213398 - head/bin/rm
On Mon, Oct 4, 2010 at 7:42 AM, Alexander Best arun...@freebsd.org wrote: On Mon Oct 4 10, Pawel Jakub Dawidek wrote: On Mon, Oct 04, 2010 at 02:35:54PM +0400, Dmitry Morozovsky wrote: On Mon, 4 Oct 2010, Alexander Best wrote: AB The -P option assumes that the underlying file system is a fixed-block AB file system. UFS is a fixed-block file system, LFS is not. In addition, AB only regular files are overwritten, other types of files are not. Maybe s/LFS/ZFS/ then, as LFS is no more relevant for FreeBSD users while ZFS now is? That's what I thought too. good point. ZFS should really be added to the list and LFS should go away. are there any other relevant filesystems without a fixed-block size that need to be mentioned? what about afs? or tmpfs? I'm not fully up-to-speed on the AFS fileserver backend, but it is certainly the case that AFS cannot guarantee that rm -P will actually overwrite the data on-disk. There are probably several mechanisms by which this could happen, the easiest to see of which would be if a filesystem like ZFS was used as the backing store for the fileserver partitions. also: is this really something belonging into a BUGS section? personally i think the BUGS section in rm(1) should be renamed to CAVEATS. BUGS is easier to find than CAVEATS, though I guess rm(1) is short enough that we can expect people to read the whole thing. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r211650 - head/share/man/man4
On Sun, Aug 22, 2010 at 5:32 PM, Pyun YongHyeon yong...@freebsd.org wrote: --- head/share/man/man4/rl.4 Sun Aug 22 21:27:15 2010 (r211649) +++ head/share/man/man4/rl.4 Sun Aug 22 21:32:48 2010 (r211650) @@ -30,7 +30,7 @@ .\ .\ $FreeBSD$ .\ -.Dd November 1, 2008 +.Dd August 22, 2010 .Dt RL 4 .Os .Sh NAME @@ -203,6 +203,13 @@ SOHO (PRAGMATIC) UE-1211C .El .Sh LOADER TUNABLES .Bl -tag -width indent +.It Va dev.rl.%unit.prefer_iomap +This tunable controls which register mapping should be used on the +specified device. +Non-zero value enables I/O space register mapping. Non-zero values enable or A non-zero value enables is better. +For controllers that have no I/O space register mapping this tunable +should be set to 0 to use I/O space register mapping. This seems odd -- should this^^^ be memory instead of I/O? Thanks, Ben Kaduk +The default value is 1 to use I/O space register mapping. .It Va dev.rl.%unit.twister_enable Non-zero value enables the long cable tuning on the specified device. Disabled by default. ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r210065 - head/usr.bin/gcore
On Wed, Jul 14, 2010 at 1:46 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Wed Jul 14 17:46:44 2010 New Revision: 210065 URL: http://svn.freebsd.org/changeset/base/210065 Log: Fix spelling. == --- head/usr.bin/gcore/gcore.1 Wed Jul 14 17:38:01 2010 (r210064) +++ head/usr.bin/gcore/gcore.1 Wed Jul 14 17:46:44 2010 (r210065) @@ -64,11 +64,11 @@ Write the core file to the specified fil .Dq Pa core.pid . .It Fl f Dumps all the available segments, excluding only the malformed ones and -un-dumpable ones. Differently from the default invocation, it also dumps -device-mapped and sglist-mapped areas that may invalidate the state of -some transactions. This flag, then, may be used very carefully, when the -full behaviour of the application is full-understood and the fallouts can -be easilly controlled. +un-dumpable ones. Unlike the default invocation, it also dumps +device- and sglist-mapped areas that may invalidate the state of +some transactions. This flag must be used very carefully, when the +behavior of the application is fully understood and the fallouts can +be easily controlled. .It Fl s Stop the process while gathering the core image, and resume it when done. Still has the style bug of not starting new sentences on new lines. Also, fallout should be singular, here. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r207709 - head/sys/dev/iwn
On Thu, May 6, 2010 at 1:53 PM, Bernhard Schmidt bschm...@freebsd.org wrote: Author: bschmidt Date: Thu May 6 17:53:04 2010 New Revision: 207709 URL: http://svn.freebsd.org/changeset/base/207709 Log: Add a workaround for a bug in the firmware regarding the transition from passive to active scans. Basicly disable it by increasing the amount packets to be received to an amount which can't be reached during dwell times. Is this expected to fix the firmware errors that have cropped up periodically for me? (Sorry for the lack of useful bug reports, etc.) Thanks, Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
