Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Niclas Zeising]

On 2020-10-22 15:22, Kyle Evans wrote:

On Sat, Oct 17, 2020 at 11:40 AM Warner Losh  wrote:




On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov  wrote:


17.10.2020, 14:07, "Hans Petter Selasky" :

On 2020-10-17 14:34, Alexander V. Chernikov wrote:

  17.10.2020, 12:32, "Hans Petter Selasky" :

   On 2020-10-17 13:27, Alexander V. Chernikov wrote:

 02.10.2020, 19:26, "Emmanuel Vadot" mailto:m...@freebsd.org>>:

  Author: manu
  Date: Fri Oct 2 18:26:41 2020
  New Revision: 366372
  URL: https://svnweb.freebsd.org/changeset/base/366372

  Log:
 linuxkpi: Add backlight support

 Add backlight function to linuxkpi.
 Graphics drivers expose the backlight of the panel 
directly so
   allow them
  to use the backlight subsystem so
 user can use backlight(8) to configure them.

 Reviewed by: hselasky
 Relnotes: yes
 Differential Revision: The FreeBSD Foundation

  Added:
 head/sys/compat/linuxkpi/common/include/linux/backlight.h
   (contents,
  props changed)
  Modified:
 head/sys/compat/linuxkpi/common/include/linux/device.h
 head/sys/compat/linuxkpi/common/src/linux_kmod.c
 head/sys/compat/linuxkpi/common/src/linux_pci.c
 head/sys/conf/kmod.mk

 It breaks the build for me with
 
/usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
 fatal error: 'backlight_if.h' file not found


   How do you build? Doesn't break over here.

  GENERIC + COMPAT_LINUXKPI.



Try adding:

options backlight

To the kernel config.

Yep, thank you!
Maybe it's worth considering adding static assert with the message describing 
this dependency?



Yes. It likely is worth doing something to highlight this issue.

Warner



I think we just need to slap the two core backlight files with an ` |
compat_linux` so that they simply get pulled in if you specify
COMPAT_LINUX. config(8) handles this terribly, configng must have a
better provides/requires/implies/whatever functionality so we can
specify that compat_linux implies backlight and not do crud like this
where it becomes more complicated to see what any given option really
entails.

Thanks,


COMPAT_LINUX can't be right.  Isn't that the linuxolator?
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

[Niclas Zeising]

On 2020-09-29 17:26, Scott Long wrote:



On Sep 27, 2020, at 2:41 AM, Niclas Zeising  wrote:

On 2020-09-27 03:38, Scott Long wrote:

On Sep 26, 2020, at 5:24 PM, Rodney W. Grimes  wrote:






On Sep 26, 2020, at 1:22 PM, Warner Losh  wrote:




I am the wrong person to answer that question.

In this case, things have not become lame.  For instance, the names
ervers for se.freebsd.org work fine, but ftp3.se and ftp6.se records are
removed.  Same for ru.freebsd.org and ftp4.ru.
I'm merely pointing out that changing ftp.CC.freebsd.org usually
requires contacting the person(s) maintaining the CC.freebsd.org zone,
which is usually not the project.

It's usually people associated with the project in some way, but who might not 
be as responsive as cluster admin. These domains have been delegated, so we 
have to get the delegated admin to make the changes, which can take a bit of 
time to chase down and doesn't lend itself to easy / automated coping with this 
situation.



Just a spitball idea here, but maybe we should consider not embedding these 
lists of mirror URLs into the binaries.  It seems pretty straight-forward that 
the list evolves over time, and that evolution is not tightly coupled with the 
updating of the binaries.  It sounds like the pkg and freebsd-update 
infrastructure use DNS TXT and/or SRV records to point to the metadata needed 
to construct a mirror URL list dynamically.  Maybe something similar can be 
done for bsdconfig?  If it?s not a crazy idea, is there anyone who would be 
interested in helping me write a proposal over at arch@?


100% behind that idea!  Especially since it seems the project has lost
(some) control over its DNS space, which IMHO, is still an issue, if
the people whom DNS zones have been deligated to are not responsive
that should also

Words of agreement don’t help at the moment, though i appreciate your 
enthusiasm.  Would you he able to help write a proposal for the arch@ mailing 
list?


I think this is the wrong approach, and the better approach is to have the 
official installer use download.freebsd.org (which already is geo-located).  I 
also feel like this is probably something that core and possibly clusteradm 
should weigh in on, since it affects how we distribute FreeBSD.

My impression was that we were generally trying to move away from mirrors 
hosted by various people and organizations all over the world, where we have 
little control, to our own mirrors behind download.freebsd.org.  If this is the 
case, perhaps we should do so in the installer as well.



I’m totally fine with this.  Also, I don’t speak for core on my own, but I am 
part of core.  We’re trying to encourage public discussion and participation on 
these kinds of issues, so that’s why I’m suggesting that this conversation 
should move to an appropriate mailing list.


I'll try to come up with something that uses download.freebsd.org, and 
send it out for discussion.  I'm not sure I can make it in time for 12.2 
though, so in the meantime I'll MFC this commit and ask re@ about 
getting it into 12.2.  That way users won't stumble over the obviously 
dead mirrors while we discuss a better approach for the future.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

[Niclas Zeising]

On 2020-09-27 03:38, Scott Long wrote:




On Sep 26, 2020, at 5:24 PM, Rodney W. Grimes  wrote:






On Sep 26, 2020, at 1:22 PM, Warner Losh  wrote:




I am the wrong person to answer that question.

In this case, things have not become lame.  For instance, the names
ervers for se.freebsd.org work fine, but ftp3.se and ftp6.se records are
removed.  Same for ru.freebsd.org and ftp4.ru.
I'm merely pointing out that changing ftp.CC.freebsd.org usually
requires contacting the person(s) maintaining the CC.freebsd.org zone,
which is usually not the project.

It's usually people associated with the project in some way, but who might not 
be as responsive as cluster admin. These domains have been delegated, so we 
have to get the delegated admin to make the changes, which can take a bit of 
time to chase down and doesn't lend itself to easy / automated coping with this 
situation.



Just a spitball idea here, but maybe we should consider not embedding these 
lists of mirror URLs into the binaries.  It seems pretty straight-forward that 
the list evolves over time, and that evolution is not tightly coupled with the 
updating of the binaries.  It sounds like the pkg and freebsd-update 
infrastructure use DNS TXT and/or SRV records to point to the metadata needed 
to construct a mirror URL list dynamically.  Maybe something similar can be 
done for bsdconfig?  If it?s not a crazy idea, is there anyone who would be 
interested in helping me write a proposal over at arch@?


100% behind that idea!  Especially since it seems the project has lost
(some) control over its DNS space, which IMHO, is still an issue, if
the people whom DNS zones have been deligated to are not responsive
that should also


Words of agreement don’t help at the moment, though i appreciate your 
enthusiasm.  Would you he able to help write a proposal for the arch@ mailing 
list?



I think this is the wrong approach, and the better approach is to have 
the official installer use download.freebsd.org (which already is 
geo-located).  I also feel like this is probably something that core and 
possibly clusteradm should weigh in on, since it affects how we 
distribute FreeBSD.


My impression was that we were generally trying to move away from 
mirrors hosted by various people and organizations all over the world, 
where we have little control, to our own mirrors behind 
download.freebsd.org.  If this is the case, perhaps we should do so in 
the installer as well.


That said, I'm not opposed to the idea of using DNS SRV/TXT records to 
construct mirror lists, especially if we want to keep on using those 
mirrors.


Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

[Niclas Zeising]

On 2020-09-26 20:28, Rodney W. Grimes wrote:

On 2020-09-26 20:12, Rodney W. Grimes wrote:

Author: zeising (doc,ports committer)
Date: Sat Sep 26 16:27:09 2020
New Revision: 366186
URL: https://svnweb.freebsd.org/changeset/base/366186

Log:
bsdconfig, bsdinstall: Prune dead mirrors

Prune dead mirrors from the list of mirrors in bsdconfig and bsdinstall.

All these return NXDOMAIN when trying to resolve them.


This seems like the wrong place to fix it, as this does
nothing for all the "shipped" releases that contain the
old values.  Shouldnt these all just be CNAMED in dns
to a nearest replacement resource?




Considering that we don't actually have control of the subdomans
(CC.freebsd.org) ourselves, that is trickier than it might sound.


How can freebsd.org NOT have ultimate control over deligations?
If things have become "lame" in a deligated zone the deligation
can and should be pulled and replaced with local data.

This is cc.freebsd.org, not freebsd.org.cc!


I am the wrong person to answer that question.

In this case, things have not become lame.  For instance, the names 
ervers for se.freebsd.org work fine, but ftp3.se and ftp6.se records are 
removed.  Same for ru.freebsd.org and ftp4.ru.
I'm merely pointing out that changing ftp.CC.freebsd.org usually 
requires contacting the person(s) maintaining the CC.freebsd.org zone, 
which is usually not the project.


Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

[Niclas Zeising]

On 2020-09-26 20:12, Rodney W. Grimes wrote:

Author: zeising (doc,ports committer)
Date: Sat Sep 26 16:27:09 2020
New Revision: 366186
URL: https://svnweb.freebsd.org/changeset/base/366186

Log:
   bsdconfig, bsdinstall: Prune dead mirrors
   
   Prune dead mirrors from the list of mirrors in bsdconfig and bsdinstall.

   All these return NXDOMAIN when trying to resolve them.


This seems like the wrong place to fix it, as this does
nothing for all the "shipped" releases that contain the
old values.  Shouldnt these all just be CNAMED in dns
to a nearest replacement resource?




Considering that we don't actually have control of the subdomans 
(CC.freebsd.org) ourselves, that is trickier than it might sound.
I do not oppose that change, but I'm not doing the work to chase all the 
subdomain DNS admins down to try to fix it.
This change cleans out some old mirrors for the 12.2 release, so that 
people installing 12.2 (and later stuff) won't have the installer 
complain when they accidentally pick a nonexistent mirror.
I believe that the proper way to fix this is to just use the FreeBSD CDN 
even for these downloads (basically, go straight to 
download.freebsd.org, or at least have that as the preferred option), 
but I haven't gotten around to that.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Sat Sep 26 16:27:09 2020
New Revision: 366186
URL: https://svnweb.freebsd.org/changeset/base/366186

Log:
  bsdconfig, bsdinstall: Prune dead mirrors
  
  Prune dead mirrors from the list of mirrors in bsdconfig and bsdinstall.
  All these return NXDOMAIN when trying to resolve them.
  
  Reviewed by:  emaste
  Approved by:  emaste
  MFC after:3 days
  Differential Revision:https://reviews.freebsd.org/D26535

Modified:
  head/usr.sbin/bsdconfig/share/media/ftp.subr
  head/usr.sbin/bsdinstall/scripts/mirrorselect

Modified: head/usr.sbin/bsdconfig/share/media/ftp.subr
==
--- head/usr.sbin/bsdconfig/share/media/ftp.subrSat Sep 26 14:44:58 
2020(r366185)
+++ head/usr.sbin/bsdconfig/share/media/ftp.subrSat Sep 26 16:27:09 
2020(r366186)
@@ -82,7 +82,6 @@ f_dialog_menu_media_ftp()
' IPv6 $msg_japan''ftp2.jp.freebsd.org'
' IPv6 $msg_sweden'   'ftp4.se.freebsd.org'
' IPv6 $msg_usa'  'ftp4.us.freebsd.org'
-   ' IPv6 $msg_turkey'   'ftp2.tr.freebsd.org'
'$msg_primary''ftp1.freebsd.org'
' $msg_primary #2''ftp2.freebsd.org'
' $msg_primary #3''ftp3.freebsd.org'
@@ -95,7 +94,6 @@ f_dialog_menu_media_ftp()
' $msg_primary #12'   'ftp12.freebsd.org'
' $msg_primary #13'   'ftp13.freebsd.org'
' $msg_primary #14'   'ftp14.freebsd.org'
-   '$msg_armenia''ftp1.am.freebsd.org'
'$msg_australia'  'ftp.au.freebsd.org'
' $msg_australia #2'  'ftp2.au.freebsd.org'
' $msg_australia #3'  'ftp3.au.freebsd.org'
@@ -103,11 +101,9 @@ f_dialog_menu_media_ftp()
'$msg_brazil' 'ftp2.br.freebsd.org'
' $msg_brazil #3' 'ftp3.br.freebsd.org'
' $msg_brazil #4' 'ftp4.br.freebsd.org'
-   '$msg_canada' 'ftp.ca.freebsd.org'
'$msg_china'  'ftp.cn.freebsd.org'
'$msg_czech_republic' 'ftp.cz.freebsd.org'
'$msg_denmark''ftp.dk.freebsd.org'
-   '$msg_estonia''ftp.ee.freebsd.org'
'$msg_finland''ftp.fi.freebsd.org'
'$msg_france' 'ftp.fr.freebsd.org'
' $msg_france #3' 'ftp3.fr.freebsd.org'
@@ -120,13 +116,11 @@ f_dialog_menu_media_ftp()
' $msg_germany #2''ftp2.de.freebsd.org'
' $msg_germany #4''ftp4.de.freebsd.org'
' $msg_germany #5''ftp5.de.freebsd.org'
-   ' $msg_germany #6''ftp6.de.freebsd.org'
' $msg_germany #7''ftp7.de.freebsd.org'
' $msg_germany #8''ftp8.de.freebsd.org'
'$msg_greece' 'ftp.gr.freebsd.org'
' $msg_greece #2' 'ftp2.gr.freebsd.org'
'$msg_ireland''ftp3.ie.freebsd.org'
-   '$msg_israel' 'ftp.il.freebsd.org'
'$msg_japan'  'ftp.jp.freebsd.org'
' $msg_japan #2'  'ftp2.jp.freebsd.org'
' $msg_japan #3'  'ftp3.jp.freebsd.org'
@@ -139,16 +133,13 @@ f_dialog_menu_media_ftp()
'$msg_korea'  'ftp.kr.freebsd.org'
' $msg_korea #2'  'ftp2.kr.freebsd.org'
'$msg_latvia' 'ftp.lv.freebsd.org'
-   '$msg_lithuania'  'ftp.lt.freebsd.org'
'$msg_netherlands''ftp.nl.freebsd.org'
' $msg_netherlands #2''ftp2.nl.freebsd.org'
'$msg_new_zealand''ftp.nz.freebsd.org'
'$msg_norway' 'ftp.no.freebsd.org'
'$msg_poland' 'ftp.pl.freebsd.org'
-   ' $msg_poland #2' 'ftp2.pl.freebsd.org'
'$msg_russia' 'ftp.ru.freebsd.org'
' $msg_russia #2' 'ftp2.ru.freebsd.org'
-   ' $msg_russia #4' 'ftp4.ru.freebsd.org'
' $msg_russia #5' 'ftp5.ru.freebsd.org'
' $msg_russia #6' 'ftp6.ru.freebsd.org'
'$msg_slovak_republic''ftp.sk.freebsd.org'
@@ -157,13 +148,9 @@ f_dialog_menu_media_ftp()
'$msg_south_africa'   'ftp.za.freebsd.org'
' $msg_south_africa #2'   'ftp2.za.freebsd.org'
' $msg_south_africa #4'   'ftp4.za.freebsd.org'
-   '$msg_spain'  'ftp.es.freebsd.org'
-   ' $msg_spain #3'  'ftp3.es.freebsd.org'
'$msg_sweden' 'ftp.se.freebsd.org'

Re: svn commit: r365640 - in head: share/man/man5 share/man/man7 tools/build/options

[Niclas Zeising]

On 2020-09-13 07:57, Gordon Bergling wrote:

Hi Niclas,

On Sat, Sep 12, 2020 at 09:13:33PM +0200, Niclas Zeising wrote:

On 2020-09-11 20:09, Gordon Bergling wrote:

Author: gbe (doc committer)
Date: Fri Sep 11 18:09:49 2020
New Revision: 365640
URL: https://svnweb.freebsd.org/changeset/base/365640

Log:
Improvements for the src.conf(5) and build(7) man pages

PR:		203863 (based on)

Submitted by:   Russell Haley 
Reviewed by:bcr, imp
Approved by:imp
MFC after:  1 week
Differential Revision:  https://reviews.freebsd.org/D26343

Modified:
head/share/man/man5/src.conf.5
head/share/man/man7/build.7
head/tools/build/options/makeman

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Fri Sep 11 17:05:09 2020
(r365639)
+++ head/share/man/man5/src.conf.5  Fri Sep 11 18:09:49 2020
(r365640)
@@ -1,6 +1,6 @@
   .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman.


As the comment above hints, this file is generated by a tool, and should
not be edited directly.  This will be overwritten the next time someone
regenerates the manual page.  You have to update the template in
tools/build/options/makeman and regenerate the manual from there.


I did updated 'tools/build/options/makeman' with this commit. I justed commited
the newly generated src.conf.5 alongside and not with a separate commit.


Sorry about that, I should have seen it in the commit log.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r365640 - in head: share/man/man5 share/man/man7 tools/build/options

[Niclas Zeising]

On 2020-09-11 20:09, Gordon Bergling wrote:

Author: gbe (doc committer)
Date: Fri Sep 11 18:09:49 2020
New Revision: 365640
URL: https://svnweb.freebsd.org/changeset/base/365640

Log:
   Improvements for the src.conf(5) and build(7) man pages
   
   PR:		203863 (based on)

   Submitted by:Russell Haley 
   Reviewed by: bcr, imp
   Approved by: imp
   MFC after:   1 week
   Differential Revision:   https://reviews.freebsd.org/D26343

Modified:
   head/share/man/man5/src.conf.5
   head/share/man/man7/build.7
   head/tools/build/options/makeman

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Fri Sep 11 17:05:09 2020
(r365639)
+++ head/share/man/man5/src.conf.5  Fri Sep 11 18:09:49 2020
(r365640)
@@ -1,6 +1,6 @@
  .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman.


As the comment above hints, this file is generated by a tool, and should 
not be edited directly.  This will be overwritten the next time someone 
regenerates the manual page.  You have to update the template in 
tools/build/options/makeman and regenerate the manual from there.



  .\" $FreeBSD$
-.Dd September 8, 2020
+.Dd September 11, 2020
  .Dt SRC.CONF 5
  .Os
  .Sh NAME
@@ -9,7 +9,8 @@
  .Sh DESCRIPTION
  The
  .Nm
-file contains settings that will apply to every build involving the
+file contains variables that control what components will be generated during
+the build process of the
  .Fx
  source tree; see
  .Xr build 7 .



Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r365264 - head/sys/dev/drm2

[Niclas Zeising]

On 2020-09-03 06:11, Ravi Pokala wrote:

This appears to have broken tinderbox:

 [${SRCTOP}] rpokala% less _.arm.TEGRA124   
 ...
 ${SRCTOP}/sys/dev/drm2/drm_os_freebsd.c:129:3: error: implicit declaration 
of function 'DRM_OBSOLETE' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
 DRM_OBSOLETE(kdev);
 ^


Yeah, sorry about that.
Should be fixed in 365287.
ponty_hat_collection++;
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r365287 - head/sys/dev/drm2

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Sep  3 05:25:39 2020
New Revision: 365287
URL: https://svnweb.freebsd.org/changeset/base/365287

Log:
  drm2: Fix build after r365264
  
  Fix the build after r365264, I forgot to exclude arm in one more place.
  
  Reported by:  rpokala
  Approved by:  manu (implicit, build fix)
  MFC after:3 days
  X-MFC-With:   365264
  Pointy-hat to:zeising

Modified:
  head/sys/dev/drm2/drm_os_freebsd.c

Modified: head/sys/dev/drm2/drm_os_freebsd.c
==
--- head/sys/dev/drm2/drm_os_freebsd.c  Thu Sep  3 03:48:42 2020
(r365286)
+++ head/sys/dev/drm2/drm_os_freebsd.c  Thu Sep  3 05:25:39 2020
(r365287)
@@ -126,7 +126,9 @@ drm_probe_helper(device_t kdev, const drm_pci_id_list_
device_get_nameunit(kdev), id_entry->name);
device_set_desc(kdev, id_entry->name);
}
+#if !defined(__arm__)
DRM_OBSOLETE(kdev);
+#endif
return (-BUS_PROBE_GENERIC);
}
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r365264 - head/sys/dev/drm2

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Sep  2 18:04:49 2020
New Revision: 365264
URL: https://svnweb.freebsd.org/changeset/base/365264

Log:
  drm2: Further improve deprecation message
  
  Further improve the drm2 deprecation message, only displaying information
  about the port for relevant architectures, and skipping the message
  completely from arm, which uses some parts of drm2 still.
  
  This is mostly intended to be merged to 12, since the base bits of drm2 on
  FreeBSD 13 are only really used on arm.
  
  Reviewed by:  manu, mmel
  Approved by:  manu
  MFC after:3 days
  X-MFC-with:   r364737
  Differential Revision:https://reviews.freebsd.org/D26275

Modified:
  head/sys/dev/drm2/drm_os_freebsd.h

Modified: head/sys/dev/drm2/drm_os_freebsd.h
==
--- head/sys/dev/drm2/drm_os_freebsd.h  Wed Sep  2 17:46:56 2020
(r365263)
+++ head/sys/dev/drm2/drm_os_freebsd.h  Wed Sep  2 18:04:49 2020
(r365264)
@@ -154,15 +154,21 @@ typedef void  irqreturn_t;
*(volatile u_int64_t *)(((vm_offset_t)(map)->handle) +  \
(vm_offset_t)(offset)) = htole64(val)
 
-#define DRM_PORT "graphics/drm-kmod"
+#if !defined(__arm__)
+#if defined(__i386__) || defined(__amd64__) || defined(__powerpc__) || 
defined(__aarch64__)
+#define DRM_MSG "This code is deprecated.  Install the graphics/drm-kmod pkg\n"
+#else
+#define DRM_MSG "This code is deprecated."
+#endif
 
 #define DRM_OBSOLETE(dev)  
\
 do {   
\
device_printf(dev, 
"===\n"); \
-   device_printf(dev, "This code is deprecated.  Install the " DRM_PORT " 
pkg\n"); \
+   device_printf(dev, DRM_MSG);
\
device_printf(dev, 
"===\n"); \
gone_in_dev(dev, 13, "drm2 drivers");   
\
 } while (0)
+#endif /* __arm__ */
 
 /* DRM_READMEMORYBARRIER() prevents reordering of reads.
  * DRM_WRITEMEMORYBARRIER() prevents reordering of writes.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r364737 - head/sys/dev/drm2

[Niclas Zeising]

On 2020-09-01 16:19, Emmanuel Vadot wrote:

On Tue, 1 Sep 2020 15:32:18 +0200
Niclas Zeising  wrote:


On 2020-09-01 15:16, Emmanuel Vadot wrote:

On Tue, 1 Sep 2020 15:13:53 +0200
Michal Meloun  wrote:




On 25.08.2020 0:53, Niclas Zeising wrote:

Author: zeising (doc,ports committer)
Date: Mon Aug 24 22:53:23 2020
New Revision: 364737
URL: https://svnweb.freebsd.org/changeset/base/364737

Log:
drm2: Update deprecation message

Update the deprecation message in the drm2 (aka legacy drm) drivers to point

towards the graphics/drm-kmod ports for all architectures, not just amd64.

Only known user of drm2 is arm/tegra124 based boards. How
graphics/drm-kmod can help for these?
Or be more specific - drm2 allows me to hot-plug monitor to tegra based
board an use 2 scaled overlay planes (which is exactly whats I want for
   my application). Which alternative can you offer me?
Btw, as you can see, the maintenance cost of drm2 is close to zero and
the dev/drm2 code does not inherit with any of the major architectures.

Michal


   I think that the goal was only to mfc this to warn users before 12.2
is branched, maybe a direct commit to 12 would have been better.



No, the change is correct.
drm-legacy-kmod (the port) is going away, especially on FreeBSD 13,
since it is preventing updates to the FreeBSD VM subsystem.  I sent
an-email about this to a variety of lists about a week ago.
I do know that there are a few special users of drm2 in FreeBSD current,
I do not know how those are affected.  Since, on FreeBSD current, most
architectures can use drm-kmod, I believe it is good to point everyone
towards that ports, instead of pointing everyone except amd64 users to
drm-legacy-kmod.
Regards
--
Niclas Zeising


  drm2 in src is only used for arm, so as Michal wrote in another email
the warning will be seen only for tegra users, the mfc'ed commit will
be seen by intel/amd ones though.



I still have to make a general change that can be MFCd.  And pointing 
arm tegra users to drm-legacy-kmod is equally wrong.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r364737 - head/sys/dev/drm2

[Niclas Zeising]

On 2020-09-01 16:10, Michal Meloun wrote:



On 01.09.2020 15:32, Niclas Zeising wrote:

On 2020-09-01 15:16, Emmanuel Vadot wrote:

On Tue, 1 Sep 2020 15:13:53 +0200
Michal Meloun  wrote:




On 25.08.2020 0:53, Niclas Zeising wrote:

Author: zeising (doc,ports committer)
Date: Mon Aug 24 22:53:23 2020
New Revision: 364737
URL: https://svnweb.freebsd.org/changeset/base/364737

Log:
    drm2: Update deprecation message
       Update the deprecation message in the drm2 (aka legacy drm)
drivers to point
    towards the graphics/drm-kmod ports for all architectures, not
just amd64.

Only known user of drm2 is arm/tegra124 based boards. How
graphics/drm-kmod can help for these?
Or be more specific - drm2 allows me to hot-plug monitor to tegra based
board an use 2 scaled overlay planes (which is exactly whats I want for
   my application). Which alternative can you offer me?
Btw, as you can see, the maintenance cost of drm2 is close to zero and
the dev/drm2 code does not inherit with any of the major architectures.

Michal


   I think that the goal was only to mfc this to warn users before 12.2
is branched, maybe a direct commit to 12 would have been better.



No, the change is correct.
drm-legacy-kmod (the port) is going away, especially on FreeBSD 13,
since it is preventing updates to the FreeBSD VM subsystem.  I sent
an-email about this to a variety of lists about a week ago.
I do know that there are a few special users of drm2 in FreeBSD current,
I do not know how those are affected.  Since, on FreeBSD current, most
architectures can use drm-kmod, I believe it is good to point everyone
towards that ports, instead of pointing everyone except amd64 users to
drm-legacy-kmod.


No, this change is not correct.
You *newly* point ARM drm2 users to use a port marked with
"ONLY_FOR_ARCHS= amd64 i386 powerpc64"
Do you think that this is correct behavior?

So again. I have not a single problem with drm-legacy-kmod removal,
I have not a problem with pointing users of supported architectures (by
kmod-*) to right port.
But I have problem with marking drm2 driver as obsolete for ARM
architecture (without single rational reason) and/or by pointing ARM
users of drm2 driver to not-existent port.
Michal



I am only improving an already existing message.  Previously, it would 
point people to drm-legacy-kmod on all architectures except amd64.  This 
is wrong, since drm-legacy-kmod will be removed.  drm-legacy-kmod is 
causing issues and preventing updates to other areas of FreeBSD, as I 
clearly stated in an email sent to current, ports, x11 and stable 
mailing lists.  drm-current-kmod is only available on i386, amd64 and 
powerpc64.  drm-devel-kmod is available on further architectures, 
covering almost all of the FreeBSD on desktop segment.

With the work manu is doing, this will improve further.
For FreeBSD 12, the situation is slightly different, since 
drm-fbsd12.1-kmod has less support.  However, drm-legacy is available in 
base there, and once again, with the work manu is doing, support for 
further architectures might be possible even on FreeBSD 12.
I have no objections if you want to opt out of the message on your tegra 
boards, but I do not want us to point users to a port that is deprecated 
and slated for removal.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r364737 - head/sys/dev/drm2

[Niclas Zeising]

On 2020-09-01 15:16, Emmanuel Vadot wrote:

On Tue, 1 Sep 2020 15:13:53 +0200
Michal Meloun  wrote:




On 25.08.2020 0:53, Niclas Zeising wrote:

Author: zeising (doc,ports committer)
Date: Mon Aug 24 22:53:23 2020
New Revision: 364737
URL: https://svnweb.freebsd.org/changeset/base/364737

Log:
   drm2: Update deprecation message
   
   Update the deprecation message in the drm2 (aka legacy drm) drivers to point

   towards the graphics/drm-kmod ports for all architectures, not just amd64.

Only known user of drm2 is arm/tegra124 based boards. How
graphics/drm-kmod can help for these?
Or be more specific - drm2 allows me to hot-plug monitor to tegra based
board an use 2 scaled overlay planes (which is exactly whats I want for
  my application). Which alternative can you offer me?
Btw, as you can see, the maintenance cost of drm2 is close to zero and
the dev/drm2 code does not inherit with any of the major architectures.

Michal


  I think that the goal was only to mfc this to warn users before 12.2
is branched, maybe a direct commit to 12 would have been better.



No, the change is correct.
drm-legacy-kmod (the port) is going away, especially on FreeBSD 13, 
since it is preventing updates to the FreeBSD VM subsystem.  I sent 
an-email about this to a variety of lists about a week ago.
I do know that there are a few special users of drm2 in FreeBSD current, 
I do not know how those are affected.  Since, on FreeBSD current, most 
architectures can use drm-kmod, I believe it is good to point everyone 
towards that ports, instead of pointing everyone except amd64 users to 
drm-legacy-kmod.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r364737 - head/sys/dev/drm2

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Aug 24 22:53:23 2020
New Revision: 364737
URL: https://svnweb.freebsd.org/changeset/base/364737

Log:
  drm2: Update deprecation message
  
  Update the deprecation message in the drm2 (aka legacy drm) drivers to point
  towards the graphics/drm-kmod ports for all architectures, not just amd64.
  drm-kmod has support for more architectures these days, and the
  graphics/drm-legacy-kmod port is being deprecated.
  
  Approved by:  imp
  MFC after:1 week
  Differential Revision:https://reviews.freebsd.org/D26174

Modified:
  head/sys/dev/drm2/drm_os_freebsd.h

Modified: head/sys/dev/drm2/drm_os_freebsd.h
==
--- head/sys/dev/drm2/drm_os_freebsd.h  Mon Aug 24 22:48:19 2020
(r364736)
+++ head/sys/dev/drm2/drm_os_freebsd.h  Mon Aug 24 22:53:23 2020
(r364737)
@@ -154,16 +154,12 @@ typedef void  irqreturn_t;
*(volatile u_int64_t *)(((vm_offset_t)(map)->handle) +  \
(vm_offset_t)(offset)) = htole64(val)
 
-#ifdef amd64
 #define DRM_PORT "graphics/drm-kmod"
-#else
-#define DRM_PORT "graphics/drm-legacy-kmod"
-#endif
 
 #define DRM_OBSOLETE(dev)  
\
 do {   
\
device_printf(dev, 
"===\n"); \
-   device_printf(dev, "This code is obsolete abandonware. Install the " 
DRM_PORT " pkg\n"); \
+   device_printf(dev, "This code is deprecated.  Install the " DRM_PORT " 
pkg\n"); \
device_printf(dev, 
"===\n"); \
gone_in_dev(dev, 13, "drm2 drivers");   
\
 } while (0)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r364436 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Aug 20 19:14:53 2020
New Revision: 364436
URL: https://svnweb.freebsd.org/changeset/base/364436

Log:
  Add ufm(4) to ObsoleteFiles.inc
  
  The ufm driver was removed in r364432, add the manual to ObsoleteFiles.
  
  OK by:imp

Modified:
  head/ObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Thu Aug 20 18:50:46 2020(r364435)
+++ head/ObsoleteFiles.inc  Thu Aug 20 19:14:53 2020(r364436)
@@ -36,6 +36,9 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20200820: Removal of the ufm driver.
+OLD_FILES+=usr/share/man/man4/ufm.4.gz
+
 # 20200816: new clang import which bumps version from 10.0.1 to 11.0.0.
 OLD_FILES+=usr/lib/clang/10.0.1/include/cuda_wrappers/algorithm
 OLD_FILES+=usr/lib/clang/10.0.1/include/cuda_wrappers/complex
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r362942 - head/sbin/shutdown

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Sun Jul  5 13:08:17 2020
New Revision: 362942
URL: https://svnweb.freebsd.org/changeset/base/362942

Log:
  shutdown.8: Fix typo
  
  Fix a typo in shutdown.8, use ',' instead of '.' when listing items.
  
  MFC after:1 week

Modified:
  head/sbin/shutdown/shutdown.8

Modified: head/sbin/shutdown/shutdown.8
==
--- head/sbin/shutdown/shutdown.8   Sun Jul  5 10:57:28 2020
(r362941)
+++ head/sbin/shutdown/shutdown.8   Sun Jul  5 13:08:17 2020
(r362942)
@@ -135,7 +135,7 @@ suffix:
 .Dq Li s ,
 .Dq Li sec ,
 .Dq Li m ,
-.Dq Li min .
+.Dq Li min ,
 .Dq Li h ,
 .Dq Li hour .
 .Pp
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

[Niclas Zeising]

On 2020-05-22 13:20, Andriy Gapon wrote:

Author: avg
Date: Fri May 22 11:20:23 2020
New Revision: 361363
URL: https://svnweb.freebsd.org/changeset/base/361363

Log:
   libprocstat: fix ZFS support
   



This might have broken a couple of ports.
The build is still going, but at least three ports have failed to link, 
all with the same error:


/usr/local/bin/ld: /usr/lib/libprocstat.so.1: undefined reference to 
`__start_set_pcpu'
/usr/local/bin/ld: /usr/lib/libprocstat.so.1: undefined reference to 
`__stop_set_pcpu'
c++: error: linker command failed with exit code 1 (use -v to see 
invocation)


See for instance
http://beefy18.nyi.freebsd.org/data/head-amd64-default/p536258_s361404/logs/errors/gnuradio-3.8.1.0_1.log
and
http://beefy18.nyi.freebsd.org/data/head-amd64-default/p536258_s361404/logs/octave-5.2.0_2.log

Or, if you're on IPv4 only:
http://www.ipv6proxy.net/go.php?u=http%3A%2F%2Fbeefy18.nyi.freebsd.org%2Fdata%2Fhead-amd64-default%2Fp536258_s361404%2Flogs%2Foctave-5.2.0_2.log=0=norefer

Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r360126 - head/sys/dev/evdev

[Niclas Zeising]

On 2020-04-20 20:13, Conrad Meyer wrote:

Hi Niclas,

On Mon, Apr 20, 2020 at 9:57 AM Niclas Zeising  wrote:


On 2020-04-20 18:39, Justin Hibbits wrote:

For just powerpc32,
you should have:

#if defined(__powerpc__) && !defined(__powerpc64__)


Ok, I wasn't aware of that, I'll fix it.


FYI, arch(7) is a great resource here (thanks, emaste@):

"""
  Architecture-specific macros:

ArchitecturePredefined macros
...
powerpc __powerpc__
powerpcspe  __powerpc__, __SPE__
powerpc64   __powerpc__, __powerpc64__
"""

For other predefined macros not covered in arch(7), I highly recommend
https://sourceforge.net/p/predef/wiki/Home/ .



I'll remember that for next time, thanks!
In any case, this should be fixed with r360132, sorry about that.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r360132 - head/sys/dev/evdev

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Apr 20 18:23:31 2020
New Revision: 360132
URL: https://svnweb.freebsd.org/changeset/base/360132

Log:
  Fix kern.evdev.rcpt_mask on powerpc
  
  In r360126, I meant to have a different mask only on powerpc, not powerpc64.
  Update the check to check that we're not compiling for powerpc64.
  
  Reported by:  jhibbits
  Approved by:  wulf (implicit)
  MFC after:2 weeks
  X-MFC-Note:   12 only
  X-MFC-With:   r360126
  Differential Revision:D24370 (followup)

Modified:
  head/sys/dev/evdev/evdev.c

Modified: head/sys/dev/evdev/evdev.c
==
--- head/sys/dev/evdev/evdev.c  Mon Apr 20 18:01:45 2020(r360131)
+++ head/sys/dev/evdev/evdev.c  Mon Apr 20 18:23:31 2020(r360132)
@@ -67,7 +67,7 @@ enum evdev_sparse_result
 MALLOC_DEFINE(M_EVDEV, "evdev", "evdev memory");
 
 /* adb keyboard driver used on powerpc does not support evdev yet */
-#ifdef __powerpc__
+#if defined(__powerpc__) && !defined(__powerpc64__)
 int evdev_rcpt_mask = EVDEV_RCPT_KBDMUX | EVDEV_RCPT_HW_MOUSE;
 #else
 int evdev_rcpt_mask = EVDEV_RCPT_HW_MOUSE | EVDEV_RCPT_HW_KBD;
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r360126 - head/sys/dev/evdev

[Niclas Zeising]

On 2020-04-20 18:39, Justin Hibbits wrote:

On Mon, 20 Apr 2020 16:17:17 + (UTC)
Niclas Zeising  wrote:


Author: zeising (doc,ports committer)
Date: Mon Apr 20 16:17:16 2020
New Revision: 360126
URL: https://svnweb.freebsd.org/changeset/base/360126

Log:
   Change kern.evdev.rcpt_mask to 12 by default
   
   Change kern.evdev.rcpt_mask from 3 to 12 by default.  This makes us

much more evdev-friendly, and will prevent everyone using xorg and
wayland with evdev devices (the default) from needing to change this
locally.
   powerpc32 still uses the old value for the keyboard part, becaues
the adb keyboard driver used there is not evdev compatible.
   
   Reviewed by:	wulf

   Approved by: wulf
   MFC after:   2 weeks
   X-MFC-Note:  12 only
   Relnotes:yes
   Differential Revision:   https://reviews.freebsd.org/D24370

Modified:
   head/sys/dev/evdev/evdev.c

Modified: head/sys/dev/evdev/evdev.c
==
--- head/sys/dev/evdev/evdev.c  Mon Apr 20 16:14:44 2020
(r360125) +++ head/sys/dev/evdev/evdev.cMon Apr 20 16:17:16
2020(r360126) @@ -66,7 +66,12 @@ enum evdev_sparse_result
  
  MALLOC_DEFINE(M_EVDEV, "evdev", "evdev memory");
  
-int evdev_rcpt_mask = EVDEV_RCPT_SYSMOUSE | EVDEV_RCPT_KBDMUX;

+/* adb keyboard driver used on powerpc does not support evdev yet */
+#ifdef __powerpc__


This affects *all* powerpc, not just powerpc32.  For just powerpc32,
you should have:

#if defined(__powerpc__) && !defined(__powerpc64__)


Ok, I wasn't aware of that, I'll fix it.



But I'm curious, why not attach to sysmouse(4) and kbdmux(4)?  What
breakage does that cause?  I could maybe see not attaching to
sysmouse(4) by default, if the protocol isn't expressive enough, but
kbdmux(4) should be sufficient.


Sysmouse hides features from evdev, so it's better to let xorg or 
wayland access the device directly.


If both are enabled, you'll get double events, meaning double key 
presses when using USB devices: https://reviews.freebsd.org/D24370#538523


Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r360126 - head/sys/dev/evdev

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Apr 20 16:17:16 2020
New Revision: 360126
URL: https://svnweb.freebsd.org/changeset/base/360126

Log:
  Change kern.evdev.rcpt_mask to 12 by default
  
  Change kern.evdev.rcpt_mask from 3 to 12 by default.  This makes us much
  more evdev-friendly, and will prevent everyone using xorg and wayland with
  evdev devices (the default) from needing to change this locally.
  
  powerpc32 still uses the old value for the keyboard part, becaues the adb
  keyboard driver used there is not evdev compatible.
  
  Reviewed by:  wulf
  Approved by:  wulf
  MFC after:2 weeks
  X-MFC-Note:   12 only
  Relnotes: yes
  Differential Revision:https://reviews.freebsd.org/D24370

Modified:
  head/sys/dev/evdev/evdev.c

Modified: head/sys/dev/evdev/evdev.c
==
--- head/sys/dev/evdev/evdev.c  Mon Apr 20 16:14:44 2020(r360125)
+++ head/sys/dev/evdev/evdev.c  Mon Apr 20 16:17:16 2020(r360126)
@@ -66,7 +66,12 @@ enum evdev_sparse_result
 
 MALLOC_DEFINE(M_EVDEV, "evdev", "evdev memory");
 
-int evdev_rcpt_mask = EVDEV_RCPT_SYSMOUSE | EVDEV_RCPT_KBDMUX;
+/* adb keyboard driver used on powerpc does not support evdev yet */
+#ifdef __powerpc__
+int evdev_rcpt_mask = EVDEV_RCPT_KBDMUX | EVDEV_RCPT_HW_MOUSE;
+#else
+int evdev_rcpt_mask = EVDEV_RCPT_HW_MOUSE | EVDEV_RCPT_HW_KBD;
+#endif
 int evdev_sysmouse_t_axis = 0;
 
 SYSCTL_NODE(_kern, OID_AUTO, evdev, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r354966 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Nov 21 15:38:27 2019
New Revision: 354966
URL: https://svnweb.freebsd.org/changeset/base/354966

Log:
  ObsoleteFiles.inc: add sio(4) leftovers
  
  Add the manual page for sio(4) to ObsoleteFiles.inc, so that make delete-all
  will remove it.  The manual page was removed together with sio(4) in
  r354929.
  
  Approved by:  emaste
  Differential Revision:https://reviews.freebsd.org/D22477

Modified:
  head/ObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Thu Nov 21 14:55:27 2019(r354965)
+++ head/ObsoleteFiles.inc  Thu Nov 21 15:38:27 2019(r354966)
@@ -38,6 +38,8 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20191121: Removal of sio(4)
+OLD_FILES+=usr/share/man/man4/sio.4.gz
 # 20191105: picobsd(8), et al, removed.
 OLD_FILES+=usr/share/man/man8/picobsd.8.gz
 # 20191009: new clang import which bumps version from 8.0.1 to 9.0.0.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r352707 - in head/sys: conf kern net sys

[Niclas Zeising]

On 2019-09-27 01:27, Warner Losh wrote:
I talked to Gleb and this will move to opt_global.h. this will fix all 
these problems.


Warner



[ trimming CC list ]
So, in conclusion, the changes made to any out of tree kmods to handle 
this should be reverted?

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r352707 - in head/sys: conf kern net sys

[Niclas Zeising]

On 2019-09-26 17:03, Charlie Li via freebsd-x11 wrote:

Kyle Evans wrote:

On Thu, Sep 26, 2019 at 9:49 AM Charlie Li wrote:

This breaks building the drm-kmod ports, as the build cannot find
opt_epoch.h (drm-devel-kmod example shown, drm-current-kmod dies the
exact same way):

--- linux_anon_inodes.o ---
cc  -O2 -pipe -fno-strict-aliasing -include
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/drivers/gpu/drm/drm_os_config.h
'-DKBUILD_MODNAME="linuxkpi_gplv2"'  -Werror -D_KERNEL -DKLD_MODULE
-nostdinc
-I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/include 
-I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/dummy/include
-I/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include
-I/usr/src/sys/compat/linuxkpi/common/include -I. -I/usr/src/sys
-I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD
-MF.depend.linux_anon_inodes.o -MTlinux_anon_inodes.o -mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value
-Wno-address-of-packed-member -Wno-format-zero-length -Wno-pointer-arith
   -mno-aes -mno-avx  -std=iso9899:1999 -c
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c
-o linux_anon_inodes.o
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodes.c:12:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/anon_inodes.h:4:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56:
In file included from /usr/src/sys/net/if_var.h:83:
/usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found
#include "opt_epoch.h"
  ^
--- linux_anon_inodefs.o ---
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/src/linux_anon_inodefs.c:45:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/debugfs.h:18:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/fs.h:6:
In file included from
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi/gplv2/include/linux/shrinker.h:5:
In file included from
/usr/src/sys/compat/linuxkpi/common/include/linux/list.h:56:
In file included from /usr/src/sys/net/if_var.h:83:
/usr/src/sys/sys/epoch.h:44:10: fatal error: 'opt_epoch.h' file not found
#include "opt_epoch.h"
  ^
--- linux_anon_inodes.o ---
1 error generated.
*** [linux_anon_inodes.o] Error code 1

make[2]: stopped in
/wrkdirs/usr/ports/graphics/drm-devel-kmod/work/kms-drm-dc414a9/linuxkpi
--- linux_anon_inodefs.o ---
1 error generated.
*** [linux_anon_inodefs.o] Error code 1

Interestingly enough, does not happen when drm-current-kmod is built as
part of buildkernel (using an existing installed package with SOURCE on).



FWIW, johalun noticed this yesterday and addressed it here:
https://github.com/FreeBSDDesktop/kms-drm/commit/b486949e7e9f0cfe8dac5f0ac7fe1a660300981d


Ah, of course I would miss these commits in the kms-drm repo,
considering that I watch them roll in. Will wait for the updated
snapshots in ports.



I'll get to updating the ports as soon as I can.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r352128 - in head: . usr.bin usr.bin/colldef usr.bin/mklocale

[Niclas Zeising]

On 2019-09-10 09:54, Baptiste Daroussin wrote:

Author: bapt
Date: Tue Sep 10 07:54:49 2019
New Revision: 352128
URL: https://svnweb.freebsd.org/changeset/base/352128

Log:
   Remove mklocale(1) and colldef(1) which are deprecated since FreeBSD 11
   
   In FreeBSD 11 along with the rework on the collation, mklocale(1) and colldef(1)

   has been replaced by localedef(1) (a note has been added to the manpage to 
state
   it).
   mklocale(1) and colldef(1) has been kept around to be able to build older
   versions of FreeBSD. None of the version requiring those tools are supported
   anymore so it is time to remove them from base

Deleted:
   head/usr.bin/colldef/
   head/usr.bin/mklocale/
Modified:
   head/ObsoleteFiles.inc
   head/usr.bin/Makefile

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Tue Sep 10 07:47:52 2019(r352127)
+++ head/ObsoleteFiles.inc  Tue Sep 10 07:54:49 2019(r352128)
@@ -38,6 +38,11 @@
  #   xargs -n1 | sort | uniq -d;
  # done
  
+# 20190910: mklocale(1) and colldef(1) removed

+OLD_FILES+=usr.bin/mklocale

^^
should be usr/bin/mklocale

+OLD_FILES+=usr/share/man/man1/mklocale.1.gz
+OLD_FILES+=usr.bin/colldef

^^
should be usr/bin/colldef

+OLD_FILES+=usr/share/man/man1/colldef.1.gz
  # 20190904: Remove boot1.efifat
  OLD_FILES+=boot/boot1.efifat
  # 20190903: pc-sysinstall(8) removed




Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r351831 - in head: . stand/efi/boot1 stand/efi/gptboot tools/build/mk

[Niclas Zeising]

On 2019-09-05 07:57, Dimitry Andric wrote:

On 4 Sep 2019, at 22:55, Rebecca Cran  wrote:


Author: bcran
Date: Wed Sep  4 20:55:48 2019
New Revision: 351831
URL: https://svnweb.freebsd.org/changeset/base/351831

Log:
  The efifat files are no longer used: remove the code to build them

  Reviewed by:  imp, tsoome, emaste
  Differential Revision:https://reviews.freebsd.org/D20562


So what are now the instructions for updating an EFI partition, after a
buildworld?  I used to find that efifat file quite handy, I could just
use gpart -p to write it into the EFI partition... :-/

-Dimitry



This is what I do:

mount -t msdosfs /dev/ada0p1 /mnt # (if that's the ESP, check with gpart 
list)

cp /boot/loader.efi /mnt/EFI/FreeBSD/loader.efi
umount /mnt

This works if proper EFI boot variables have been set up.  This can be 
done with, it's only needed the first time, or if they are somehow 
overwritten.


efibootmgr --create --activate --label FreeBSD --loader 
/dev/ada0p1:/EFI/FreeBSD/loader.efi


Once again, check that /dev/ada0p1 is the ESP.
You can check your efi boot variables with efibootmgr -v

Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r351608 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Aug 29 17:25:50 2019
New Revision: 351608
URL: https://svnweb.freebsd.org/changeset/base/351608

Log:
  Use relative paths in ObsoleteFiles.inc
  
  Approved by:  imp
  Differential Revision:https://reviews.freebsd.org/D21467

Modified:
  head/ObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Thu Aug 29 17:17:39 2019(r351607)
+++ head/ObsoleteFiles.inc  Thu Aug 29 17:25:50 2019(r351608)
@@ -39,8 +39,8 @@
 # done
 
 # 20190825: zlib 1.0.4 removed from kernel
-OLD_FILES+=/usr/include/sys/zlib.h
-OLD_FILES+=/usr/include/sys/zutil.h
+OLD_FILES+=usr/include/sys/zlib.h
+OLD_FILES+=usr/include/sys/zutil.h
 # 20190817: pft_ping.py and sniffer.py moved to /usr/tests/sys/netpfil/common
 OLD_FILES+=usr/tests/sys/netpfil/pf/sniffer.py
 OLD_FILES+=usr/tests/sys/netpfil/pf/pft_ping.py
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r351607 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Aug 29 17:17:39 2019
New Revision: 351607
URL: https://svnweb.freebsd.org/changeset/base/351607

Log:
  pwm.9 symlink shouldn't be removed
  
  When the pwm.9 manual was removed, a symlink between pwmbus.9 and pwm.9 was
  created, but there's an entry in ObsoleteFiles.inc to remove pwn.9, meaning
  that on every installation pwm.9 is created, and make delete-old deletes it.
  
  Remove the entry from ObsoleteFiles.inc, the symlink is clearly intentional
  and shouldn't be removed.
  
  Reviewed by:  imp, ian
  Approved by:  imp (implicit, review OK)
  Differential Revision:https://reviews.freebsd.org/D21198

Modified:
  head/ObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Thu Aug 29 17:02:02 2019(r351606)
+++ head/ObsoleteFiles.inc  Thu Aug 29 17:17:39 2019(r351607)
@@ -57,8 +57,8 @@ OLD_FILES+=usr/share/man/man3/cap_random_buf.3.gz
 OLD_FILES+=usr/share/man/man9/vm_page_hold.9.gz
 # 20190618: sys/capability.h removed (sys/capsicum.h is the one to use)
 OLD_FILES+=usr/include/sys/capability.h
-# 20190615: sys/pwm.h renamed to dev/pwmc.h and pwm(9) removed
-OLD_FILES+=usr/include/sys/pwm.h usr/share/man/man9/pwm.9.gz
+# 20190615: sys/pwm.h renamed to dev/pwmc.h
+OLD_FILES+=usr/include/sys/pwm.h
 # 20190612: new clang import which bumps version from 8.0.0 to 8.0.1.
 OLD_FILES+=usr/lib/clang/8.0.0/include/sanitizer/allocator_interface.h
 OLD_FILES+=usr/lib/clang/8.0.0/include/sanitizer/asan_interface.h
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r351009 - head/sys/compat/linuxkpi/common/include/linux

[Niclas Zeising]

On 2019-08-14 21:24, Cy Schubert wrote:

On August 14, 2019 12:06:24 PM PDT, Hans Petter Selasky  
wrote:

On 2019-08-14 21:00, Cy Schubert wrote:

John's patch to drm-current-kmod (ports r508877) works! This broke
drm-current-kmod.


You need to update the port. This patch should have been tested too.

Did you try that first?

--HPS


The port is up to date. Sorry for not attaching output. I was in a rush to get 
back to $JOB. I'll rerun it tonight.




Ports should be updated with a fix now, sorry about that.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r350390 - head/sys/kern

[Niclas Zeising]

On 2019-07-28 18:14, Alan Somers wrote:

On Sun, Jul 28, 2019 at 10:11 AM Niclas Zeising
 wrote:


On 2019-07-28 18:07, Alan Somers wrote:

Author: asomers
Date: Sun Jul 28 16:07:27 2019
New Revision: 350390
URL: https://svnweb.freebsd.org/changeset/base/350390

Log:
Better comments for vlrureclaim

MFC after: 2 weeks
Sponsored by:  The FreeBSD Foundation

Modified:
head/sys/kern/vfs_subr.c

Modified: head/sys/kern/vfs_subr.c
==
--- head/sys/kern/vfs_subr.c  Sun Jul 28 15:20:47 2019(r350389)
+++ head/sys/kern/vfs_subr.c  Sun Jul 28 16:07:27 2019(r350390)
@@ -947,9 +947,16 @@ vattr_null(struct vattr *vap)
* desirable to reuse such vnodes.  These conditions may cause the
* number of vnodes to reach some minimum value regardless of what
* you set kern.maxvnodes to.  Do not set kern.maxvnodes too low.
+ *
+ * @param mp  Try to reclaim vnodes from this mountpoint
+ * @param reclaim_nc_src Only reclaim directories with outgoing namecache
+ *entries if this argument is strue
+ * @param trigger Only reclaim vnodes with fewer than this many resident
+ *pages.
+ * @returnThe number of vnodes that were reclaimed.
*/
   static int
-vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger)
+vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger)
   {
   struct vnode *vp;
   int count, done, target;
@@ -1238,7 +1245,8 @@ vnlru_proc(void)
   {
   struct mount *mp, *nmp;
   unsigned long onumvnodes;
- int done, force, reclaim_nc_src, trigger, usevnodes;
+ int done, force, trigger, usevnodes;
+ bool reclaim_nc_src;

   EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc,
   SHUTDOWN_PRI_FIRST);


Was this change intended?  It's not mentioned in the commit message.
Thanks!
Regards
--
Niclas


Yes, it was intended.  Since it makes no difference at runtime, I
thought of the type change as basically being documentation.  That's
why I didn't explicitly mention it.


Ok!
Thank you for the explanation.
Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r350390 - head/sys/kern

[Niclas Zeising]

On 2019-07-28 18:07, Alan Somers wrote:

Author: asomers
Date: Sun Jul 28 16:07:27 2019
New Revision: 350390
URL: https://svnweb.freebsd.org/changeset/base/350390

Log:
   Better comments for vlrureclaim
   
   MFC after:	2 weeks

   Sponsored by:The FreeBSD Foundation

Modified:
   head/sys/kern/vfs_subr.c

Modified: head/sys/kern/vfs_subr.c
==
--- head/sys/kern/vfs_subr.cSun Jul 28 15:20:47 2019(r350389)
+++ head/sys/kern/vfs_subr.cSun Jul 28 16:07:27 2019(r350390)
@@ -947,9 +947,16 @@ vattr_null(struct vattr *vap)
   * desirable to reuse such vnodes.  These conditions may cause the
   * number of vnodes to reach some minimum value regardless of what
   * you set kern.maxvnodes to.  Do not set kern.maxvnodes too low.
+ *
+ * @param mpTry to reclaim vnodes from this mountpoint
+ * @param reclaim_nc_src Only reclaim directories with outgoing namecache
+ *  entries if this argument is strue
+ * @param trigger   Only reclaim vnodes with fewer than this many resident
+ *  pages.
+ * @return  The number of vnodes that were reclaimed.
   */
  static int
-vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger)
+vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger)
  {
struct vnode *vp;
int count, done, target;
@@ -1238,7 +1245,8 @@ vnlru_proc(void)
  {
struct mount *mp, *nmp;
unsigned long onumvnodes;
-   int done, force, reclaim_nc_src, trigger, usevnodes;
+   int done, force, trigger, usevnodes;
+   bool reclaim_nc_src;
  
  	EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc,

SHUTDOWN_PRI_FIRST);


Was this change intended?  It's not mentioned in the commit message.
Thanks!
Regards
--
Niclas

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r349607 - head/share/man/man4

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Tue Jul  2 17:48:27 2019
New Revision: 349607
URL: https://svnweb.freebsd.org/changeset/base/349607

Log:
  pci(4): Use plural configuration registers
  
  Change to use registers instead of register, as it is customary to use
  plural when talking about PCI registers.
  
  This was missed in r349150.
  
  MFC after:3 days

Modified:
  head/share/man/man4/pci.4

Modified: head/share/man/man4/pci.4
==
--- head/share/man/man4/pci.4   Tue Jul  2 17:24:25 2019(r349606)
+++ head/share/man/man4/pci.4   Tue Jul  2 17:48:27 2019(r349607)
@@ -290,7 +290,7 @@ This
 .Xr ioctl 2
 reads the
 .Tn PCI
-configuration register specified by the passed-in
+configuration registers specified by the passed-in
 .Va pci_io
 structure.
 The
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r349146 - head/share/man/man4

[Niclas Zeising]

On 2019-06-17 19:27, Scott Long wrote:

It’s customary to refer to PCI configuration registers in the plural form.  
Would
you mind changing back from “register” to “registers”?



I didn't know that.
Changed in r349150
Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r349150 - head/share/man/man4

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Jun 17 17:35:55 2019
New Revision: 349150
URL: https://svnweb.freebsd.org/changeset/base/349150

Log:
  pci.4: Use plural configuration registers
  
  It is customary to use plural when talking about PCI configure registers.
  
  Reported by:  scottl
  MFC after:2 weeks
  X-MFC-with:   r349133

Modified:
  head/share/man/man4/pci.4

Modified: head/share/man/man4/pci.4
==
--- head/share/man/man4/pci.4   Mon Jun 17 17:17:01 2019(r349149)
+++ head/share/man/man4/pci.4   Mon Jun 17 17:35:55 2019(r349150)
@@ -307,7 +307,7 @@ from the ioctl.
 .It pi_reg
 The
 .Tn PCI
-configuration register the user would like to access.
+configuration registers the user would like to access.
 .It pi_width
 The width, in bytes, of the data the user would like to read.
 This value
@@ -323,7 +323,7 @@ This
 .Xr ioctl 2
 allows users to write to the
 .Tn PCI
-configuration register specified in the passed-in
+configuration registers specified in the passed-in
 .Va pci_io
 structure.
 The
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r349146 - head/share/man/man4

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Jun 17 16:54:51 2019
New Revision: 349146
URL: https://svnweb.freebsd.org/changeset/base/349146

Log:
  pci.4: wordsmith and add missing words
  
  Add missing words after PCI in the description of the PCIOCWRITE and
  PCIOCATTACHED ioctls.
  Use singular in PCIOCREAD, we only read one register at the time.
  
  Reviewed by:  bcr, bjk, rgrimes, cem
  MFC after:2 weeks
  X-MFC-with:   r349133
  Differential Revision:https://reviews.freebsd.org/D20671

Modified:
  head/share/man/man4/pci.4

Modified: head/share/man/man4/pci.4
==
--- head/share/man/man4/pci.4   Mon Jun 17 16:50:58 2019(r349145)
+++ head/share/man/man4/pci.4   Mon Jun 17 16:54:51 2019(r349146)
@@ -290,7 +290,7 @@ This
 .Xr ioctl 2
 reads the
 .Tn PCI
-configuration registers specified by the passed-in
+configuration register specified by the passed-in
 .Va pci_io
 structure.
 The
@@ -323,7 +323,7 @@ This
 .Xr ioctl 2
 allows users to write to the
 .Tn PCI
-specified in the passed-in
+configuration register specified in the passed-in
 .Va pci_io
 structure.
 The
@@ -338,7 +338,7 @@ This
 .Xr ioctl 2
 allows users to query if a driver is attached to the
 .Tn PCI
-specified in the passed-in
+device specified in the passed-in
 .Va pci_io
 structure.
 The
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r349133 - head/share/man/man4

[Niclas Zeising]

On 2019-06-17 12:27, Niclas Zeising wrote:

On 2019-06-17 11:03, Rodney W. Grimes wrote:

On 2019-06-17 09:56, Benjamin Kaduk wrote:

On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising mailto:zeis...@freebsd.org>> wrote:

 Author: zeising (doc,ports committer)
 Date: Mon Jun 17 05:41:47 2019
 New Revision: 349133
 URL: https://svnweb.freebsd.org/changeset/base/349133

 Log:
  ? pci(4): Document PCIOCATTACHED

  ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual.
  ? PCIOCATTACHED is used to query if a driver has attached to a 
PCI.


  ? Reviewed by:? bcr, imp
  ? MFC after:? ? 2 weeks
  ? Differential Revision: https://reviews.freebsd.org/D20652

 Modified:
  ? head/share/man/man4/pci.4

 Modified: head/share/man/man4/pci.4
 
== 


 --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019
 (r349132)
 +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019
 (r349133)
 @@ -24,7 +24,7 @@
  ?.\"
  ?.\" $FreeBSD$
  ?.\"
 -.Dd June 14, 2018
 +.Dd June 17, 2019
  ?.Dt PCI 4
  ?.Os
  ?.Sh NAME
 @@ -333,6 +333,26 @@ The limitations on data width described for
  ?reading registers, above, also apply to writing
  ?.Tn PCI
  ?configuration registers.
 +.It PCIOCATTACHED
 +This
 +.Xr ioctl 2
 +allows users to query if a driver is attached to the
 +.Tn PCI
 +specified in the passed-in


Is there a missing word like "device" here?


Actally I think the missing word, in both cases, is register,
unless I am misreading some part of the manual page and
what a struct pci_io points at.  I guess if the pi_reg is null
then this would be device.  Either way there is defanity a
missing word.


I'll try to fix this.  In the PCIOCWRITE case, perhaps register is best, 
however, inthe PCIOCATTACHED case, device is best, I think.
I'll create a patch and put it for review, I'll get back to you once 
it's done.

Regards



Here's the review with my proposed change.  Let me know what you think.
https://reviews.freebsd.org/D20671

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r349133 - head/share/man/man4

[Niclas Zeising]

On 2019-06-17 11:03, Rodney W. Grimes wrote:

On 2019-06-17 09:56, Benjamin Kaduk wrote:

On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising mailto:zeis...@freebsd.org>> wrote:

 Author: zeising (doc,ports committer)
 Date: Mon Jun 17 05:41:47 2019
 New Revision: 349133
 URL: https://svnweb.freebsd.org/changeset/base/349133

 Log:
  ? pci(4): Document PCIOCATTACHED

  ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual.
  ? PCIOCATTACHED is used to query if a driver has attached to a PCI.

  ? Reviewed by:? bcr, imp
  ? MFC after:? ? 2 weeks
  ? Differential Revision: https://reviews.freebsd.org/D20652

 Modified:
  ? head/share/man/man4/pci.4

 Modified: head/share/man/man4/pci.4
 
==
 --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019
 (r349132)
 +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019
 (r349133)
 @@ -24,7 +24,7 @@
  ?.\"
  ?.\" $FreeBSD$
  ?.\"
 -.Dd June 14, 2018
 +.Dd June 17, 2019
  ?.Dt PCI 4
  ?.Os
  ?.Sh NAME
 @@ -333,6 +333,26 @@ The limitations on data width described for
  ?reading registers, above, also apply to writing
  ?.Tn PCI
  ?configuration registers.
 +.It PCIOCATTACHED
 +This
 +.Xr ioctl 2
 +allows users to query if a driver is attached to the
 +.Tn PCI
 +specified in the passed-in


Is there a missing word like "device" here?


Actally I think the missing word, in both cases, is register,
unless I am misreading some part of the manual page and
what a struct pci_io points at.  I guess if the pi_reg is null
then this would be device.  Either way there is defanity a
missing word.


I'll try to fix this.  In the PCIOCWRITE case, perhaps register is best, 
however, inthe PCIOCATTACHED case, device is best, I think.
I'll create a patch and put it for review, I'll get back to you once 
it's done.

Regards





I just followed the same syntax as for the PCIOCWRITE ioctl in the
paragraph before.


Probably a mistake there too.


I found it a little strange when I read it, but I
kind of assumed there was a reason it said PCI and not PCI device,
perhaps similar to using RAM instead of RAM memory, if you understand
what I mean.


RAM memory == Random Access Memory Memory
PCI == Peripheral Component Interconnect
PCI {Register, Device, Bus} all make valid sense,
PCI alone does not.


Regards
Niclas



 +.Va pci_io
 +structure.
 +The
 +.Va pci_io
 +structure is described above, however, the
 +.Va pi_reg
 +and
 +.Va pi_width
 +fields are not used.
 +The status of the device is stored in the
 +.Va pi_data
 +field.
 +A value of 0 indicates no driver is attached, while a value larger
 than 0
 +indicates that a driver is attached.
  ?.It PCIOCBARMMAP
  ?This
  ?.Xr ioctl 2



--
Niclas Zeising








--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r349133 - head/share/man/man4

[Niclas Zeising]

On 2019-06-17 09:56, Benjamin Kaduk wrote:
On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising <mailto:zeis...@freebsd.org>> wrote:


Author: zeising (doc,ports committer)
Date: Mon Jun 17 05:41:47 2019
New Revision: 349133
URL: https://svnweb.freebsd.org/changeset/base/349133

Log:
   pci(4): Document PCIOCATTACHED

   Document the PCIOCATTACHED ioctl(2) in the pci(4) manual.
   PCIOCATTACHED is used to query if a driver has attached to a PCI.

   Reviewed by:  bcr, imp
   MFC after:    2 weeks
   Differential Revision: https://reviews.freebsd.org/D20652

Modified:
   head/share/man/man4/pci.4

Modified: head/share/man/man4/pci.4

==
--- head/share/man/man4/pci.4   Mon Jun 17 03:48:44 2019   
(r349132)
+++ head/share/man/man4/pci.4   Mon Jun 17 05:41:47 2019   
(r349133)

@@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
-.Dd June 14, 2018
+.Dd June 17, 2019
  .Dt PCI 4
  .Os
  .Sh NAME
@@ -333,6 +333,26 @@ The limitations on data width described for
  reading registers, above, also apply to writing
  .Tn PCI
  configuration registers.
+.It PCIOCATTACHED
+This
+.Xr ioctl 2
+allows users to query if a driver is attached to the
+.Tn PCI
+specified in the passed-in


Is there a missing word like "device" here?


I just followed the same syntax as for the PCIOCWRITE ioctl in the 
paragraph before.  I found it a little strange when I read it, but I 
kind of assumed there was a reason it said PCI and not PCI device, 
perhaps similar to using RAM instead of RAM memory, if you understand 
what I mean.

Regards
Niclas



+.Va pci_io
+structure.
+The
+.Va pci_io
+structure is described above, however, the
+.Va pi_reg
+and
+.Va pi_width
+fields are not used.
+The status of the device is stored in the
+.Va pi_data
+field.
+A value of 0 indicates no driver is attached, while a value larger
than 0
+indicates that a driver is attached.
  .It PCIOCBARMMAP
  This
  .Xr ioctl 2



--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r349133 - head/share/man/man4

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Jun 17 05:41:47 2019
New Revision: 349133
URL: https://svnweb.freebsd.org/changeset/base/349133

Log:
  pci(4): Document PCIOCATTACHED
  
  Document the PCIOCATTACHED ioctl(2) in the pci(4) manual.
  PCIOCATTACHED is used to query if a driver has attached to a PCI.
  
  Reviewed by:  bcr, imp
  MFC after:2 weeks
  Differential Revision:https://reviews.freebsd.org/D20652

Modified:
  head/share/man/man4/pci.4

Modified: head/share/man/man4/pci.4
==
--- head/share/man/man4/pci.4   Mon Jun 17 03:48:44 2019(r349132)
+++ head/share/man/man4/pci.4   Mon Jun 17 05:41:47 2019(r349133)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd June 14, 2018
+.Dd June 17, 2019
 .Dt PCI 4
 .Os
 .Sh NAME
@@ -333,6 +333,26 @@ The limitations on data width described for
 reading registers, above, also apply to writing
 .Tn PCI
 configuration registers.
+.It PCIOCATTACHED
+This
+.Xr ioctl 2
+allows users to query if a driver is attached to the
+.Tn PCI
+specified in the passed-in
+.Va pci_io
+structure.
+The
+.Va pci_io
+structure is described above, however, the
+.Va pi_reg
+and
+.Va pi_width
+fields are not used.
+The status of the device is stored in the
+.Va pi_data
+field.
+A value of 0 indicates no driver is attached, while a value larger than 0
+indicates that a driver is attached.
 .It PCIOCBARMMAP
 This
 .Xr ioctl 2
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r348873 - head/sys/dev/atkbdc

[Niclas Zeising]

On 2019-06-10 22:04, Rodney W. Grimes wrote:

Author: zeising (doc,ports committer)
Date: Mon Jun 10 18:19:49 2019
New Revision: 348873
URL: https://svnweb.freebsd.org/changeset/base/348873

Log:
   psm(4): Enable touchpads and trackpads by default
   
   Enable synaptics and elantech touchpads, as well as IBM/Lenovo TrackPoints

   by default, instead of having users find and toggle a loader tunable.
   This makes things like two finger scroll and other modern features work out
   of the box with X.  By enabling these settings by default, we get a better
   desktop experience in X, since xserver and evdev can make use of the more
   advanced synaptics and elantech features.
   
   Reviewed by:	imp, wulf, 0mp

   Approved by: imp
   Sponsored by:B3 Init (zeising)
   Differential Revision:   https://reviews.freebsd.org/D20507


This should of probably had a
Relnotes:   Yes
as it changes default system behavior.


You are right, sorry for not thinking about that.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r348873 - head/sys/dev/atkbdc

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Jun 10 18:19:49 2019
New Revision: 348873
URL: https://svnweb.freebsd.org/changeset/base/348873

Log:
  psm(4): Enable touchpads and trackpads by default
  
  Enable synaptics and elantech touchpads, as well as IBM/Lenovo TrackPoints
  by default, instead of having users find and toggle a loader tunable.
  This makes things like two finger scroll and other modern features work out
  of the box with X.  By enabling these settings by default, we get a better
  desktop experience in X, since xserver and evdev can make use of the more
  advanced synaptics and elantech features.
  
  Reviewed by:  imp, wulf, 0mp
  Approved by:  imp
  Sponsored by: B3 Init (zeising)
  Differential Revision:https://reviews.freebsd.org/D20507

Modified:
  head/sys/dev/atkbdc/psm.c

Modified: head/sys/dev/atkbdc/psm.c
==
--- head/sys/dev/atkbdc/psm.c   Mon Jun 10 17:44:50 2019(r348872)
+++ head/sys/dev/atkbdc/psm.c   Mon Jun 10 18:19:49 2019(r348873)
@@ -513,9 +513,9 @@ static devclass_t psm_devclass;
 /* Tunables */
 static int tap_enabled = -1;
 static int verbose = PSM_DEBUG;
-static int synaptics_support = 0;
-static int trackpoint_support = 0;
-static int elantech_support = 0;
+static int synaptics_support = 1;
+static int trackpoint_support = 1;
+static int elantech_support = 1;
 
 /* for backward compatibility */
 #defineOLD_MOUSE_GETHWINFO _IOR('M', 1, old_mousehw_t)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r348355 - head/sys/dev/iicbus

[Niclas Zeising]

On 2019-06-03 17:19, Andriy Gapon wrote:

On 03/06/2019 17:52, Ian Lepore wrote:

Please don't.  We still have a situation where nobody has shown a
runtime failure at all.  This build failure could be fixed by simply
defining a do-nothing iicbus_set_nostop() function if a quick fix is
needed.


Well, I am quite certain that the run-time failure will follow after the build
time failure is fixed.


Putting this nostop concept into code that is shared by many drivers is
an abomination.  We have exactly one driver that needs this
functionality, so the right fix is to implement it wholly within that
one driver.  I'll put together a diff for that.


That's true that we have just one such driver.
At the same time, the "no stop" (or rather, repeated start) behavior makes more
sense.  If stop+start between transfers are needed then that can be done with
multiple calls to iicbus_transfer.  If multiple messages are given to
iicbus_transfer, then it's reasonable to assume that a repeated started is
wanted between them.  But it would be a big change to review and, if needed, fix
or tidy up all code that uses iicbus_transfer.  So, iicbus_set_nostop() could be
just a small step towards the bigger goal.

But I really don't have a strong opinion.
Fixing drm2 directly is just as good for me as iicbus_set_nostop.



Hi!
From my perspective, either solution is fine, as long as the drm-legacy 
drivers keep on working, and I get some help fixing the issue.


Is there any way we can revert this change while we're discussing the 
best solution to this?

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r348355 - head/sys/dev/iicbus

[Niclas Zeising]

On 2019-06-03 14:08, Andriy Gapon wrote:

On 03/06/2019 14:16, Niclas Zeising wrote:

Hi!
It seems like things broke after all, latest pkg build (on head-amd64) reports
this:


/wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2:
error: implicit declaration of function 'iicbus_set_nostop' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
     iicbus_set_nostop(idev, true);
     ^
/wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2:
error: this function declaration is not a prototype 
[-Werror,-Wstrict-prototypes]
2 errors generated.

Full log:

http://beefy12.nyi.freebsd.org/data/head-amd64-default/p503023_s348376/logs/drm-legacy-kmod-g20190523.log


Hi!  Thank you for the report.
I am going to restore iicbus_set_nostop, but this time as a function that
modifies iicbus softc (instead of an ivar accessor for the bus).
I am including a patch that I would like to commit.

However, for the drm code to request the nostop mode correctly it needs to be
fixed as well.
My proposed patch is here: https://github.com/FreeBSDDesktop/drm-legacy/pull/9




Thank you, I will try it out.
Will this break drm-legacy-kmod on 12, which doesn't have the iic bus 
change you proposed?

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r348355 - head/sys/dev/iicbus

[Niclas Zeising]

On 2019-05-29 22:52, Ian Lepore wrote:

On Wed, 2019-05-29 at 15:12 +0300, Andriy Gapon wrote:

On 29/05/2019 14:54, Niclas Zeising wrote:

On 2019-05-29 11:08, Andriy Gapon wrote:

Author: avg
Date: Wed May 29 09:08:20 2019
New Revision: 348355
URL: https://svnweb.freebsd.org/changeset/base/348355

Log:
revert r273728 and parts of r306589, iicbus no-stop by default feature
   Since drm2 removal, there has not been any consumer of the feature in the
tree.  I am also unaware of any out-of-tree consumer.
More importantly, the feature has been broken from the very start, both
before and after r306589, because the ivar was set on a device that does
not support it and it was read from another device that also does not
support it.
   A bus-wide no-stop flag cannot be implemented as an ivar as iicbus
attaches as a child of various drivers.  Implementing the ivar in each
and every I2C driver is just impractical.
   If we ever want to implement this feature properly, then probably the
easiest way to do it would be via a flag in the softc of iicbus.
In fact, we might have to do that in the stable branches if we want to
fix the code for them.
   Reported by:ian (long time ago)
MFC after:1 month (maybe)
X-MFC-note:cannot just merge the change, must keep drm2 happy



Hi!
Just a note, be aware that drm2 lives on in ports as drm-legacy-kmod.  I haven't
tested, but, from the description above I worry that it will affect the port.
What do you think?


Oh, I forgot about that one...
I think that it could be affected if it still uses FreeBSD iic code.
I guess I might have to revert the change.




I don't think so, because I don't think this change ever worked.  I'm
not sure how anybody convinced themselves that it did.  It attempts to
retrieve ivars from a device that doesn't have them, so the net effect
is that the nostop variable is initialized from stack garbage.  Maybe
whoever wrote and tested it was lucky enough to have that accidentally
be consistently zero or non-zero, so their testing appeared to work.

Looking at the drm2 code that is the only user of this, it appears that
the nostop value is only used in the case where the driver falls back
to using the builtin intel_iicbb_driver.  That driver relies on
iicbus_transfer_gen() which is where the nostop kludge was added.
That's the fundamental problem in all of this:  the right thing to do,
IMO, would have been to implement the iicbus_transfer method directly
in the intel_iicbb_driver (probably by just cut-and-pasting the code
from iicconf.c then doing whatever is necessary to ignore stops).  And
we can still do that, pretty trivially, if necessary.

-- Ian




Hi!
It seems like things broke after all, latest pkg build (on head-amd64) 
reports this:



/wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2: 
error: implicit declaration of function 'iicbus_set_nostop' is invalid 
in C99 [-Werror,-Wimplicit-function-declaration]

iicbus_set_nostop(idev, true);
^
/wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/src/dev/drm2/i915/intel_iic.c:570:2: 
error: this function declaration is not a prototype 
[-Werror,-Wstrict-prototypes]

2 errors generated.

Full log:

http://beefy12.nyi.freebsd.org/data/head-amd64-default/p503023_s348376/logs/drm-legacy-kmod-g20190523.log

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r348355 - head/sys/dev/iicbus

[Niclas Zeising]

On 2019-05-29 11:08, Andriy Gapon wrote:

Author: avg
Date: Wed May 29 09:08:20 2019
New Revision: 348355
URL: https://svnweb.freebsd.org/changeset/base/348355

Log:
   revert r273728 and parts of r306589, iicbus no-stop by default feature
   
   Since drm2 removal, there has not been any consumer of the feature in the

   tree.  I am also unaware of any out-of-tree consumer.
   More importantly, the feature has been broken from the very start, both
   before and after r306589, because the ivar was set on a device that does
   not support it and it was read from another device that also does not
   support it.
   
   A bus-wide no-stop flag cannot be implemented as an ivar as iicbus

   attaches as a child of various drivers.  Implementing the ivar in each
   and every I2C driver is just impractical.
   
   If we ever want to implement this feature properly, then probably the

   easiest way to do it would be via a flag in the softc of iicbus.
   In fact, we might have to do that in the stable branches if we want to
   fix the code for them.
   
   Reported by:	ian (long time ago)

   MFC after:   1 month (maybe)
   X-MFC-note:  cannot just merge the change, must keep drm2 happy



Hi!
Just a note, be aware that drm2 lives on in ports as drm-legacy-kmod.  I 
haven't tested, but, from the description above I worry that it will 
affect the port.  What do you think?

Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r348114 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed May 22 16:59:22 2019
New Revision: 348114
URL: https://svnweb.freebsd.org/changeset/base/348114

Log:
  Fix ObsoleteFiles after ethernet driver removal
  
  Fix OpsoleteFiles.inc after removal of ethernet drivers.  The drivers have
  manual pages, and manual pages are generally stored compressed, with a .gz
  suffix, but this is not reflected in ObsoleteFiles and make delete-old fails
  to remove them.
  
  Approved by:  brooks
  Sponsored by: B3 Init
  Differential Revision:https://reviews.freebsd.org/D20351

Modified:
  head/ObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Wed May 22 16:24:39 2019(r348113)
+++ head/ObsoleteFiles.inc  Wed May 22 16:59:22 2019(r348114)
@@ -39,31 +39,31 @@
 # done
 
 # 20190517: Remove obsolete 10 and 10/100 ethernet drivers.
-OLD_FILES+=usr/share/man/man4/bm.4
-OLD_FILES+=usr/share/man/man4/cs.4
-OLD_FILES+=usr/share/man/man4/de.4
-OLD_FILES+=usr/share/man/man4/if_de.4
-OLD_FILES+=usr/share/man/man4/ed.4
-OLD_FILES+=usr/share/man/man4/if_ed.4
-OLD_FILES+=usr/share/man/man4/ep.4
-OLD_FILES+=usr/share/man/man4/ex.4
-OLD_FILES+=usr/share/man/man4/fe.4
-OLD_FILES+=usr/share/man/man4/pcn.4
-OLD_FILES+=usr/share/man/man4/if_pcn.4
-OLD_FILES+=usr/share/man/man4/sf.4
-OLD_FILES+=usr/share/man/man4/if_sf.4
-OLD_FILES+=usr/share/man/man4/sn.4
-OLD_FILES+=usr/share/man/man4/if_sn.4
-OLD_FILES+=usr/share/man/man4/tl.4
-OLD_FILES+=usr/share/man/man4/if_tl.4
-OLD_FILES+=usr/share/man/man4/tx.4
-OLD_FILES+=usr/share/man/man4/if_tx.4
-OLD_FILES+=usr/share/man/man4/txp.4
-OLD_FILES+=usr/share/man/man4/if_txp.4
-OLD_FILES+=usr/share/man/man4/vx.4
-OLD_FILES+=usr/share/man/man4/wb.4
-OLD_FILES+=usr/share/man/man4/xe.4
-OLD_FILES+=usr/share/man/man4/if_xe.4
+OLD_FILES+=usr/share/man/man4/bm.4.gz
+OLD_FILES+=usr/share/man/man4/cs.4.gz
+OLD_FILES+=usr/share/man/man4/de.4.gz
+OLD_FILES+=usr/share/man/man4/if_de.4.gz
+OLD_FILES+=usr/share/man/man4/ed.4.gz
+OLD_FILES+=usr/share/man/man4/if_ed.4.gz
+OLD_FILES+=usr/share/man/man4/ep.4.gz
+OLD_FILES+=usr/share/man/man4/ex.4.gz
+OLD_FILES+=usr/share/man/man4/fe.4.gz
+OLD_FILES+=usr/share/man/man4/pcn.4.gz
+OLD_FILES+=usr/share/man/man4/if_pcn.4.gz
+OLD_FILES+=usr/share/man/man4/sf.4.gz
+OLD_FILES+=usr/share/man/man4/if_sf.4.gz
+OLD_FILES+=usr/share/man/man4/sn.4.gz
+OLD_FILES+=usr/share/man/man4/if_sn.4.gz
+OLD_FILES+=usr/share/man/man4/tl.4.gz
+OLD_FILES+=usr/share/man/man4/if_tl.4.gz
+OLD_FILES+=usr/share/man/man4/tx.4.gz
+OLD_FILES+=usr/share/man/man4/if_tx.4.gz
+OLD_FILES+=usr/share/man/man4/txp.4.gz
+OLD_FILES+=usr/share/man/man4/if_txp.4.gz
+OLD_FILES+=usr/share/man/man4/vx.4.gz
+OLD_FILES+=usr/share/man/man4/wb.4.gz
+OLD_FILES+=usr/share/man/man4/xe.4.gz
+OLD_FILES+=usr/share/man/man4/if_xe.4.gz
 # 20190513: libcap_sysctl interface change
 OLD_FILES+=lib/casper/libcap_sysctl.1
 # 20190509: tests/sys/opencrypto requires the net/py-dpkt package.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r347695 - in head/sys: amd64/amd64 amd64/include kern

[Niclas Zeising]

On 2019-05-19 10:11, Dmitry Chagin wrote:

сб, 18 мая 2019 г. в 11:44, Konstantin Belousov :


On Sat, May 18, 2019 at 11:35:29AM +0300, Dmitry Chagin wrote:

чт, 16 мая 2019 г. в 16:29, Konstantin Belousov :


Author: kib
Date: Thu May 16 13:28:48 2019
New Revision: 347695
URL: https://svnweb.freebsd.org/changeset/base/347695

Log:
   amd64 pmap: rework delayed invalidation, removing global mutex.

   For machines having cmpxcgh16b instruction, i.e. everything but very
   early Athlons, provide lockless implementation of delayed
   invalidation.

   The implementation maintains lock-less single-linked list with the
   trick from the T.L. Harris article about volatile mark of the

elements

   being removed. Double-CAS is used to atomically update both link and
   generation.  New thread starting DI appends itself to the end of the
   queue, setting the generation to the generation of the last element
   +1.  On DI finish, thread donates its generation to the previous
   element.  The generation of the fake head of the list is the last
   passed DI generation.  Basically, the implementation is a queued
   spinlock but without spinlock.




Hi, Kostik! First of all thanks for the previous help.
Second, this commit broke i915kms module. Unfortunatelly,
I can't give you a lot of information becouse I see only black screen,
but I can help with testing

Did you recompiled the module ?




I use pkg, but after your mail, yes, compiled drm-current-kmod

root@mordor:~ # kldstat
Id Refs AddressSize Name
  14 0x8020  1d536e0 kernel
  21 0x81f54000 11e8 acpi_call.ko
root@mordor:~ # kldload i915kms
sysctl_warn_reuse: can't re-use a leaf (compat.linuxkpi.debug)!
drmn1:  on vgapci1
device_attach: drmn1 attach returned 19
root@mordor:~

so, I'll ping freebsd-x11


Hi!
drm-current-kmod was updated to the 20190519 snapshot, can you try that? 
 If it still fails, please send a message to x...@freebsd.org .

Thanks!
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r346958 - head/sys/compat/linuxkpi/common/src

[Niclas Zeising]

On 2019-04-30 12:41, Hans Petter Selasky wrote:

Author: hselasky
Date: Tue Apr 30 10:41:20 2019
New Revision: 346958
URL: https://svnweb.freebsd.org/changeset/base/346958

Log:
   Reduce the number of mutexes after r346645 in the LinuxKPI.
   Make function macro wrappers for locking and unlocking to ease readability.
   
   No functional change.
   
   Discussed with:		kib@, tychon@ and zeising@


I was not part of any discussion regarding this.  If this is related to 
https://reviews.freebsd.org/D20097 I explicitly asked you on gitter to 
hold of for a bit, while we try to figure out why we are seeing 
regressions in graphics with the latest dmar changes.


Can you please revert this since it colludes the dmar graphics issue, 
and it makes the suggested patch not apply cleanly, which makes it 
harder to get people to help test.

Thank you!
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r346899 - head

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Apr 29 18:20:51 2019
New Revision: 346899
URL: https://svnweb.freebsd.org/changeset/base/346899

Log:
  Add a note to MAINTAINERS for lkpi for graphics
  
  Add a note to MAINTAINERS requesting pre-commit review from the graphics
  team, using phabricator, for changes to the lkpi subsystem.  This is done in
  order to give us a chance to test the graphics drivers (drm drivers) for
  regressions, and to try to avoid breakage, errors and issues with the
  graphics drivers.
  The review is done via the #x11 group on phabricator.
  
  Please note that hselasky also want to review changes.
  
  Discussed with:   hselasky, imp
  Approved by:  imp

Modified:
  head/MAINTAINERS

Modified: head/MAINTAINERS
==
--- head/MAINTAINERSMon Apr 29 18:09:55 2019(r346898)
+++ head/MAINTAINERSMon Apr 29 18:20:51 2019(r346899)
@@ -90,6 +90,10 @@ share/mk/*.test.mk   freebsd-testing,ngie (same list as 
 stand/forthdteske  Pre-commit review requested.
 stand/lua  kevans  Pre-commit review requested
 sys/compat/linuxkpihselaskyIf in doubt, ask.
+   zeising, johalunpre-commit review requested via
+   #x11 phabricator group.
+   (to avoid drm graphics drivers
+   inpact)
 sys/contrib/ipfilter   cy  Pre-commit review requested.
 sys/dev/e1000  erj Pre-commit phabricator review requested.
 sys/dev/ixgbe  erj Pre-commit phabricator review requested.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r342389 - head/share/man/man5

[Niclas Zeising]

On 12/28/18 7:43 PM, Chris Rees wrote:

Hey,

On 28 December 2018 18:19:57 GMT+00:00, Niclas Zeising  
wrote:

On 12/24/18 11:47 AM, Chris Rees wrote:

Author: crees (doc,ports committer)
Date: Mon Dec 24 10:47:48 2018
New Revision: 342389
URL: https://svnweb.freebsd.org/changeset/base/342389

Log:
Clarify kld_list format

PR:		docs/234248

Submitted by:   David Fiander
Submitted by:   Miroslav Lachman

Modified:
head/share/man/man5/rc.conf.5

Modified: head/share/man/man5/rc.conf.5


==

--- head/share/man/man5/rc.conf.5   Mon Dec 24 06:14:32 2018
(r342388)
+++ head/share/man/man5/rc.conf.5   Mon Dec 24 10:47:48 2018
(r342389)
@@ -248,12 +248,14 @@ Default
   .Pa /etc/ddb.conf .
   .It Va kld_list
   .Pq Vt str
-A list of kernel modules to load right after the local
-disks are mounted.
+A whitespace-separated list of kernel modules to load right after
+the local disks are mounted, without any
+.Pa .ko
+extension or path.
   Loading modules at this point in the boot process is
   much faster than doing it via
   .Pa /boot/loader.conf
-for those modules not necessary for mounting local disk.
+for those modules not necessary for mounting local disks.
   .It Va kldxref_enable
   .Pq Vt bool
   Set to



Hi!
Sorry for jumping into this so late.
Please please PLEASE don't break loading modules by path in kld_list.
This is used by the drm-kmod files to distinguish them from the base
modules, and this has been communicated in documentation all over the
place, including numerous ports.

Can this please be reverted, or amended to match reality.

In practice, adding both the path and the extension (.ko) to a module
in
kld_list works and the module loads.


As the code itself stands, it works for loading, but throws an error if you try 
to load an already loaded module adding a .ko extension.  In other words, it 
works but is wrong.  The path actually still does work, which was my mistake.

I'm awaiting approval for this, which correctly handles all cases:

https://reviews.freebsd.org/D18670

Konstantin has reviewed, but doesn't feel comfortable giving approval as it's 
not his area, which is fair enough.

Chris



Ok.
Will this continue to work when loading /path/to/foo.ko rather than 
path/to/foo? (I assume it will)

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r342389 - head/share/man/man5

[Niclas Zeising]

On 12/24/18 11:47 AM, Chris Rees wrote:

Author: crees (doc,ports committer)
Date: Mon Dec 24 10:47:48 2018
New Revision: 342389
URL: https://svnweb.freebsd.org/changeset/base/342389

Log:
   Clarify kld_list format
   
   PR:		docs/234248

   Submitted by:David Fiander
   Submitted by:Miroslav Lachman

Modified:
   head/share/man/man5/rc.conf.5

Modified: head/share/man/man5/rc.conf.5
==
--- head/share/man/man5/rc.conf.5   Mon Dec 24 06:14:32 2018
(r342388)
+++ head/share/man/man5/rc.conf.5   Mon Dec 24 10:47:48 2018
(r342389)
@@ -248,12 +248,14 @@ Default
  .Pa /etc/ddb.conf .
  .It Va kld_list
  .Pq Vt str
-A list of kernel modules to load right after the local
-disks are mounted.
+A whitespace-separated list of kernel modules to load right after
+the local disks are mounted, without any
+.Pa .ko
+extension or path.
  Loading modules at this point in the boot process is
  much faster than doing it via
  .Pa /boot/loader.conf
-for those modules not necessary for mounting local disk.
+for those modules not necessary for mounting local disks.
  .It Va kldxref_enable
  .Pq Vt bool
  Set to



Hi!
Sorry for jumping into this so late.
Please please PLEASE don't break loading modules by path in kld_list. 
This is used by the drm-kmod files to distinguish them from the base 
modules, and this has been communicated in documentation all over the 
place, including numerous ports.


Can this please be reverted, or amended to match reality.

In practice, adding both the path and the extension (.ko) to a module in 
kld_list works and the module loads.


Regards
--
Niclas Zeising
FreeBSD Graphics Team
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r340997 - head/lib/libarchive

[Niclas Zeising]

On 12/2/18 4:03 AM, Justin Hibbits wrote:

On Mon, Nov 26, 2018 at 3:45 PM Martin Matuska  wrote:


Author: mm
Date: Mon Nov 26 21:45:27 2018
New Revision: 340997
URL: https://svnweb.freebsd.org/changeset/base/340997

Log:
   libarchive configuration changes
   - move HAVE_BZLIB_H, HAVE_LIBLZMA and HAVE_LZMA_H to config_freebsd.h
   - activate support for multi-threaded lzma encoding [1]

   PR:   233543 [1]
   Reported by:  cem
   MFC after:1 week

Modified:
   head/lib/libarchive/Makefile
   head/lib/libarchive/config_freebsd.h

Modified: head/lib/libarchive/Makefile
==
--- head/lib/libarchive/MakefileMon Nov 26 20:56:05 2018
(r340996)
+++ head/lib/libarchive/MakefileMon Nov 26 21:45:27 2018
(r340997)
@@ -7,7 +7,6 @@ _LIBARCHIVEDIR= ${SRCTOP}/contrib/libarchive
  LIB=   archive

  LIBADD=z bz2 lzma bsdxml
-CFLAGS+= -DHAVE_BZLIB_H=1 -DHAVE_LIBLZMA=1 -DHAVE_LZMA_H=1

  # FreeBSD SHLIB_MAJOR value is managed as part of the FreeBSD system.
  # It has no real relation to the libarchive version number.

Modified: head/lib/libarchive/config_freebsd.h
==
--- head/lib/libarchive/config_freebsd.hMon Nov 26 20:56:05 2018
(r340996)
+++ head/lib/libarchive/config_freebsd.hMon Nov 26 21:45:27 2018
(r340997)
@@ -133,14 +133,17 @@
  #define HAVE_LCHFLAGS 1
  #define HAVE_LCHMOD 1
  #define HAVE_LCHOWN 1
+#define HAVE_LIBLZMA 1
  #define HAVE_LIBZ 1
  #define HAVE_LIMITS_H 1
  #define HAVE_LINK 1
+#define HAVE_LZMA_H 1
  #define HAVE_LOCALE_H 1
  #define HAVE_LOCALTIME_R 1
  #define HAVE_LONG_LONG_INT 1
  #define HAVE_LSTAT 1
  #define HAVE_LUTIMES 1
+#define HAVE_LZMA_STREAM_ENCODER_MT 1
  #define HAVE_MBRTOWC 1
  #define HAVE_MEMMOVE 1
  #define HAVE_MEMORY_H 1



This breaks ports-mgmt/pkg now, with the following failure log:

--- pkg-static ---
/usr/lib/liblzma.a(stream_encoder_mt.o): In function `mythread_cond_init':
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:230:
undefined reference to `pthread_condattr_init'
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:233:
undefined reference to `pthread_condattr_setclock'
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:237:
undefined reference to `pthread_condattr_destroy'
/usr/lib/liblzma.a(stream_encoder_mt.o): In function `get_thread':
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:237:
undefined reference to `pthread_condattr_destroy'
/usr/lib/liblzma.a(stream_encoder_mt.o): In function `mythread_cond_init':
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:233:
undefined reference to `pthread_condattr_setclock'
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:237:
undefined reference to `pthread_condattr_destroy'
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:230:
undefined reference to `pthread_condattr_init'
/usr/local/poudriere/jails/ppc64/usr/src/contrib/xz/src/common/mythread.h:237:
undefined reference to `pthread_condattr_destroy'
*** [pkg-static] Error code 1



I'm seeing the same issue when builing i386 packages on amd64 using 
poudriere.  For some reason the amd64 build is fine.  This needs to be 
reverted or fixed asap.


In the diff above it also looks like the -DHAVE_BZLIB_H=1 flag was 
forgottgen when moving to config_freebsd.h, but perhaps this was 
intentional.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r340694 - head/sys/powerpc/conf

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Tue Nov 20 19:31:02 2018
New Revision: 340694
URL: https://svnweb.freebsd.org/changeset/base/340694

Log:
  Enable evdev on ppc32
  
  Enable evdev on ppc32 as well, similar to what was done i386 and amd64 in
  r340387 and ppc64 in r340632.
  
  Evdev can be used by X and is used by wayland to handle input devices.
  
  Approved by:  jhibbits
  MFC after:2 weeks
  Differential Revision:https://reviews.freebsd.org/D18049

Modified:
  head/sys/powerpc/conf/GENERIC

Modified: head/sys/powerpc/conf/GENERIC
==
--- head/sys/powerpc/conf/GENERIC   Tue Nov 20 19:02:10 2018
(r340693)
+++ head/sys/powerpc/conf/GENERIC   Tue Nov 20 19:31:02 2018
(r340694)
@@ -228,3 +228,8 @@ device  sound   # Generic sound driver 
(required)
 device snd_ai2s# Apple I2S audio
 device snd_davbus  # Apple DAVBUS audio
 device snd_uaudio  # USB Audio
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r340632 - head/sys/powerpc/conf

[Niclas Zeising]

On 11/19/18 4:42 PM, Justin Hibbits wrote:

On Mon, 19 Nov 2018 15:36:58 + (UTC)
Niclas Zeising  wrote:


Author: zeising (doc,ports committer)
Date: Mon Nov 19 15:36:58 2018
New Revision: 340632
URL: https://svnweb.freebsd.org/changeset/base/340632

Log:
   Enable evdev on ppc64
   
   Enable evdev on ppc64 as well, similar to what was done for amd64

and i386 in r340387.
   
   Evdev can be used by X and is used by wayland to handle input

devices.
   Approved by: mmacy
   MFC after:   2 weeks
   Differential Revision:   https://reviews.freebsd.org/D18026

Modified:
   head/sys/powerpc/conf/GENERIC64

Modified: head/sys/powerpc/conf/GENERIC64
==
--- head/sys/powerpc/conf/GENERIC64 Mon Nov 19 15:31:54
2018(r340631) +++ head/sys/powerpc/conf/GENERIC64   Mon
Nov 19 15:36:58 2018(r340632) @@ -246,3 +246,8 @@
device  snd_uaudio  # USB Audio
  # Netmap provides direct access to TX/RX rings on supported NICs
  devicenetmap  # netmap(4) support
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in
legacy drivers +device  evdev   #
input event device support +device
uinput  # install /dev/uinput cdev



Is there a reason this is only in GENERIC64, not GENERIC as well?  Does
it not compile for 32-bit powerpc?

- Justin



Hi!
mmacy only asked about ppc64, and as far as I know it's only tested 
there.  I can create a patch for ppc32 as well, but I can't test myself.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r339476 - head/sys/i386/conf

[Niclas Zeising]

On 10/20/18 9:16 PM, Conrad Meyer wrote:

Author: cem
Date: Sat Oct 20 19:16:43 2018
New Revision: 339476
URL: https://svnweb.freebsd.org/changeset/base/339476

Log:
   Add a MINIMAL config for i386, based on amd64
   


Any plans to MFC this?
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r340632 - head/sys/powerpc/conf

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Nov 19 15:36:58 2018
New Revision: 340632
URL: https://svnweb.freebsd.org/changeset/base/340632

Log:
  Enable evdev on ppc64
  
  Enable evdev on ppc64 as well, similar to what was done for amd64 and i386
  in r340387.
  
  Evdev can be used by X and is used by wayland to handle input devices.
  
  Approved by:  mmacy
  MFC after:2 weeks
  Differential Revision:https://reviews.freebsd.org/D18026

Modified:
  head/sys/powerpc/conf/GENERIC64

Modified: head/sys/powerpc/conf/GENERIC64
==
--- head/sys/powerpc/conf/GENERIC64 Mon Nov 19 15:31:54 2018
(r340631)
+++ head/sys/powerpc/conf/GENERIC64 Mon Nov 19 15:36:58 2018
(r340632)
@@ -246,3 +246,8 @@ device  snd_uaudio  # USB Audio
 
 # Netmap provides direct access to TX/RX rings on supported NICs
 device netmap  # netmap(4) support
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r340387 - in head/sys: amd64/conf i386/conf

[Niclas Zeising]

On 11/13/18 7:10 AM, Kevin Bowling wrote:

ppc64 will be the next arch after amd64 to get modern graphics
(https://github.com/POWER9BSD/freebsd/commits/projects/lkpi) but we
like the tier-2 status for now and will replay changes from amd64
GENERIC once I'm able to test.

FWIW evdev is the standard with libinput for X11 under Linux.  It's
useful for modern trackpads and has no downsides for traditional
keyboards and mice under X11.  It's also a requisite for Wayland.  So
I am happy to see this change, thanks Niclas!.



This is great!
Let me and the rest of the graphics team know if we can help in any way.
I have no problem enabling evdev support in ppc64 (or any other arches) 
if it's tested at least a little.
The only reason I only enabled it for i386 and amd64 is that those are 
the platforms I have available myself.

Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r340387 - in head/sys: amd64/conf i386/conf

[Niclas Zeising]

On 11/13/18 1:49 AM, Warner Losh wrote:

On Mon, Nov 12, 2018 at 5:30 PM Rodney W. Grimes <
free...@pdx.rh.cn85.dnsmgr.net> wrote:


On Mon, Nov 12, 2018, 3:12 PM Rodney W. Grimes <
free...@pdx.rh.cn85.dnsmgr.net wrote:


Author: zeising (doc,ports committer)
Date: Mon Nov 12 21:01:28 2018
New Revision: 340387
URL: https://svnweb.freebsd.org/changeset/base/340387

Log:
   Add evdev support to amd64 and i386 kernels

   Include evdev support and drivers in the amd64 and i386 GENERIC and

MINIMAL

   kernels.  Evdev is used by X and wayland to handle input devices,

and

this

   change, together with upcomming changes in ports will make us

handle

input

   devices better in graphical UIs.


Well these "upcomming" changes in ports effect aarch64 and powerpc
who are also consumers of X?



Likely. Though there is little experience with them, so we don't know if

it

is even safe to turn them on there yet. This has taken 6 months to get
stable on x86 due to its fragile console locking protocol. Similar time

has

not been invested elsewhere, so until that happens, we should keep them

off

by default. Otherwise we run the risk of destabilizing these platforms,
even for people who don't use X. As tier 2 platforms, this has been how
we've traditionally approached risk. Even though aarch64 is approaching
tier1 status overall, in graphics it is still lagging.


 From some place aarch64 is already a tier1 platform, specifically
it is listed as such in the pkg.freebsd.org package download page.



Graphics on aarch64 is tier 2, and will remain tier 2 for the foreseeable
future. Tier 1 support requires that we leverage other people's drivers,
and we can't easily do that w/o a good linux compat layer. The structure of
FreeBSD and Linux are just enough different that doing so is somewhat
tricky and labor intensive. This is especially true for the acceleration
features. Basic framebuffer support isn't terribly hard, but to get good 2d
and 3d acceleration, we'll likely need to run upstream vendor's code (which
in many cases is available only as a binary blob + linux glue).



My real concern here is that it sounded like changes to what are
in the ports/packages are going to be made in such a way that you
are required to have evdev to use them.  If this suddently becomes
mandatory to be able to use X we need to ensure that this code
(evdev) does infact work on aarch64 and others before such changes are
put in place.  My reading here is that this code is only avaliable
as static compile into the kernel, aka no moduleto load, making this
a non-trivial road block to rpi3, etc users.



This is just for touchscreen support on x86, which requires evdev to work
well. Whatever works today won't change. However, without a lot of testing,
I'm hesitant to blindly enable it on aarch64. Once that changes, we can
turn it on, but until then it would be unwise. And evdev can be turned off
on a per-platform basis in the packages / ports tree should the need arise.
I don't think this is going to be an issue.



Hi!
This change makes it easier, and in some case possible, to use certain 
input devices, such as touchscreens, input tablets and so on. It will 
make it easier to use things like two finger scrolling or horizontal 
scrolling on touchpads, for instance.
Using evdev and libinput (from ports) is a prerequisite for Wayland, and 
useful for X, however, for X the old input drivers are not going away, 
and can still be used on architectures without evdev.
The input stack (for graphical environments) in FreeBSD is lagging 
behind Linux, and this is a first step to get it at least a little bit 
closer in terms of support.


With regards to other architectures, I only have access to amd64 and to 
some extent i386, and only enabled the drivers there.  I have no problem 
with enabling this on further architectures if I get help testing, or 
hardware to test on.


As stated, this won't cause regressions on these platforms, the old 
input device drivers (xf86-input-*) won't go anywhere in a hurry, if 
ever, and is still available for use.


I hope this clears things up a little.
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r340387 - in head/sys: amd64/conf i386/conf

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon Nov 12 21:01:28 2018
New Revision: 340387
URL: https://svnweb.freebsd.org/changeset/base/340387

Log:
  Add evdev support to amd64 and i386 kernels
  
  Include evdev support and drivers in the amd64 and i386 GENERIC and MINIMAL
  kernels.  Evdev is used by X and wayland to handle input devices, and this
  change, together with upcomming changes in ports will make us handle input
  devices better in graphical UIs.
  
  Reviewed by:  wulf, bapt, imp
  Approved by:  imp
  Differential Revision:https://reviews.freebsd.org/D17912

Modified:
  head/sys/amd64/conf/GENERIC
  head/sys/amd64/conf/MINIMAL
  head/sys/i386/conf/GENERIC
  head/sys/i386/conf/MINIMAL

Modified: head/sys/amd64/conf/GENERIC
==
--- head/sys/amd64/conf/GENERIC Mon Nov 12 20:44:22 2018(r340386)
+++ head/sys/amd64/conf/GENERIC Mon Nov 12 21:01:28 2018(r340387)
@@ -372,3 +372,8 @@ device  vmx # VMware 
VMXNET3 Ethernet
 
 # Netmap provides direct access to TX/RX rings on supported NICs
 device netmap  # netmap(4) support
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev

Modified: head/sys/amd64/conf/MINIMAL
==
--- head/sys/amd64/conf/MINIMAL Mon Nov 12 20:44:22 2018(r340386)
+++ head/sys/amd64/conf/MINIMAL Mon Nov 12 21:01:28 2018(r340387)
@@ -147,3 +147,8 @@ device  bpf # Berkeley 
packet filter
 # NOTE: XENHVM depends on xenpci.  They must be added or removed together.
 optionsXENHVM  # Xen HVM kernel infrastructure
 device xenpci  # Xen HVM Hypervisor services driver
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev

Modified: head/sys/i386/conf/GENERIC
==
--- head/sys/i386/conf/GENERIC  Mon Nov 12 20:44:22 2018(r340386)
+++ head/sys/i386/conf/GENERIC  Mon Nov 12 21:01:28 2018(r340387)
@@ -366,3 +366,8 @@ device  xenpci  # Xen HVM 
Hypervisor services driver
 
 # VMware support
 device vmx # VMware VMXNET3 Ethernet
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev

Modified: head/sys/i386/conf/MINIMAL
==
--- head/sys/i386/conf/MINIMAL  Mon Nov 12 20:44:22 2018(r340386)
+++ head/sys/i386/conf/MINIMAL  Mon Nov 12 21:01:28 2018(r340387)
@@ -148,3 +148,8 @@ device  bpf # Berkeley 
packet filter
 # NOTE: XENHVM depends on xenpci.  They must be added or removed together.
 optionsXENHVM  # Xen HVM kernel infrastructure
 device xenpci  # Xen HVM Hypervisor services driver
+
+# evdev interface
+optionsEVDEV_SUPPORT   # evdev support in legacy drivers
+device evdev   # input event device support
+device uinput  # install /dev/uinput cdev
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r339823 - in head/sys/dev: atkbdc evdev kbdmux usb/input

[Niclas Zeising]

On 10/27/18 11:26 PM, Vladimir Kondratyev wrote:

On 27.10.2018 23:32, Niclas Zeising wrote:

On 10/27/18 10:22 PM, Vladimir Kondratyev wrote:

Author: wulf
Date: Sat Oct 27 20:22:41 2018
New Revision: 339823
URL: https://svnweb.freebsd.org/changeset/base/339823

Log:
    evdev: Use console lock as evdev lock for all supported keyboard
drivers.
       Now evdev part of keyboard drivers does not take any locks if
corresponding
    input/eventN device node is not opened by userland consumers.
       Do not assert console lock inside evdev to handle the cases
when keyboard
    driver is called from some special single-threaded context like
shutdown
    thread.


Related to https://reviews.freebsd.org/D15070 ?


Yes it is a part of D15070.

Along with r339824 it closes all issues known to me that preventing
evdev to be enabled by default.



Thank you!
Any chance you can add a note in phabricator and close/abandon the review?
Once again thank you!
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r339823 - in head/sys/dev: atkbdc evdev kbdmux usb/input

[Niclas Zeising]

On 10/27/18 10:22 PM, Vladimir Kondratyev wrote:

Author: wulf
Date: Sat Oct 27 20:22:41 2018
New Revision: 339823
URL: https://svnweb.freebsd.org/changeset/base/339823

Log:
   evdev: Use console lock as evdev lock for all supported keyboard drivers.
   
   Now evdev part of keyboard drivers does not take any locks if corresponding

   input/eventN device node is not opened by userland consumers.
   
   Do not assert console lock inside evdev to handle the cases when keyboard

   driver is called from some special single-threaded context like shutdown
   thread.

Modified:
   head/sys/dev/atkbdc/atkbd.c
   head/sys/dev/evdev/evdev_private.h
   head/sys/dev/kbdmux/kbdmux.c
   head/sys/dev/usb/input/ukbd.c



Related to https://reviews.freebsd.org/D15070 ?
Regards
--
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r336203 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/patches contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers

[Niclas Zeising]

On 07/19/18 15:20, Cy Schubert wrote:

In message <2f0ab2c2-b7cc-3dae-2d65-ea3c4a951...@daemonic.se>, Niclas
Zeising w
rites:

[ sending this again since I missed the list the first time, apologies
if anyone receives a duplicate ]

On 07/19/18 13:57, Kyle Evans wrote:

On Thu, Jul 19, 2018 at 4:51 AM, Alexey Dokuchaev  wrote

:

On Thu, Jul 19, 2018 at 11:48:03AM +0300, Andrey V. Elsukov wrote:

...
Yesterday I updated my notebook (with iwm(4)) and also noticed that
wi-fi connection periodically breaks. /etc/rc.d/wpa_supplicant restart
wlan0 helps. After your message I reinstalled wpa_supplicant from old
source and now it works stable already about 2 hours.


So, right now, we have broken wpa_supplicant(8) in -CURRENT? :-/


Well, "broken". It's incredibly stable outside of rekeying events, and
further testing shows that I don't actually notice these disconnects
most of the time because it reassociates fast enough. I noticed it the
first time because apparently I had both SSIDs from my AP uncommented
in my wpa_supplicant.conf and it decided at that point to connect to
the other one, which took a little longer.

Contrary to Andrey's report, though, I don't have to kick
wpa_supplicant at all. It will reassociate on its own every single
time.



Hi!
I have the exact same problem as Andrey, with the same driver.  I've not
investigated very much, but when using the 2.8 wpa_supplicant the wifi
network dies after a little while, and I have to restart it (usually
with /etc/rc.d/netif restart).  Then it works for a little while, before
going down again.  With the old wpa_supplicant I didn't have this problem.

I don't have very much else to add except noting that I'm affected as
well. I haven't had time to debug it properly (which is why I've never
reported it)


Do these events happen at regular intervals as Kyle experienced or
randomly?

What sort of key_mgmt do you connect with to your AP? Could it be
WPA-EAP?




I do not know if it is random or not, I haven't timed it.  It usually 
happens quite soon after a reboot.  All nets I've tested have been WPA2 
PSK.  I've had the difference connecting to at least two different 
hotspots, once dual band 2.4/5GHz (although the NIC used 2.4GHz) and one 
with only 5 GHz.

Regards
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r336203 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/patches contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers

[Niclas Zeising]

[ sending this again since I missed the list the first time, apologies 
if anyone receives a duplicate ]


On 07/19/18 13:57, Kyle Evans wrote:

On Thu, Jul 19, 2018 at 4:51 AM, Alexey Dokuchaev  wrote:

On Thu, Jul 19, 2018 at 11:48:03AM +0300, Andrey V. Elsukov wrote:

...
Yesterday I updated my notebook (with iwm(4)) and also noticed that
wi-fi connection periodically breaks. /etc/rc.d/wpa_supplicant restart
wlan0 helps. After your message I reinstalled wpa_supplicant from old
source and now it works stable already about 2 hours.


So, right now, we have broken wpa_supplicant(8) in -CURRENT? :-/


Well, "broken". It's incredibly stable outside of rekeying events, and
further testing shows that I don't actually notice these disconnects
most of the time because it reassociates fast enough. I noticed it the
first time because apparently I had both SSIDs from my AP uncommented
in my wpa_supplicant.conf and it decided at that point to connect to
the other one, which took a little longer.

Contrary to Andrey's report, though, I don't have to kick
wpa_supplicant at all. It will reassociate on its own every single
time.



Hi!
I have the exact same problem as Andrey, with the same driver.  I've not 
investigated very much, but when using the 2.8 wpa_supplicant the wifi 
network dies after a little while, and I have to restart it (usually 
with /etc/rc.d/netif restart).  Then it works for a little while, before 
going down again.  With the old wpa_supplicant I didn't have this problem.


I don't have very much else to add except noting that I'm affected as 
well. I haven't had time to debug it properly (which is why I've never 
reported it)

Regards
--
Niclas

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r334288 - head/etc/mtree

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Mon May 28 17:08:37 2018
New Revision: 334288
URL: https://svnweb.freebsd.org/changeset/base/334288

Log:
  Complete removal of lmc(4)
  
  The lmc(4) driver was removed in r333144 and relevant files added to
  ObsoleteFiles.inc, however, include/sys/dev/lmc was not removed from mtree
  and is recreated on every install.  Remove it from mtree.
  
  Reviewed by:  imp, emaste
  Approved by:  emaste
  Differential Revision:https://reviews.freebsd.org/D15590

Modified:
  head/etc/mtree/BSD.include.dist

Modified: head/etc/mtree/BSD.include.dist
==
--- head/etc/mtree/BSD.include.dist Mon May 28 16:23:39 2018
(r334287)
+++ head/etc/mtree/BSD.include.dist Mon May 28 17:08:37 2018
(r334288)
@@ -128,8 +128,6 @@
 ..
 io
 ..
-lmc
-..
 mfi
 ..
 mlx5
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r333420 - in head: lib/libc/string usr.sbin/ipfwpcap

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed May  9 17:06:52 2018
New Revision: 333420
URL: https://svnweb.freebsd.org/changeset/base/333420

Log:
  Remove "all rights reserved" on files where I have copyright.
  
  According to r91 it is not needed any more.
  
  Reviewed by:  imp, emaste
  Differential Revision:https://reviews.freebsd.org/D15370

Modified:
  head/lib/libc/string/strchrnul.c
  head/usr.sbin/ipfwpcap/ipfwpcap.8

Modified: head/lib/libc/string/strchrnul.c
==
--- head/lib/libc/string/strchrnul.cWed May  9 16:52:28 2018
(r333419)
+++ head/lib/libc/string/strchrnul.cWed May  9 17:06:52 2018
(r333420)
@@ -2,7 +2,6 @@
  * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
  *
  * Copyright (c) 2013 Niclas Zeising
- * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions

Modified: head/usr.sbin/ipfwpcap/ipfwpcap.8
==
--- head/usr.sbin/ipfwpcap/ipfwpcap.8   Wed May  9 16:52:28 2018
(r333419)
+++ head/usr.sbin/ipfwpcap/ipfwpcap.8   Wed May  9 17:06:52 2018
(r333420)
@@ -1,5 +1,4 @@
 .\" Copyright (c) 2006 Niclas Zeising <zeis...@freebsd.org>
-.\" All rights reserved.
 .\"
 .\" Redistribution and use in source and binary forms, with or without
 .\" modification, are permitted provided that the following conditions
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329154 - in head/etc: defaults devd

[Niclas Zeising]

On 02/12/18 10:25, Gary Jennejohn wrote:

On Mon, 12 Feb 2018 07:01:56 +
Alexey Dokuchaev  wrote:


On Sun, Feb 11, 2018 at 10:55:48PM -0800, Cy Schubert wrote:

In message <201802120651.w1c6pkqf042...@repo.freebsd.org>, Warner Losh
writes:

New Revision: 329154
URL: https://svnweb.freebsd.org/changeset/base/329154

Log:
   Turn devmatch on by default.
   
   Turn devmatch on by default. However, use 'start' instead of

   'onestart' in the devmatch.conf file so the setting of
   'devmatch_enable' is honored. Give an example of what to put in
   devd.conf if you want to disable just the run-time part of devmatch.
   
...

@@ -41,7 +41,7 @@ ddb_enable="NO" # Set to YES to load ddb script
s at b
  ddb_config="/etc/ddb.conf"  # ddb(8) config file.
  devd_enable="YES"   # Run devd, to trigger programs on device tree changes.
  devd_flags=""   # Additional flags for devd(8).
-devmatch_enable="NO" # Demand load kernel modules based on device ids.
+devmatch_enable="YES"# Demand load kernel modules based on device id
s.


This assumes that everyone has /usr in /. We might want to consider
moving devmatch to /sbin, or document that


I was actually surprised to find out it's installed as /usr/sbin/devmatch;
/sbin indeed looks more appropriate.


/usr and / be merged.


Please don't.



+1



Any chance of moving /usr/bin/limits to /bin/limits at the same time? 
It's preventing some scripts (ddb) from running at boot.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206291 for info.
Regards!
--
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r326792 - head/stand/uboot/common

[Niclas Zeising]

On 12/12/17 20:27, Cy Schubert wrote:

PR 224080???


Yes please.
Regards
--
Niclas

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r326733 - head/usr.sbin/acpi/acpiconf

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Sat Dec  9 15:59:10 2017
New Revision: 326733
URL: https://svnweb.freebsd.org/changeset/base/326733

Log:
  Improve options and error handling.
  
  Improve options handling and error out if multiple mutually exclusive
  options are passed to acpiconf.  Switch from using atoi() to strtol() for
  argument parsing, and add error checking and handling, instead of blindly
  trusting that the integer conversion is OK.
  Cange err() to errx() in once case, the errno value was garbage there.
  
  Reviewed by:  emaste
  Approved by:  emaste
  Differential Revision:D13430

Modified:
  head/usr.sbin/acpi/acpiconf/acpiconf.c

Modified: head/usr.sbin/acpi/acpiconf/acpiconf.c
==
--- head/usr.sbin/acpi/acpiconf/acpiconf.c  Sat Dec  9 15:47:26 2017
(r326732)
+++ head/usr.sbin/acpi/acpiconf/acpiconf.c  Sat Dec  9 15:59:10 2017
(r326733)
@@ -92,7 +92,7 @@ acpi_battinfo(int num)
uint32_t volt;
 
if (num < 0 || num > 64)
-   err(EX_USAGE, "invalid battery %d", num);
+   errx(EX_USAGE, "invalid battery %d", num);
 
/* Print battery design information. */
battio.unit = num;
@@ -205,8 +205,9 @@ usage(const char* prog)
 int
 main(int argc, char *argv[])
 {
-   char*prog;
-   int c, sleep_type;
+   char*prog, *end;
+   int c, sleep_type, battery, ack;
+   int iflag = 0, kflag = 0, sflag = 0;
 
prog = argv[0];
if (argc < 2)
@@ -218,16 +219,24 @@ main(int argc, char *argv[])
while ((c = getopt(argc, argv, "hi:k:s:")) != -1) {
switch (c) {
case 'i':
-   acpi_battinfo(atoi(optarg));
+   iflag = 1;
+   battery = strtol(optarg, , 10);
+   if ((size_t)(end - optarg) != strlen(optarg))
+   errx(EX_USAGE, "invalid battery");
break;
case 'k':
-   acpi_sleep_ack(atoi(optarg));
+   kflag = 1;
+   ack = strtol(optarg, , 10);
+   if ((size_t)(end - optarg) != strlen(optarg))
+   errx(EX_USAGE, "invalid ack argument");
break;
case 's':
+   sflag = 1;
if (optarg[0] == 'S')
-   sleep_type = optarg[1] - '0';
-   else
-   sleep_type = optarg[0] - '0';
+   optarg++;
+   sleep_type = strtol(optarg, , 10);
+   if ((size_t)(end - optarg) != strlen(optarg))
+   errx(EX_USAGE, "invalid sleep type");
if (sleep_type < 1 || sleep_type > 4)
errx(EX_USAGE, "invalid sleep type (%d)",
 sleep_type);
@@ -241,7 +250,25 @@ main(int argc, char *argv[])
argc -= optind;
argv += optind;
 
-   if (sleep_type != -1)
+   if (iflag != 0 && kflag != 0 && sflag != 0)
+   errx(EX_USAGE, "-i, -k and -s are mutually exclusive");
+
+   if (iflag  != 0) {
+   if (kflag != 0)
+   errx(EX_USAGE, "-i and -k are mutually exclusive");
+   if (sflag != 0)
+   errx(EX_USAGE, "-i and -s are mutually exclusive");
+   acpi_battinfo(battery);
+   }
+
+   if (kflag != 0) {
+   if (sflag != 0)
+   errx(EX_USAGE, "-k and -s are mutually exclusive");
+   acpi_sleep_ack(ack);
+   }
+
+
+   if (sflag != 0)
acpi_sleep(sleep_type);
 
close(acpifd);
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r326099 - head/usr.bin/iscsictl

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Nov 22 18:06:41 2017
New Revision: 326099
URL: https://svnweb.freebsd.org/changeset/base/326099

Log:
  Fix language in a bunch of error messages.
  
  Reviewed by:  emaste
  Approved by:  emaste
  MFC after:1 month
  Differential Revision:D13193

Modified:
  head/usr.bin/iscsictl/iscsictl.c

Modified: head/usr.bin/iscsictl/iscsictl.c
==
--- head/usr.bin/iscsictl/iscsictl.cWed Nov 22 16:45:27 2017
(r326098)
+++ head/usr.bin/iscsictl/iscsictl.cWed Nov 22 18:06:41 2017
(r326099)
@@ -813,41 +813,41 @@ main(int argc, char **argv)
if (Aflag != 0) {
if (aflag != 0) {
if (enable != ENABLE_UNSPECIFIED)
-   xo_errx(1, "-a and -e and mutually exclusive");
+   xo_errx(1, "-a and -e are mutually exclusive");
if (portal != NULL)
-   xo_errx(1, "-a and -p and mutually exclusive");
+   xo_errx(1, "-a and -p are mutually exclusive");
if (target != NULL)
-   xo_errx(1, "-a and -t and mutually exclusive");
+   xo_errx(1, "-a and -t are mutually exclusive");
if (user != NULL)
-   xo_errx(1, "-a and -u and mutually exclusive");
+   xo_errx(1, "-a and -u are mutually exclusive");
if (secret != NULL)
-   xo_errx(1, "-a and -s and mutually exclusive");
+   xo_errx(1, "-a and -s are mutually exclusive");
if (nickname != NULL)
-   xo_errx(1, "-a and -n and mutually exclusive");
+   xo_errx(1, "-a and -n are mutually exclusive");
if (discovery_host != NULL)
-   xo_errx(1, "-a and -d and mutually exclusive");
+   xo_errx(1, "-a and -d are mutually exclusive");
if (rflag != 0)
-   xo_errx(1, "-a and -r and mutually exclusive");
+   xo_errx(1, "-a and -r are mutually exclusive");
} else if (nickname != NULL) {
if (enable != ENABLE_UNSPECIFIED)
-   xo_errx(1, "-n and -e and mutually exclusive");
+   xo_errx(1, "-n and -e are mutually exclusive");
if (portal != NULL)
-   xo_errx(1, "-n and -p and mutually exclusive");
+   xo_errx(1, "-n and -p are mutually exclusive");
if (target != NULL)
-   xo_errx(1, "-n and -t and mutually exclusive");
+   xo_errx(1, "-n and -t are mutually exclusive");
if (user != NULL)
-   xo_errx(1, "-n and -u and mutually exclusive");
+   xo_errx(1, "-n and -u are mutually exclusive");
if (secret != NULL)
-   xo_errx(1, "-n and -s and mutually exclusive");
+   xo_errx(1, "-n and -s are mutually exclusive");
if (discovery_host != NULL)
-   xo_errx(1, "-n and -d and mutually exclusive");
+   xo_errx(1, "-n and -d are mutually exclusive");
if (rflag != 0)
-   xo_errx(1, "-n and -r and mutually exclusive");
+   xo_errx(1, "-n and -r are mutually exclusive");
} else if (discovery_host != NULL) {
if (portal != NULL)
-   xo_errx(1, "-d and -p and mutually exclusive");
+   xo_errx(1, "-d and -p are mutually exclusive");
if (target != NULL)
-   xo_errx(1, "-d and -t and mutually exclusive");
+   xo_errx(1, "-d and -t are mutually exclusive");
} else {
if (target == NULL && portal == NULL)
xo_errx(1, "must specify -a, -n or -t/-p");
@@ -874,15 +874,15 @@ main(int argc, char **argv)
 
if (nickname != NULL) {
if (enable != ENABLE_UNSPECIFIED)
-   xo_errx(1, "-n and -e and mutually exclusive");
+   xo_errx(1, "-n and -e are mutually exclusive");
if (portal != NULL)
-   xo_errx(1, "-n and -p and mutually exclusive");
+   

svn commit: r303106 - head/lib/libc/sys

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Jul 20 18:16:58 2016
New Revision: 303106
URL: https://svnweb.freebsd.org/changeset/base/303106

Log:
  Change wording to use function rather than system call in the description
  as well.
  
  Reviewed by:  brooks
  MFC after:5 days

Modified:
  head/lib/libc/sys/pipe.2

Modified: head/lib/libc/sys/pipe.2
==
--- head/lib/libc/sys/pipe.2Wed Jul 20 18:11:22 2016(r303105)
+++ head/lib/libc/sys/pipe.2Wed Jul 20 18:16:58 2016(r303106)
@@ -46,7 +46,7 @@
 .Sh DESCRIPTION
 The
 .Fn pipe
-system call
+function
 creates a
 .Em pipe ,
 which is an object allowing
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r288291 - head/etc

[Niclas Zeising]

On 2016-06-19 16:08, Cy Schubert wrote:
> In message <4e985ab9-0d98-a160-bdad-fa4924ddc...@freebsd.org>, Niclas 
> Zeising writes:
>>
>> This is wrong, and how I discovered it.  ddb (/etc/rc.d/ddb) starts
>> before disks, and currently refuses to start on my systems with this
>> issue.  This means no crash dumps, unless I remember to manually start
>> it later in the boot process, so this is an issue.
> 
> ddb isn't a daemon. It's an interface into the kernel that configures DDB 
> properties. It runs and completes. And, yes, it is affected by limits not 
> being found in the path.

I think I misunderstood what you mean, I thought you meant nothing is
affected by this.  Apologies for that.

> 
> My point is, since there are no daemons, as per the definition of a daemon 
> (processes that become daemons and run in the background) prior to the 
> filesystems being run, to say that there would be differing systems 
> behavior before and after filesystems are started is presently false 
> (though technically true because one day we might have daemons started 
> before critical filesystems are mounted).

Agreed.  I understand if we are too late in the release cycle for 11 to
move limits to /bin, which seems like the best solutions.  Are there any
other reasons not to move /usr/bin/limits?

I wanted to bring this to attention, since it seems noone else has
noticed it, or cared enough about it.  It is nothing that stops me from
using FreeBSD, I will just have to remember to start ddb manually, or
run the commands in case of a panic.
Regards!
-- 
Niclas

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r288291 - head/etc

[Niclas Zeising]

On 2016-06-19 07:12, Cy Schubert wrote:
> In message  om>
> , Adrian Chadd writes:
>> i think that's fine for -11. I'd like to just move limits to /bin for
>> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..)
>>
>> I don't want to see differing system behaviour between limits but it's
>> likely unavoidable for 11 and could do with some errata notice so
>> people know what to expect.
> 
> There aren't any daemons started prior to critical local filesystems being 
> mounted. I suppose one day there could be but none at this point in time. 
> Setting limits before filesystems are mounted is practically a NOP anyway. 
> (Except it could negatively affect fsck of huge UFS filesystems some day.)
> 
> 

This is wrong, and how I discovered it.  ddb (/etc/rc.d/ddb) starts
before disks, and currently refuses to start on my systems with this
issue.  This means no crash dumps, unless I remember to manually start
it later in the boot process, so this is an issue.
Regards!
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r288291 - head/etc

[Niclas Zeising]

On 2016-06-19 05:45, Allan Jude wrote:
> On 2016-06-18 23:32, Adrian Chadd wrote:
>> i think that's fine for -11. I'd like to just move limits to /bin for
>> 12. (I mean, it's 2016, why are you splitting / and /usr again? But..)
>>
> 
> bsdinstall for UFS just uses one big /, and ZFS does something similar
> for boot environments. Only people who have partitioned manually, or
> upgraded in place from 8.x or earlier, will still have separate / and
> /usr. We can't throw those people under the bus, but, it is reasonable
> to consider switching things around for 12.
> 


I have several systems with separate /usr, done either manually or
upgraded in place since forever, so this is an issue, and I expect there
are several others out there in the same situation.
Regards!
-- 
Niclas

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r288291 - head/etc

[Niclas Zeising]

On 09/27/15 06:03, Adrian Chadd wrote:
> Author: adrian
> Date: Sun Sep 27 04:03:11 2015
> New Revision: 288291
> URL: https://svnweb.freebsd.org/changeset/base/288291
> 
> Log:
>   Enforce consistent limits of daemons run from rc.subr:
>   
>   * Allow the user to configure the login class to use in rc.conf
> by using {daemon}_login_class, which;
>   * Use the daemon class by default;
>   * .. and then use 'limits' to set the login class so it works both
> via init at startup (which runs this in 'daemon' class) and via
> whichever root environment (eg command line, other daemons, etc.)
>   
>   Reviewed by:dteske
>   Differential Revision:  https://reviews.freebsd.org/D3630
> 
> Modified:
>   head/etc/rc.subr
> 
> Modified: head/etc/rc.subr
> ==
> --- head/etc/rc.subr  Sun Sep 27 03:46:55 2015(r288290)
> +++ head/etc/rc.subr  Sun Sep 27 04:03:11 2015(r288291)
> @@ -768,6 +768,8 @@ check_startmsgs()
>  #
>  #${name}_prepend n   Command added before ${command}.
>  #
> +#${name}_login_class n   Login class to use, else "daemon".
> +#
>  #${rc_arg}_cmd   n   If set, use this as the method when invoked;
>  #Otherwise, use default command (see below)
>  #
> @@ -942,7 +944,7 @@ run_rc_command()
>   _nice=\$${name}_nice_user=\$${name}_user \
>   _group=\$${name}_group  _groups=\$${name}_groups \
>   _fib=\$${name}_fib  _env=\$${name}_env \
> - _prepend=\$${name}_prepend
> + _prepend=\$${name}_prepend  
> _login_class=\${${name}_login_class:-daemon}
>  
>   if [ -n "$_user" ]; then# unset $_user if running as that user
>   if [ "$_user" = "$(eval $IDCMD)" ]; then
> @@ -1050,6 +1052,9 @@ $command $rc_flags $command_args"
>   fi
>   fi
>  
> + # Prepend default limits
> + _doit="limits -C $_login_class $_doit"
   ^^
> +
>   # run the full command
>   #
>   if ! _run_rc_doit "$_doit"; then

Apologies for waking so late.
This breaks the start of scripts running before file systems are
mounted, for example /etc/rc.d/ddb, if / and /usr are on separate
partitions.  The issue is that limits is /usr/bin/limits, and for
obvious reasons can't be found before /usr is mounted.
I suggest either move /usr/bin/limits to /bin/limits or avoid using it
altogether.
Do you want me to open a PR to track this issue?
Regards!
-- 
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r299109 - head/sys/modules/bhnd/bhndb

[Niclas Zeising]

On 2016-05-05 17:51, Adrian Chadd wrote:
> I'll check. I've done full kernel builds with this though, I wonder
> why it's not showing up here.
> 

Hi!
I'm bitten by the same issue and just developed the same fix
independently of Ivan Klymenko.  However, at least for me, the issue
only shows when doing a parallel build of the kernel, in my case make -j8.
Regards!
-- 
Niclas
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r261832 - in head: share/man/man5 usr.sbin/jail

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Feb 13 12:52:26 2014
New Revision: 261832
URL: http://svnweb.freebsd.org/changeset/base/261832

Log:
  Add cross references between rc.conf(5) and jail.conf(5).
  
  MFC after:2 weeks

Modified:
  head/share/man/man5/rc.conf.5
  head/usr.sbin/jail/jail.conf.5

Modified: head/share/man/man5/rc.conf.5
==
--- head/share/man/man5/rc.conf.5   Thu Feb 13 10:11:14 2014
(r261831)
+++ head/share/man/man5/rc.conf.5   Thu Feb 13 12:52:26 2014
(r261832)
@@ -4462,6 +4462,7 @@ The default is 30.
 .Xr fstab 5 ,
 .Xr ipf 5 ,
 .Xr ipnat 5 ,
+.Xr jail.conf 5 ,
 .Xr motd 5 ,
 .Xr newsyslog.conf 5 ,
 .Xr pf.conf 5 ,

Modified: head/usr.sbin/jail/jail.conf.5
==
--- head/usr.sbin/jail/jail.conf.5  Thu Feb 13 10:11:14 2014
(r261831)
+++ head/usr.sbin/jail/jail.conf.5  Thu Feb 13 12:52:26 2014
(r261832)
@@ -207,6 +207,7 @@ bar {
 .Ed
 .Sh SEE ALSO
 .Xr jail_set 2
+.Xr rc.conf 5
 .Xr jail 8
 .Xr jls 8
 .Sh HISTORY
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r261833 - head/usr.sbin/jail

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Feb 13 12:53:57 2014
New Revision: 261833
URL: http://svnweb.freebsd.org/changeset/base/261833

Log:
  Add commas (,) to the list in the SEE ALSO section, to match most other
  manuals.
  
  MFC after:2 weeks

Modified:
  head/usr.sbin/jail/jail.conf.5

Modified: head/usr.sbin/jail/jail.conf.5
==
--- head/usr.sbin/jail/jail.conf.5  Thu Feb 13 12:52:26 2014
(r261832)
+++ head/usr.sbin/jail/jail.conf.5  Thu Feb 13 12:53:57 2014
(r261833)
@@ -206,9 +206,9 @@ bar {
 }
 .Ed
 .Sh SEE ALSO
-.Xr jail_set 2
-.Xr rc.conf 5
-.Xr jail 8
+.Xr jail_set 2 ,
+.Xr rc.conf 5 ,
+.Xr jail 8 ,
 .Xr jls 8
 .Sh HISTORY
 The
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r261834 - in head: share/man/man5 usr.sbin/jail

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Feb 13 13:11:34 2014
New Revision: 261834
URL: http://svnweb.freebsd.org/changeset/base/261834

Log:
  Bump .Dd forgotten in r261832.
  
  MFC after:2 weeks

Modified:
  head/share/man/man5/rc.conf.5
  head/usr.sbin/jail/jail.conf.5

Modified: head/share/man/man5/rc.conf.5
==
--- head/share/man/man5/rc.conf.5   Thu Feb 13 12:53:57 2014
(r261833)
+++ head/share/man/man5/rc.conf.5   Thu Feb 13 13:11:34 2014
(r261834)
@@ -24,7 +24,7 @@
 .\
 .\ $FreeBSD$
 .\
-.Dd December 25, 2013
+.Dd February 13, 2014
 .Dt RC.CONF 5
 .Os
 .Sh NAME

Modified: head/usr.sbin/jail/jail.conf.5
==
--- head/usr.sbin/jail/jail.conf.5  Thu Feb 13 12:53:57 2014
(r261833)
+++ head/usr.sbin/jail/jail.conf.5  Thu Feb 13 13:11:34 2014
(r261834)
@@ -24,7 +24,7 @@
 .\
 .\ $FreeBSD$
 .\
-.Dd May 23, 2012
+.Dd February 13, 2014
 .Dt JAIL.CONF 5
 .Os
 .Sh NAME
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r259016 - in head/sys: conf dev/drm2 dev/drm2/i915 dev/drm2/radeon dev/fb dev/vt kern modules/drm2/i915kms modules/drm2/radeonkms sparc64/sparc64 sys teken

[Niclas Zeising]

On 12/18/13 01:24, Baptiste Daroussin wrote:
 On Wed, Dec 18, 2013 at 02:21:56AM +0200, Aleksandr Rybalko wrote:
 On Tue, 10 Dec 2013 23:49:38 +0100
 Andreas Tobler andre...@freebsd.org wrote:

 On 10.12.13 14:43, Tijl Coosemans wrote:
 On Tue, 10 Dec 2013 15:31:44 +0200 Aleksandr Rybalko wrote:
 That keyboards have no Shift key for that? :)
 I will be glad to apply your changes, but I have to know how it
 should be controlled.

 RU and UA PC keyboards have same 3 symbols '2', '', '@'
 To get '2' i have to press only '2'
 To get '@' I have to press Shift+'2'
 To get '' I have to switch to UA or RU and press Shift+'2'

 Ahh, or use some called Third-Level (IIRC) in Xorg terms. Temporary
 lang switch. Which commonly mapped to one of Alt. Right?
 So R-Alt+Shift+'2'?

 https://en.wikipedia.org/wiki/AltGr

 Thanks Tijl!

 To get the @ I have to press AltGr + '2'.
 There are combinations where I have to press AltGr+Shift. e.g to get
 the 'broken bar, ¦', AltGr+Shift+'7'.

 Andreas


 Hello Andreas and Tijl!

 Since I think not a whole world have AltGr key (read as not most
 keyboards on the Earth) :)
 Think it is OK to use R.Alt as an Alt by default, and enable AltGr with
 sysctl kern.vt.enable_altgr.

 I tend to disagree with you, lots of keyboards mapping are concerned here.
 

alt-gr is there on most, if not all, western european keyboard layouts,
and probably more layouts than that.  Have a look at
http://en.wikipedia.org/wiki/AltGr_key
for instance.
Regards!
-- 
Niclas
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r259016 - in head/sys: conf dev/drm2 dev/drm2/i915 dev/drm2/radeon dev/fb dev/vt kern modules/drm2/i915kms modules/drm2/radeonkms sparc64/sparc64 sys teken

[Niclas Zeising]

On 2013-12-05 23:38, Aleksandr Rybalko wrote:
 Author: ray
 Date: Thu Dec  5 22:38:53 2013
 New Revision: 259016
 URL: http://svnweb.freebsd.org/changeset/base/259016
 
 Log:
   Merge VT(9) project (a.k.a. newcons).

WOHO!
Congratulations!
Don't forget to update kernel configurations, and if/when you enable it
by default (or now, maybe) please bump osversion.
Regards!
-- 
Niclas
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r255321 - in head: contrib/llvm/tools/clang/lib/Driver gnu/lib gnu/usr.bin/cc share/mk sys/sys tools/build/options

[Niclas Zeising]

On 09/06/13 22:08, David Chisnall wrote:
 Author: theraven
 Date: Fri Sep  6 20:08:03 2013
 New Revision: 255321
 URL: http://svnweb.freebsd.org/changeset/base/255321
 
 Log:
   On platforms where clang is the default compiler, don't build gcc or 
 libstdc++.
   To enable them, set WITH_GCC and WITH_GNUCXX in src.conf.
   Make clang default to using libc++ on FreeBSD 10.
   Bumped __FreeBSD_version for the change.

Please remember to regenerate src.conf(5), or let me know and I'll fix it.
Regards!
-- 
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r255327 - head/share/man/man5

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Fri Sep  6 20:51:15 2013
New Revision: 255327
URL: http://svnweb.freebsd.org/changeset/base/255327

Log:
  Regenerate after unhooking gcc/g++ from the default build for some arches.

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Fri Sep  6 20:49:48 2013
(r255326)
+++ head/share/man/man5/src.conf.5  Fri Sep  6 20:51:15 2013
(r255327)
@@ -1,7 +1,7 @@
 .\ DO NOT EDIT-- this file is automatically generated.
 .\ from FreeBSD: head/tools/build/options/makeman 253304 2013-07-12 23:08:44Z 
bapt
 .\ $FreeBSD$
-.Dd August 29, 2013
+.Dd September 6, 2013
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -471,12 +471,17 @@ Set to not build
 .\ from FreeBSD: head/tools/build/options/WITHOUT_GAMES 156932 2006-03-21 
07:50:50Z ru
 Set to not build games.
 .It Va WITHOUT_GCC
-.\ from FreeBSD: head/tools/build/options/WITHOUT_GCC 222090 2011-05-19 
05:13:25Z imp
-Set to not install gcc and g++.
-.Bf -symbolic
-The option does not generally work for build targets, unless some alternative
-toolchain is enabled.
-.Ef
+.\ from FreeBSD: head/tools/build/options/WITHOUT_GCC 255326 2013-09-06 
20:49:48Z zeising
+Set to not build and install gcc and g++.
+.Pp
+It is a default setting on
+amd64/amd64, arm/arm, arm/armv6 and i386/i386.
+.It Va WITH_GCC
+.\ from FreeBSD: head/tools/build/options/WITH_GCC 255326 2013-09-06 
20:49:48Z zeising
+Set to build and install gcc and g++.
+.Pp
+It is a default setting on
+arm/armeb, arm/armv6eb, ia64/ia64, mips/mipsel, mips/mips, mips/mips64el, 
mips/mips64, mips/mipsn32, pc98/i386, powerpc/powerpc, powerpc/powerpc64 and 
sparc64/sparc64.
 .It Va WITHOUT_GCOV
 .\ from FreeBSD: head/tools/build/options/WITHOUT_GCOV 156932 2006-03-21 
07:50:50Z ru
 Set to not build the
@@ -500,6 +505,20 @@ When set, it also enforces the following
 .It
 .Va WITHOUT_GNU_SUPPORT
 .El
+.It Va WITHOUT_GNUCXX
+.\ from FreeBSD: head/tools/build/options/WITHOUT_GNUCXX 255321 2013-09-06 
20:08:03Z theraven
+Do not build the GNU C++ stack (g++, libstdc++).
+This is the default on platforms where clang is the system compiler.
+.Pp
+It is a default setting on
+amd64/amd64, arm/arm, arm/armv6, i386/i386 and pc98/i386.
+.It Va WITH_GNUCXX
+.\ from FreeBSD: head/tools/build/options/WITH_GNUCXX 255321 2013-09-06 
20:08:03Z theraven
+Build the GNU C++ stack (g++, libstdc++).
+This is the default on platforms where gcc is the system compiler.
+.Pp
+It is a default setting on
+arm/armeb, arm/armv6eb, ia64/ia64, mips/mipsel, mips/mips, mips/mips64el, 
mips/mips64, mips/mipsn32, powerpc/powerpc, powerpc/powerpc64 and 
sparc64/sparc64.
 .It Va WITHOUT_GNU_SUPPORT
 .\ from FreeBSD: head/tools/build/options/WITHOUT_GNU_SUPPORT 156932 
2006-03-21 07:50:50Z ru
 Set to build some programs without optional GNU support.
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r255018 - head/tools/build/mk

[Niclas Zeising]

On 2013-08-29 13:40, Andreas Tobler wrote:
 Author: andreast
 Date: Thu Aug 29 11:40:45 2013
 New Revision: 255018
 URL: http://svnweb.freebsd.org/changeset/base/255018
 
 Log:
   Remove GNU_PATCH leftover.
 
 Modified:
   head/tools/build/mk/OptionalObsoleteFiles.inc

They should probably be moved to ObsoleteFiles.inc instead.
Regards!
-- 
Niclas
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r254981 - head/share/man/man5

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Tue Aug 27 23:30:02 2013
New Revision: 254981
URL: http://svnweb.freebsd.org/changeset/base/254981

Log:
  Really regen after r254962.
  
  This removes the WITH_BSDCONFIG description alltogether, since this option
  is removed.
  At the same time, fix the WITHOUT_LIBCPLUSPLUS option that had gotten
  inverted.

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Tue Aug 27 23:09:34 2013
(r254980)
+++ head/share/man/man5/src.conf.5  Tue Aug 27 23:30:02 2013
(r254981)
@@ -1,7 +1,7 @@
 .\ DO NOT EDIT-- this file is automatically generated.
 .\ from FreeBSD: head/tools/build/options/makeman 253304 2013-07-12 23:08:44Z 
bapt
 .\ $FreeBSD$
-.Dd August 27, 2013
+.Dd August 28, 2013
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -235,9 +235,6 @@ This option will be removed in due time.
 .It Va WITHOUT_BOOT
 .\ from FreeBSD: head/tools/build/options/WITHOUT_BOOT 156932 2006-03-21 
07:50:50Z ru
 Set to not build the boot blocks and loader.
-.It Va WITH_BSDCONFIG
-.\ from FreeBSD: head/tools/build/options/WITH_BSDCONFIG 238448 2012-07-14 
10:17:47Z zeising
-Set to install bsdconfig(8), a BSD-licensed configuration/management utility.
 .It Va WITHOUT_BSD_CPIO
 .\ from FreeBSD: head/tools/build/options/WITHOUT_BSD_CPIO 179813 2008-06-16 
05:48:15Z dougb
 Set to not build the BSD licensed version of cpio based on
@@ -704,9 +701,9 @@ and
 On amd64, set to not build 32-bit library set and a
 .Nm ld-elf32.so.1
 runtime linker.
-.It Va WITH_LIBCPLUSPLUS
-.\ from FreeBSD: head/tools/build/options/WITH_LIBCPLUSPLUS 228082 2011-11-28 
17:56:46Z dim
-Set to build libcxxrt and libc++.
+.It Va WITHOUT_LIBCPLUSPLUS
+.\ from FreeBSD: head/tools/build/options/WITHOUT_LIBCPLUSPLUS 246262 
2013-02-02 22:42:46Z dim
+Set to avoid building libcxxrt and libc++.
 .It Va WITH_LIBICONV_COMPAT
 .\ from FreeBSD: head/tools/build/options/WITH_LIBICONV_COMPAT 254919 
2013-08-26 17:15:56Z antoine
 Set to build libiconv API and link time compatibility.
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r252561 - head/tools/build/options

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Jul  3 12:36:47 2013
New Revision: 252561
URL: http://svnweb.freebsd.org/changeset/base/252561

Log:
  Document WITHOUT_SVNLITE and WITH_SVN.
  
  PR:   docs/180025
  Submitted by: Garrett Cooper yaneurab...@gmail.com

Added:
  head/tools/build/options/WITHOUT_SVNLITE   (contents, props changed)
  head/tools/build/options/WITH_SVN   (contents, props changed)

Added: head/tools/build/options/WITHOUT_SVNLITE
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/tools/build/options/WITHOUT_SVNLITEWed Jul  3 12:36:47 2013
(r252561)
@@ -0,0 +1,4 @@
+.\ $FreeBSD$
+Set to not build
+.Xr svnlite 1
+and related programs.

Added: head/tools/build/options/WITH_SVN
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/tools/build/options/WITH_SVN   Wed Jul  3 12:36:47 2013
(r252561)
@@ -0,0 +1,5 @@
+.\ $FreeBSD$
+Set to install
+.Xr svnlite 1
+as
+.Xr svn 1 .
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r252562 - head/share/man/man5

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Jul  3 12:53:06 2013
New Revision: 252562
URL: http://svnweb.freebsd.org/changeset/base/252562

Log:
  Regenerate after r252561
  
  PR:   docs/180025
  Submitted by: Garrett Cooper yaneurab...@gmail.com

Modified:
  head/share/man/man5/rc.conf.5
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/rc.conf.5
==
--- head/share/man/man5/rc.conf.5   Wed Jul  3 12:36:47 2013
(r252561)
+++ head/share/man/man5/rc.conf.5   Wed Jul  3 12:53:06 2013
(r252562)
@@ -3449,6 +3449,40 @@ For example,
 will set the
 .Xr syscons 4
 scrollback (history) buffer to 200 lines.
+.It Va auditd_enable
+.Pq Vt bool
+If set to
+.Dq Li YES ,
+run the
+.Xr auditd 8
+daemon at system boot time.
+.It Va auditd_program
+.Pq Vt str
+Path to
+.Xr autitd 8
+(default
+.Pa /usr/sbin/auditd ) .
+.It Va auditd_flags
+.Pq Vt str
+Flags to pass to
+.Xr audtid 8 .
+.It Va auditdistd_enable
+.Pq Vt bool
+If set to
+.Dq Li YES ,
+run the
+.Xr auditdistd 8
+daemon at system boot time.
+.It Va auditdistd_program
+.Pq Vt str
+Path to
+.Xr auditdistd 8
+(default
+.Pa /usr/sbin/auditdistd ) .
+.It Va auditdistd_flags
+.Pq Vt str
+Flags to pass to
+.Xr auditdistd 8 .
 .It Va cron_enable
 .Pq Vt bool
 If set to

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Wed Jul  3 12:36:47 2013
(r252561)
+++ head/share/man/man5/src.conf.5  Wed Jul  3 12:53:06 2013
(r252562)
@@ -1,7 +1,7 @@
 .\ DO NOT EDIT-- this file is automatically generated.
 .\ from FreeBSD: head/tools/build/options/makeman 251685 2013-06-13 13:05:08Z 
emaste
 .\ $FreeBSD$
-.Dd June 16, 2013
+.Dd July 3, 2013
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -1055,6 +1055,17 @@ Set to not build kernel modules that inc
 .It Va WITHOUT_SSP
 .\ from FreeBSD: head/tools/build/options/WITHOUT_SSP 180012 2008-06-25 
21:33:28Z ru
 Set to not build world with propolice stack smashing protection.
+.It Va WITH_SVN
+.\ from FreeBSD: head/tools/build/options/WITH_SVN 252561 2013-07-03 
12:36:47Z zeising
+Set to install
+.Xr svnlite 1
+as
+.Xr svn 1 .
+.It Va WITHOUT_SVNLITE
+.\ from FreeBSD: head/tools/build/options/WITHOUT_SVNLITE 252561 2013-07-03 
12:36:47Z zeising
+Set to not build
+.Xr svnlite 1
+and related programs.
 .It Va WITHOUT_SYMVER
 .\ from FreeBSD: head/tools/build/options/WITHOUT_SYMVER 169649 2007-05-17 
05:03:24Z deischen
 Set to disable symbol versioning when building shared libraries.
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r252564 - head/share/man/man5

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Jul  3 12:58:53 2013
New Revision: 252564
URL: http://svnweb.freebsd.org/changeset/base/252564

Log:
  Revert previous revision, local change that accidentally snuck in.

Modified:
  head/share/man/man5/rc.conf.5

Modified: head/share/man/man5/rc.conf.5
==
--- head/share/man/man5/rc.conf.5   Wed Jul  3 12:58:17 2013
(r252563)
+++ head/share/man/man5/rc.conf.5   Wed Jul  3 12:58:53 2013
(r252564)
@@ -3449,40 +3449,6 @@ For example,
 will set the
 .Xr syscons 4
 scrollback (history) buffer to 200 lines.
-.It Va auditd_enable
-.Pq Vt bool
-If set to
-.Dq Li YES ,
-run the
-.Xr auditd 8
-daemon at system boot time.
-.It Va auditd_program
-.Pq Vt str
-Path to
-.Xr autitd 8
-(default
-.Pa /usr/sbin/auditd ) .
-.It Va auditd_flags
-.Pq Vt str
-Flags to pass to
-.Xr audtid 8 .
-.It Va auditdistd_enable
-.Pq Vt bool
-If set to
-.Dq Li YES ,
-run the
-.Xr auditdistd 8
-daemon at system boot time.
-.It Va auditdistd_program
-.Pq Vt str
-Path to
-.Xr auditdistd 8
-(default
-.Pa /usr/sbin/auditdistd ) .
-.It Va auditdistd_flags
-.Pq Vt str
-Flags to pass to
-.Xr auditdistd 8 .
 .It Va cron_enable
 .Pq Vt bool
 If set to
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r251819 - head/share/man/man5

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Sun Jun 16 20:51:44 2013
New Revision: 251819
URL: http://svnweb.freebsd.org/changeset/base/251819

Log:
  Fix the libc++ option.
  This somehow got reverted when this was updated after the CVS removal.

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Sun Jun 16 19:35:01 2013
(r251818)
+++ head/share/man/man5/src.conf.5  Sun Jun 16 20:51:44 2013
(r251819)
@@ -1,7 +1,7 @@
 .\ DO NOT EDIT-- this file is automatically generated.
 .\ from FreeBSD: head/tools/build/options/makeman 251685 2013-06-13 13:05:08Z 
emaste
 .\ $FreeBSD$
-.Dd June 15, 2013
+.Dd June 16, 2013
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -698,9 +698,9 @@ and
 On amd64, set to not build 32-bit library set and a
 .Nm ld-elf32.so.1
 runtime linker.
-.It Va WITH_LIBCPLUSPLUS
-.\ from FreeBSD: head/tools/build/options/WITH_LIBCPLUSPLUS 228082 2011-11-28 
17:56:46Z dim
-Set to build libcxxrt and libc++.
+.It Va WITHOUT_LIBCPLUSPLUS
+.\ from FreeBSD: head/tools/build/options/WITHOUT_LIBCPLUSPLUS 246262 
2013-02-02 22:42:46Z dim
+Set to avoid building libcxxrt and libc++.
 .It Va WITHOUT_LIBPTHREAD
 .\ from FreeBSD: head/tools/build/options/WITHOUT_LIBPTHREAD 188848 
2009-02-20 11:09:55Z mtm
 Set to not build the
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r251795 - head/share/man/man5

[Niclas Zeising]

On 2013-06-15 23:29, Eitan Adler wrote:
 Author: eadler
 Date: Sat Jun 15 21:29:47 2013
 New Revision: 251795
 URL: http://svnweb.freebsd.org/changeset/base/251795
 
 Log:
   Regenerate after CVS removal (and it seems other missed changes)

 @@ -701,9 +698,9 @@ and
  On amd64, set to not build 32-bit library set and a
  .Nm ld-elf32.so.1
  runtime linker.
 -.It Va WITHOUT_LIBCPLUSPLUS
 -.\ from FreeBSD: head/tools/build/options/WITHOUT_LIBCPLUSPLUS 246262 
 2013-02-02 22:42:46Z dim
 -Set to avoid building libcxxrt and libc++.
 +.It Va WITH_LIBCPLUSPLUS
 +.\ from FreeBSD: head/tools/build/options/WITH_LIBCPLUSPLUS 228082 
 2011-11-28 17:56:46Z dim
 +Set to build libcxxrt and libc++.
  .It Va WITHOUT_LIBPTHREAD
  .\ from FreeBSD: head/tools/build/options/WITHOUT_LIBPTHREAD 188848 
 2009-02-20 11:09:55Z mtm
  Set to not build the

This part seems really strange.  Can you please double check that it is
as intended?
Regards!
-- 
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r250148 - head/share/misc

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed May  1 17:29:42 2013
New Revision: 250148
URL: http://svnweb.freebsd.org/changeset/base/250148

Log:
  Add OpenBSD 5.3, released today, May 1 2013.

Modified:
  head/share/misc/bsd-family-tree

Modified: head/share/misc/bsd-family-tree
==
--- head/share/misc/bsd-family-tree Wed May  1 15:02:58 2013
(r250147)
+++ head/share/misc/bsd-family-tree Wed May  1 17:29:42 2013
(r250148)
@@ -261,6 +261,10 @@ FreeBSD 5.2   |  |  
  |  FreeBSD   |  | |   |
  |9.1 |  | |   |
  ||  | |   |
+ ||  |OpenBSD 5.3  |
+ ||  | |   |
+ ||  | |   |
+ ||  | |   |
 FreeBSD 10 -current   |  NetBSD -current  OpenBSD -current |
  ||  | |   |
  vv  v v   v
@@ -558,6 +562,7 @@ NetBSD 6.0  2012-10-17 [NBD]
 OpenBSD 5.22012-11-01 [OBD]
 DragonFly 3.2.12012-11-02 [DFB]
 FreeBSD 9.12012-12-30 [FBD]
+OpenBSD 5.32013-05-01 [OBD]
 
 Bibliography
 
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r249115 - in head: sbin/camcontrol sys/sys

[Niclas Zeising]

On 04/05/13 01:19, Steven Hartland wrote:
 Author: smh
 Date: Thu Apr  4 23:19:51 2013
 New Revision: 249115
 URL: http://svnweb.freebsd.org/changeset/base/249115
 
 Log:
   Adds security options to camcontrol this includes the ability to secure 
 erase
   disks such as SSD's
   
   Adds the ability to run ATA commands via the SCSI ATA Pass-Through(16) 
 comand
   
   Reviewed by:mav
   Approved by:pjd (mentor)
   MFC after:  2 weeks
 
 Modified:
   head/sbin/camcontrol/camcontrol.8

You should bump the date in the manual as well, look for .Dd.
Regards!
-- 
Niclas

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r249083 - in head: rescue/rescue sbin sbin/atacontrol share/man/man4 sys/amd64/conf sys/arm/conf sys/cam/ata sys/conf sys/dev/ata sys/dev/ata/chipsets sys/i386/conf sys/ia64/conf sys/m

[Niclas Zeising]

On 2013-04-04 09:12, Alexander Motin wrote:
 
 Deleted:
   head/sbin/atacontrol/
   head/share/man/man4/atapicam.4
   head/share/man/man4/ataraid.4

Those three should probably be added to ObsoleteFiles.inc as well.
Regards!
-- 
Niclas
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r247899 - head/lib/libc/string

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Mar  6 19:59:42 2013
New Revision: 247899
URL: http://svnweb.freebsd.org/changeset/base/247899

Log:
  Create a symlink from strchrnul.3 to strchr.3.
  This was forgotten in the initial commit of strchrnul()
  
  Approved by:  theraven

Modified:
  head/lib/libc/string/Makefile.inc

Modified: head/lib/libc/string/Makefile.inc
==
--- head/lib/libc/string/Makefile.inc   Wed Mar  6 19:37:38 2013
(r247898)
+++ head/lib/libc/string/Makefile.inc   Wed Mar  6 19:59:42 2013
(r247899)
@@ -46,7 +46,8 @@ MLINKS+=strcasecmp.3 strncasecmp.3 \
strcasecmp.3 strcasecmp_l.3 \
strcasecmp.3 strncasecmp_l.3
 MLINKS+=strcat.3 strncat.3
-MLINKS+=strchr.3 strrchr.3
+MLINKS+=strchr.3 strrchr.3 \
+   strchr.3 strchrnul.3
 MLINKS+=strcmp.3 strncmp.3
 MLINKS+=strcoll.3 strcoll_l.3
 MLINKS+=strcpy.3 stpcpy.3 \
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r246803 - head/include

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Feb 14 19:26:58 2013
New Revision: 246803
URL: http://svnweb.freebsd.org/changeset/base/246803

Log:
  FreeBSD uses #if __BSD_VISIBLE to hide non-standard functions, fix this.
  
  Noticed by:   kib
  Approved by:  kib

Modified:
  head/include/string.h

Modified: head/include/string.h
==
--- head/include/string.h   Thu Feb 14 19:22:15 2013(r246802)
+++ head/include/string.h   Thu Feb 14 19:26:58 2013(r246803)
@@ -74,7 +74,7 @@ char  *strcasestr(const char *, const cha
 #endif
 char   *strcat(char * __restrict, const char * __restrict);
 char   *strchr(const char *, int) __pure;
-#if defined(_GNU_SOURCE)
+#if __BSD_VISIBLE
 char   *strchrnul(const char*, int) __pure;
 #endif
 int strcmp(const char *, const char *) __pure;
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r246809 - head/lib/libc/net

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Thu Feb 14 21:29:55 2013
New Revision: 246809
URL: http://svnweb.freebsd.org/changeset/base/246809

Log:
  Change examples to be consistent with what style(9) says.
  
  Approved by:  joel (mentor)
  MFC After:2 weeks

Modified:
  head/lib/libc/net/getaddrinfo.3
  head/lib/libc/net/getnameinfo.3

Modified: head/lib/libc/net/getaddrinfo.3
==
--- head/lib/libc/net/getaddrinfo.3 Thu Feb 14 21:02:18 2013
(r246808)
+++ head/lib/libc/net/getaddrinfo.3 Thu Feb 14 21:29:55 2013
(r246809)
@@ -18,7 +18,7 @@
 .\
 .\ $FreeBSD$
 .\
-.Dd January 6, 2009
+.Dd February 14, 2013
 .Dt GETADDRINFO 3
 .Os
 .Sh NAME
@@ -339,7 +339,7 @@ hints.ai_socktype = SOCK_STREAM;
 error = getaddrinfo(www.kame.net, http, hints, res0);
 if (error) {
errx(1, %s, gai_strerror(error));
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 s = -1;
 for (res = res0; res; res = res-ai_next) {
@@ -361,7 +361,7 @@ for (res = res0; res; res = res-ai_next
 }
 if (s  0) {
err(1, %s, cause);
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 freeaddrinfo(res0);
 .Ed
@@ -383,7 +383,7 @@ hints.ai_flags = AI_PASSIVE;
 error = getaddrinfo(NULL, http, hints, res0);
 if (error) {
errx(1, %s, gai_strerror(error));
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 nsock = 0;
 for (res = res0; res  nsock  MAXSOCK; res = res-ai_next) {
@@ -405,7 +405,7 @@ for (res = res0; res  nsock  MAXSOCK;
 }
 if (nsock == 0) {
err(1, %s, cause);
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 freeaddrinfo(res0);
 .Ed

Modified: head/lib/libc/net/getnameinfo.3
==
--- head/lib/libc/net/getnameinfo.3 Thu Feb 14 21:02:18 2013
(r246808)
+++ head/lib/libc/net/getnameinfo.3 Thu Feb 14 21:29:55 2013
(r246809)
@@ -18,7 +18,7 @@
 .\
 .\ $FreeBSD$
 .\
-.Dd February 28, 2007
+.Dd February 14, 2013
 .Dt GETNAMEINFO 3
 .Os
 .Sh NAME
@@ -157,7 +157,7 @@ char hbuf[NI_MAXHOST], sbuf[NI_MAXSERV];
 if (getnameinfo(sa, sa-sa_len, hbuf, sizeof(hbuf), sbuf,
 sizeof(sbuf), NI_NUMERICHOST | NI_NUMERICSERV)) {
errx(1, could not get numeric hostname);
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 printf(host=%s, serv=%s\en, hbuf, sbuf);
 .Ed
@@ -170,7 +170,7 @@ char hbuf[NI_MAXHOST];
 if (getnameinfo(sa, sa-sa_len, hbuf, sizeof(hbuf), NULL, 0,
 NI_NAMEREQD)) {
errx(1, could not resolve hostname);
-   /*NOTREACHED*/
+   /* NOTREACHED */
 }
 printf(host=%s\en, hbuf);
 .Ed
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

svn commit: r246766 - in head: include lib/libc/string

[Niclas Zeising]

Author: zeising (doc,ports committer)
Date: Wed Feb 13 15:46:33 2013
New Revision: 246766
URL: http://svnweb.freebsd.org/changeset/base/246766

Log:
  Add strchrnul(), a GNU function similar to strchr(), except that it returns
  a pointer to the end of the string, rather than NULL, if the character was
  not found.
  
  Approved by:  theraven

Added:
  head/lib/libc/string/strchrnul.c   (contents, props changed)
Modified:
  head/include/string.h
  head/lib/libc/string/Makefile.inc
  head/lib/libc/string/Symbol.map
  head/lib/libc/string/strchr.3

Modified: head/include/string.h
==
--- head/include/string.h   Wed Feb 13 15:43:15 2013(r246765)
+++ head/include/string.h   Wed Feb 13 15:46:33 2013(r246766)
@@ -74,6 +74,9 @@ char  *strcasestr(const char *, const cha
 #endif
 char   *strcat(char * __restrict, const char * __restrict);
 char   *strchr(const char *, int) __pure;
+#if defined(_GNU_SOURCE)
+char   *strchrnul(const char*, int) __pure;
+#endif
 int strcmp(const char *, const char *) __pure;
 int strcoll(const char *, const char *);
 char   *strcpy(char * __restrict, const char * __restrict);

Modified: head/lib/libc/string/Makefile.inc
==
--- head/lib/libc/string/Makefile.inc   Wed Feb 13 15:43:15 2013
(r246765)
+++ head/lib/libc/string/Makefile.inc   Wed Feb 13 15:46:33 2013
(r246766)
@@ -10,9 +10,9 @@ MISRCS+=bcmp.c bcopy.c bzero.c ffs.c ffs
memccpy.c memchr.c memrchr.c memcmp.c \
memcpy.c memmem.c memmove.c memset.c \
stpcpy.c stpncpy.c strcasecmp.c \
-   strcat.c strcasestr.c strchr.c strcmp.c strcoll.c strcpy.c strcspn.c \
-   strdup.c strerror.c strlcat.c strlcpy.c strlen.c strmode.c strncat.c \
-   strncmp.c strncpy.c strndup.c strnlen.c strnstr.c \
+   strcat.c strcasestr.c strchr.c strchrnul.c strcmp.c strcoll.c strcpy.c\
+   strcspn.c strdup.c strerror.c strlcat.c strlcpy.c strlen.c strmode.c \
+   strncat.c strncmp.c strncpy.c strndup.c strnlen.c strnstr.c \
strpbrk.c strrchr.c strsep.c strsignal.c strspn.c strstr.c strtok.c \
strxfrm.c swab.c wcpcpy.c wcpncpy.c wcscasecmp.c wcscat.c \
wcschr.c wcscmp.c wcscoll.c wcscpy.c wcscspn.c wcsdup.c \

Modified: head/lib/libc/string/Symbol.map
==
--- head/lib/libc/string/Symbol.map Wed Feb 13 15:43:15 2013
(r246765)
+++ head/lib/libc/string/Symbol.map Wed Feb 13 15:46:33 2013
(r246766)
@@ -94,6 +94,7 @@ FBSD_1.1 {
 FBSD_1.3 {
strcasecmp_l;
strcasestr_l;
+   strchrnul;
strncasecmp_l;
wcswidth_l;
wcwidth_l;

Modified: head/lib/libc/string/strchr.3
==
--- head/lib/libc/string/strchr.3   Wed Feb 13 15:43:15 2013
(r246765)
+++ head/lib/libc/string/strchr.3   Wed Feb 13 15:46:33 2013
(r246766)
@@ -32,11 +32,11 @@
 .\ @(#)strchr.3   8.2 (Berkeley) 4/19/94
 .\ $FreeBSD$
 .\
-.Dd April 19, 1994
+.Dd February 13, 2013
 .Dt STRCHR 3
 .Os
 .Sh NAME
-.Nm strchr , strrchr
+.Nm strchr , strrchr , strchrnul
 .Nd locate character in string
 .Sh LIBRARY
 .Lb libc
@@ -46,6 +46,8 @@
 .Fn strchr const char *s int c
 .Ft char *
 .Fn strrchr const char *s int c
+.Ft char *
+.Fn strchrnul const char *s int c
 .Sh DESCRIPTION
 The
 .Fn strchr
@@ -69,6 +71,18 @@ function is identical to
 .Fn strchr
 except it locates the last occurrence of
 .Fa c .
+.Pp
+The
+.Fn strchrnul
+function is identical to
+.Fn strchr
+except that if
+.Fa c
+is not found in
+.Fa s
+a pointer to the terminating
+.Ql \e0
+is returned.
 .Sh RETURN VALUES
 The functions
 .Fn strchr
@@ -77,6 +91,11 @@ and
 return a pointer to the located character, or
 .Dv NULL
 if the character does not appear in the string.
+.Pp
+.Fn strchrnul
+returns a pointer to the terminating
+.Ql \e0
+if the character does not appear in the string.
 .Sh SEE ALSO
 .Xr memchr 3 ,
 .Xr memmem 3 ,
@@ -94,3 +113,11 @@ and
 .Fn strrchr
 conform to
 .St -isoC .
+The
+.Fn strchrnul
+is a GNU extension .
+.Sh History
+The
+.Fn strchrnul
+function first appeared in glibc 2.1.1 and was added in
+.Fx 10.0 .

Added: head/lib/libc/string/strchrnul.c
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/lib/libc/string/strchrnul.cWed Feb 13 15:46:33 2013
(r246766)
@@ -0,0 +1,48 @@
+/*-
+ * Copyright (c) 2013 Niclas Zeising
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions

Re: svn commit: r243960 - in head/sys: amd64/include i386/include x86/include

[Niclas Zeising]

On 12/06/12 23:33, Jim Harris wrote:
 Author: jimharris
 Date: Thu Dec  6 22:33:31 2012
 New Revision: 243960
 URL: http://svnweb.freebsd.org/changeset/base/243960
 
 Log:
   Add amd64 implementations for 8-byte bus_space routines.
   

 +#include sys/systm.h
  #include x86/bus.h
 +
 +#define KASSERT_BUS_SPACE_MEM_ONLY(tag) \
 + KASSERT((tag) == X86_BUS_SPACE_MEM, \
 + (%s: can only handle mem space, __func__))
 +
 +static __inline uint64_t
 +bus_space_read_8(bus_space_tag_t tag, bus_space_handle_t bsh,
 +bus_size_t ofs)
 +{
 +
 + KASSERT_BUS_SPACE_MEM_ONLY(tag);
 +
 + return (*(volatile uint64_t *)(bsh + ofs));
 +}

Hi!
Can the include of sys/systm.h and the added KASSERTs please be hidden
under #ifdef _KERNEL or something similar?  devel/libpciaccess from the
experimental xorg-dev tree
(http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess)
uses machine/bus.h on amd64 and i386 to be able to read/write to the pci
bus, and this change breaks the compile of devel/libpciaccess.
It is probably so that libpciaccess is wrong in using machine/bus.h
but I have no idea how to fix it.  If you have a better suggestion on
how to fix libpciaccess I am all ears.
Regards!
-- 
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r243960 - in head/sys: amd64/include i386/include x86/include

[Niclas Zeising]

On 12/11/12 00:32, Carl Delsey wrote:
 On 12/10/12 16:20, Niclas Zeising wrote:
 On 12/06/12 23:33, Jim Harris wrote:
 Author: jimharris
 Date: Thu Dec  6 22:33:31 2012
 New Revision: 243960
 URL: http://svnweb.freebsd.org/changeset/base/243960

 Log:
Add amd64 implementations for 8-byte bus_space routines.
+#include sys/systm.h
   #include x86/bus.h
 +
 +#define KASSERT_BUS_SPACE_MEM_ONLY(tag) \
 +KASSERT((tag) == X86_BUS_SPACE_MEM, \
 +(%s: can only handle mem space, __func__))
 +
 +static __inline uint64_t
 +bus_space_read_8(bus_space_tag_t tag, bus_space_handle_t bsh,
 +bus_size_t ofs)
 +{
 +
 +KASSERT_BUS_SPACE_MEM_ONLY(tag);
 +
 +return (*(volatile uint64_t *)(bsh + ofs));
 +}
 Hi!
 Can the include of sys/systm.h and the added KASSERTs please be hidden
 under #ifdef _KERNEL or something similar?  devel/libpciaccess from the
 experimental xorg-dev tree
 (http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess)
 uses machine/bus.h on amd64 and i386 to be able to read/write to the pci
 bus, and this change breaks the compile of devel/libpciaccess.
 It is probably so that libpciaccess is wrong in using machine/bus.h
 but I have no idea how to fix it.  If you have a better suggestion on
 how to fix libpciaccess I am all ears.
 Regards!
 Does libpciaccess make use of the bus_space_read/write_* routines in
 these files, or does it just use some constants and types from them?
 

libpciaccess uses bus_space_[read,write]_[1,2,4], which are defined in
x86/bus.h.  It does not use the quad functions.
Regards!
-- 
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r243960 - in head/sys: amd64/include i386/include x86/include

[Niclas Zeising]

On 12/11/12 00:54, Carl Delsey wrote:
 On 12/10/12 16:40, Niclas Zeising wrote:
 On 12/11/12 00:32, Carl Delsey wrote:
 On 12/10/12 16:20, Niclas Zeising wrote:
 On 12/06/12 23:33, Jim Harris wrote:
 Author: jimharris
 Date: Thu Dec  6 22:33:31 2012
 New Revision: 243960
 URL: http://svnweb.freebsd.org/changeset/base/243960

 Log:
 Add amd64 implementations for 8-byte bus_space routines.
 +#include sys/systm.h
#include x86/bus.h
 +
 +#define KASSERT_BUS_SPACE_MEM_ONLY(tag) \
 +KASSERT((tag) == X86_BUS_SPACE_MEM, \
 +(%s: can only handle mem space, __func__))
 +
 +static __inline uint64_t
 +bus_space_read_8(bus_space_tag_t tag, bus_space_handle_t bsh,
 +bus_size_t ofs)
 +{
 +
 +KASSERT_BUS_SPACE_MEM_ONLY(tag);
 +
 +return (*(volatile uint64_t *)(bsh + ofs));
 +}
 Hi!
 Can the include of sys/systm.h and the added KASSERTs please be
 hidden
 under #ifdef _KERNEL or something similar?  devel/libpciaccess from the
 experimental xorg-dev tree
 (http://trillian.chruetertee.ch/ports/browser/trunk/devel/libpciaccess)
 uses machine/bus.h on amd64 and i386 to be able to read/write to the
 pci
 bus, and this change breaks the compile of devel/libpciaccess.
 It is probably so that libpciaccess is wrong in using machine/bus.h
 but I have no idea how to fix it.  If you have a better suggestion on
 how to fix libpciaccess I am all ears.
 Regards!
 Does libpciaccess make use of the bus_space_read/write_* routines in
 these files, or does it just use some constants and types from them?

 libpciaccess uses bus_space_[read,write]_[1,2,4], which are defined in
 x86/bus.h.  It does not use the quad functions.
 Regards!
 Ok. In that case I won't ifdef out the functions themselves, just the
 KASSERT in case libpciaccess expands in the future to 8 byte accesses
 :-)  I had another related change in the works. I'll add this change in.

Sounds good to me, thank you very much!
Don't forget to ifdef the include o sys/systm.h as well as the KASSERTs.
Regards!
-- 
Niclas Zeising
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org