svn commit: r368188 - head/tools/tools/ifinfo

[Olivier Cochard]

Author: olivier (ports committer)
Date: Mon Nov 30 15:04:35 2020
New Revision: 368188
URL: https://svnweb.freebsd.org/changeset/base/368188

Log:
  Fix compilation on head and while here:
  - remove unwanted whitespaces
  - remove useless function ifphys()
  - fix the Makefile to install it into /usr/bin
  
  PR:   250133
  Reviewed by:  glebius, maxim
  Approved by:  glebius
  Differential Revision:https://reviews.freebsd.org/D27155

Modified:
  head/tools/tools/ifinfo/Makefile
  head/tools/tools/ifinfo/ifinfo.c

Modified: head/tools/tools/ifinfo/Makefile
==
--- head/tools/tools/ifinfo/MakefileMon Nov 30 14:51:48 2020
(r368187)
+++ head/tools/tools/ifinfo/MakefileMon Nov 30 15:04:35 2020
(r368188)
@@ -3,5 +3,6 @@
 PROG=  ifinfo
 SRCS=  ifinfo.c rfc1650.c
 MAN=
+BINDIR?= /usr/bin
 
 .include 

Modified: head/tools/tools/ifinfo/ifinfo.c
==
--- head/tools/tools/ifinfo/ifinfo.cMon Nov 30 14:51:48 2020
(r368187)
+++ head/tools/tools/ifinfo/ifinfo.cMon Nov 30 15:04:35 2020
(r368188)
@@ -12,7 +12,7 @@
  * no representations about the suitability of this software for any
  * purpose.  It is provided "as is" without express or implied
  * warranty.
- * 
+ *
  * THIS SOFTWARE IS PROVIDED BY M.I.T. ``AS IS''.  M.I.T. DISCLAIMS
  * ALL EXPRESS OR IMPLIED WARRANTIES WITH REGARD TO THIS SOFTWARE,
  * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
@@ -49,7 +49,6 @@
 
 static void printit(const struct ifmibdata *, const char *);
 static const char *iftype(int);
-static const char *ifphys(int, int);
 static int isit(int, char **, const char *);
 static printfcn findlink(int);
 
@@ -83,7 +82,7 @@ main(int argc, char **argv)
usage(argv[0]);
}
}
-   
+
retval = 1;
 
name[0] = CTL_NET;
@@ -132,15 +131,15 @@ main(int argc, char **argv)
if (dolink && (pf = findlink(ifmd.ifmd_data.ifi_type))) {
name[5] = IFDATA_LINKSPECIFIC;
if (sysctl(name, 6, 0, , 0, 0) < 0)
-   err(EX_OSERR, 
+   err(EX_OSERR,
"sysctl(net.link.ifdata.%d.linkspec) size",
i);
linkmib = malloc(linkmiblen);
if (!linkmib)
-   err(EX_OSERR, "malloc(%lu)", 
+   err(EX_OSERR, "malloc(%lu)",
(u_long)linkmiblen);
if (sysctl(name, 6, linkmib, , 0, 0) < 0)
-   err(EX_OSERR, 
+   err(EX_OSERR,
"sysctl(net.link.ifdata.%d.linkspec)",
i);
pf(linkmib, linkmiblen);
@@ -165,15 +164,13 @@ printit(const struct ifmibdata *ifmd, const char *dnam
printf("\tsend queue max length: %d\n", ifmd->ifmd_snd_maxlen);
printf("\tsend queue drops: %d\n", ifmd->ifmd_snd_drops);
printf("\ttype: %s\n", iftype(ifmd->ifmd_data.ifi_type));
-   printf("\tphysical: %s\n", ifphys(ifmd->ifmd_data.ifi_type,
- ifmd->ifmd_data.ifi_physical));
printf("\taddress length: %d\n", ifmd->ifmd_data.ifi_addrlen);
printf("\theader length: %d\n", ifmd->ifmd_data.ifi_hdrlen);
printf("\tlink state: %u\n", ifmd->ifmd_data.ifi_link_state);
printf("\tvhid: %u\n", ifmd->ifmd_data.ifi_vhid);
printf("\tdatalen: %u\n", ifmd->ifmd_data.ifi_datalen);
-   printf("\tmtu: %lu\n", ifmd->ifmd_data.ifi_mtu);
-   printf("\tmetric: %lu\n", ifmd->ifmd_data.ifi_metric);
+   printf("\tmtu: %u\n", ifmd->ifmd_data.ifi_mtu);
+   printf("\tmetric: %u\n", ifmd->ifmd_data.ifi_metric);
printf("\tline rate: %lu bit/s\n", ifmd->ifmd_data.ifi_baudrate);
printf("\tpackets received: %lu\n", ifmd->ifmd_data.ifi_ipackets);
printf("\tinput errors: %lu\n", ifmd->ifmd_data.ifi_ierrors);
@@ -185,7 +182,7 @@ printit(const struct ifmibdata *ifmd, const char *dnam
printf("\tmulticasts received: %lu\n", ifmd->ifmd_data.ifi_imcasts);
printf("\tmulticasts transmitted: %lu\n", ifmd->ifmd_data.ifi_omcasts);
printf("\tinput queue drops: %lu\n", ifmd->ifmd_data.ifi_iqdrops);
-   printf("\tpackets for unknown protocol: %lu\n", 
+   printf("\tpackets for unknown protocol: %lu\n",
   ifmd->ifmd_data.ifi_noproto);
printf("\tHW offload capabilities: 0x%lx\n",
ifmd->ifmd_data.ifi_hwassist);
@@ -193,7 +190,7 @@ printit(const struct ifmibdata *ifmd, const char *dnam
ifmd->ifmd_data.ifi_epoch);
 #ifdef notdef
printf("\treceive timing: %lu usec\n", 

svn commit: r367478 - head/usr.sbin/bhyve

[Olivier Cochard]

Author: olivier (ports committer)
Date: Sun Nov  8 07:49:39 2020
New Revision: 367478
URL: https://svnweb.freebsd.org/changeset/base/367478

Log:
  Return the same value for smbios.chassis.maker as smbios.system.maker (and 
prevents returning a space character).
  
  Reviewed by:  grehan
  Approved by:  grehan
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D27123

Modified:
  head/usr.sbin/bhyve/smbiostbl.c

Modified: head/usr.sbin/bhyve/smbiostbl.c
==
--- head/usr.sbin/bhyve/smbiostbl.c Sun Nov  8 04:24:29 2020
(r367477)
+++ head/usr.sbin/bhyve/smbiostbl.c Sun Nov  8 07:49:39 2020
(r367478)
@@ -374,7 +374,7 @@ struct smbios_table_type3 smbios_type3_template = {
 };
 
 const char *smbios_type3_strings[] = {
-   " ",/* manufacturer string */
+   "FreeBSD",  /* manufacturer string */
"1.0",  /* version string */
"None", /* serial number string */
"None", /* asset tag string */
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r367152 - head/usr.sbin/bhyve

[Olivier Cochard]

Author: olivier (ports committer)
Date: Fri Oct 30 00:03:59 2020
New Revision: 367152
URL: https://svnweb.freebsd.org/changeset/base/367152

Log:
  bhyve currently reports each of "smbios.system.maker" and
  "smbios.system.family" as " ".
  This presents challenges for both humans and tools when trying to parse output
  that uses those results.
  The new values reported are now:
  smbios.system.family="Virtual Machine"
  smbios.system.maker="FreeBSD"
  
  PR:   250728
  Approved by:  gre...@freebsd.org
  Sponsored by: Netflix

Modified:
  head/usr.sbin/bhyve/smbiostbl.c

Modified: head/usr.sbin/bhyve/smbiostbl.c
==
--- head/usr.sbin/bhyve/smbiostbl.c Thu Oct 29 23:28:39 2020
(r367151)
+++ head/usr.sbin/bhyve/smbiostbl.c Fri Oct 30 00:03:59 2020
(r367152)
@@ -346,12 +346,12 @@ static int smbios_type1_initializer(struct smbios_stru
 uint16_t *n, uint16_t *size);
 
 const char *smbios_type1_strings[] = {
-   " ",/* manufacturer string */
-   "BHYVE",/* product name string */
-   "1.0",  /* version string */
-   "None", /* serial number string */
-   "None", /* sku string */
-   " ",/* family name string */
+   "FreeBSD",  /* manufacturer string */
+   "BHYVE",/* product name string */
+   "1.0",  /* version string */
+   "None", /* serial number string */
+   "None", /* sku string */
+   "Virtual Machine",  /* family name string */
NULL
 };
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r366159 - head/tests/sys/netinet

[Olivier Cochard]

Author: olivier (ports committer)
Date: Fri Sep 25 16:02:13 2020
New Revision: 366159
URL: https://svnweb.freebsd.org/changeset/base/366159

Log:
  Enable SO_LINGER to the so_reuseport_lb_test regression tests, preventing
  many sockets in TIME_WAIT state at the end of the test.
  
  PR:   249885
  Reviewed by:  markj
  Approved by:  markj
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D26549

Modified:
  head/tests/sys/netinet/so_reuseport_lb_test.c

Modified: head/tests/sys/netinet/so_reuseport_lb_test.c
==
--- head/tests/sys/netinet/so_reuseport_lb_test.c   Fri Sep 25 13:59:50 
2020(r366158)
+++ head/tests/sys/netinet/so_reuseport_lb_test.c   Fri Sep 25 16:02:13 
2020(r366159)
@@ -54,6 +54,7 @@ lb_simple_accept_loop(int domain, const struct sockadd
size_t i;
int *acceptcnt;
int csd, error, excnt, sd;
+   const struct linger lopt = { 1, 0 };
 
/*
 * We expect each listening socket to accept roughly nconns/nsds
@@ -71,6 +72,10 @@ lb_simple_accept_loop(int domain, const struct sockadd
 
error = connect(sd, addr, addr->sa_len);
ATF_REQUIRE_MSG(error == 0, "connect() failed: %s",
+   strerror(errno));
+
+   error = setsockopt(sd, SOL_SOCKET, SO_LINGER, , 
sizeof(lopt));
+   ATF_REQUIRE_MSG(error == 0, "Setting linger failed: %s",
strerror(errno));
 
/*
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r365449 - head/sbin/rcorder

[Olivier Cochard-Labbé]

On Thu, Sep 17, 2020 at 10:21 PM John Baldwin  wrote:

>
>
> I don't think the issue is with rcorder though.  I think the reason the
> ordering matters warrants further investigation.  Is aesni not getting
> used when ipsec is loaded first?  You can use dtrace with the script at
> https://github.com/bsdjhb/kdbg/blob/master/dtrace/crypto_drivers.d to see
> which driver is being used.
>
>
Hi,

The driver used is cryptosoft when ipsec keys are set before the aesni
module is loaded.

  I suspect
> btw that you could just do 'sh /etc/rc.d/ipsec restart' post-boot without
> unloading any modules which would also fix your benchmark.
>


Correct, just restarting ipsec fix the benchmark.
And once restarted, the driver used is aesni.


> I think long term we want OCF's notions of sessions to be a bit more
> fluid such that "client" sessions for things like GELI and IPSec can
> be backed by one or more "driver" sessions (including "driver" sessions
> coming and going as devices come and go).  That's a fair bit more work
> however.
>
>
And why not simply add 'kld' into the REQUIRE part of /etc/rc.d/ipsec ?
But this will fix only IPsec: What about other crypto consumers ?

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r365449 - head/sbin/rcorder

[Olivier Cochard-Labbé]

On Tue, Sep 8, 2020 at 12:36 PM Andrey V. Elsukov  wrote:

> Author: ae
> Date: Tue Sep  8 10:36:11 2020
> New Revision: 365449
> URL: https://svnweb.freebsd.org/changeset/base/365449
>
> Log:
>   Add a few features to rcorder:
>
>
>
Hi Andrey,

I've spent some time bisecting an IPSec gateway performance regression on
-head that points to this commit.

So my bench uses a simple static IPSec aes-gcm-16 setup, and their results
vary a lot between those 2 revisions:

   - r365448: Estimated Equilibrium Ethernet throughput= 1413 Mb/s (maximum
   value seen: 1419 Mb/s)
   - r365449: Estimated Equilibrium Ethernet throughput= 469 Mb/s (maximum
   value seen: 469 Mb/s)

How could a modification to the rcoder be the source cause of that ?
My rc.conf contains this:
kld_list="aesni"
ipsec_enable="YES"

So My first thought was that the aesni module wasn't loaded anymore:
Before upgrade:
[root@hp]~# uname -a
FreeBSD hp 13.0-CURRENT FreeBSD 13.0-CURRENT #15 r365448M: Thu Sep 17
18:17:58 CEST 2020 oliv...@lame4.bsdrp.net:/usr/src/amd64.amd64/sys/amd64
 amd64
[root@hp]~# kldstat
Id Refs AddressSize Name
 1   11 0x8020  1ee58b0 kernel
 21 0x82319000 34c8 fdescfs.ko
 31 0x8231d000 a240 aesni.ko
 41 0x82328000 8c98 ioat.ko
 51 0x82331000 e350 ipsec.ko

Then after upgrade:

[root@hp]~# uname -a
FreeBSD hp 13.0-CURRENT FreeBSD 13.0-CURRENT #14 r365449M: Thu Sep 17
17:01:35 CEST 2020 oliv...@lame4.bsdrp.net:/usr/src/amd64.amd64/sys/amd64
 amd64
[root@hp]~# kldstat
Id Refs AddressSize Name
 1   11 0x8020  1ee58b0 kernel
 21 0x82319000 34c8 fdescfs.ko
 31 0x8231d000 e350 ipsec.ko
 41 0x8232c000 a240 aesni.ko
 51 0x82337000 8c98 ioat.ko

=> aesni.ko is correctly loaded, so it is not the problem, but notice the
order of the kernel modules that have changed.
Could be this the source of the problem ? Let's try:

[root@hp]~# service ipsec stop
Clearing ipsec manual keys/policies.
[root@hp]~# kld
kldconfig kldload   kldstat   kldunload kldxref
[root@hp]~# kldunload ioat
[root@hp]~# kldunload aesni
[root@hp]~# kldunload ipsec
[root@hp]~# kldload aesni
[root@hp]~# kldload ipsec
[root@hp]~# service ipsec start
Installing ipsec manual keys/policies.
[root@hp]~# kldstat
Id Refs AddressSize Name
 1   11 0x8020  1ee58b0 kernel
 21 0x82319000 34c8 fdescfs.ko
 51 0x82337000 8c98 ioat.ko
 61 0x8231d000 a240 aesni.ko
 71 0x82328000 e350 ipsec.ko

And after that the IPSec bench results are back to their previous value :-)
So rcorder needs to load aesni before ipsec.

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r363868 - head/sbin/route/tests

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Aug  4 21:34:13 2020
New Revision: 363868
URL: https://svnweb.freebsd.org/changeset/base/363868

Log:
  Skip sbin/route tests if jail not installed (WITHOUT_JAIL).
  
  Approved by:  kp
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D25935

Modified:
  head/sbin/route/tests/basic.sh

Modified: head/sbin/route/tests/basic.sh
==
--- head/sbin/route/tests/basic.sh  Tue Aug  4 21:09:36 2020
(r363867)
+++ head/sbin/route/tests/basic.sh  Tue Aug  4 21:34:13 2020
(r363868)
@@ -34,7 +34,7 @@ basic_v4_head()
 {
atf_set descr 'add/change/delete route test for v4'
atf_set require.user root
-   atf_set require.progs jq
+   atf_set require.progs jail jq
 }
 
 basic_v4_body()
@@ -79,7 +79,7 @@ basic_v6_head()
 {
atf_set descr 'add/change/delete route test for v6'
atf_set require.user root
-   atf_set require.progs jq
+   atf_set require.progs jail jq
 }
 
 basic_v6_body()
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r363032 - in head: etc/mtree include

[Olivier Cochard]

Author: olivier (ports committer)
Date: Wed Jul  8 21:40:27 2020
New Revision: 363032
URL: https://svnweb.freebsd.org/changeset/base/363032

Log:
  Install extra TCP stack header files: They are needed to compile a userland
  component of TCP Blackbox Recorder as example.
  
  Approved by:  rrs
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D25584

Modified:
  head/etc/mtree/BSD.include.dist
  head/include/Makefile

Modified: head/etc/mtree/BSD.include.dist
==
--- head/etc/mtree/BSD.include.dist Wed Jul  8 21:20:12 2020
(r363031)
+++ head/etc/mtree/BSD.include.dist Wed Jul  8 21:40:27 2020
(r363032)
@@ -228,6 +228,8 @@
 ..
 netdump
 ..
+tcp_stacks
+..
 ..
 netinet6
 ..

Modified: head/include/Makefile
==
--- head/include/Makefile   Wed Jul  8 21:20:12 2020(r363031)
+++ head/include/Makefile   Wed Jul  8 21:40:27 2020(r363032)
@@ -57,6 +57,7 @@ LSUBDIRS= cam/ata cam/mmc cam/nvme cam/scsi \
netgraph/atm netgraph/netflow \
netinet/cc \
netinet/netdump \
+   netinet/tcp_stacks \
security/audit \
security/mac_biba security/mac_bsdextended security/mac_lomac \
security/mac_mls security/mac_partition \
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r360465 - head/sbin/bectl/tests

[Olivier Cochard]

Author: olivier (ports committer)
Date: Wed Apr 29 14:15:21 2020
New Revision: 360465
URL: https://svnweb.freebsd.org/changeset/base/360465

Log:
  Skip bectl jail test if jail not installed (WITHOUT_JAIL).
  
  Approved by:  kevans
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D24613

Modified:
  head/sbin/bectl/tests/bectl_test.sh

Modified: head/sbin/bectl/tests/bectl_test.sh
==
--- head/sbin/bectl/tests/bectl_test.sh Wed Apr 29 14:14:15 2020
(r360464)
+++ head/sbin/bectl/tests/bectl_test.sh Wed Apr 29 14:15:21 2020
(r360465)
@@ -343,6 +343,7 @@ bectl_jail_head()
 
atf_set "descr" "Check bectl rename"
atf_set "require.user" root
+   atf_set "require.progs" jail
 }
 bectl_jail_body()
 {
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r360045 - head/tests/sys/net/routing

[Olivier Cochard]

Author: olivier (ports committer)
Date: Fri Apr 17 16:31:07 2020
New Revision: 360045
URL: https://svnweb.freebsd.org/changeset/base/360045

Log:
  Skip routing regression tests depending on if_epair if this module isn't 
installed.
  
  Approved by:  melifaro
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D24468

Modified:
  head/tests/sys/net/routing/Makefile
  head/tests/sys/net/routing/rtsock_common.h
  head/tests/sys/net/routing/rtsock_config.h

Modified: head/tests/sys/net/routing/Makefile
==
--- head/tests/sys/net/routing/Makefile Fri Apr 17 15:19:42 2020
(r360044)
+++ head/tests/sys/net/routing/Makefile Fri Apr 17 16:31:07 2020
(r360045)
@@ -14,4 +14,6 @@ ${PACKAGE}FILESMODE_generic_cleanup.sh=0555
 # so running them in parallel will lead to weird results.
 TEST_METADATA+=is_exclusive=true
 
+CFLAGS+=   -I${.CURDIR:H:H:H}
+
 .include 

Modified: head/tests/sys/net/routing/rtsock_common.h
==
--- head/tests/sys/net/routing/rtsock_common.h  Fri Apr 17 15:19:42 2020
(r360044)
+++ head/tests/sys/net/routing/rtsock_common.h  Fri Apr 17 16:31:07 2020
(r360045)
@@ -45,6 +45,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -63,6 +64,7 @@
 #include 
 
 #include 
+#include "freebsd_test_suite/macros.h"
 
 #include "rtsock_print.h"
 #include "params.h"
@@ -126,33 +128,6 @@ _check_cloner(char *name)
return (found);
 }
 
-/*
- * Tries to ensure if_tap is loaded.
- * Checks list of interface cloners first, then tries
- * to load the module.
- *
- * return nonzero on success.
- */
-static int
-_enforce_cloner_loaded(char *cloner_name)
-{
-   if (_check_cloner(cloner_name))
-   return (1);
-   /* need to load */
-   RLOG("trying to load %s driver", cloner_name);
-
-   char cmd[64];
-
-   snprintf(cmd, sizeof(cmd), "/sbin/kldload if_%s", cloner_name);
-   int ret = system(cmd);
-   if (ret != 0) {
-   RLOG("'%s' failed, error %d", cmd, ret);
-   return (0);
-   }
-
-   return (1);
-}
-
 static char *
 iface_create(char *ifname_orig)
 {
@@ -164,9 +139,6 @@ iface_create(char *ifname_orig)
for (src = ifname_orig, dst = prefix; *src && isalpha(*src); src++)
*dst++ = *src;
*dst = '\0';
-
-   if (_enforce_cloner_loaded(prefix) == 0)
-   return (NULL);
 
memset(, 0, sizeof(struct ifreq));
 

Modified: head/tests/sys/net/routing/rtsock_config.h
==
--- head/tests/sys/net/routing/rtsock_config.h  Fri Apr 17 15:19:42 2020
(r360044)
+++ head/tests/sys/net/routing/rtsock_config.h  Fri Apr 17 16:31:07 2020
(r360045)
@@ -127,6 +127,9 @@ config_setup(const atf_tc_t *tc, struct rtsock_config_
inet_ntop(AF_INET6, >addr6.sin6_addr, c->addr6_str, 
INET6_ADDRSTRLEN);
 
if (co->num_interfaces > 0) {
+   kldload("if_epair");
+   ATF_REQUIRE_KERNEL_MODULE("if_epair");
+
c->ifnames = calloc(co->num_interfaces, sizeof(char *));
for (int i = 0; i < co->num_interfaces; i++)
c->ifnames[i] = iface_create("epair");
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r358589 - head/tests/sys/net

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Mar  3 17:35:15 2020
New Revision: 358589
URL: https://svnweb.freebsd.org/changeset/base/358589

Log:
  Skip if_epair regression test if module doesn't exist
  
  Approved by:  kp
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D23876

Modified:
  head/tests/sys/net/Makefile
  head/tests/sys/net/if_epair.c

Modified: head/tests/sys/net/Makefile
==
--- head/tests/sys/net/Makefile Tue Mar  3 17:30:13 2020(r358588)
+++ head/tests/sys/net/Makefile Tue Mar  3 17:35:15 2020(r358589)
@@ -22,6 +22,8 @@ TEST_METADATA+=   is_exclusive=true
 MAN=
 PROGS+=randsleep
 
+CFLAGS+=-I${.CURDIR:H:H}
+
 WARNS?=6
 
 .include 

Modified: head/tests/sys/net/if_epair.c
==
--- head/tests/sys/net/if_epair.c   Tue Mar  3 17:30:13 2020
(r358588)
+++ head/tests/sys/net/if_epair.c   Tue Mar  3 17:35:15 2020
(r358589)
@@ -40,6 +40,7 @@
 #include 
 
 #include 
+#include "freebsd_test_suite/macros.h"
 
 ATF_TC(params);
 ATF_TC_HEAD(params, tc)
@@ -52,9 +53,8 @@ ATF_TC_BODY(params, tc)
struct ifreq ifr;
int s;
 
-   s = kldload("if_epair");
-   if (s == -1 && errno != EEXIST)
-   atf_tc_fail("Failed to load if_epair");
+   kldload("if_epair");
+   ATF_REQUIRE_KERNEL_MODULE("if_epair");
 
s = socket(AF_INET, SOCK_DGRAM, 0);
if (s < 0)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r352654 - head/sys/dev/pccard

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Sep 24 16:49:42 2019
New Revision: 352654
URL: https://svnweb.freebsd.org/changeset/base/352654

Log:
  Fix a minor typo
  
  Approved by:  lwhsu
  MFC after:1 month
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D19970

Modified:
  head/sys/dev/pccard/pccard.c

Modified: head/sys/dev/pccard/pccard.c
==
--- head/sys/dev/pccard/pccard.cTue Sep 24 16:45:34 2019
(r352653)
+++ head/sys/dev/pccard/pccard.cTue Sep 24 16:49:42 2019
(r352654)
@@ -266,7 +266,7 @@ pccard_probe_and_attach_child(device_t dev, device_t c
 * In NetBSD, the drivers are responsible for activating each
 * function of a card and selecting the config to use.  In
 * FreeBSD, all that's done automatically in the typical lazy
-* way we do device resoruce allocation (except we pick the
+* way we do device resource allocation (except we pick the
 * cfe up front).  This is the biggest depature from the
 * inherited NetBSD model, apart from the FreeBSD resource code.
 *
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r352653 - head/tests/sys/kern

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Sep 24 16:45:34 2019
New Revision: 352653
URL: https://svnweb.freebsd.org/changeset/base/352653

Log:
  Fix coredump_phnum_test in case of kern.compress_user_cores=1
  
  PR:   240783
  Approved by:  ngie, lwhsu
  MFC after:1 month
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D21776

Modified:
  head/tests/sys/kern/coredump_phnum_test.sh

Modified: head/tests/sys/kern/coredump_phnum_test.sh
==
--- head/tests/sys/kern/coredump_phnum_test.sh  Tue Sep 24 13:15:24 2019
(r352652)
+++ head/tests/sys/kern/coredump_phnum_test.sh  Tue Sep 24 16:45:34 2019
(r352653)
@@ -45,10 +45,12 @@ coredump_phnum_body()
ulimit -c '$(ulimit -c)'
sysctl kern.coredump=$(sysctl -n kern.coredump)
sysctl kern.corefile='$(sysctl -n kern.corefile)'
+   sysctl kern.compress_user_cores='$(sysctl -n kern.compress_user_cores)'
 EOF
 
ulimit -c unlimited
sysctl kern.coredump=1
+   sysctl kern.compress_user_cores=0
sysctl kern.corefile="$(pwd)/coredump_phnum_helper.core"
 
atf_check -s signal:sigabrt "$(atf_get_srcdir)/coredump_phnum_helper"
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r346605 - head/tests/sys/geom/class/mirror

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Apr 23 21:07:47 2019
New Revision: 346605
URL: https://svnweb.freebsd.org/changeset/base/346605

Log:
  Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes
  aren't available
  
  PR:   237051
  Reviewed by:  asomers, imp, ngie, emaste (IRC)
  Approved by:  ngie
  MFC after: 1 month
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D19958

Modified:
  head/tests/sys/geom/class/mirror/component_selection.sh

Modified: head/tests/sys/geom/class/mirror/component_selection.sh
==
--- head/tests/sys/geom/class/mirror/component_selection.sh Tue Apr 23 
20:25:25 2019(r346604)
+++ head/tests/sys/geom/class/mirror/component_selection.sh Tue Apr 23 
21:07:47 2019(r346605)
@@ -1,5 +1,9 @@
 # $FreeBSD$
 
+ATF_TEST=true
+class=mirror
+. $(atf_get_srcdir)/conf.sh
+
 atf_test_case run_latest_genid cleanup
 run_latest_genid_head()
 {
@@ -9,7 +13,10 @@ run_latest_genid_head()
 }
 run_latest_genid_body()
 {
-   . $(atf_get_srcdir)/conf.sh
+   geom_atf_test_setup
+   if ! error_message=$(geom_load_class_if_needed nop); then
+   atf_skip "$error_message"
+   fi
 
f1=$(mktemp ${base}.XX)
f2=$(mktemp ${base}.XX)


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345893 - in head/lib/atf: libatf-c++/tests libatf-c/tests

[Olivier Cochard]

Author: olivier (ports committer)
Date: Thu Apr  4 20:34:17 2019
New Revision: 345893
URL: https://svnweb.freebsd.org/changeset/base/345893

Log:
  Add requiered programs (cc and c++) for some lib/atf regression tests
  
  PR:   236889
  Reviewed by:  ngie
  Approved by:  emaste (on IRC)
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/lib/atf/libatf-c++/tests/Makefile
  head/lib/atf/libatf-c/tests/Makefile

Modified: head/lib/atf/libatf-c++/tests/Makefile
==
--- head/lib/atf/libatf-c++/tests/Makefile  Thu Apr  4 20:30:14 2019
(r345892)
+++ head/lib/atf/libatf-c++/tests/Makefile  Thu Apr  4 20:34:17 2019
(r345893)
@@ -27,4 +27,11 @@ ATF_TESTS_CXX+=  ${_T}
 SRCS.${_T}=${_T}.cpp test_helpers.cpp
 .endfor
 
+.for _T in atf_c++_test \
+   build_test \
+   check_test \
+   macros_test
+TEST_METADATA.${_T}+=  required_programs="c++"
+.endfor
+
 .include 

Modified: head/lib/atf/libatf-c/tests/Makefile
==
--- head/lib/atf/libatf-c/tests/MakefileThu Apr  4 20:30:14 2019
(r345892)
+++ head/lib/atf/libatf-c/tests/MakefileThu Apr  4 20:34:17 2019
(r345893)
@@ -33,4 +33,11 @@ ATF_TESTS_C+=${_T}
 SRCS.${_T}=${_T}.c test_helpers.c
 .endfor
 
+.for _T in atf_c_test \
+   build_test \
+   check_test \
+   macros_test
+TEST_METADATA.${_T}+=  required_programs="cc"
+.endfor
+
 .include 


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345765 - head/tests/sys/audit

[Olivier Cochard]

Author: olivier (ports committer)
Date: Mon Apr  1 14:21:32 2019
New Revision: 345765
URL: https://svnweb.freebsd.org/changeset/base/345765

Log:
  Fix and simplify code by using ATF_REQUIRE_FEATURE macro
  
  PR:   236857
  Reviewed by:  asomers, ngie
  Approved by:  emaste
  MFC after: 1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/audit/Makefile
  head/tests/sys/audit/process-control.c

Modified: head/tests/sys/audit/Makefile
==
--- head/tests/sys/audit/Makefile   Mon Apr  1 14:19:09 2019
(r345764)
+++ head/tests/sys/audit/Makefile   Mon Apr  1 14:21:32 2019
(r345765)
@@ -55,4 +55,6 @@ WARNS?=   6
 
 LDFLAGS+=  -lbsm -lutil
 
+CFLAGS.process-control.c+= -I${SRCTOP}/tests
+
 .include 

Modified: head/tests/sys/audit/process-control.c
==
--- head/tests/sys/audit/process-control.c  Mon Apr  1 14:19:09 2019
(r345764)
+++ head/tests/sys/audit/process-control.c  Mon Apr  1 14:21:32 2019
(r345765)
@@ -48,6 +48,8 @@
 
 #include "utils.h"
 
+#include "freebsd_test_suite/macros.h"
+
 static pid_t pid;
 static int filedesc, status;
 static struct pollfd fds[1];
@@ -1512,15 +1514,8 @@ ATF_TC_HEAD(cap_enter_success, tc)
 
 ATF_TC_BODY(cap_enter_success, tc)
 {
-   int capinfo;
-   size_t len = sizeof(capinfo);
-   const char *capname = "kern.features.security_capability_mode";
-   ATF_REQUIRE_EQ(0, sysctlbyname(capname, , , NULL, 0));
+   ATF_REQUIRE_FEATURE("security_capability_mode");
 
-   /* Without CAPABILITY_MODE enabled, cap_enter() returns ENOSYS */
-   if (!capinfo)
-   atf_tc_skip("Capsicum is not enabled in the system");
-
FILE *pipefd = setup(fds, auclass);
ATF_REQUIRE((pid = fork()) != -1);
if (pid) {
@@ -1550,14 +1545,9 @@ ATF_TC_HEAD(cap_getmode_success, tc)
 
 ATF_TC_BODY(cap_getmode_success, tc)
 {
-   int capinfo, modep;
-   size_t len = sizeof(capinfo);
-   const char *capname = "kern.features.security_capability_mode";
-   ATF_REQUIRE_EQ(0, sysctlbyname(capname, , , NULL, 0));
+   int modep;
 
-   /* Without CAPABILITY_MODE enabled, cap_getmode() returns ENOSYS */
-   if (!capinfo)
-   atf_tc_skip("Capsicum is not enabled in the system");
+   ATF_REQUIRE_FEATURE("security_capability_mode");
 
pid = getpid();
snprintf(pcregex, sizeof(pcregex), "cap_getmode.*%d.*success", pid);


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345681 - head/tests/sys/capsicum

[Olivier Cochard]

Author: olivier (ports committer)
Date: Fri Mar 29 08:43:21 2019
New Revision: 345681
URL: https://svnweb.freebsd.org/changeset/base/345681

Log:
  Skip test if feature security_capabilities is not available
  
  PR:   236863
  Approved by:  asomers
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/capsicum/Makefile
  head/tests/sys/capsicum/ioctls_test.c

Modified: head/tests/sys/capsicum/Makefile
==
--- head/tests/sys/capsicum/MakefileFri Mar 29 04:00:46 2019
(r345680)
+++ head/tests/sys/capsicum/MakefileFri Mar 29 08:43:21 2019
(r345681)
@@ -5,7 +5,7 @@ TESTSDIR=   ${TESTSBASE}/sys/capsicum
 ATF_TESTS_C+=  bindat_connectat
 ATF_TESTS_C+=  ioctls_test
 
-CFLAGS.bindat_connectat.c+=-I${SRCTOP}/tests
+CFLAGS+=   -I${SRCTOP}/tests
 
 WARNS?=6
 

Modified: head/tests/sys/capsicum/ioctls_test.c
==
--- head/tests/sys/capsicum/ioctls_test.c   Fri Mar 29 04:00:46 2019
(r345680)
+++ head/tests/sys/capsicum/ioctls_test.c   Fri Mar 29 08:43:21 2019
(r345681)
@@ -37,6 +37,8 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
+#include "freebsd_test_suite/macros.h"
+
 /*
  * A variant of ATF_REQUIRE that is suitable for use in child
  * processes.  This only works if the parent process is tripped up by
@@ -72,6 +74,8 @@ ATF_TC_BODY(cap_ioctls__listen_copy, tc)
pid_t pid;
char dummy;
int s[2], status;
+
+   ATF_REQUIRE_FEATURE("security_capabilities");
 
s[0] = socket(AF_INET, SOCK_STREAM, 0);
ATF_REQUIRE(s[0] > 0);


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345644 - head/tests/sys/netmap

[Olivier Cochard]

Author: olivier (ports committer)
Date: Thu Mar 28 16:17:33 2019
New Revision: 345644
URL: https://svnweb.freebsd.org/changeset/base/345644

Log:
  Skip this test if if_tap module is not available
  
  PR:   236842
  Approved by:  asomers
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/netmap/Makefile
  head/tests/sys/netmap/ctrl-api-test.c

Modified: head/tests/sys/netmap/Makefile
==
--- head/tests/sys/netmap/Makefile  Thu Mar 28 14:21:22 2019
(r345643)
+++ head/tests/sys/netmap/Makefile  Thu Mar 28 16:17:33 2019
(r345644)
@@ -7,6 +7,7 @@ TEST_METADATA+= required_user="root"
 TEST_METADATA+=is_exclusive=true
 
 LDFLAGS+=  -lpthread
+CFLAGS+=   -I${SRCTOP}/tests
 PLAIN_TESTS_C+=ctrl-api-test
 
 WARNS?=6

Modified: head/tests/sys/netmap/ctrl-api-test.c
==
--- head/tests/sys/netmap/ctrl-api-test.c   Thu Mar 28 14:21:22 2019
(r345643)
+++ head/tests/sys/netmap/ctrl-api-test.c   Thu Mar 28 16:17:33 2019
(r345644)
@@ -48,9 +48,15 @@
 #include 
 #include 
 
+#ifdef __FreeBSD__
+#include "freebsd_test_suite/macros.h"
+#endif
+
+
 #ifdef __linux__
 #include 
 #else
+
 static int
 eventfd(int x __unused, int y __unused)
 {
@@ -1830,6 +1836,10 @@ main(int argc, char **argv)
int list = 0;
int opt;
int i;
+
+#ifdef __FreeBSD__
+   PLAIN_REQUIRE_KERNEL_MODULE("if_tap", 0);
+#endif
 
memset(_, 0, sizeof(ctx_));
 


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r350019 - head/lib/libc/tests/net

[Olivier Cochard]

Author: olivier (ports committer)
Date: Mon Jul 15 23:41:00 2019
New Revision: 350019
URL: https://svnweb.freebsd.org/changeset/base/350019

Log:
  Fix filename to avoid skipping lib/libc/net/servent test.
  
  PR:   239177
  Approved by:  ngie
  MFC after:1 month
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D20943

Modified:
  head/lib/libc/tests/net/Makefile

Modified: head/lib/libc/tests/net/Makefile
==
--- head/lib/libc/tests/net/MakefileMon Jul 15 22:33:37 2019
(r350018)
+++ head/lib/libc/tests/net/MakefileMon Jul 15 23:41:00 2019
(r350019)
@@ -38,4 +38,6 @@ aton_ether_subr.c: gen_ether_subr ${SRCTOP}/sys/net/if
 ${PACKAGE}FILES+=  hosts
 ${PACKAGE}FILES+=  resolv.conf
 
+ATF_TESTS_SH_SED_servent_test= -e 's,services.cdb,services.db,g'
+
 .include 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r346605 - head/tests/sys/geom/class/mirror

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Apr 23 21:07:47 2019
New Revision: 346605
URL: https://svnweb.freebsd.org/changeset/base/346605

Log:
  Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes
  aren't available
  
  PR:   237051
  Reviewed by:  asomers, imp, ngie, emaste (IRC)
  Approved by:  ngie
  MFC after: 1 month
  Sponsored by: Netflix
  Differential Revision:https://reviews.freebsd.org/D19958

Modified:
  head/tests/sys/geom/class/mirror/component_selection.sh

Modified: head/tests/sys/geom/class/mirror/component_selection.sh
==
--- head/tests/sys/geom/class/mirror/component_selection.sh Tue Apr 23 
20:25:25 2019(r346604)
+++ head/tests/sys/geom/class/mirror/component_selection.sh Tue Apr 23 
21:07:47 2019(r346605)
@@ -1,5 +1,9 @@
 # $FreeBSD$
 
+ATF_TEST=true
+class=mirror
+. $(atf_get_srcdir)/conf.sh
+
 atf_test_case run_latest_genid cleanup
 run_latest_genid_head()
 {
@@ -9,7 +13,10 @@ run_latest_genid_head()
 }
 run_latest_genid_body()
 {
-   . $(atf_get_srcdir)/conf.sh
+   geom_atf_test_setup
+   if ! error_message=$(geom_load_class_if_needed nop); then
+   atf_skip "$error_message"
+   fi
 
f1=$(mktemp ${base}.XX)
f2=$(mktemp ${base}.XX)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345893 - in head/lib/atf: libatf-c++/tests libatf-c/tests

[Olivier Cochard]

Author: olivier (ports committer)
Date: Thu Apr  4 20:34:17 2019
New Revision: 345893
URL: https://svnweb.freebsd.org/changeset/base/345893

Log:
  Add requiered programs (cc and c++) for some lib/atf regression tests
  
  PR:   236889
  Reviewed by:  ngie
  Approved by:  emaste (on IRC)
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/lib/atf/libatf-c++/tests/Makefile
  head/lib/atf/libatf-c/tests/Makefile

Modified: head/lib/atf/libatf-c++/tests/Makefile
==
--- head/lib/atf/libatf-c++/tests/Makefile  Thu Apr  4 20:30:14 2019
(r345892)
+++ head/lib/atf/libatf-c++/tests/Makefile  Thu Apr  4 20:34:17 2019
(r345893)
@@ -27,4 +27,11 @@ ATF_TESTS_CXX+=  ${_T}
 SRCS.${_T}=${_T}.cpp test_helpers.cpp
 .endfor
 
+.for _T in atf_c++_test \
+   build_test \
+   check_test \
+   macros_test
+TEST_METADATA.${_T}+=  required_programs="c++"
+.endfor
+
 .include 

Modified: head/lib/atf/libatf-c/tests/Makefile
==
--- head/lib/atf/libatf-c/tests/MakefileThu Apr  4 20:30:14 2019
(r345892)
+++ head/lib/atf/libatf-c/tests/MakefileThu Apr  4 20:34:17 2019
(r345893)
@@ -33,4 +33,11 @@ ATF_TESTS_C+=${_T}
 SRCS.${_T}=${_T}.c test_helpers.c
 .endfor
 
+.for _T in atf_c_test \
+   build_test \
+   check_test \
+   macros_test
+TEST_METADATA.${_T}+=  required_programs="cc"
+.endfor
+
 .include 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345765 - head/tests/sys/audit

[Olivier Cochard]

Author: olivier (ports committer)
Date: Mon Apr  1 14:21:32 2019
New Revision: 345765
URL: https://svnweb.freebsd.org/changeset/base/345765

Log:
  Fix and simplify code by using ATF_REQUIRE_FEATURE macro
  
  PR:   236857
  Reviewed by:  asomers, ngie
  Approved by:  emaste
  MFC after: 1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/audit/Makefile
  head/tests/sys/audit/process-control.c

Modified: head/tests/sys/audit/Makefile
==
--- head/tests/sys/audit/Makefile   Mon Apr  1 14:19:09 2019
(r345764)
+++ head/tests/sys/audit/Makefile   Mon Apr  1 14:21:32 2019
(r345765)
@@ -55,4 +55,6 @@ WARNS?=   6
 
 LDFLAGS+=  -lbsm -lutil
 
+CFLAGS.process-control.c+= -I${SRCTOP}/tests
+
 .include 

Modified: head/tests/sys/audit/process-control.c
==
--- head/tests/sys/audit/process-control.c  Mon Apr  1 14:19:09 2019
(r345764)
+++ head/tests/sys/audit/process-control.c  Mon Apr  1 14:21:32 2019
(r345765)
@@ -48,6 +48,8 @@
 
 #include "utils.h"
 
+#include "freebsd_test_suite/macros.h"
+
 static pid_t pid;
 static int filedesc, status;
 static struct pollfd fds[1];
@@ -1512,15 +1514,8 @@ ATF_TC_HEAD(cap_enter_success, tc)
 
 ATF_TC_BODY(cap_enter_success, tc)
 {
-   int capinfo;
-   size_t len = sizeof(capinfo);
-   const char *capname = "kern.features.security_capability_mode";
-   ATF_REQUIRE_EQ(0, sysctlbyname(capname, , , NULL, 0));
+   ATF_REQUIRE_FEATURE("security_capability_mode");
 
-   /* Without CAPABILITY_MODE enabled, cap_enter() returns ENOSYS */
-   if (!capinfo)
-   atf_tc_skip("Capsicum is not enabled in the system");
-
FILE *pipefd = setup(fds, auclass);
ATF_REQUIRE((pid = fork()) != -1);
if (pid) {
@@ -1550,14 +1545,9 @@ ATF_TC_HEAD(cap_getmode_success, tc)
 
 ATF_TC_BODY(cap_getmode_success, tc)
 {
-   int capinfo, modep;
-   size_t len = sizeof(capinfo);
-   const char *capname = "kern.features.security_capability_mode";
-   ATF_REQUIRE_EQ(0, sysctlbyname(capname, , , NULL, 0));
+   int modep;
 
-   /* Without CAPABILITY_MODE enabled, cap_getmode() returns ENOSYS */
-   if (!capinfo)
-   atf_tc_skip("Capsicum is not enabled in the system");
+   ATF_REQUIRE_FEATURE("security_capability_mode");
 
pid = getpid();
snprintf(pcregex, sizeof(pcregex), "cap_getmode.*%d.*success", pid);
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345681 - head/tests/sys/capsicum

[Olivier Cochard]

Author: olivier (ports committer)
Date: Fri Mar 29 08:43:21 2019
New Revision: 345681
URL: https://svnweb.freebsd.org/changeset/base/345681

Log:
  Skip test if feature security_capabilities is not available
  
  PR:   236863
  Approved by:  asomers
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/capsicum/Makefile
  head/tests/sys/capsicum/ioctls_test.c

Modified: head/tests/sys/capsicum/Makefile
==
--- head/tests/sys/capsicum/MakefileFri Mar 29 04:00:46 2019
(r345680)
+++ head/tests/sys/capsicum/MakefileFri Mar 29 08:43:21 2019
(r345681)
@@ -5,7 +5,7 @@ TESTSDIR=   ${TESTSBASE}/sys/capsicum
 ATF_TESTS_C+=  bindat_connectat
 ATF_TESTS_C+=  ioctls_test
 
-CFLAGS.bindat_connectat.c+=-I${SRCTOP}/tests
+CFLAGS+=   -I${SRCTOP}/tests
 
 WARNS?=6
 

Modified: head/tests/sys/capsicum/ioctls_test.c
==
--- head/tests/sys/capsicum/ioctls_test.c   Fri Mar 29 04:00:46 2019
(r345680)
+++ head/tests/sys/capsicum/ioctls_test.c   Fri Mar 29 08:43:21 2019
(r345681)
@@ -37,6 +37,8 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
+#include "freebsd_test_suite/macros.h"
+
 /*
  * A variant of ATF_REQUIRE that is suitable for use in child
  * processes.  This only works if the parent process is tripped up by
@@ -72,6 +74,8 @@ ATF_TC_BODY(cap_ioctls__listen_copy, tc)
pid_t pid;
char dummy;
int s[2], status;
+
+   ATF_REQUIRE_FEATURE("security_capabilities");
 
s[0] = socket(AF_INET, SOCK_STREAM, 0);
ATF_REQUIRE(s[0] > 0);
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r345644 - head/tests/sys/netmap

[Olivier Cochard]

Author: olivier (ports committer)
Date: Thu Mar 28 16:17:33 2019
New Revision: 345644
URL: https://svnweb.freebsd.org/changeset/base/345644

Log:
  Skip this test if if_tap module is not available
  
  PR:   236842
  Approved by:  asomers
  MFC after:1 month
  Sponsored by: Netflix

Modified:
  head/tests/sys/netmap/Makefile
  head/tests/sys/netmap/ctrl-api-test.c

Modified: head/tests/sys/netmap/Makefile
==
--- head/tests/sys/netmap/Makefile  Thu Mar 28 14:21:22 2019
(r345643)
+++ head/tests/sys/netmap/Makefile  Thu Mar 28 16:17:33 2019
(r345644)
@@ -7,6 +7,7 @@ TEST_METADATA+= required_user="root"
 TEST_METADATA+=is_exclusive=true
 
 LDFLAGS+=  -lpthread
+CFLAGS+=   -I${SRCTOP}/tests
 PLAIN_TESTS_C+=ctrl-api-test
 
 WARNS?=6

Modified: head/tests/sys/netmap/ctrl-api-test.c
==
--- head/tests/sys/netmap/ctrl-api-test.c   Thu Mar 28 14:21:22 2019
(r345643)
+++ head/tests/sys/netmap/ctrl-api-test.c   Thu Mar 28 16:17:33 2019
(r345644)
@@ -48,9 +48,15 @@
 #include 
 #include 
 
+#ifdef __FreeBSD__
+#include "freebsd_test_suite/macros.h"
+#endif
+
+
 #ifdef __linux__
 #include 
 #else
+
 static int
 eventfd(int x __unused, int y __unused)
 {
@@ -1830,6 +1836,10 @@ main(int argc, char **argv)
int list = 0;
int opt;
int i;
+
+#ifdef __FreeBSD__
+   PLAIN_REQUIRE_KERNEL_MODULE("if_tap", 0);
+#endif
 
memset(_, 0, sizeof(ctx_));
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r337736 - in head/sys: netinet netinet6

[Olivier Cochard-Labbé]

On Fri, Aug 17, 2018 at 3:33 PM Andrey V. Elsukov  wrote:

>
> I think it is because IPv4 tests use broadcast addresses in some places.
> The attached patch fixes the test for me.
>
>
I confirm it was a typo from me, and I never intend to badly use these
broadcast addresses.
The patch correctly fix it.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329269 - head/stand/i386/boot2

[Olivier Cochard-Labbé]

On Wed, Feb 14, 2018 at 7:07 PM, Benno Rice  wrote:

> Author: benno
> Date: Wed Feb 14 18:07:27 2018
> New Revision: 329269
> URL: https://svnweb.freebsd.org/changeset/base/329269
>
> Log:
>   Reformat to come significantly closer to style(9).
>
>   Reviewed by:  imp, jhibbits
>   Differential Revision:https://reviews.freebsd.org/D14366
>
> Modified:
>   head/stand/i386/boot2/boot2.c
>
>
​Hi,

I've got 2 regressions with this commit on my headless servers (Netgate RCC
and PC Engines​
​).

I'm using this configuration file on all my headless servers:
[root@netgate]~# cat /boot.config
-S115200 -h

Now with this commit, I meet a first regression: they all stop to boot
automatically at the boot stage.

**
/boot/config: -S115200 -h

FreeBSD/x86 boot
Default: 0:ad(0,a)/boot/loader
boot:
***

I had to connect to the serial console and to press "enter" here for
continuing the boot process.
Once the boot process go to the next stage, I meet the second regression:
loader menu is correctly displayed, but dmesg messages are no visible on
the console.

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r320659 - head/usr.sbin/nfsuserd

[Olivier Cochard-Labbé]

On Wed, Jul 5, 2017 at 7:06 AM, Konstantin Belousov 
wrote:

> On Tue, Jul 04, 2017 at 10:20:30PM +, Rick Macklem wrote:
> > +Since the kernel communicates with the
> > +.Nm
> > +daemon via an upcall that uses the IP address 127.0.0.1, it does not
> work correctly when
> > +.Xr jail 8
> > +are used and can crash the system.
>
> Does it indeed break when jails are used, or does it break when the daemon
> is started in a jail ?
>
>
​And does it break on a jail/vnet too ?
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r312395 - head/sbin/devd

[Olivier Cochard-Labbé]

On Wed, Jan 18, 2017 at 9:24 PM, Alan Somers  wrote:

> Author: asomers
> Date: Wed Jan 18 20:24:37 2017
> New Revision: 312395
> URL: https://svnweb.freebsd.org/changeset/base/312395
>
> Log:
>   Fix several Coverity CIDs in devd
>
>

​Hi,

this break buildworld for mips arch:
​

​
--- devd.o ---
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc: In
function 'void event_loop()':
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: expected type-specifier
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: expected unqualified-id before 'e'
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: expected `)' before 'e'
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: expected `{' before 'e'
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: 'e' was not declared in this scope
/usr/local/poudriere/jails/head-mips32/usr/src/sbin/devd/devd.cc:1066:
error: expected `;' before ')' token
--- all_subdir_sbin/hastd ---
​
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r309725 - head/sys/dev/cxgbe

[Olivier Cochard-Labbé]

On Fri, Dec 9, 2016 at 3:21 AM, Navdeep Parhar  wrote:

> Author: np
> Date: Fri Dec  9 02:21:27 2016
> New Revision: 309725
> URL: https://svnweb.freebsd.org/changeset/base/309725
>
> Log:
>   cxgbe(4): netmap does not set IFCAP_NETMAP in an ifnet's if_capabilities
>   any more (since r307394).  Do it in the driver instead.
>
>   MFC after:1 week
>
>
​Thanks:It's better!

Now I can start one pkt-gen process without panicing my server.

But as soon as I start a second pkt-gen at the same time it panic again.

I don't have this problem with Intel NIC, only with Chelsio.


Fatal trap 12: page fault while in kernel mode
cpuid = 5; apic id = 0a
fault virtual address   = 0x0
fault code  = supervisor read data, page not present
instruction pointer = 0x20:0x8047c63a
stack pointer   = 0x28:0xfe0466004240
frame pointer   = 0x28:0xfe0466004310
code segment= base 0x0, limit 0xf, type 0x1b
= DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags= interrupt enabled, resume, IOPL = 0
current process = 1902 (pkt-gen)
trap number = 12
panic: page fault
cpuid = 5
KDB: stack backtrace:
#0 0x8095cc07 at kdb_backtrace+0x67
#1 0x80916af6 at vpanic+0x186
#2 0x80916963 at panic+0x43
#3 0x80d36b82 at trap_fatal+0x322
#4 0x80d36d4c at trap_pfault+0x1bc
#5 0x80d36400 at trap+0x280
#6 0x80d198b1 at calltrap+0x8
#7 0x80634bec at netmap_hw_reg+0x2c
#8 0x806321cb at netmap_do_regif+0x2ab
#9 0x80632da8 at netmap_ioctl+0xb58
#10 0x8063688e at freebsd_netmap_ioctl+0x3e
#11 0x8084ea37 at devfs_ioctl+0xb7
#12 0x80ec6d28 at VOP_IOCTL_APV+0x88
#13 0x809f24d1 at vn_ioctl+0x161
#14 0x8084f27f at devfs_ioctl_f+0x1f
#15 0x8097a66b at kern_ioctl+0x31b
#16 0x8097a2ac at sys_ioctl+0x13c
#17 0x80d374f5 at amd64_syscall+0x4f5
Uptime: 59m40s
(kgdb) backtrace
#0  doadump (textdump=) at pcpu.h:222
#1  0x80916579 in kern_reboot (howto=260) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:366
#2  0x80916b30 in vpanic (fmt=, ap=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:759
#3  0x80916963 in panic (fmt=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:690
#4  0x80d36b82 in trap_fatal (frame=0xfe0465fb7180, eva=0) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:801
#5  0x80d36d4c in trap_pfault (frame=0xfe0465fb7180,
usermode=0) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:658
#6  0x80d36400 in trap (frame=0xfe0465fb7180) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:421
#7  0x80d198b1 in calltrap () at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/exception.S:236
#8  0x8047c63a in cxgbe_netmap_reg (na=,
on=) at netmap_kern.h:1747
#9  0x80634bec in netmap_hw_reg (na=0xf800055bc400, onoff=1) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2788
#10 0x806321cb in netmap_do_regif (priv=,
na=, ringid=, flags=)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2050
#11 0x80632da8 in netmap_ioctl (priv=,
cmd=, data=0xfe0465fb79b0 "vcxl0",
td=0xf800371bb500)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2257
#12 0x8063688e in freebsd_netmap_ioctl (dev=,
cmd=3225184658, data=0xfe0465fb79b0 "vcxl0", ffla=, td=0xf800371bb500)
at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap_freebsd.c:1389
#13 0x8084ea37 in devfs_ioctl (ap=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/fs/devfs/devfs_vnops.c:831
#14 0x80ec6d28 in VOP_IOCTL_APV (vop=,
a=) at vnode_if.c:1067
#15 0x809f24d1 in vn_ioctl (fp=0xf800372d0be0, com=, data=0xfe0465fb79b0, active_cred=0xf8003714b500,
td=)
at vnode_if.h:448
#16 0x8084f27f in devfs_ioctl_f (fp=,
com=, data=, cred=, td=0xf800371bb500)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/fs/devfs/devfs_vnops.c:789
#17 0x8097a66b in kern_ioctl (td=, fd=, com=3225184658, data=0xfe0465fb79b0 "vcxl0") at
file.h:327
#18 0x8097a2ac in sys_ioctl (td=0xf800371bb500,
uap=0xfe0465fb7b60) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/sys_generic.c:746
#19 0x80d374f5 in amd64_syscall (td=0xf800371bb500, traced=0)
at subr_syscall.c:135
#20 0x80d19b9b in Xfast_syscall () at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/exception.S:396
#21 0x00080100c3aa in ?? ()
Previous frame inner to this frame (corrupt stack?)
Current language:  auto; currently minimal
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to 

Re: svn commit: r307394 - in head: share/man/man4 sys/conf sys/dev/netmap sys/modules/netmap sys/net tools/tools/netmap

[Olivier Cochard-Labbé]

​Hi,

since this commit, my system panic when using netmap pkt-gen with a Chelsio
T540-CR NIC (I didn't reproduce it with Intel NIC).

- Latest known working system: FreeBSD 12.0-CURRENT #2 r307393
- Crash since: FreeBSD 12.0-CURRENT #1 r307396

On a fresh (r309034) system, here is he behavior:

[root@SM]~# pkt-gen -i vcxl0 -f rx -w 4
133.571714 main [2546] interface is vcxl0
133.572025 main [2670] running on 1 cpus (have 8)
133.572377 extract_ip_range [462] range is 10.0.0.1:1234 to 10.0.0.1:1234
133.572393 extract_ip_range [462] range is 10.1.0.1:1234 to 10.1.0.1:1234

​Fatal trap 12: page fault while in kernel mode
cpuid = 7; apic id = 0e
fault virtual address   = 0x0
fault code  = supervisor write data, page not present
instruction pointer = 0x20:0x80d5480e
stack pointer   = 0x28:0xfe0466ba61e0
frame pointer   = 0x28:0xfe0466ba61e0
code segment= base 0x0, limit 0xf, type 0x1b
= DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags= interrupt enabled, resume, IOPL = 0
current process = 1900 (pkt-gen)
trap number = 12
panic: page fault
cpuid = 7
KDB: stack backtrace:
#0 0x80971167 at kdb_backtrace+0x67
#1 0x80929b72 at vpanic+0x182
#2 0x809299e3 at panic+0x43
#3 0x80d56e84 at trap_fatal+0x324
#4 0x80d57083 at trap_pfault+0x1e3
#5 0x80d56683 at trap+0x273
#6 0x80d39261 at calltrap+0x8
#7 0x8047c664 at cxgbe_netmap_reg+0x2f4
#8 0x8063d48c at netmap_hw_reg+0x2c
#9 0x8063a93b at netmap_do_regif+0x2ab
#10 0x8063b564 at netmap_ioctl+0xba4
#11 0x8063f14e at freebsd_netmap_ioctl+0x3e
#12 0x8085e47c at devfs_ioctl+0xac
#13 0x80eee78d at VOP_IOCTL_APV+0x8d
#14 0x80a08901 at vn_ioctl+0x131
#15 0x8085ecdf at devfs_ioctl_f+0x1f
#16 0x8098ed7b at kern_ioctl+0x29b
#17 0x8098ea71 at sys_ioctl+0x171
Uptime: 4m41s
Dumping 1112 out of 16325 MB:..2%..11%..21%..31%..41%..
51%..61%..71%..81%..91%
Dump complete

(kgdb) backtrace
#0  doadump (textdump=) at pcpu.h:222
#1  0x809295f9 in kern_reboot (howto=260) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:366
#2  0x80929bab in vpanic (fmt=, ap=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:759
#3  0x809299e3 in panic (fmt=0x0) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/kern_shutdown.c:690
#4  0x80d56e84 in trap_fatal (frame=0xfe0466ba6120, eva=0) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:801
#5  0x80d57083 in trap_pfault (frame=0xfe0466ba6120,
usermode=0) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:658
#6  0x80d56683 in trap (frame=0xfe0466ba6120) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/trap.c:421
#7  0x80d39261 in calltrap () at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/exception.S:236
#8  0x80d5480e in bzero () at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/support.S:53
#9  0x8047c664 in cxgbe_netmap_reg (na=,
on=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/cxgbe/t4_netmap.c:102
#10 0x8063d48c in netmap_hw_reg (na=0xf800055ba400, onoff=1) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2788
#11 0x8063a93b in netmap_do_regif (priv=,
na=, ringid=, flags=)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2050
#12 0x8063b564 in netmap_ioctl (priv=,
cmd=, data=0xfe0466ba69b0 "vcxl0",
td=0xf8001509a500)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap.c:2257
#13 0x8063f14e in freebsd_netmap_ioctl (dev=,
cmd=3225184658, data=0xfe0466ba69b0 "vcxl0", ffla=,
td=0xf8001509a500) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/dev/netmap/netmap_freebsd.c:1389
#14 0x8085e47c in devfs_ioctl (ap=) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/fs/devfs/devfs_vnops.c:831
#15 0x80eee78d in VOP_IOCTL_APV (vop=,
a=) at vnode_if.c:1067
#16 0x80a08901 in vn_ioctl (fp=0xf80015191f00, com=, data=0xfe0466ba69b0, active_cred=0xf8019928bd00,
td=0x1) at vnode_if.h:448
#17 0x8085ecdf in devfs_ioctl_f (fp=0x0, com=131072, data=0x0,
cred=0x4000, td=0xf8001509a500)
at /usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/fs/devfs/devfs_vnops.c:789
#18 0x8098ed7b in kern_ioctl (td=, fd=, com=3225184658, data=0xfe0466ba69b0 "vcxl0") at
file.h:327
#19 0x8098ea71 in sys_ioctl (td=0xf8001509a500,
uap=0xfe0466ba6b10) at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/kern/sys_generic.c:746
#20 0x80d57825 in amd64_syscall (td=,
traced=0) at subr_syscall.c:135
#21 0x80d3954b in Xfast_syscall () at
/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/amd64/amd64/exception.S:396
#22 0x00080100e5ca in ?? ()


​Regards,

Olivier​

Re: svn commit: r303643 - in head/sys: kern sys

[Olivier Cochard-Labbé]

On Mon, Aug 1, 2016 at 11:48 PM, Mateusz Guzik  wrote:

> Author: mjg
> Date: Mon Aug  1 21:48:37 2016
> New Revision: 303643
> URL: https://svnweb.freebsd.org/changeset/base/303643
>
> Log:
>   Implement trivial backoff for locking primitives.
>
>
>
​I was checking FreeBSD's forwarding speed evolution of year 2016​, when I
found a unexpected improvement:

http://dev.bsdrp.net/benchs/2016.jan-nov.SM5018A-FTN4-Chelsio.png

Something append between r303601 (July 31th) and r303818 (August 6th).

ae@ advices me to bench this specific commit:
http://dev.bsdrp.net/benchs/r303643.png

Thanks !

Olivier
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r295653 - in head: share/misc usr.bin/calendar/calendars

[Olivier Cochard]

Author: olivier (ports committer)
Date: Tue Feb 16 10:33:45 2016
New Revision: 295653
URL: https://svnweb.freebsd.org/changeset/base/295653

Log:
  Add myself as ports committer (including calendar)
  
  Approved by:  jadawin
  Differential Revision:https://reviews.freebsd.org/D5295

Modified:
  head/share/misc/committers-ports.dot
  head/usr.bin/calendar/calendars/calendar.freebsd

Modified: head/share/misc/committers-ports.dot
==
--- head/share/misc/committers-ports.dotTue Feb 16 03:50:56 2016
(r295652)
+++ head/share/misc/committers-ports.dotTue Feb 16 10:33:45 2016
(r295653)
@@ -175,6 +175,7 @@ nork [label="Norikatsu Shigemura\nnork@F
 novel [label="Roman Bogorodskiy\nno...@freebsd.org\n2005/03/07"]
 nox [label="Juergen Lock\n...@freebsd.org\n2006/12/22"]
 obrien [label="David E. O'Brien\nobr...@freebsd.org\n1996/10/29"]
+olivier [label="Olivier Cochard-Labbe\noliv...@freebsd.org\n2016/02/02"]
 olivierd [label="Olivier Duchateau\nolivi...@freebsd.org\n2012/05/29"]
 osa [label="Sergey A. Osokin\n...@freebsd.org\n2003/06/04"]
 pat [label="Patrick Li\n...@freebsd.org\n2001/11/14"]
@@ -400,6 +401,7 @@ itetcu -> sylvio
 
 jadawin -> bapt
 jadawin -> flo
+jadawin -> olivier
 jadawin -> riggs
 jadawin -> sbz
 jadawin -> wen

Modified: head/usr.bin/calendar/calendars/calendar.freebsd
==
--- head/usr.bin/calendar/calendars/calendar.freebsdTue Feb 16 03:50:56 
2016(r295652)
+++ head/usr.bin/calendar/calendars/calendar.freebsdTue Feb 16 10:33:45 
2016(r295653)
@@ -224,6 +224,7 @@
 07/02  Vasil Venelinov Dimov <v...@freebsd.org> born in Shumen, Bulgaria, 1982
 07/04  Motoyuki Konno <motoy...@freebsd.org> born in Musashino, Tokyo, Japan, 
1969
 07/04  Florent Thoumie <f...@freebsd.org> born in Montmorency, Val d'Oise, 
France, 1982
+07/05  Olivier Cochard-Labbe <oliv...@freebsd.org> born in Brest, France, 1977
 07/05  Sergey Kandaurov <pluk...@freebsd.org> born in Gubkin, Russian 
Federation, 1985
 07/07  Andrew Thompson <thom...@freebsd.org> born in Lower Hutt, Wellington, 
New Zealand, 1979
 07/07  Maxime Henrion <m...@freebsd.org> born in Metz, France, 1981
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r295062 - head/sbin/nvmecontrol

[Olivier Cochard-Labbé]

On Sat, Jan 30, 2016 at 7:18 AM, Warner Losh  wrote:

> Author: imp
> Date: Sat Jan 30 06:18:37 2016
> New Revision: 295062
> URL: https://svnweb.freebsd.org/changeset/base/295062
>
> Log:
>   Implement power command to list all power modes, find out the power
>   mode we're in and to set the power mode.
>
> Added:
>   head/sbin/nvmecontrol/power.c   (contents, props changed)
>

​Hi Warner,

my buildworld is no more happy ;-)​


--- power.o ---
/usr/src/sbin/nvmecontrol/power.c:44:16: error: invalid application of
'sizeof' to an incomplete type 'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
   ^ ~
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
--- all_subdir_kerberos5 ---
--- inquire_cred_by_mech.po ---
--- all_subdir_sbin ---
/usr/src/sbin/nvmecontrol/power.c:60:14: error: incomplete definition of
type 'struct nvme_power_state'
mpower = nps->mp;
 ~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:61:9: error: incomplete definition of
type 'struct nvme_power_state'
if (nps->mps == 0)
~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:63:14: error: incomplete definition of
type 'struct nvme_power_state'
ipower = nps->idlp;
 ~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:64:9: error: incomplete definition of
type 'struct nvme_power_state'
if (nps->ips == 1)
~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:66:14: error: incomplete definition of
type 'struct nvme_power_state'
apower = nps->actp;
 ~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:67:9: error: incomplete definition of
type 'struct nvme_power_state'
if (nps->aps == 1)
~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:71:12: error: incomplete definition of
type 'struct nvme_power_state'
   nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % 1000,
   ~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,
 ^
/usr/src/sbin/nvmecontrol/power.c:71:35: error: incomplete definition of
type 'struct nvme_power_state'
   nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % 1000,
  ~~~^
/usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of
'struct nvme_power_state'
_Static_assert(sizeof(struct nvme_power_state) == 256 / NBBY,

etc.
​
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r291913 - head/tools/tools/nanobsd

[Olivier Cochard-Labbé]

On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh  wrote:

> Author: imp
> Date: Mon Dec  7 04:02:31 2015
> New Revision: 291913
> URL: https://svnweb.freebsd.org/changeset/base/291913
>
> Log:
>   Generally use shorter, more idiomatic sh expressions in a bunch of
>   places.
>
> Modified:
>   head/tools/tools/nanobsd/defaults.sh   (contents, props changed)
>


​Hi,

I beleive there is a tipo here :
​


>
> Modified: head/tools/tools/nanobsd/defaults.sh
>
> ==
> --- head/tools/tools/nanobsd/defaults.shMon Dec  7 04:02:19 2015
>   (r291912)
> +++ head/tools/tools/nanobsd/defaults.shMon Dec  7 04:02:31 2015
>   (r291913)
>
>  ###
> @@ -949,21 +949,21 @@ export_var ( ) {  # Don't wawnt a subshe
>  # Call this function to set defaults _after_ parsing options.
>  # dont want a subshell otherwise variable setting is thrown away.
>  set_defaults_and_export ( ) {
> -   test -n "${NANO_OBJ}" || NANO_OBJ=/usr/obj/nanobsd.${NANO_NAME}
> -   test -n "${MAKEOBJDIRPREFIX}" || MAKEOBJDIRPREFIX=${NANO_OBJ}
> -   test -n "${NANO_DISKIMGDIR}" || NANO_DISKIMGDIR=${NANO_OBJ}
> +   : ${NANO_OBJ:=/usr/obj/nanobsd.${NANO_NAME}}
> +   : ${MAKEOBJDIRPREFIX:=${NANO_OBJ}}
> +   : ${NANO_DISKIMGDIR=:${NANO_OBJ}}
> NANO_WORLDDIR=${NANO_OBJ}/_.w
> NANO_MAKE_CONF_BUILD=${MAKEOBJDIRPREFIX}/make.conf.build
> NANO_MAKE_CONF_INSTALL=${NANO_OBJ}/make.conf.install
>
>


​Notice the line:
: ${NANO_DISKIMGDIR=:${NANO_OBJ}}

I beleive the good one is:
: ${NANO_DISKIMGDIR=${NANO_OBJ}}
​(without the ':' before ${NANO_OBJ}}

Because with the ':' variable NANO_DISKIMGDIR includes the ':' in front of
its values, and dd didn't like it:

+ IMG=:/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img
+ MNT=/usr/obj/BSDRPcur.amd64/_.mnt
+ mkdir -p /usr/obj/BSDRPcur.amd64/_.mnt
+ [ file '=' swap ]
+ echo 'Creating md backing file...'
Creating md backing file...
+ rm -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img
+ echo 'NANO RM -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img'
NANO RM -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img
+ uname -r
+ command rm -x -f :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img
+ dd 'if=/dev/zero'
'of=:/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img'
'seek=100' 'count=0'
dd: :/usr/obj/BSDRPcur.amd64/BSDRP-1.9998-full-amd64-vga.img: No such file
or directory


Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r291912 - head/tools/tools/nanobsd

[Olivier Cochard-Labbé]

On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh  wrote:

> Author: imp
> Date: Mon Dec  7 04:02:19 2015
> New Revision: 291912
> URL: https://svnweb.freebsd.org/changeset/base/291912
>
> Log:
>   Default serial connection to 115200. Hardly anybody uses slower these
>   days, and those that do can use NANO_BOOT2CFG to change it.
>
>
​Hi Warner,

​Cool change,
but boot0sio still doesn't support speed greater than 9600, right ?
​
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r287358 - head

[Olivier Cochard-Labbé]

On Wed, Sep 2, 2015 at 3:57 PM, Alexander Motin  wrote:

>
>
> Sorry if it is documented somewhere, but can this be disabled somehow?
> On my development server installkernel for some reason already took more
> time then buildkernel -DKERNFAST. Now I suppose it will take twice more.
> I am doing it hundred times a day, and I am not happy. :-\
>
>
​This create problem for generating nanobsd image too: It install kernel
twice, then the resulting /boot is too big for being copied into the small
OS partition.

Regards,

​Olivier​
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r285051 - head/sys/netinet

[Olivier Cochard-Labbé]

On Mon, Aug 3, 2015 at 5:05 PM, Ermal Luçi e...@freebsd.org wrote:

 Hello Olivier,

 its strange seeing so much contention on the arp tables on your PMC stats.
 Do you run ping(to prepopulate arp) or static arp to remove the noise from
 that interaction?


​I'm using static ARP on my devices (and static MAC assignement on switches
too) during my benchs.
​



 Also do you run with flowtable active?


​No I didn't have options FLOWTABLE in my kernel.

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r285051 - head/sys/netinet

[Olivier Cochard-Labbé]

On Mon, Aug 3, 2015 at 7:19 PM, Ermal Luçi e...@freebsd.org wrote:




 On Mon, Aug 3, 2015 at 5:18 PM, Olivier Cochard-Labbé oliv...@cochard.me
 wrote:

 On Mon, Aug 3, 2015 at 5:05 PM, Ermal Luçi e...@freebsd.org wrote:

 Hello Olivier,

 its strange seeing so much contention on the arp tables on your PMC
 stats.
 Do you run ping(to prepopulate arp) or static arp to remove the noise
 from that interaction?


 ​I'm using static ARP on my devices (and static MAC assignement on
 switches too) during my benchs.


 Then you have to create static ARPs for all your pkt-gen ips :)


​No because the static ARP entry correspond to a next-hop router​. And all
destination IPs generated by pkt-gen are behind this next-hop.
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r285051 - head/sys/netinet

[Olivier Cochard-Labbé]

On Tue, Jul 28, 2015 at 2:42 PM, Gleb Smirnoff gleb...@freebsd.org wrote:


 Here is suggested patch. Ermal and Oliver, can you please test/benchmark
 it?


​Hi,

this patch reduce performanece :-(

Here are the results regarding forwarding:

x r285046.pps.forwarding (IPSEC compiled but not used)
+ r285051.pps.forwarding (IPSEC compiled but not used)
* r285051-glebius-patched.pps.forwarding (IPSEC compiled but not used)
++
|xxx xx *
+ +++|
||_M_A___|
|_A_| |AM||
++
N   Min   MaxMedian   AvgStddev
x   5397733406951399300  401613.8 4324.9755
+   5478095482079480869  480543.6 1666.0282
Difference at 95.0% confidence
78929.8 +/- 4779.72
19.6532% +/- 1.19013%
(Student's t, pooled s = 3277.27)
*   5424720430745427014  427378.4 2351.7439
Difference at 95.0% confidence
25764.6 +/- 5076.98
6.41527% +/- 1.26415%
(Student's t, pooled s = 3481.1)
​


PMC stats during forwarding bench:
[root@netgate]/data# pmcannotate pmc.forwarding.out
/data/debug/boot/kernel/kernel.symbols
CONVERSION STATISTICS:
 #samples/total   33880
Profile trace for function: __rw_rlock() [6.29%]
Profile trace for function: ip_forward() [4.68%]
Profile trace for function: ip_output() [4.64%]
Profile trace for function: binuptime() [4.05%]
Profile trace for function: igb_mq_start_locked() [3.79%]
Profile trace for function: igb_rxeof() [3.46%]
Profile trace for function: tsc_get_timecount_low_lfence() [3.25%]
Profile trace for function: ether_output() [3.03%]
Profile trace for function: rtalloc1_fib() [2.77%]
Profile trace for function: random_ivy_read() [2.64%]
Profile trace for function: _rw_runlock_cookie() [2.64%]
Profile trace for function: ether_nh_input() [2.63%]
Profile trace for function: ip_input() [2.55%]
Profile trace for function: key_allocsp_default() [2.39%]
Profile trace for function: igb_mq_start() [2.39%]
Profile trace for function: bzero() [2.08%]
Profile trace for function: uma_zalloc_arg() [1.95%]
Profile trace for function: memcpy() [1.84%]
Profile trace for function: _mtx_lock_spin_cookie() [1.83%]
Profile trace for function: bcopy() [1.76%]
Profile trace for function: random_harvest_queue() [1.63%]
Profile trace for function: __mtx_lock_sleep() [1.56%]
Profile trace for function: uma_zfree_arg() [1.47%]
Profile trace for function: arpresolve() [1.39%]
Profile trace for function: in_cksumdata() [1.25%]
Profile trace for function: bounce_bus_dmamap_load_buffer() [1.22%]
Profile trace for function: bcmp() [1.13%]
Profile trace for function: rtalloc_ign_fib() [1.11%]
Profile trace for function: rn_match() [1.03%]
Profile trace for function: netisr_dispatch_src() [1.03%]
Profile trace for function: critical_exit() [1.02%]
Profile trace for function: bus_dmamap_load_mbuf_sg() [0.87%]
Profile trace for function: spinlock_exit() [0.79%]
Profile trace for function: in_cksum_skip() [0.75%]
Profile trace for function: ip_ipsec_output() [0.75%]
Profile trace for function: acpi_cpu_c1() [0.74%]
Profile trace for function: in_broadcast() [0.74%]
Profile trace for function: spinlock_enter() [0.74%]
Profile trace for function: igb_refresh_mbufs() [0.71%]
Profile trace for function: in_lltable_lookup() [0.71%]
Profile trace for function: ip_fastforward() [0.68%]
Profile trace for function: m_adj() [0.65%]
Profile trace for function: ether_demux() [0.65%]
Profile trace for function: _key_freesp() [0.61%]
Profile trace for function: lockstat_nsecs() [0.60%]
Profile trace for function: m_freem() [0.58%]
Profile trace for function: critical_enter() [0.56%]
Profile trace for function: m_copydata() [0.55%]
Profile trace for function: mb_free_ext() [0.54%]
Profile trace for function: pmap_kextract() [0.50%]

​

​And about fastforwarding:
​
x 285046.pps.fastforwarding (IPSEC compiled but not used)
+ 285051.pps.fastforwarding (IPSEC compiled but not used)
* r285051-glebius-patched.pps.fastforwarding (IPSEC compiled but not used)
++
|*
+|
|* * * *++ +x
x+ xx x|
||AM__|
|_MA__|__AM_| |
++
N   Min   MaxMedian   AvgStddev
x   5742683754709750940  749015.6 4944.9059
+   5736459747593738197  740112.4 4511.1611
Difference at 95.0% confidence
-8903.2 +/- 6902.82
-1.18865% +/- 0.921585%
(Student's t, pooled s = 4733)
*   5638356652855646668  

Re: svn commit: r285051 - head/sys/netinet

[Olivier Cochard-Labbé]

On Thu, Jul 2, 2015 at 8:10 PM, Ermal Luçi e...@freebsd.org wrote:

 Author: eri
 Date: Thu Jul  2 18:10:41 2015
 New Revision: 285051
 URL: https://svnweb.freebsd.org/changeset/base/285051

 Log:
   Avoid doing multiple route lookups for the same destination IP during
 forwarding

   ip_forward() does a route lookup for testing this packet can be sent to
 a known destination,
   it also can do another route lookup if it detects that an ICMP redirect
 is needed,
   it forgets all of this and handovers to ip_output() to do the same
 lookup yet again.

   This optimisation just does one route lookup during the forwarding path
 and handovers that to be considered by ip_output().




​Thanks,

This bring good improvement regarding simple forwarding (value in
paquet-per-second, smallest size, on a Netgate RCC-VE 4860):

x r285046.pps.forwarding (IPSEC compiled but not used)
+ r285051.pps.forwarding (IPSEC compiled but not used)
+--+
| +|
|xxxxx+ +++|
||_M_A__|  |
|  |_A||
+--+
N   Min   MaxMedian   AvgStddev
x   5397733406951399300  401613.8 4324.9755
+   5478095482079480869  480543.6 1666.0282
Difference at 95.0% confidence
78929.8 +/- 4779.72
19.6532% +/- 1.19013%
(Student's t, pooled s = 3277.27)



But how this patch reduce fastforwarding performance in the same time?

x r285046.pps.fastforwarding (IPSEC compiled but not used)
+ r285051.pps.fastforwarding (IPSEC compiled but not used)
+--+
|   +   +  +  + xx +x x   x|
||__A___M__|   |
||_M__A|   |
+--+
N   Min   MaxMedian   AvgStddev
x   5742683754709750940  749015.6 4944.9059
+   5736459747593738197  740112.4 4511.1611
Difference at 95.0% confidence
-8903.2 +/- 6902.82
-1.18865% +/- 0.921585%
(Student's t, pooled s = 4733)


Regards,

Olivier
​
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r284589 - head/usr.sbin/fstyp

[Olivier Cochard-Labbé]

On Fri, Jun 19, 2015 at 7:09 AM, Allan Jude allanj...@freebsd.org wrote:

 Author: allanjude (doc committer)
 Date: Fri Jun 19 05:09:02 2015
 New Revision: 284589
 URL: https://svnweb.freebsd.org/changeset/base/284589

 Log:
   Add the ability to detect ZFS and GELI encrypted file systems to fstyp(8)

   Functionality is hidden behind the -u flag to avoid confusing
 automounters

   PR:   200823
   Reviewed by:  asomers, eadler, wblock (man page)
   Approved by:  trasz
   MFC after:10 days
   Relnotes: yes
   Sponsored by: ScaleEngine Inc.
   Differential Revision:https://reviews.freebsd.org/D2045


 +
 +.if ${MK_CDDL} != no
 +SRCS +=zfs.c
 +.endif
 +



​Hi,​

​My nanobsd use WITHOUT_ZFS (MK_ZFS=no) but kept CDDL​ enabled for dtrace
(MK_CDDL= yes): Then it failed to build world on usr.sbin/fstyp.

Regards,
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r277714 - head/sbin/ipfw

[Olivier Cochard-Labbé]

On Mon, Jan 26, 2015 at 10:50 PM, Nick Hibma n...@van-laarhoven.org wrote:


  On 26 Jan 2015, at 22:24, John Baldwin j...@freebsd.org wrote:
 
 
  It might.  What happened for me is that I was using nat over wlan0 for
 VM's
  on my laptop to reach the outside world, but wlan0 doesn't get an IP
 until
  later in the boot after it associates.  As a result, wlan0 wasn't
 passing any
  IP traffic until this fix (or if I reloaded ipfw after wlan0 was
 configured).


With a FreeBSD 11-current 277728 I still have the ipfw_nat problem on
unconfigured/unexistant interface.


 I don't think it does. The interface is not available until openvpn is
 started.You need to clone the interface during boot by adding

 cloned_interfaces='tun0'

 in your /etc/rc.conf. Initialisation is then done later by openvpn.

 Let me know if that works for you.


I've tried with cloned_interfaces too: but same problem.

Here is the status of ipfw just after a boot (ipfw loaded before tun0 IP
setup):

[]~ ipfw show
00100   0 0 allow ip from any to any via lo0
00200   0 0 allow ip from any to any via lo1
00300   0 0 allow ip from any to any via vtnet6
00400   0 0 allow ip from any to any via wlan0
00500 172 21355 nat 1 ip from any to any in via vtnet4
00600  62  4264 nat 2 ip from any to any in via tun0
00700   0 0 check-state
00800   0 0 allow udp from 0.0.0.0 68 to 255.255.255.255 dst-port 67
out via vtnet4
00900   0 0 allow udp from any 67 to me dst-port 68 in via vtnet4
01000   0 0 allow udp from any 67 to 255.255.255.255 dst-port 68 in via
vtnet4
01100   0 0 allow icmp from me to any out via vtnet4 keep-state
01200  11   756 allow udp from me to any dst-port 53 out via vtnet4
keep-state
01300   4   304 allow udp from me to any dst-port 123 out via vtnet4
keep-state
01400 172 21725 allow udp from me to any dst-port 1195 out via vtnet4
keep-state
01500   0 0 nat 1 ip from 10.6.1.0/24,10.6.2.0/24 to any out via vtnet4
01600   0 0 nat 2 udp from me to 2.2.2.2 dst-port 1812,1813 out via tun0
01700  68  4452 allow ip from any to any via tun0
65535   0 0 deny ip from any to any

= All rules are present (even the nat 2 table) and seems ok.
= No packet seems to be denied
But my OSPF adjacency didn't came up on the tun0 interface:

[]~ tcpdump -pni tun0
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on tun0, link-type NULL (BSD loopback), capture size 262144 bytes
capability mode sandbox enabled
21:25:09.555746 IP 10.0.3.2  224.0.0.5: OSPFv2, Hello, length 44
21:25:10.595286 IP 10.0.3.1  224.0.0.5: OSPFv2, Hello, length 48
^C
2 packets captured
2 packets received by filter
0 packets dropped by kernel

= tcpdump shows only some multicast traffic: It's the problem because ifpw
is filtering all unicast traffic on tun0 in its current state.
For solving this problem I just had to reload ipfw:

[]~ service ipfw restart
net.inet.ip.fw.enable: 1 - 0
net.inet6.ip6.fw.enable: 1 - 0
Firewall rules loaded.

= This fix the problem, unicast traffic are now allowed:

[]~ tcpdump -pni tun0
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on tun0, link-type NULL (BSD loopback), capture size 262144 bytes
capability mode sandbox enabled
21:25:34.772225 IP 10.0.3.2  10.0.3.1: OSPFv2, Database Description,
length 32
21:25:35.784449 IP 10.0.3.1  10.0.3.2: OSPFv2, Database Description,
length 32
21:25:35.784550 IP 10.0.3.2  10.0.3.1: OSPFv2, Database Description,
length 52
21:25:35.785904 IP 10.0.3.1  10.0.3.2: OSPFv2, Database Description,
length 192
21:25:35.786007 IP 10.0.3.2  10.0.3.1: OSPFv2, Database Description,
length 32
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r277714 - head/sbin/ipfw

[Olivier Cochard-Labbé]

On Sun, Jan 25, 2015 at 9:37 PM, John Baldwin j...@freebsd.org wrote:

 Author: jhb
 Date: Sun Jan 25 20:37:32 2015
 New Revision: 277714
 URL: https://svnweb.freebsd.org/changeset/base/277714

 Log:
   natd(8) will work with an unconfigured interface and effectively not do
   anything until the interface is assigned an address.  This fixes
   ipfw_nat to do the same by using an IP of INADDR_ANY instead of
   aborting the nat setup if the requested interface is not yet configured.



Hi,

I've still a problem with ipfw_nat and unconfigured interface:
On my setup I'm using ipfw with NAT rules using an OpenVPN tunnel interface
as source address for NATting.

During the machine startup, ipfw is started before openvpn (hopefully) and
its configuration mention do to NAT using tun0 IP address.
Then OpenVPN start and create a tun0 and set an IP address on it.
= But no unicast traffic is allowed on this tun0 interface until I restart
ipfw.

If I correctly understand the log of this commit: This behavior should be
fixed by this commit, right ?
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys

[Olivier Cochard-Labbé]

On Fri, Oct 10, 2014 at 9:26 PM, George V. Neville-Neil g...@freebsd.org
wrote:

 Author: gnn
 Date: Fri Oct 10 19:26:26 2014
 New Revision: 272906
 URL: https://svnweb.freebsd.org/changeset/base/272906

 Log:
   Change the PF hash from Jenkins to Murmur3.  In forwarding tests
   this showed a conservative 3% incrase in PPS.



It's not easy to measure 3% of difference ;-)

My benchs didn't reach to measure it (about 2000 flows of minimum
packet-size, result displayed in packet-per-second):

In state-full:


x 272685.pf-statefull
+ 273009.pf-statefull
+--+
|xx+   +  xx  x++ +|
||__A_M___||
|   |A_M___|   |
+--+
N   Min   MaxMedian   AvgStddev
x   5   1297273   1332110   1329176 1321089.2 14527.702
+   5   1324108   1351078   1336257 1335044.2 10562.448
No difference proven at 95.0% confidence


Neither in stateless:

x 272685.pf-stateless
+ 273009.pf-stateless
+--+
|x   x  + x+x x   +   +   +|
| |___M_A| |
|  |__A_|  |
+--+
N   Min   MaxMedian   AvgStddev
x   5   1311342   1316466   1313645 1313898.6 2378.5845
+   5   1312893   1320772   1316878 1316927.4 3607.1013
No difference proven at 95.0% confidence

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r259638 - head/usr.bin/netstat

[Olivier Cochard-Labbé]

On Fri, Dec 20, 2013 at 1:17 AM, Alexander V. Chernikov 
melif...@freebsd.org wrote:

 Author: melifaro
 Date: Fri Dec 20 00:17:26 2013
 New Revision: 259638
 URL: http://svnweb.freebsd.org/changeset/base/259638

 Log:
   Use more fine-grained kvm(3) symbol lookup: routing code retrieves only
   necessary symbols needed per subsystem. Main kvm(3) init is now delayed
   as much as possbile. This finally fixes performance issues reported in
   kern/167204.
   Some non-working code (ng_socket.ko symbol addresses calculation)
 removed.
   Some global variables eliminated.

   PR:   kern/167204
   MFC after:4 weeks


Hi Alexander,

netstat -gW no more correctly detect inet4 MROUTING after this commit
(that was MFC to stable).

Behavior of my MROUTING enabled system before your commit:

-
[root@router]~# uname -a
FreeBSD router.bsdrp.net 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259635: Tue
Apr 29 09:08:10 CEST 2014
r...@orange.bsdrp.net:/usr/obj/TESTING.amd64/usr/local/BSDRP/TESTING/FreeBSD/src/sys/amd64
amd64
[root@router]~# sysctl kern.conftxt | grep MROUTING
options MROUTING
[root@router]~# netstat -gW

IPv4 Virtual Interface Table is empty

IPv4 Multicast Forwarding Table is empty


IPv6 Multicast Interface Table is empty

IPv6 Multicast Forwarding Table is empty
-

And the new behavior after your commit:

-
[root@router]~# uname -a
FreeBSD router.bsdrp.net 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259638: Mon
Apr 28 20:58:06 CEST 2014
r...@orange.bsdrp.net:/usr/obj/TESTING.amd64/usr/local/BSDRP/TESTING/FreeBSD/src/sys/amd64
amd64
[root@router]~# sysctl kern.conftxt | grep MROUTING
options MROUTING
[root@router]~# netstat -gW
No IPv4 MROUTING kernel support.

IPv6 Multicast Interface Table is empty

IPv6 Multicast Forwarding Table is empty
-

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r264601 - in head: share/man/man4 sys/boot/fdt/dts/mips sys/dev/netfpga10g sys/dev/netfpga10g/nf10bmac sys/mips/beri sys/mips/conf sys/modules sys/modules/netfpga10g sys/modules/netfpg

[Olivier Cochard-Labbé]

On Thu, Apr 17, 2014 at 2:33 PM, Bjoern A. Zeeb b...@freebsd.org wrote:

 Author: bz
 Date: Thu Apr 17 12:33:26 2014
 New Revision: 264601
 URL: http://svnweb.freebsd.org/changeset/base/264601

 Log:
   Add the initial version of if_nf10bmac(4), a driver to support an
   NetFPGA-10G Embedded CPU Ethernet Core.



Hi Bjoern,

I meet this problem during installworld since this commit:

install -o root -g wheel -m 444 netfpga10g_nf10bmac.4.gz
/usr/obj/nanobsd.amd64/_.w/usr/share/man/man4
install: netfpga10g_nf10bmac.4.gz: No such file or directory
*** [_maninstall] Error code 71

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r257529 - in head: share/man/man4 sys/conf sys/dev/e1000 sys/dev/ixgbe sys/dev/netmap sys/dev/re sys/net tools/tools/netmap

[Olivier Cochard-Labbé]

On Fri, Nov 1, 2013 at 10:21 PM, Luigi Rizzo lu...@freebsd.org wrote:

 Author: luigi
 Date: Fri Nov  1 21:21:14 2013
 New Revision: 257529
 URL: http://svnweb.freebsd.org/changeset/base/257529

 Log:
   update to the latest netmap snapshot.
   This includes the following:
   - use separate memory regions for VALE ports
   - locking fixes
   - some simplifications in the NIC-specific routines
   - performance improvements for the VALE switch
   - some new features in the pkt-gen test program


Thanks a lot's for adding the range feature to pkt-gen !

But there is a problem with this new option: The checksum is not
updated when the IP addresses are updated.

If we use the IP src or dst range, only the packet using the first IP
addresse has a correct checksum, all other paquets checksum are wrong.

As example, if I start pkt-gen with -d 2.3.3.1-2.3.3.4 -s
1.3.3.1-1.3.3.4, give me these errors :

[root@bsdrp2]~# tcpdump -npi igb2 -c 100 -v
tcpdump: listening on igb2, link-type EN10MB (Ethernet), capture size
65535 bytes
00:00:56.439325 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b9)!)
  1.3.3.2.0  2.3.3.1.0: UDP, length 0
00:00:56.439325 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b5)!)1.3.3.3.0 
2.3.3.4.0: UDP, length 0
00:00:56.439326 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b8)!)1.3.3.3.0 
2.3.3.1.0: UDP, length 0
00:00:56.439327 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b8)!)1.3.3.2.0 
2.3.3.2.0: UDP, length 0
00:00:56.439330 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28)1.3.3.1.0  2.3.3.1.0: UDP, length 0
00:00:56.439332 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b7)!)1.3.3.4.0 
2.3.3.1.0: UDP, length 0
00:00:56.439332 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b6)!)1.3.3.4.0 
2.3.3.2.0: UDP, length 0
00:00:56.439333 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b9)!)1.3.3.1.0 
2.3.3.2.0: UDP, length 0
00:00:56.439334 IP (tos 0x10, ttl 64, id 0, offset 0, flags [DF],
proto UDP (17), length 28, bad cksum 31ba (-31b8)!)1.3.3.1.0 
2.3.3.3.0: UDP, length 0

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r253088 - in head: sys/netipsec usr.bin/netstat

[Olivier Cochard-Labbé]

On Tue, Jul 9, 2013 at 12:08 PM, Andrey V. Elsukov a...@freebsd.org wrote:
 Author: ae
 Date: Tue Jul  9 10:08:13 2013
 New Revision: 253088
 URL: http://svnweb.freebsd.org/changeset/base/253088

 Log:
   Migrate structs ahstat, espstat, ipcompstat, ipipstat, pfkeystat,
   ipsec4stat, ipsec6stat to PCPU counters.

Hi Andrey,

Can these changes prevent to compile /usr/src/tools/tools/crypto ?

I've got these errors now:

ipsecstats.c:103:2: error: use of undeclared identifier 'uintmax_t'
AHSTAT(ahs.ahs_input, input packets processed);

ipsecstats.c:104:2: error: use of undeclared identifier 'uintmax_t'
AHSTAT(ahs.ahs_output, output packets processed);

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r253727 - head/sys/net80211

[Olivier Cochard-Labbé]

On Sun, Jul 28, 2013 at 6:53 AM, Adrian Chadd adr...@freebsd.org wrote:
 Author: adrian
 Date: Sun Jul 28 04:53:00 2013
 New Revision: 253727
 URL: http://svnweb.freebsd.org/changeset/base/253727

...

 Modified:
   head/sys/net80211/ieee80211_mesh.c
   head/sys/net80211/ieee80211_output.c


Hi,

I've got this problem during buildkernel:

cc  -c -O2 -pipe -fno-strict-aliasing  -std=c99 -g -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
-Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs
-fdiagnostics-show-option  -Wno-error-tautological-compare
-Wno-error-empty-body  -Wno-error-parentheses-equality  -nostdinc  -I.
-I/usr/src/sys -I/usr/src/sys/contrib/altq
-I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
-include opt_global.h  -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -mno-aes -mno-avx -mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fstack-protector
-Werror  /usr/src/sys/net80211/ieee80211_mesh.c
/usr/src/sys/net80211/ieee80211_mesh.c:1061:9: error: implicit declaration of
  function 'ieee80211_vap_pkt_send_dest' is invalid in C99
  [-Werror,-Wimplicit-function-declaration]
(void) ieee80211_vap_pkt_send_dest(vap, m, ni);
   ^
/usr/src/sys/net80211/ieee80211_mesh.c:1043:23: error: unused variable 'ic'
  [-Werror,-Wunused-variable]
struct ieee80211com *ic = vap-iv_ic;
 ^
2 errors generated.


Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r249041 - in head/sys/dev/drm2: . i915

[Olivier Cochard-Labbé]

On Sun, Apr 7, 2013 at 7:33 PM, Jean-Sébastien Pédron
dumbb...@freebsd.org wrote:

 Hi Olivier!

 Could you please try the following patch?
 http://people.freebsd.org/~dumbbell/radeonkms/drm-i915-intel_iic.a.patch

 It reverts a part of the commit, the one in intel_gmbus_transfer(). I
 think this function was called with the .slave address already left-shifted.


Thanks for your fast response:
svn up to latest rev 249241 + applied your patch… But still same problem :-(

Here is my full dmesg+xorg.log at r249241 with your patch (non working):
http://gugus69.free.fr/freebsd/i915kms.r249241-patched.txt

And here is the full dmesg + xorg.log at r249040 (working):
http://gugus69.free.fr/freebsd/i915kms.r249040.txt

Regards,

Olivier
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r249041 - in head/sys/dev/drm2: . i915

[Olivier Cochard-Labbé]

On Sun, Apr 7, 2013 at 9:05 PM, Konstantin Belousov kostik...@gmail.com wrote:

 More useful debug info could be obtained by setting the kenv
 drm.debug to 3, and then looking at the dmesg.

OK, here are the 2 dmesg files:
http://gugus69.free.fr/freebsd/dmesg.drm.debug.r249241-patched-non-working.txt
http://gugus69.free.fr/freebsd/dmesg.drm.debug.r249040-working.txt

## Fast diff between theses files ##

### r249241-patched-non-working ###

Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:7:LVDS-1]
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:7:LVDS-1] probed modes :
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_mode_debug_printmodeline] Modeline 27:1366x768
60 76300 1366 1430 1478 1606 768 770 775 792 0x8 0xa
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:11:VGA-1]
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:intel_ironlake_crt_detect_hotplug] trigger hotplug
detect cycle: adpa=0xf4
Apr  7 22:48:25 laptop kernel: [drm:pid12:pch_irq_handler] i915: PCH
transcoder audio interrupt
Apr  7 22:48:25 laptop kernel: [drm:pid0:i915_hotplug_work_func]
running encoder hotplug functions
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid0:i915_hotplug_work_func]
running encoder hotplug functions
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:intel_ironlake_crt_detect_hotplug] ironlake hotplug
adpa=0xf4, result 0
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_crt_detect] CRT
not detected via hotplug
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:11:VGA-1] disconnected
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:14:HDMI-A-1]
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 5 error 2
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 4 error 2
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 3 error 2
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 2 error 2
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 1 error 2
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_hdmi_detect]
[CONNECTOR:14:HDMI-A-1] got no edid, ddc port 5
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:14:HDMI-A-1] disconnected
Apr  7 22:48:25 laptop kernel:
[drm:KMS:pid945:drm_helper_probe_single_connector_modes]
[CONNECTOR:17:DP-1]
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 5 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 4 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 3 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 2 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 1 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:iic_dp_aux_xfer]
dp_aux_xfer return 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:drm_do_probe_ddc_edid]
iicbus_transfer countdown 5 error 6
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop kernel: [drm:KMS:pid945:intel_dp_i2c_aux_ch] aux_i2c nack
Apr  7 22:48:25 laptop