Re: svn commit: r205132 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-20 Thread Pawel Jakub Dawidek
On Sat, Mar 13, 2010 at 09:41:53PM +, Kip Macy wrote:
> Author: kmacy
> Date: Sat Mar 13 21:41:52 2010
> New Revision: 205132
> URL: http://svn.freebsd.org/changeset/base/205132
> 
> Log:
>   Don't bottleneck on acquiring the stream locks - this avoids a massive
>   drop off in throughput with large numbers of simultaneous reads

This is another[1] change we agreed (I hoped) to properly evaluate first
through zfs-c...@opensolaris.org.

1) Message-ID: <20100320110219.gd1...@garage.freebsd.pl>

-- 
Pawel Jakub Dawidek   http://www.wheelsystems.com
p...@freebsd.org   http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!


pgpmnsVOP2nh1.pgp
Description: PGP signature


Re: svn commit: r205132 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-20 Thread K. Macy
Be my guest. I've established the technical merits in production.

Thanks,
Kip

On Mar 20, 2010 4:10 AM, "Pawel Jakub Dawidek"  wrote:

On Sat, Mar 13, 2010 at 09:41:53PM +, Kip Macy wrote:
> Author: kmacy
> Date: Sat Mar 13 21:41:5...
This is another[1] change we agreed (I hoped) to properly evaluate first
through zfs-c...@opensolaris.org.

1) Message-ID: <20100320110219.gd1...@garage.freebsd.pl>

--
Pawel Jakub Dawidek   http://www.wheelsystems.com
p...@freebsd.org   http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r205132 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-20 Thread K. Macy
On Sat, Mar 20, 2010 at 3:10 AM, Pawel Jakub Dawidek  wrote:
> On Sat, Mar 13, 2010 at 09:41:53PM +, Kip Macy wrote:
>> Author: kmacy
>> Date: Sat Mar 13 21:41:52 2010
>> New Revision: 205132
>> URL: http://svn.freebsd.org/changeset/base/205132
>>
>> Log:
>>   Don't bottleneck on acquiring the stream locks - this avoids a massive
>>   drop off in throughput with large numbers of simultaneous reads
>
> This is another[1] change we agreed (I hoped) to properly evaluate first
> through zfs-c...@opensolaris.org.
>

Hi pjd -
I ran it by zfs-code@ a year ago. I never got any meaningful feedback.
I'm not being flippant when I say that I would like you to interact
with them.

One thing you need to also bear in mind is that Opensolaris !=
FreeBSD. I don't mean that in the phk "this is the wrong mailing list"
sense, but rather the two have different behavioral properties. The
deadlock that I had to track down by hand because you had disabled
witness on ZFS locks occurred within 10 minutes on a modest web
serving load and within 2 minutes under fsstress. It had been in ZFS
quite some time when they finally patched it and yet it was a very
serious problem on FreeBSD. Web serving throughput would drop from
2.5Gbps to a few hundred megabits per second without this change. I
can only guess that sx locks do not behave the same as Solaris'
mutexes to such a large extent that we get very different behaviors
and you'll have to keep an open mind to local changes that cope with
that fact.


Thanks,
Kip
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"