Re: svn commit: r236362 - head/share/misc
On 5/31/2012 12:33 PM, Tom Judge wrote: - Sort the node list while I'm here. This falls under the category of a whitespace change, which should have been done as a separate commit (usually first, then substantive changes second). This is a tiny bit more work for you, but down the road when someone who is !tj is reviewing the logs, diffs, etc. it really helps to make the substantive changes stand out. Doug -- This .signature sanitized for your protection ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r236362 - head/share/misc
On 31 May 2012 18:29, Doug Barton do...@freebsd.org wrote: On 5/31/2012 12:33 PM, Tom Judge wrote: - Sort the node list while I'm here. This falls under the category of a whitespace change, which should have been done as a separate commit (usually first, then substantive changes second). I figured none of the changes were really substantive so it was okay to sort and fix the \n at the same time. -- Eitan Adler Source Ports committer X11, Bugbusting teams ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r236362 - head/share/misc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/05/2012 21:29, Doug Barton wrote: On 5/31/2012 12:33 PM, Tom Judge wrote: - Sort the node list while I'm here. This falls under the category of a whitespace change, which should have been done as a separate commit (usually first, then substantive changes second). This is a tiny bit more work for you, but down the road when someone who is !tj is reviewing the logs, diffs, etc. it really helps to make the substantive changes stand out. Feedback noted for next time. Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPyCMZAAoJEEJSM9yB4iIWo1cH/130Fb9qDCpI8jJnukHR4EI1 4LJj7q0TLSNoocvB+JleVpO1i3wOuFJX+jj64yTC/BOuMU9Z/FJ7MxoyBTEOXpBO AfUibDN3jquHKIP1eZLZzGYVSOLUg9sXCTG+yryPKfGvaC5iNhkhH3rL3+QBCLzA pQLEG65rcG2yTgzohEejCyJxSBxNl+8O5WmLRUvn+GQlmefBYh2kHyphLAA2iFE+ J8jC7afDZQMg3TA8OhllEcfg3ErbIpzI/CPoHbr+6A2tKTlbzcb1AKUBFkZPLDib 1uSHkEvLUT+ZTsB+8qDiGbbZ42eMlF206jGf5vXdG5AD9C2Xp2zwVVeya8G5o9Y= =LwiQ -END PGP SIGNATURE- ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r236362 - head/share/misc
On 5/31/2012 6:59 PM, Eitan Adler wrote: On 31 May 2012 18:29, Doug Barton do...@freebsd.org wrote: On 5/31/2012 12:33 PM, Tom Judge wrote: - Sort the node list while I'm here. This falls under the category of a whitespace change, which should have been done as a separate commit (usually first, then substantive changes second). I figured none of the changes were really substantive so it was okay to sort and fix the \n at the same time. These were the changes: Log: - Fix my botched merge and correct mentor ordering. (Spotted by flo) - Fix missing new line in node block. (Spotted by gavin) - Sort the node list while I'm here. The last is definitely WS, the second probably is, the first definitely isn't. hth, Doug -- This .signature sanitized for your protection ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
