Re: svn commit: r242897 - head/release

2012-11-11 Thread Xin Li 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 11/11/12 1:52 PM, Glen Barber wrote:
 Author: gjb (doc,ports committer) Date: Sun Nov 11 21:52:18 2012 
 New Revision: 242897 URL: 
 http://svnweb.freebsd.org/changeset/base/242897
 
 Log: Prevent including .zfs snapshot directories in the src.txz 
 distribution.  This can happen if the src/ tree checkout is within 
 its own ZFS dataset, and the 'snapdir' ZFS property is set to 
 'visible.'

Since snapdir=visible is non-standard setting, will it be sensible to
exclude .snap as well?  (maybe also .git?)

Cheers,

 Approved by:  hrs MFC after:  3 days X-MFC-To:stable/9 only
 
 Modified: head/release/Makefile
 
 Modified: head/release/Makefile 
 ==


 
- --- head/release/Makefile Sun Nov 11 15:34:58 2012(r242896)
 +++ head/release/Makefile Sun Nov 11 21:52:18 2012(r242897) @@ 
 -83,7 +83,7 @@ kernel.txz: src.txz: mkdir -p ${DISTDIR}/usr ln -fs 
 ${WORLDDIR} ${DISTDIR}/usr/src -  cd ${DISTDIR}  tar cLvJf 
 ${.OBJDIR}/src.txz --exclude .svn \ + cd ${DISTDIR}  tar cLvJf 
 ${.OBJDIR}/src.txz --exclude .svn --exclude .zfs \ --exclude CVS 
 --exclude @ --exclude usr/src/release/dist usr/src
 
 ports.txz:
 

-BEGIN PGP SIGNATURE-

iQEcBAEBCAAGBQJQoCXsAAoJEG80Jeu8UPuzlHQH/iB1qtSH4QcDwxUtIM1gZysI
7xJIcP47dq00W6X9v97p30s149x6VzJP+Ps1zfAt7cgwozTrD5XQGIUcJn/56rUH
4geVwfvkDTK9EqM9yPeederiio+fcSXG9mIQGuW3W345IuUHk9p8wfh6w9rQMKCR
Vor/s9gQ5q5bCb3t6NZ0rAoq1LGs7pWPfU9WckHa/4Ekjw21WziwkiEfOOH4UeJl
z9Di+td1Jd9pzYxh74ZFzEDY4l28/A0Pmmtj0GtNjIFtGJiXGWUgADrSuXozBwPg
7aArwKcoeL/pFsVWhll3IQ/IznMU8BwVLQkDOs5wwSLGqNoKJJvQeNWs+K2f7g4=
=nLZI
-END PGP SIGNATURE-
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r242897 - head/release

2012-11-11 Thread Glen Barber 
On Sun, Nov 11, 2012 at 02:25:48PM -0800, Xin Li wrote:
  Log: Prevent including .zfs snapshot directories in the src.txz 
  distribution.  This can happen if the src/ tree checkout is within 
  its own ZFS dataset, and the 'snapdir' ZFS property is set to 
  'visible.'
 
 Since snapdir=visible is non-standard setting, will it be sensible to
 exclude .snap as well?  (maybe also .git?)
 

Yes, I think so.  This was mentioned yesterday, but I had already sent
this patch for review.  I do intend to exclude more dot-dirs.

Glen



pgpjoQsmG5FKX.pgp
Description: PGP signature

Re: svn commit: r242897 - head/release

2012-11-11 Thread Daniel O'Connor 

On 12/11/2012, at 9:00, Glen Barber g...@freebsd.org wrote:
 Since snapdir=visible is non-standard setting, will it be sensible to
 exclude .snap as well?  (maybe also .git?)
 
 
 Yes, I think so.  This was mentioned yesterday, but I had already sent
 this patch for review.  I do intend to exclude more dot-dirs.


Why not just exclude '.??*' ?

I doubt the source tree will ever grow a top level directory whose name starts 
with a dot.

--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
The nice thing about standards is that there
are so many of them to choose from.
  -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C

Re: svn commit: r242897 - head/release

2012-11-11 Thread Glen Barber 
On Mon, Nov 12, 2012 at 10:24:02AM +1030, Daniel O'Connor wrote:
 
 On 12/11/2012, at 9:00, Glen Barber g...@freebsd.org wrote:
  Since snapdir=visible is non-standard setting, will it be sensible to
  exclude .snap as well?  (maybe also .git?)
  
  
  Yes, I think so.  This was mentioned yesterday, but I had already sent
  this patch for review.  I do intend to exclude more dot-dirs.
 
 
 Why not just exclude '.??*' ?
 

Because I have not yet had a chance to test such a change.

Glen



pgp19ufkztu9K.pgp
Description: PGP signature