Re: svn commit: r274926 - head/sys/dev/mpt

2014-11-23 Thread Dimitry Andric 
On 23 Nov 2014, at 22:37, Ian Lepore i...@freebsd.org wrote:
 
 Author: ian
 Date: Sun Nov 23 21:37:33 2014
 New Revision: 274926
 URL: https://svnweb.freebsd.org/changeset/base/274926
 
 Log:
  Squelch a (bogus) used before init warning when building with gcc.

There have been quite a number of commits now for silencing gcc's mostly
incorrect used-before-init warnings.  Of course, this is due to base gcc
being very old.  So maybe it's time to start using -Wno-uninitialized
for gcc 4.2 and earlier?

-Dimitry



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r274926 - head/sys/dev/mpt

2014-11-23 Thread Ian Lepore 
On Sun, 2014-11-23 at 22:47 +0100, Dimitry Andric wrote:
 On 23 Nov 2014, at 22:37, Ian Lepore i...@freebsd.org wrote:
  
  Author: ian
  Date: Sun Nov 23 21:37:33 2014
  New Revision: 274926
  URL: https://svnweb.freebsd.org/changeset/base/274926
  
  Log:
   Squelch a (bogus) used before init warning when building with gcc.
 
 There have been quite a number of commits now for silencing gcc's mostly
 incorrect used-before-init warnings.  Of course, this is due to base gcc
 being very old.  So maybe it's time to start using -Wno-uninitialized
 for gcc 4.2 and earlier?
 
 -Dimitry
 

It does seem like just sprinking trash over the source code.

Does clang warn properly (or at least better than gcc does), or if we
squelch this will we have no warnings at all?  Hmmm, coverity should
tell us if we introduce new use-before-inits, right?

-- Ian


___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org