svn commit: r216493 - head/sbin/geom/class/eli

2010-12-16 Thread David E. O'Brien 
Author: obrien
Date: Thu Dec 16 17:54:56 2010
New Revision: 216493
URL: http://svn.freebsd.org/changeset/base/216493

Log:
  Revert r216473.
  WARNS=6 causes warning: cast increases required alignment of target type
  on arm, ia64, mips, and sparc64.

Modified:
  head/sbin/geom/class/eli/Makefile

Modified: head/sbin/geom/class/eli/Makefile
==
--- head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:14:37 2010
(r216492)
+++ head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:54:56 2010
(r216493)
@@ -11,7 +11,7 @@ SRCS+=sha2.c
 DPADD= ${LIBMD} ${LIBCRYPTO}
 LDADD= -lmd -lcrypto
 
-WARNS?=6
+WARNS?=3
 
 CFLAGS+=-I${.CURDIR}/../../../../sys
 
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r216493 - head/sbin/geom/class/eli

2010-12-16 Thread Dimitry Andric 

On 2010-12-16 19:54, Garrett Cooper wrote:

-WARNS?=6
+WARNS?=3

  CFLAGS+=-I${.CURDIR}/../../../../sys


 I think it's actually safe to bump it to WARNS = 6 if you define
NO_WCAST_ALIGN = 1, but that would need to be tested.


I'm not sure if this SHA2 stuff is contributed code, but those warnings
might actually indicate a problem, that needs to be fixed?
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r216493 - head/sbin/geom/class/eli

2010-12-16 Thread Warner Losh 

On 12/16/2010 11:54, Garrett Cooper wrote:

On Thu, Dec 16, 2010 at 9:54 AM, David E. O'Brienobr...@freebsd.org  wrote:

Author: obrien
Date: Thu Dec 16 17:54:56 2010
New Revision: 216493
URL: http://svn.freebsd.org/changeset/base/216493

Log:
  Revert r216473.
  WARNS=6 causes warning: cast increases required alignment of target type
  on arm, ia64, mips, and sparc64.

Modified:
  head/sbin/geom/class/eli/Makefile

Modified: head/sbin/geom/class/eli/Makefile
==
--- head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:14:37 2010
(r216492)
+++ head/sbin/geom/class/eli/Makefile   Thu Dec 16 17:54:56 2010
(r216493)
@@ -11,7 +11,7 @@ SRCS+=sha2.c
  DPADD= ${LIBMD} ${LIBCRYPTO}
  LDADD= -lmd -lcrypto

-WARNS?=6
+WARNS?=3

  CFLAGS+=-I${.CURDIR}/../../../../sys

 I think it's actually safe to bump it to WARNS = 6 if you define
NO_WCAST_ALIGN = 1, but that would need to be tested.
And the code in question needs to be audited to make sure that the 
alignment changes are benign.  Blindly setting this just papers over the 
bugs...


Warner

Cheers,
-Garrett





___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org