Re: svn commit: r229800 - head/sys/conf
On Sun, Jan 08, 2012 at 02:58:56PM -0800, Adrian Chadd wrote: On 8 January 2012 02:43, Pawel Jakub Dawidek p...@freebsd.org wrote: If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? I'd rather find a cleaner solution - it's pulling in code which just isn't being used if you aren't using UFS_ACL or ZFS. How about wrapping those two up in a module which zfs can register a dependency on? Adrian, I see no progress was made on this and I just was beaten by this change. I upgrade a box, but forget about this and I couldn't load zfs module. Until better idea is found and implemented, once again, please back this one out. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpF2rTDveJ5N.pgp Description: PGP signature
Re: svn commit: r229800 - head/sys/conf
On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: Author: adrian Date: Sun Jan 8 00:55:22 2012 New Revision: 229800 URL: http://svn.freebsd.org/changeset/base/229800 Log: Make these two files conditionally build on UFS_ACL, as it doesn't seem to be used elsewhere. Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't break anything - but please beat me to fix things if it does. If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? Why not make 'options ZFS' work? Then you can have subr_acl_nfs.c depend on ZFS as well. -- John Baldwin ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r229800 - head/sys/conf
On Mon, Jan 09, 2012 at 08:15:44AM -0500, John Baldwin wrote: On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: Author: adrian Date: Sun Jan 8 00:55:22 2012 New Revision: 229800 URL: http://svn.freebsd.org/changeset/base/229800 Log: Make these two files conditionally build on UFS_ACL, as it doesn't seem to be used elsewhere. Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't break anything - but please beat me to fix things if it does. If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? Why not make 'options ZFS' work? Then you can have subr_acl_nfs.c depend on ZFS as well. At the time I looked at it, it was very hard (at least for me) to make it work. Note that initial import of ZFS was delayed, because of this very reason. Then des@ convinced me to go ahead with module-only solution. The problem with having ZFS compiled into the kernel is that OpenSolaris compatiblity layer needs its headers to be included before system headers, which is/was impossible or hard to express for kernel compilation. AFAIR Kip Macy was working on it and my understanding was that he finished it or almost finished it (CCed). I'm all for making ZFS be compilable as part of the kernel itself, but it is really very low on my list, because ZFS simply works now and also because as I said, it was far from trivial for me to do it. If someone who is more familiar with the bits responsible for kernel compilation wants to work on including ZFS there, I'll gladly provide help from the ZFS side. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgphFHNqBOC61.pgp Description: PGP signature
Re: svn commit: r229800 - head/sys/conf
The problem with having ZFS compiled into the kernel is that OpenSolaris compatiblity layer needs its headers to be included before system headers, which is/was impossible or hard to express for kernel compilation. AFAIR Kip Macy was working on it and my understanding was that he finished it or almost finished it (CCed). I did indeed make it work. The (only) reason I didn't check it in was because there were some collisions between freebsd's older zlib which ppp depends on and the one in the solaris layer. Both bz and I were kind of busy at the time. I'm all for making ZFS be compilable as part of the kernel itself, but it is really very low on my list, because ZFS simply works now and also because as I said, it was far from trivial for me to do it. If someone who is more familiar with the bits responsible for kernel compilation wants to work on including ZFS there, I'll gladly provide help from the ZFS side. I think this can be done without much work, (re)work out the dependencies. Cheers ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r229800 - head/sys/conf
On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: Author: adrian Date: Sun Jan 8 00:55:22 2012 New Revision: 229800 URL: http://svn.freebsd.org/changeset/base/229800 Log: Make these two files conditionally build on UFS_ACL, as it doesn't seem to be used elsewhere. Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't break anything - but please beat me to fix things if it does. If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? This reduces the footprint of the kernel on small embedded systems (think 1MB flash for the compressed kernel image) just enough to actually fit. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpwOEHNmkx4H.pgp Description: PGP signature
Re: svn commit: r229800 - head/sys/conf
On 8 January 2012 02:43, Pawel Jakub Dawidek p...@freebsd.org wrote: If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? I'd rather find a cleaner solution - it's pulling in code which just isn't being used if you aren't using UFS_ACL or ZFS. How about wrapping those two up in a module which zfs can register a dependency on? Adrian ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r229800 - head/sys/conf
On Sun, Jan 08, 2012 at 02:58:56PM -0800, Adrian Chadd wrote: On 8 January 2012 02:43, Pawel Jakub Dawidek p...@freebsd.org wrote: If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS kernel module to work doesn't sound very intuitive. I understand what you are trying to accomplish, but we really need to find better way to do this. Until then, could you back it out? I'd rather find a cleaner solution - it's pulling in code which just isn't being used if you aren't using UFS_ACL or ZFS. How about wrapping those two up in a module which zfs can register a dependency on? This would be one weird module, but let's see:) -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpCvwLMWMQjs.pgp Description: PGP signature
svn commit: r229800 - head/sys/conf
Author: adrian
Date: Sun Jan 8 00:55:22 2012
New Revision: 229800
URL: http://svn.freebsd.org/changeset/base/229800
Log:
Make these two files conditionally build on UFS_ACL, as it doesn't
seem to be used elsewhere.
Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't
break anything - but please beat me to fix things if it does.
This reduces the footprint of the kernel on small embedded systems
(think 1MB flash for the compressed kernel image) just enough to
actually fit.
Modified:
head/sys/conf/files
Modified: head/sys/conf/files
==
--- head/sys/conf/files Sun Jan 8 00:42:07 2012(r229799)
+++ head/sys/conf/files Sun Jan 8 00:55:22 2012(r229800)
@@ -2409,8 +2409,9 @@ kern/sched_ule.c optional sched_ule
kern/serdev_if.m standard
kern/stack_protector.c standard \
compile-with ${NORMAL_C:N-fstack-protector*}
-kern/subr_acl_nfs4.c standard
-kern/subr_acl_posix1e.cstandard
+# XXX subr_acl_nfs4.c is also used by ZFS
+kern/subr_acl_nfs4.c optional ufs_acl
+kern/subr_acl_posix1e.coptional ufs_acl
kern/subr_autoconf.c standard
kern/subr_blist.c standard
kern/subr_bus.cstandard
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
