Re: svn commit: r250809 - head/sys/netinet

2013-05-24 Thread Julian Elischer 

On 5/24/13 2:52 PM, Michael Tuexen wrote:

On May 24, 2013, at 8:50 AM, Michael Tuexen wrote:


On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote:


On Sun, 19 May 2013, Michael Tuexen wrote:


Author: tuexen
Date: Sun May 19 16:06:43 2013
New Revision: 250809
URL: http://svnweb.freebsd.org/changeset/base/250809

Log:
Initialize the fibnum for outgoing packets to 0. This avoids
crashing due to the usage of uninitialized fibnum.
This bugs became visiable after
http://svnweb.freebsd.org/changeset/base/250700


That just masks the real bug, please back it out.

And the real bug is that SCTP doesn't support multiple fibs, right?
That would mean the system crashes on reception of an out of the blue
SCTP packet...

OK. I just saw
http://svnweb.freebsd.org/changeset/base/250952

I'll back out
http://svnweb.freebsd.org/changeset/base/250809
later today.


yeah. sorry about that...


Best regards
Michael

Best regards
Michael



MFC after: 2 weeks

Modified:
head/sys/netinet/sctp_os_bsd.h

Modified: head/sys/netinet/sctp_os_bsd.h
==
--- head/sys/netinet/sctp_os_bsd.h  Sun May 19 15:26:15 2013
(r250808)
+++ head/sys/netinet/sctp_os_bsd.h  Sun May 19 16:06:43 2013
(r250809)
@@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
{ \
int o_flgs = IP_RAWOUTPUT; \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && \
local_stcb->sctp_ep && \
local_stcb->sctp_ep->sctp_socket) \
@@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
#define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
{ \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && local_stcb->sctp_ep) \
result = ip6_output(o_pak, \
((struct in6pcb 
*)(local_stcb->sctp_ep))->in6p_outputopts, \


--
Bjoern A. Zeeb ? ??? ??? ??:
'??? ???  ??  ??? ?? ?? ??? ??? ??? ? ? 
?? ?? ? ',  ? ?, "??? ? ?? ?", ?.???









___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

2013-05-23 Thread Michael Tuexen 
On May 24, 2013, at 8:50 AM, Michael Tuexen wrote:

> On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote:
> 
>> On Sun, 19 May 2013, Michael Tuexen wrote:
>> 
>>> Author: tuexen
>>> Date: Sun May 19 16:06:43 2013
>>> New Revision: 250809
>>> URL: http://svnweb.freebsd.org/changeset/base/250809
>>> 
>>> Log:
>>> Initialize the fibnum for outgoing packets to 0. This avoids
>>> crashing due to the usage of uninitialized fibnum.
>>> This bugs became visiable after
>>> http://svnweb.freebsd.org/changeset/base/250700
>> 
>> 
>> That just masks the real bug, please back it out.
> And the real bug is that SCTP doesn't support multiple fibs, right?
> That would mean the system crashes on reception of an out of the blue
> SCTP packet...
OK. I just saw
http://svnweb.freebsd.org/changeset/base/250952

I'll back out
http://svnweb.freebsd.org/changeset/base/250809
later today.

Best regards
Michael
> 
> Best regards
> Michael
>> 
>> 
>>> MFC after: 2 weeks
>>> 
>>> Modified:
>>> head/sys/netinet/sctp_os_bsd.h
>>> 
>>> Modified: head/sys/netinet/sctp_os_bsd.h
>>> ==
>>> --- head/sys/netinet/sctp_os_bsd.h  Sun May 19 15:26:15 2013
>>> (r250808)
>>> +++ head/sys/netinet/sctp_os_bsd.h  Sun May 19 16:06:43 2013
>>> (r250809)
>>> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
>>> { \
>>> int o_flgs = IP_RAWOUTPUT; \
>>> struct sctp_tcb *local_stcb = stcb; \
>>> +   M_SETFIB(o_pak, 0); \
>>> if (local_stcb && \
>>> local_stcb->sctp_ep && \
>>> local_stcb->sctp_ep->sctp_socket) \
>>> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
>>> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
>>> { \
>>> struct sctp_tcb *local_stcb = stcb; \
>>> +   M_SETFIB(o_pak, 0); \
>>> if (local_stcb && local_stcb->sctp_ep) \
>>> result = ip6_output(o_pak, \
>>> ((struct in6pcb 
>>> *)(local_stcb->sctp_ep))->in6p_outputopts, \
>>> 
>> 
>> -- 
>> Bjoern A. Zeeb ? ??? ??? ??:
>> '??? ???  ??  ??? ?? ?? ??? ??? ??? ? ? 
>> ?? ?? ? ',  ? ?, "??? ? ?? ?", ?.???
>> 
> 
> 

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

2013-05-23 Thread Michael Tuexen 
On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote:

> On Sun, 19 May 2013, Michael Tuexen wrote:
> 
>> Author: tuexen
>> Date: Sun May 19 16:06:43 2013
>> New Revision: 250809
>> URL: http://svnweb.freebsd.org/changeset/base/250809
>> 
>> Log:
>> Initialize the fibnum for outgoing packets to 0. This avoids
>> crashing due to the usage of uninitialized fibnum.
>> This bugs became visiable after
>> http://svnweb.freebsd.org/changeset/base/250700
> 
> 
> That just masks the real bug, please back it out.
And the real bug is that SCTP doesn't support multiple fibs, right?
That would mean the system crashes on reception of an out of the blue
SCTP packet...

Best regards
Michael
> 
> 
>> MFC after: 2 weeks
>> 
>> Modified:
>> head/sys/netinet/sctp_os_bsd.h
>> 
>> Modified: head/sys/netinet/sctp_os_bsd.h
>> ==
>> --- head/sys/netinet/sctp_os_bsd.h   Sun May 19 15:26:15 2013
>> (r250808)
>> +++ head/sys/netinet/sctp_os_bsd.h   Sun May 19 16:06:43 2013
>> (r250809)
>> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
>> { \
>>  int o_flgs = IP_RAWOUTPUT; \
>>  struct sctp_tcb *local_stcb = stcb; \
>> +M_SETFIB(o_pak, 0); \
>>  if (local_stcb && \
>>  local_stcb->sctp_ep && \
>>  local_stcb->sctp_ep->sctp_socket) \
>> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
>> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
>> { \
>>  struct sctp_tcb *local_stcb = stcb; \
>> +M_SETFIB(o_pak, 0); \
>>  if (local_stcb && local_stcb->sctp_ep) \
>>  result = ip6_output(o_pak, \
>>  ((struct in6pcb 
>> *)(local_stcb->sctp_ep))->in6p_outputopts, \
>> 
> 
> -- 
> Bjoern A. Zeeb ? ??? ??? ??:
> '??? ???  ??  ??? ?? ?? ??? ??? ??? ? ? 
> ?? ?? ? ',  ? ?, "??? ? ?? ?", ?.???
> 

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

2013-05-23 Thread Bjoern A. Zeeb 

On Sun, 19 May 2013, Michael Tuexen wrote:


Author: tuexen
Date: Sun May 19 16:06:43 2013
New Revision: 250809
URL: http://svnweb.freebsd.org/changeset/base/250809

Log:
 Initialize the fibnum for outgoing packets to 0. This avoids
 crashing due to the usage of uninitialized fibnum.
 This bugs became visiable after
 http://svnweb.freebsd.org/changeset/base/250700



That just masks the real bug, please back it out.



 MFC after: 2 weeks

Modified:
 head/sys/netinet/sctp_os_bsd.h

Modified: head/sys/netinet/sctp_os_bsd.h
==
--- head/sys/netinet/sctp_os_bsd.h  Sun May 19 15:26:15 2013
(r250808)
+++ head/sys/netinet/sctp_os_bsd.h  Sun May 19 16:06:43 2013
(r250809)
@@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
{ \
int o_flgs = IP_RAWOUTPUT; \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && \
local_stcb->sctp_ep && \
local_stcb->sctp_ep->sctp_socket) \
@@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
#define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
{ \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && local_stcb->sctp_ep) \
result = ip6_output(o_pak, \
((struct in6pcb 
*)(local_stcb->sctp_ep))->in6p_outputopts, \



--
Bjoern A. Zeeb ? ??? ??? ??:
'??? ???  ??  ??? ?? ?? ??? ??? ??? ? ? 
?? ?? ? ',  ? ?, "??? ? ?? ?", ?.???
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

2013-05-20 Thread Julian Elischer 

On 5/19/13 9:06 AM, Michael Tuexen wrote:

   crashing due to the usage of uninitialized fibnum.
   This bugs became visiable after
I don't pretend to know the context, but do you want 0, or the fib of 
the active process?

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r250809 - head/sys/netinet

2013-05-19 Thread Michael Tuexen 
Author: tuexen
Date: Sun May 19 16:06:43 2013
New Revision: 250809
URL: http://svnweb.freebsd.org/changeset/base/250809

Log:
  Initialize the fibnum for outgoing packets to 0. This avoids
  crashing due to the usage of uninitialized fibnum.
  This bugs became visiable after
  http://svnweb.freebsd.org/changeset/base/250700
  
  MFC after: 2 weeks

Modified:
  head/sys/netinet/sctp_os_bsd.h

Modified: head/sys/netinet/sctp_os_bsd.h
==
--- head/sys/netinet/sctp_os_bsd.h  Sun May 19 15:26:15 2013
(r250808)
+++ head/sys/netinet/sctp_os_bsd.h  Sun May 19 16:06:43 2013
(r250809)
@@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t;
 { \
int o_flgs = IP_RAWOUTPUT; \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && \
local_stcb->sctp_ep && \
local_stcb->sctp_ep->sctp_socket) \
@@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t;
 #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
 { \
struct sctp_tcb *local_stcb = stcb; \
+   M_SETFIB(o_pak, 0); \
if (local_stcb && local_stcb->sctp_ep) \
result = ip6_output(o_pak, \
((struct in6pcb 
*)(local_stcb->sctp_ep))->in6p_outputopts, \
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"