Re: svn commit: r298769 - head/sys/netinet

2016-05-03 Thread hiren panchasara 
On 05/03/16 at 09:29P, Sepherosa Ziehau wrote:
> On Fri, Apr 29, 2016 at 11:55 PM, hiren panchasara
>  wrote:
> > On 04/29/16 at 07:23P, Sepherosa Ziehau wrote:
> >> Author: sephe
> >> Date: Fri Apr 29 07:23:08 2016
> >> New Revision: 298769
> >> URL: https://svnweb.freebsd.org/changeset/base/298769
> >>
> >> Log:
> >>   tcp/syncache: Set flowid and hash type properly for SYN|ACK
> >>
> >>   So the underlying drivers can use it to select the sending queue
> >>   properly for SYN|ACK instead of rolling their own hash.
> >>
> >>   Sponsored by:   Microsoft OSTC
> >>   Differential Revision:  https://reviews.freebsd.org/D6120
> >>
> >> Modified:
> >>   head/sys/netinet/tcp_syncache.c
> >
> > Would it be possible to MFC this?
> 
> I _think_ we can :)

That'd be nice. Thank you!

Cheers,
Hiren


pgpiyoPXg3VVN.pgp
Description: PGP signature

Re: svn commit: r298769 - head/sys/netinet

2016-05-02 Thread Sepherosa Ziehau 
On Fri, Apr 29, 2016 at 11:55 PM, hiren panchasara
 wrote:
> On 04/29/16 at 07:23P, Sepherosa Ziehau wrote:
>> Author: sephe
>> Date: Fri Apr 29 07:23:08 2016
>> New Revision: 298769
>> URL: https://svnweb.freebsd.org/changeset/base/298769
>>
>> Log:
>>   tcp/syncache: Set flowid and hash type properly for SYN|ACK
>>
>>   So the underlying drivers can use it to select the sending queue
>>   properly for SYN|ACK instead of rolling their own hash.
>>
>>   Sponsored by:   Microsoft OSTC
>>   Differential Revision:  https://reviews.freebsd.org/D6120
>>
>> Modified:
>>   head/sys/netinet/tcp_syncache.c
>
> Would it be possible to MFC this?

I _think_ we can :)

Thanks,
sephe

-- 
Tomorrow Will Never Die
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r298769 - head/sys/netinet

2016-04-29 Thread hiren panchasara 
On 04/29/16 at 07:23P, Sepherosa Ziehau wrote:
> Author: sephe
> Date: Fri Apr 29 07:23:08 2016
> New Revision: 298769
> URL: https://svnweb.freebsd.org/changeset/base/298769
> 
> Log:
>   tcp/syncache: Set flowid and hash type properly for SYN|ACK
>   
>   So the underlying drivers can use it to select the sending queue
>   properly for SYN|ACK instead of rolling their own hash.
>   
>   Sponsored by:   Microsoft OSTC
>   Differential Revision:  https://reviews.freebsd.org/D6120
> 
> Modified:
>   head/sys/netinet/tcp_syncache.c

Would it be possible to MFC this?

Cheers,
Hiren


pgpfS0rnfSu5Y.pgp
Description: PGP signature

svn commit: r298769 - head/sys/netinet

2016-04-29 Thread Sepherosa Ziehau 
Author: sephe
Date: Fri Apr 29 07:23:08 2016
New Revision: 298769
URL: https://svnweb.freebsd.org/changeset/base/298769

Log:
  tcp/syncache: Set flowid and hash type properly for SYN|ACK
  
  So the underlying drivers can use it to select the sending queue
  properly for SYN|ACK instead of rolling their own hash.
  
  Sponsored by: Microsoft OSTC
  Differential Revision:https://reviews.freebsd.org/D6120

Modified:
  head/sys/netinet/tcp_syncache.c

Modified: head/sys/netinet/tcp_syncache.c
==
--- head/sys/netinet/tcp_syncache.c Fri Apr 29 05:28:40 2016
(r298768)
+++ head/sys/netinet/tcp_syncache.c Fri Apr 29 07:23:08 2016
(r298769)
@@ -127,7 +127,8 @@ SYSCTL_INT(_net_inet_tcp, OID_AUTO, sync
 static void syncache_drop(struct syncache *, struct syncache_head *);
 static void syncache_free(struct syncache *);
 static void syncache_insert(struct syncache *, struct syncache_head *);
-static int  syncache_respond(struct syncache *, struct syncache_head *, 
int);
+static int  syncache_respond(struct syncache *, struct syncache_head *, 
int,
+   const struct mbuf *);
 static struct   socket *syncache_socket(struct syncache *, struct socket *,
struct mbuf *m);
 static void syncache_timeout(struct syncache *sc, struct syncache_head 
*sch,
@@ -457,7 +458,7 @@ syncache_timer(void *xsch)
free(s, M_TCPLOG);
}
 
-   syncache_respond(sc, sch, 1);
+   syncache_respond(sc, sch, 1, NULL);
TCPSTAT_INC(tcps_sc_retransmitted);
syncache_timeout(sc, sch, 0);
}
@@ -1307,7 +1308,7 @@ syncache_add(struct in_conninfo *inc, st
s, __func__);
free(s, M_TCPLOG);
}
-   if (syncache_respond(sc, sch, 1) == 0) {
+   if (syncache_respond(sc, sch, 1, m) == 0) {
sc->sc_rxmits = 0;
syncache_timeout(sc, sch, 1);
TCPSTAT_INC(tcps_sndacks);
@@ -1474,7 +1475,7 @@ skip_alloc:
/*
 * Do a standard 3-way handshake.
 */
-   if (syncache_respond(sc, sch, 0) == 0) {
+   if (syncache_respond(sc, sch, 0, m) == 0) {
if (V_tcp_syncookies && V_tcp_syncookiesonly && sc != &scs)
syncache_free(sc);
else if (sc != &scs)
@@ -1505,7 +1506,8 @@ tfo_done:
 }
 
 static int
-syncache_respond(struct syncache *sc, struct syncache_head *sch, int locked)
+syncache_respond(struct syncache *sc, struct syncache_head *sch, int locked,
+const struct mbuf *m0)
 {
struct ip *ip = NULL;
struct mbuf *m;
@@ -1686,6 +1688,10 @@ syncache_respond(struct syncache *sc, st
 
M_SETFIB(m, sc->sc_inc.inc_fibnum);
m->m_pkthdr.csum_data = offsetof(struct tcphdr, th_sum);
+   if (m0 != NULL && M_HASHTYPE_GET(m0) != M_HASHTYPE_NONE) {
+   m->m_pkthdr.flowid = m0->m_pkthdr.flowid;
+   M_HASHTYPE_SET(m, M_HASHTYPE_GET(m0));
+   }
 #ifdef INET6
if (sc->sc_inc.inc_flags & INC_ISIPV6) {
m->m_pkthdr.csum_flags = CSUM_TCP_IPV6;
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"