Re: svn commit: r329148 - head/etc/devd

2018-02-13 Thread Warner Losh 
On Tue, Feb 13, 2018 at 2:04 AM, Hans Petter Selasky 
wrote:

> On 02/12/18 20:13, Renato Botelho wrote:
>
>> On 12/02/18 02:45, Warner Losh wrote:
>>
>>> Author: imp
>>> Date: Mon Feb 12 04:45:26 2018
>>> New Revision: 329148
>>> URL: https://svnweb.freebsd.org/changeset/base/329148
>>>
>>> Log:
>>>Switch to using devmatch to autoload drivers. Remove usb.conf
>>>as obsolete because devmatch gets its information from the same
>>>place as the genration scripts.
>>>
>>> Added:
>>>head/etc/devd/devmatch.conf   (contents, props changed)
>>> Deleted:
>>>head/etc/devd/usb.conf
>>>
>>> Added: head/etc/devd/devmatch.conf
>>> 
>>> ==
>>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>>> +++ head/etc/devd/devmatch.conf Mon Feb 12 04:45:26 2018(r329148)
>>> @@ -0,0 +1,13 @@
>>> +#
>>> +# $FreeBSD$
>>> +#
>>> +
>>> +#
>>> +# Example devd configuration file for automatically
>>> +# loading what modules we can based on nomatch
>>> +# events.
>>> +#
>>> +# Generic NOMATCH event
>>> +nomatch 100 {
>>> +   action "service devmatch onestart"
>>>
>>
>> Config syntax is broken. It's missing ; in the end of above line
>>
>>
> I've just fixed this in r329194.
>
> BTW: I see another annoying issue. Devmatch, when it receives a NOMATCH
> event, should limit the searching to the current system. I.E. when you plug
> a USB device, devmatch should not search PCI drivers aswell.
>
> Warner, can you add this support?


Yes, but on boot, it's still going to match everything because all the
NOMATCH events are in the queue.

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329148 - head/etc/devd

2018-02-13 Thread Hans Petter Selasky 

On 02/12/18 20:13, Renato Botelho wrote:

On 12/02/18 02:45, Warner Losh wrote:

Author: imp
Date: Mon Feb 12 04:45:26 2018
New Revision: 329148
URL: https://svnweb.freebsd.org/changeset/base/329148

Log:
   Switch to using devmatch to autoload drivers. Remove usb.conf
   as obsolete because devmatch gets its information from the same
   place as the genration scripts.

Added:
   head/etc/devd/devmatch.conf   (contents, props changed)
Deleted:
   head/etc/devd/usb.conf

Added: head/etc/devd/devmatch.conf
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/etc/devd/devmatch.conf Mon Feb 12 04:45:26 2018(r329148)
@@ -0,0 +1,13 @@
+#
+# $FreeBSD$
+#
+
+#
+# Example devd configuration file for automatically
+# loading what modules we can based on nomatch
+# events.
+#
+# Generic NOMATCH event
+nomatch 100 {
+   action "service devmatch onestart"


Config syntax is broken. It's missing ; in the end of above line



I've just fixed this in r329194.

BTW: I see another annoying issue. Devmatch, when it receives a NOMATCH 
event, should limit the searching to the current system. I.E. when you 
plug a USB device, devmatch should not search PCI drivers aswell.


Warner, can you add this support?

--HPS
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329148 - head/etc/devd

2018-02-12 Thread Renato Botelho 
On 12/02/18 02:45, Warner Losh wrote:
> Author: imp
> Date: Mon Feb 12 04:45:26 2018
> New Revision: 329148
> URL: https://svnweb.freebsd.org/changeset/base/329148
> 
> Log:
>   Switch to using devmatch to autoload drivers. Remove usb.conf
>   as obsolete because devmatch gets its information from the same
>   place as the genration scripts.
> 
> Added:
>   head/etc/devd/devmatch.conf   (contents, props changed)
> Deleted:
>   head/etc/devd/usb.conf
> 
> Added: head/etc/devd/devmatch.conf
> ==
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ head/etc/devd/devmatch.conf   Mon Feb 12 04:45:26 2018
> (r329148)
> @@ -0,0 +1,13 @@
> +#
> +# $FreeBSD$
> +#
> +
> +#
> +# Example devd configuration file for automatically
> +# loading what modules we can based on nomatch
> +# events.
> +#
> +# Generic NOMATCH event
> +nomatch 100 {
> + action "service devmatch onestart"

Config syntax is broken. It's missing ; in the end of above line

-- 
Renato Botelho
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329148 - head/etc/devd

2018-02-12 Thread John Baldwin 
On Monday, February 12, 2018 04:45:26 AM Warner Losh wrote:
> Author: imp
> Date: Mon Feb 12 04:45:26 2018
> New Revision: 329148
> URL: https://svnweb.freebsd.org/changeset/base/329148
> 
> Log:
>   Switch to using devmatch to autoload drivers. Remove usb.conf
>   as obsolete because devmatch gets its information from the same
>   place as the genration scripts.
> 
> Added:
>   head/etc/devd/devmatch.conf   (contents, props changed)
> Deleted:
>   head/etc/devd/usb.conf

This is a bigger hammer.  The old approach only loaded the specific driver
for the device plugged in.  This might load other drivers as well which users
might find surprising.

-- 
John Baldwin
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329148 - head/etc/devd

2018-02-11 Thread Warner Losh 
On Feb 11, 2018 10:08 PM, "Rodney W. Grimes" 
wrote:

> Author: imp
> Date: Mon Feb 12 04:45:26 2018
> New Revision: 329148
> URL: https://svnweb.freebsd.org/changeset/base/329148
>
> Log:
>   Switch to using devmatch to autoload drivers. Remove usb.conf
>   as obsolete because devmatch gets its information from the same
>   place as the genration scripts.
>
> Added:
>   head/etc/devd/devmatch.conf   (contents, props changed)
> Deleted:
>   head/etc/devd/usb.conf

I know you did this in a hurry and as you said while angry,
perhaps take a day and step back?  I think this was rather
hap hazzard, and now devmatch is stucking files in devd that
is to be obsoleted, is this really how we want this nice
clean solution to start its new life?



No time like the present.


> Added: head/etc/devd/devmatch.conf

Shouldnt this gone to head/etc/devmatch?


No.

Warner

> 
==
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ head/etc/devd/devmatch.conf   Mon Feb 12 04:45:26 2018
(r329148)
> @@ -0,0 +1,13 @@
> +#
> +# $FreeBSD$
> +#
> +
> +#
> +# Example devd configuration file for automatically
> +# loading what modules we can based on nomatch
> +# events.
> +#
> +# Generic NOMATCH event
> +nomatch 100 {
> + action "service devmatch onestart"
> +};
>
>

--
Rod Grimes
rgri...@freebsd.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r329148 - head/etc/devd

2018-02-11 Thread Rodney W. Grimes 
> Author: imp
> Date: Mon Feb 12 04:45:26 2018
> New Revision: 329148
> URL: https://svnweb.freebsd.org/changeset/base/329148
> 
> Log:
>   Switch to using devmatch to autoload drivers. Remove usb.conf
>   as obsolete because devmatch gets its information from the same
>   place as the genration scripts.
> 
> Added:
>   head/etc/devd/devmatch.conf   (contents, props changed)
> Deleted:
>   head/etc/devd/usb.conf

I know you did this in a hurry and as you said while angry,
perhaps take a day and step back?  I think this was rather
hap hazzard, and now devmatch is stucking files in devd that
is to be obsoleted, is this really how we want this nice
clean solution to start its new life?


> Added: head/etc/devd/devmatch.conf

Shouldnt this gone to head/etc/devmatch?

> ==
> --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> +++ head/etc/devd/devmatch.conf   Mon Feb 12 04:45:26 2018
> (r329148)
> @@ -0,0 +1,13 @@
> +#
> +# $FreeBSD$
> +#
> +
> +#
> +# Example devd configuration file for automatically
> +# loading what modules we can based on nomatch
> +# events.
> +#
> +# Generic NOMATCH event
> +nomatch 100 {
> + action "service devmatch onestart"
> +};
> 
> 

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r329148 - head/etc/devd

2018-02-11 Thread Warner Losh 
Author: imp
Date: Mon Feb 12 04:45:26 2018
New Revision: 329148
URL: https://svnweb.freebsd.org/changeset/base/329148

Log:
  Switch to using devmatch to autoload drivers. Remove usb.conf
  as obsolete because devmatch gets its information from the same
  place as the genration scripts.

Added:
  head/etc/devd/devmatch.conf   (contents, props changed)
Deleted:
  head/etc/devd/usb.conf

Added: head/etc/devd/devmatch.conf
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/etc/devd/devmatch.conf Mon Feb 12 04:45:26 2018(r329148)
@@ -0,0 +1,13 @@
+#
+# $FreeBSD$
+#
+
+#
+# Example devd configuration file for automatically
+# loading what modules we can based on nomatch
+# events.
+#
+# Generic NOMATCH event
+nomatch 100 {
+   action "service devmatch onestart"
+};
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"