Re: svn commit: r332512 - head/sys/conf

[Brooks Davis]

On Sun, Apr 15, 2018 at 07:28:29PM +0200, Dimitry Andric wrote:
> On 15 Apr 2018, at 17:37, Brooks Davis  wrote:
> > 
> > On Sun, Apr 15, 2018 at 10:33:18AM -0500, Benjamin Kaduk wrote:
> >> On Sun, Apr 15, 2018 at 10:13 AM, Brooks Davis  wrote:
> >> 
> >>> On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote:
>  Author: brooks
>  Date: Sun Apr 15 15:06:07 2018
>  New Revision: 332512
>  URL: https://svnweb.freebsd.org/changeset/base/332512
>  
>  Log:
>   Remove device cm which was removed in r332490.
> >>> 
> >>> I'm quite confused by the fact that tinderbox didn't trip on this when I
> >>> ran it.  Are -DNO_CLEAN tinderbox builds insufficent for device removal?
> >>> 
> >> 
> >> Given that they would leave around the old object files needed to resolve
> >> stale
> >> references to removed driver components, it seems likely.
> > 
> > The thing is, config should have failed and it always runs in
> > -DNO_CLEAN buildkernel.  I expected the same to hold for tinderbox, but
> > apparently not.
> 
> But were any of the LINT files updated?  I guess not, if you didn't
> remove anything from NOTES.  I think it is likely that config will *not*
> be run again if the LINT files are older than their respective targets?

NOTES was updated because I did remove device arcnet, I just somehow
failed to find the cm(4) entries.  I'll just try to remember to do
-DNO_CLEAN kernel builds for future removals.

-- Brooks


signature.asc
Description: PGP signature

Re: svn commit: r332512 - head/sys/conf

[Dimitry Andric]

On 15 Apr 2018, at 17:37, Brooks Davis  wrote:
> 
> On Sun, Apr 15, 2018 at 10:33:18AM -0500, Benjamin Kaduk wrote:
>> On Sun, Apr 15, 2018 at 10:13 AM, Brooks Davis  wrote:
>> 
>>> On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote:
 Author: brooks
 Date: Sun Apr 15 15:06:07 2018
 New Revision: 332512
 URL: https://svnweb.freebsd.org/changeset/base/332512
 
 Log:
  Remove device cm which was removed in r332490.
>>> 
>>> I'm quite confused by the fact that tinderbox didn't trip on this when I
>>> ran it.  Are -DNO_CLEAN tinderbox builds insufficent for device removal?
>>> 
>> 
>> Given that they would leave around the old object files needed to resolve
>> stale
>> references to removed driver components, it seems likely.
> 
> The thing is, config should have failed and it always runs in
> -DNO_CLEAN buildkernel.  I expected the same to hold for tinderbox, but
> apparently not.

But were any of the LINT files updated?  I guess not, if you didn't
remove anything from NOTES.  I think it is likely that config will *not*
be run again if the LINT files are older than their respective targets?

-Dimitry



signature.asc
Description: Message signed with OpenPGP

Re: svn commit: r332512 - head/sys/conf

[Brooks Davis]

On Sun, Apr 15, 2018 at 10:33:18AM -0500, Benjamin Kaduk wrote:
> On Sun, Apr 15, 2018 at 10:13 AM, Brooks Davis  wrote:
> 
> > On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote:
> > > Author: brooks
> > > Date: Sun Apr 15 15:06:07 2018
> > > New Revision: 332512
> > > URL: https://svnweb.freebsd.org/changeset/base/332512
> > >
> > > Log:
> > >   Remove device cm which was removed in r332490.
> >
> > I'm quite confused by the fact that tinderbox didn't trip on this when I
> > ran it.  Are -DNO_CLEAN tinderbox builds insufficent for device removal?
> >
> 
> Given that they would leave around the old object files needed to resolve
> stale
> references to removed driver components, it seems likely.

The thing is, config should have failed and it always runs in
-DNO_CLEAN buildkernel.  I expected the same to hold for tinderbox, but
apparently not.

-- Brooks


signature.asc
Description: PGP signature

Re: svn commit: r332512 - head/sys/conf

[Benjamin Kaduk]

On Sun, Apr 15, 2018 at 10:13 AM, Brooks Davis  wrote:

> On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote:
> > Author: brooks
> > Date: Sun Apr 15 15:06:07 2018
> > New Revision: 332512
> > URL: https://svnweb.freebsd.org/changeset/base/332512
> >
> > Log:
> >   Remove device cm which was removed in r332490.
>
> I'm quite confused by the fact that tinderbox didn't trip on this when I
> ran it.  Are -DNO_CLEAN tinderbox builds insufficent for device removal?
>

Given that they would leave around the old object files needed to resolve
stale
references to removed driver components, it seems likely.

-Ben
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r332512 - head/sys/conf

[Brooks Davis]

On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote:
> Author: brooks
> Date: Sun Apr 15 15:06:07 2018
> New Revision: 332512
> URL: https://svnweb.freebsd.org/changeset/base/332512
> 
> Log:
>   Remove device cm which was removed in r332490.

I'm quite confused by the fact that tinderbox didn't trip on this when I
ran it.  Are -DNO_CLEAN tinderbox builds insufficent for device removal?

-- Brooks


signature.asc
Description: PGP signature

svn commit: r332512 - head/sys/conf

[Brooks Davis]

Author: brooks
Date: Sun Apr 15 15:06:07 2018
New Revision: 332512
URL: https://svnweb.freebsd.org/changeset/base/332512

Log:
  Remove device cm which was removed in r332490.

Modified:
  head/sys/conf/NOTES

Modified: head/sys/conf/NOTES
==
--- head/sys/conf/NOTES Sun Apr 15 08:44:26 2018(r332511)
+++ head/sys/conf/NOTES Sun Apr 15 15:06:07 2018(r332512)
@@ -2066,11 +2066,6 @@ device   xmphy   # XaQti XMAC II
 
 # Order for ISA devices is important here
 
-device cm
-hint.cm.0.at="isa"
-hint.cm.0.port="0x2e0"
-hint.cm.0.irq="9"
-hint.cm.0.maddr="0xdc000"
 device ep
 device ex
 device fe
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"