Re: svn commit: r333017 - head

[Warner Losh]

On Thu, Apr 26, 2018 at 7:47 AM, Ed Maste  wrote:

> On 26 April 2018 at 09:18, Ed Maste  wrote:
> >
> > Log:
> >   Correct r307825 BOOTSTRAPPING test for unsupported upgrade
> >
> >   __FreeBSD_version has five digits after the major number, but the min
> >   versions in the test had an extra 0 (so the test was always false).
>
> With the test adjusted I believe we should now set the minimum
> supported rel to 10.3. No 9.x release contains r286035, so if
> reporting a minimum release (as opposed to SVN rev) then 10.3 is the
> first release with the fix (r286033).
>
> That said, is it time to just bump the minimum and remove the special
> cases?
>

I added the original case so that up-to-date stable-9 systems that were at
(Juniper?) could work.

The bug was such that we don't know that it wasn't being used. It would
never trigger on those systems, so people could be using it and we'll not
know it.

Basically, we should ask Juniper first before removing it since they
specifically asked me to allow it.

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r333017 - head

[Ed Maste]

On 26 April 2018 at 09:18, Ed Maste  wrote:
>
> Log:
>   Correct r307825 BOOTSTRAPPING test for unsupported upgrade
>
>   __FreeBSD_version has five digits after the major number, but the min
>   versions in the test had an extra 0 (so the test was always false).

With the test adjusted I believe we should now set the minimum
supported rel to 10.3. No 9.x release contains r286035, so if
reporting a minimum release (as opposed to SVN rev) then 10.3 is the
first release with the fix (r286033).

That said, is it time to just bump the minimum and remove the special cases?
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r333017 - head

[Ed Maste]

Author: emaste
Date: Thu Apr 26 13:18:24 2018
New Revision: 333017
URL: https://svnweb.freebsd.org/changeset/base/333017

Log:
  Correct r307825 BOOTSTRAPPING test for unsupported upgrade
  
  __FreeBSD_version has five digits after the major number, but the min
  versions in the test had an extra 0 (so the test was always false).

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Thu Apr 26 12:23:31 2018(r333016)
+++ head/Makefile.inc1  Thu Apr 26 13:18:24 2018(r333017)
@@ -1851,9 +1851,9 @@ legacy: .PHONY
 # the version bump in r296219 (from July 29, 2015 -> Feb 29, 2016).
 .if ${BOOTSTRAPPING} != 0 && \
${WANT_COMPILER_TYPE} == "clang" && ${COMPILER_TYPE} == "clang" && 
${COMPILER_VERSION} < 30601
-.if   ${BOOTSTRAPPING} > 1000 && ${BOOTSTRAPPING} < 1002501
+.if   ${BOOTSTRAPPING} > 100 && ${BOOTSTRAPPING} < 1002501
@echo "ERROR: Source upgrades from stable/10 prior to r286033 are not 
supported."; false
-.elif ${BOOTSTRAPPING} >  900 && ${BOOTSTRAPPING} <  903509
+.elif ${BOOTSTRAPPING} >  90 && ${BOOTSTRAPPING} <  903509
@echo "ERROR: Source upgrades from stable/9 prior to r286035 are not 
supported."; false
 .endif
 .endif
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"