Re: svn commit: r350301 - head/lib/libsysdecode

[Ed Maste]

On Wed, 24 Jul 2019 at 22:04, Cy Schubert  wrote:
>
> In message <201907242106.x6ol6kam068...@repo.freebsd.org>, Ed Maste
> writes:
> > Author: emaste
> > Date: Wed Jul 24 21:06:19 2019
> > New Revision: 350301
> > URL: https://svnweb.freebsd.org/changeset/base/350301
> >
> > Log:
> >   libsysdecode: add explicit dependencies on recently changed headers
> >
> Hi Ed,
>
> This breaks 32-bit compatibility builds on amd64.

Thanks for the note and sorry about that. lwhsu had a workaround in
r350322 and it should have a proper fix as of r350327.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r350301 - head/lib/libsysdecode

[Cy Schubert]

In message <201907242106.x6ol6kam068...@repo.freebsd.org>, Ed Maste 
writes:
> Author: emaste
> Date: Wed Jul 24 21:06:19 2019
> New Revision: 350301
> URL: https://svnweb.freebsd.org/changeset/base/350301
>
> Log:
>   libsysdecode: add explicit dependencies on recently changed headers
>   
>   r349369 removed IP_MIN_MEMBERSHIPS and IPV6_MIN_MEMBERSHIPS, and r349893
>   removed TCP_RACK_SESS_CWV. libsysdecode lacked dependencies to trigger a
>   rebuild of tables.h.
>   
>   Add explicit dependencies as a workaround to address these specific
>   cases; a holistic solution is still needed.
>   
>   Sponsored by:   The FreeBSD Foundation
>
> Modified:
>   head/lib/libsysdecode/Makefile
>
> Modified: head/lib/libsysdecode/Makefile
> =
> =
> --- head/lib/libsysdecode/MakefileWed Jul 24 20:17:39 2019(r35030
> 0)
> +++ head/lib/libsysdecode/MakefileWed Jul 24 21:06:19 2019(r35030
> 1)
> @@ -123,7 +123,8 @@ CFLAGS.gcc.ioctl.c+= -Wno-redundant-decls
>  CFLAGS.gcc+= ${CFLAGS.gcc.${.IMPSRC}}
>  
>  DEPENDOBJS+= tables.h
> -tables.h: mktables
> +tables.h: mktables ${SYSROOT}/sys/netinet/in.h ${SYSROOT}/sys/netinet/tcp.h 
> \
> +${SYSROOT}/sys/netinet6/in6.h
>   sh ${.CURDIR}/mktables ${SYSROOT:U${DESTDIR}}${INCLUDEDIR} ${.TARGET}.t
> mp && \
>   mv -f ${.TARGET}.tmp ${.TARGET}
>  
>

Hi Ed,

This breaks 32-bit compatibility builds on amd64.

--- all_subdir_lib/libsysdecode ---
===> lib/libsysdecode (all)
make[5]: make[5]: don't know how to make /export/obj/opt/src/svn-current
/amd64.amd64/obj-lib32/tmp/sys/netinet/in.h. Stop

make[5]: stopped in /opt/src/svn-current/lib/libsysdecode


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX: Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r350301 - head/lib/libsysdecode

[Ed Maste]

Author: emaste
Date: Wed Jul 24 21:06:19 2019
New Revision: 350301
URL: https://svnweb.freebsd.org/changeset/base/350301

Log:
  libsysdecode: add explicit dependencies on recently changed headers
  
  r349369 removed IP_MIN_MEMBERSHIPS and IPV6_MIN_MEMBERSHIPS, and r349893
  removed TCP_RACK_SESS_CWV. libsysdecode lacked dependencies to trigger a
  rebuild of tables.h.
  
  Add explicit dependencies as a workaround to address these specific
  cases; a holistic solution is still needed.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libsysdecode/Makefile

Modified: head/lib/libsysdecode/Makefile
==
--- head/lib/libsysdecode/Makefile  Wed Jul 24 20:17:39 2019
(r350300)
+++ head/lib/libsysdecode/Makefile  Wed Jul 24 21:06:19 2019
(r350301)
@@ -123,7 +123,8 @@ CFLAGS.gcc.ioctl.c+= -Wno-redundant-decls
 CFLAGS.gcc+=   ${CFLAGS.gcc.${.IMPSRC}}
 
 DEPENDOBJS+=   tables.h
-tables.h: mktables
+tables.h: mktables ${SYSROOT}/sys/netinet/in.h ${SYSROOT}/sys/netinet/tcp.h \
+${SYSROOT}/sys/netinet6/in6.h
sh ${.CURDIR}/mktables ${SYSROOT:U${DESTDIR}}${INCLUDEDIR} 
${.TARGET}.tmp && \
mv -f ${.TARGET}.tmp ${.TARGET}
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"