Author: ae
Date: Mon Aug 19 12:42:03 2019
New Revision: 351214
URL: https://svnweb.freebsd.org/changeset/base/351214

Log:
  Use TAILQ_FOREACH_SAFE() macro to avoid use after free in soclose().
  
  PR:           239893
  MFC after:    1 week

Modified:
  head/sys/kern/uipc_socket.c

Modified: head/sys/kern/uipc_socket.c
==============================================================================
--- head/sys/kern/uipc_socket.c Mon Aug 19 11:18:36 2019        (r351213)
+++ head/sys/kern/uipc_socket.c Mon Aug 19 12:42:03 2019        (r351214)
@@ -1131,9 +1131,9 @@ drop:
        so->so_state |= SS_NOFDREF;
        sorele(so);
        if (listening) {
-               struct socket *sp;
+               struct socket *sp, *tsp;
 
-               TAILQ_FOREACH(sp, &lqueue, so_list) {
+               TAILQ_FOREACH_SAFE(sp, &lqueue, so_list, tsp) {
                        SOCK_LOCK(sp);
                        if (sp->so_count == 0) {
                                SOCK_UNLOCK(sp);
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to