Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-28 Thread Eric van Gyzen

On 5/25/20 3:37 AM, Tijl Coosemans wrote:

On Tue, 12 May 2020 15:22:41 + (UTC) Eric van Gyzen
 wrote:

Author: vangyzen
Date: Tue May 12 15:22:40 2020
New Revision: 360964
URL: https://svnweb.freebsd.org/changeset/base/360964

Log:
   Remove tests for obsolete compilers in the build system
   
   Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree.

   Assume clang is at least 6, which was in 11.2-RELEASE.  Drop conditions
   for older compilers.
   
   Reviewed by:	imp (earlier version), emaste, jhb

   MFC after:   2 weeks
   Sponsored by:Dell EMC Isilon
   Differential Revision:   https://reviews.freebsd.org/D24802


This broke devel/linux_libusb.  It is FreeBSD libusb built with Linux
gcc 4.8.5 (devel/linux-c7-devtools).  It's probably caused by the
changes to share/mk/*.

http://beefy18.nyi.freebsd.org/data/head-amd64-default/p536258_s361404/logs/linux_libusb-13.0r358841.log


This should be fixed in r361605.  Thanks for bringing it to my attention.

Eric
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-25 Thread Tijl Coosemans
On Tue, 12 May 2020 15:22:41 + (UTC) Eric van Gyzen
 wrote:
> Author: vangyzen
> Date: Tue May 12 15:22:40 2020
> New Revision: 360964
> URL: https://svnweb.freebsd.org/changeset/base/360964
> 
> Log:
>   Remove tests for obsolete compilers in the build system
>   
>   Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree.
>   Assume clang is at least 6, which was in 11.2-RELEASE.  Drop conditions
>   for older compilers.
>   
>   Reviewed by:imp (earlier version), emaste, jhb
>   MFC after:  2 weeks
>   Sponsored by:   Dell EMC Isilon
>   Differential Revision:  https://reviews.freebsd.org/D24802

This broke devel/linux_libusb.  It is FreeBSD libusb built with Linux
gcc 4.8.5 (devel/linux-c7-devtools).  It's probably caused by the
changes to share/mk/*.

http://beefy18.nyi.freebsd.org/data/head-amd64-default/p536258_s361404/logs/linux_libusb-13.0r358841.log
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-13 Thread Eric van Gyzen

> Why is this marked for MFC? FreeBSD 12 uses base GCC 4.2.1 on some platforms.

You’re right, this won’t be MFC’d.  My client is configured to add the MFC by 
default, and I failed to remove it.

Eric
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-12 Thread Brandon Bergren
Why is this marked for MFC? FreeBSD 12 uses base GCC 4.2.1 on some platforms.

On Tue, May 12, 2020, at 1:34 PM, Ravi Pokala wrote:
> This feels like it deserves an UPDATING (and possibly a RELNOTES) entry.
> 
> -Ravi (rpokala@)
> 
> -Original Message-
> From:  on behalf of Eric van Gyzen 
> 
> Date: 2020-05-12, Tuesday at 08:22
> To: , , 
> 
> Subject: svn commit: r360964 - in head: lib/libclang_rt lib/libthr 
> lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand 
> stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader 
> stand/i386/boot2 st...
> 
> Author: vangyzen
> Date: Tue May 12 15:22:40 2020
> New Revision: 360964
> URL: https://svnweb.freebsd.org/changeset/base/360964
> 
> Log:
>   Remove tests for obsolete compilers in the build system
> 
>   Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree.
>   Assume clang is at least 6, which was in 11.2-RELEASE.  Drop conditions
>   for older compilers.
> 
>   Reviewed by:imp (earlier version), emaste, jhb
>   MFC after:  2 weeks
>   Sponsored by:   Dell EMC Isilon
>   Differential Revision:  https://reviews.freebsd.org/D24802
> 
> Modified:
>   head/lib/libclang_rt/Makefile.inc
>   head/lib/libthr/Makefile
>   head/lib/msun/Makefile
>   head/libexec/rtld-elf/Makefile
>   head/libexec/tftpd/tests/Makefile
>   head/share/mk/bsd.compiler.mk
>   head/share/mk/bsd.sys.mk
>   head/stand/arm/uboot/Makefile
>   head/stand/defs.mk
>   head/stand/efi/Makefile
>   head/stand/efi/boot1/Makefile
>   head/stand/efi/loader/Makefile
>   head/stand/i386/boot2/Makefile
>   head/stand/i386/isoboot/Makefile
>   head/stand/libsa/Makefile
>   head/sys/conf/Makefile.arm
>   head/sys/conf/Makefile.powerpc
>   head/sys/conf/kern.mk
>   head/sys/conf/kern.post.mk
>   head/sys/conf/kern.pre.mk
>   head/sys/conf/kmod.mk
>   head/sys/modules/Makefile
>   head/usr.sbin/acpi/acpidb/Makefile
>   head/usr.sbin/trpt/Makefile
>   head/usr.sbin/zic/zic/Makefile
> 
> Modified: head/lib/libclang_rt/Makefile.inc
> 
> ==
> --- head/lib/libclang_rt/Makefile.inc Tue May 12 14:47:38 
> 2020  (r360963)
> +++ head/lib/libclang_rt/Makefile.inc Tue May 12 15:22:40 
> 2020  (r360964)
> @@ -32,7 +32,7 @@ CFLAGS+=${PICFLAG}
>  CFLAGS+= -fno-builtin
>  CFLAGS+= -fno-exceptions
>  CXXFLAGS+=   -fno-rtti
> -.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 30700
> +.if ${COMPILER_TYPE} == clang
>  CFLAGS+= -fno-sanitize=safe-stack
>  .endif
>  CFLAGS+= -fno-stack-protector
> 
> Modified: head/lib/libthr/Makefile
> 
> ==
> --- head/lib/libthr/Makefile  Tue May 12 14:47:38 2020
> (r360963)
> +++ head/lib/libthr/Makefile  Tue May 12 15:22:40 2020
> (r360964)
> @@ -29,10 +29,7 @@ CFLAGS+=-Winline
> 
>  CFLAGS.thr_stack.c+= -Wno-cast-align
>  CFLAGS.rtld_malloc.c+=   -Wno-cast-align
> -.include 
> -.if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} < 40300)
>  CFLAGS.thr_symbols.c+=   -Wno-missing-variable-declarations
> -.endif
> 
>  .ifndef NO_THREAD_UNWIND_STACK
>  CFLAGS+=-fexceptions
> 
> Modified: head/lib/msun/Makefile
> 
> ==
> --- head/lib/msun/MakefileTue May 12 14:47:38 2020
> (r360963)
> +++ head/lib/msun/MakefileTue May 12 15:22:40 2020
> (r360964)
> @@ -108,13 +108,13 @@ COMMON_SRCS+=   catrigl.c \
>   s_nextafterl.c s_nexttoward.c s_remquol.c s_rintl.c s_roundl.c \
>   s_scalbnl.c s_sinl.c s_sincosl.c \
>   s_tanhl.c s_tanl.c s_truncl.c w_cabsl.c
> -# Work around this warning from gcc 6:
> +# Work around this warning from gcc:
>  # lib/msun/ld80/e_powl.c:275:1: error: floating constant 
> exceeds range of
>  # 'long double' [-Werror=overflow]
>  # if( y >= LDBL_MAX )
>  # See also: 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=130067
>  .include 
> -.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 6
> +.if ${COMPILER_TYPE} == "gcc"
>  CFLAGS.e_powl.c+= -Wno-error=overflow
>  .endif
>  .endif
> 
> Modified: head/libexec/rtld-elf/Makefile
> 
> ==
> --- head/libexec/rtld-elf/MakefileTue May 12 14:47:38 
> 2020  (r360963)
> +++ head/libexec/rtld-elf/MakefileTue May 12 15:22:40 
> 2020  (r360964)
> @@ -90,8 +90,4 @@ ${PROG_FULL}:   ${VERSION_MAP}
>  # GCC warns about redeclarations even though they have __exported
>  # and are therefore not identical to the on

Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

2020-05-12 Thread Ravi Pokala
This feels like it deserves an UPDATING (and possibly a RELNOTES) entry.

-Ravi (rpokala@)

-Original Message-
From:  on behalf of Eric van Gyzen 

Date: 2020-05-12, Tuesday at 08:22
To: , , 

Subject: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun 
libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi 
stand/efi/boot1 stand/efi/loader stand/i386/boot2 st...

Author: vangyzen
Date: Tue May 12 15:22:40 2020
New Revision: 360964
URL: https://svnweb.freebsd.org/changeset/base/360964

Log:
  Remove tests for obsolete compilers in the build system

  Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree.
  Assume clang is at least 6, which was in 11.2-RELEASE.  Drop conditions
  for older compilers.

  Reviewed by:  imp (earlier version), emaste, jhb
  MFC after:2 weeks
  Sponsored by: Dell EMC Isilon
  Differential Revision:https://reviews.freebsd.org/D24802

Modified:
  head/lib/libclang_rt/Makefile.inc
  head/lib/libthr/Makefile
  head/lib/msun/Makefile
  head/libexec/rtld-elf/Makefile
  head/libexec/tftpd/tests/Makefile
  head/share/mk/bsd.compiler.mk
  head/share/mk/bsd.sys.mk
  head/stand/arm/uboot/Makefile
  head/stand/defs.mk
  head/stand/efi/Makefile
  head/stand/efi/boot1/Makefile
  head/stand/efi/loader/Makefile
  head/stand/i386/boot2/Makefile
  head/stand/i386/isoboot/Makefile
  head/stand/libsa/Makefile
  head/sys/conf/Makefile.arm
  head/sys/conf/Makefile.powerpc
  head/sys/conf/kern.mk
  head/sys/conf/kern.post.mk
  head/sys/conf/kern.pre.mk
  head/sys/conf/kmod.mk
  head/sys/modules/Makefile
  head/usr.sbin/acpi/acpidb/Makefile
  head/usr.sbin/trpt/Makefile
  head/usr.sbin/zic/zic/Makefile

Modified: head/lib/libclang_rt/Makefile.inc

==
--- head/lib/libclang_rt/Makefile.inc   Tue May 12 14:47:38 2020
(r360963)
+++ head/lib/libclang_rt/Makefile.inc   Tue May 12 15:22:40 2020
(r360964)
@@ -32,7 +32,7 @@ CFLAGS+=  ${PICFLAG}
 CFLAGS+=   -fno-builtin
 CFLAGS+=   -fno-exceptions
 CXXFLAGS+= -fno-rtti
-.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 30700
+.if ${COMPILER_TYPE} == clang
 CFLAGS+=   -fno-sanitize=safe-stack
 .endif
 CFLAGS+=   -fno-stack-protector

Modified: head/lib/libthr/Makefile

==
--- head/lib/libthr/MakefileTue May 12 14:47:38 2020
(r360963)
+++ head/lib/libthr/MakefileTue May 12 15:22:40 2020
(r360964)
@@ -29,10 +29,7 @@ CFLAGS+=-Winline

 CFLAGS.thr_stack.c+=   -Wno-cast-align
 CFLAGS.rtld_malloc.c+= -Wno-cast-align
-.include 
-.if !(${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} < 40300)
 CFLAGS.thr_symbols.c+= -Wno-missing-variable-declarations
-.endif

 .ifndef NO_THREAD_UNWIND_STACK
 CFLAGS+=-fexceptions

Modified: head/lib/msun/Makefile

==
--- head/lib/msun/Makefile  Tue May 12 14:47:38 2020(r360963)
+++ head/lib/msun/Makefile  Tue May 12 15:22:40 2020(r360964)
@@ -108,13 +108,13 @@ COMMON_SRCS+= catrigl.c \
s_nextafterl.c s_nexttoward.c s_remquol.c s_rintl.c s_roundl.c \
s_scalbnl.c s_sinl.c s_sincosl.c \
s_tanhl.c s_tanl.c s_truncl.c w_cabsl.c
-# Work around this warning from gcc 6:
+# Work around this warning from gcc:
 # lib/msun/ld80/e_powl.c:275:1: error: floating constant exceeds range 
of
 # 'long double' [-Werror=overflow]
 # if( y >= LDBL_MAX )
 # See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=130067
 .include 
-.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 6
+.if ${COMPILER_TYPE} == "gcc"
 CFLAGS.e_powl.c+= -Wno-error=overflow
 .endif
 .endif

Modified: head/libexec/rtld-elf/Makefile

==
--- head/libexec/rtld-elf/Makefile  Tue May 12 14:47:38 2020
(r360963)
+++ head/libexec/rtld-elf/Makefile  Tue May 12 15:22:40 2020
(r360964)
@@ -90,8 +90,4 @@ ${PROG_FULL}: ${VERSION_MAP}
 # GCC warns about redeclarations even though they have __exported
 # and are therefore not identical to the ones from the system headers.
 CFLAGS+=   -Wno-redundant-decls
-.if ${COMPILER_VERSION} < 40300
-# Silence -Wshadow false positives in ancient GCC
-CFLAGS+=   -Wno-shadow
-.endif
 .endif

Modified: head/libexec/tftpd/tests/Makefile

==
--- head/libexec/tftpd/tests/Mak