Re: svn commit: r364071 - head/sys/kern
Ravi Pokala wrote in : |-Original Message- |From: on behalf of Mateusz Guzik \ | |Date: 2020-08-10, Monday at 03:40 |To: , , |Subject: svn commit: r364071 - head/sys/kern | |Author: mjg |Date: Mon Aug 10 10:40:14 2020 |New Revision: 364071 |URL: https://svnweb.freebsd.org/changeset/base/364071 | |Log: | cache: strlcpy -> memcpy | |But why? Ach, i like it! I, coming from (basic ->) perl -> java -> C++ -> C always hated that C string functions which iterate stuff over and over again, but especially so if working on buffers of which the length is known. I mean, you know, if i know i have a NUL terminated buffer and its length, why in the world should i use one of those mysterious C string functions? I know there is one NUL, it is at LENGTH, dammit! I like it, several such commits flew by over the last at least weeks, and i could imagine that in a cache it also matters. --steffen | |Der Kragenbaer,The moon bear, |der holt sich munter he cheerfully and one by one |einen nach dem anderen runter wa.ks himself off |(By Robert Gernhardt) ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r364071 - head/sys/kern
-Original Message- From: on behalf of Mateusz Guzik Date: 2020-08-10, Monday at 03:40 To: , , Subject: svn commit: r364071 - head/sys/kern Author: mjg Date: Mon Aug 10 10:40:14 2020 New Revision: 364071 URL: https://svnweb.freebsd.org/changeset/base/364071 Log: cache: strlcpy -> memcpy But why? -Ravi (rpokala@) Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c == --- head/sys/kern/vfs_cache.c Mon Aug 10 10:37:16 2020 (r364070) +++ head/sys/kern/vfs_cache.c Mon Aug 10 10:40:14 2020 (r364071) @@ -1934,7 +1934,8 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, } len = ncp->nc_nlen = cnp->cn_namelen; hash = cache_get_hash(cnp->cn_nameptr, len, dvp); - strlcpy(ncp->nc_name, cnp->cn_nameptr, len + 1); + memcpy(ncp->nc_name, cnp->cn_nameptr, len); + ncp->nc_name[len] = '\0'; cache_enter_lock(, dvp, vp, hash); /* ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r364071 - head/sys/kern
Author: mjg Date: Mon Aug 10 10:40:14 2020 New Revision: 364071 URL: https://svnweb.freebsd.org/changeset/base/364071 Log: cache: strlcpy -> memcpy Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c == --- head/sys/kern/vfs_cache.c Mon Aug 10 10:37:16 2020(r364070) +++ head/sys/kern/vfs_cache.c Mon Aug 10 10:40:14 2020(r364071) @@ -1934,7 +1934,8 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, } len = ncp->nc_nlen = cnp->cn_namelen; hash = cache_get_hash(cnp->cn_nameptr, len, dvp); - strlcpy(ncp->nc_name, cnp->cn_nameptr, len + 1); + memcpy(ncp->nc_name, cnp->cn_nameptr, len); + ncp->nc_name[len] = '\0'; cache_enter_lock(, dvp, vp, hash); /* ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
