Re: svn commit: r367651 - head/usr.sbin/bhyve
On 11/13/20 5:47 PM, Ravi Pokala wrote: +#define FIRMWARE_RELEASE_DATE "11/10/2020" Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-) I wish! I'll add a comment clarifying that the specification mandates mm/dd/. -- Rebecca Cran ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367651 - head/usr.sbin/bhyve
-Original Message- From: on behalf of Jessica Clarke Date: 2020-11-13, Friday at 16:53 To: Ravi Pokala Cc: Rebecca Cran , , , Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve On 14 Nov 2020, at 00:47, Ravi Pokala wrote: > >> +#define FIRMWARE_RELEASE_DATE "11/10/2020" > > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-) Alas that is a "feature" of the specification: String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/ format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/ format is required for SMBIOS version 2.3 and later. (SMBIOS Specification version 3.4.0c) Yeah, it occurred to me that it might be something like that shortly after I hit "send". :-p It might be worth putting a comment in so people don't accidentally change it to the wrong thing in future though, given it's currently ambiguous otherwise. That would be appreciated. Thanks, Ravi (rpokala@) Jess ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367651 - head/usr.sbin/bhyve
On 14 Nov 2020, at 00:47, Ravi Pokala wrote: > >> +#define FIRMWARE_RELEASE_DATE "11/10/2020" > > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 > demand? ;-) Alas that is a "feature" of the specification: String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/ format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/ format is required for SMBIOS version 2.3 and later. (SMBIOS Specification version 3.4.0c) It might be worth putting a comment in so people don't accidentally change it to the wrong thing in future though, given it's currently ambiguous otherwise. Jess ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367651 - head/usr.sbin/bhyve
>+#define FIRMWARE_RELEASE_DATE "11/10/2020" Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-) Thanks, Ravi (rpokala@) -Original Message- From: on behalf of Rebecca Cran Date: 2020-11-13, Friday at 11:47 To: , , Subject: svn commit: r367651 - head/usr.sbin/bhyve Author: bcran Date: Fri Nov 13 19:47:16 2020 New Revision: 367651 URL: https://svnweb.freebsd.org/changeset/base/367651 Log: bhyve: update smbiostbl.c to bump the version and release date Since lots of work has been done on bhyve since 2014, increase the version to 13.0 to match 13-CURRENT, and update the release date. Reviewed by: grehan Differential Revision:https://reviews.freebsd.org/D27147 Modified: head/usr.sbin/bhyve/smbiostbl.c Modified: head/usr.sbin/bhyve/smbiostbl.c == --- head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:22:53 2020 (r367650) +++ head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:47:16 2020 (r367651) @@ -51,6 +51,9 @@ __FBSDID("$FreeBSD$"); #define SMBIOS_BASE0xF1000 +#define FIRMWARE_VERSION "13.0" +#define FIRMWARE_RELEASE_DATE "11/10/2020" + /* BHYVE_ACPI_BASE - SMBIOS_BASE) */ #defineSMBIOS_MAX_LENGTH (0xF2400 - 0xF1000) @@ -323,9 +326,9 @@ struct smbios_table_type0 smbios_type0_template = { }; const char *smbios_type0_strings[] = { - "BHYVE",/* vendor string */ - "1.00", /* bios version string */ - "03/14/2014", /* bios release date string */ + "BHYVE",/* vendor string */ + FIRMWARE_VERSION, /* bios version string */ + FIRMWARE_RELEASE_DATE, /* bios release date string */ NULL }; ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367651 - head/usr.sbin/bhyve
On 11/13/20 1:03 PM, Shawn Webb wrote: Style nit: shouldn't there be a tab between #define and the macro? Thanks, I'll try and remember that in future. -- Rebecca Cran ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367651 - head/usr.sbin/bhyve
On Fri, Nov 13, 2020 at 07:47:16PM +, Rebecca Cran wrote: > Author: bcran > Date: Fri Nov 13 19:47:16 2020 > New Revision: 367651 > URL: https://svnweb.freebsd.org/changeset/base/367651 > > Log: > bhyve: update smbiostbl.c to bump the version and release date > > Since lots of work has been done on bhyve since 2014, increase the version > to 13.0 to match 13-CURRENT, and update the release date. > > Reviewed by:grehan > Differential Revision: https://reviews.freebsd.org/D27147 > > Modified: > head/usr.sbin/bhyve/smbiostbl.c > > Modified: head/usr.sbin/bhyve/smbiostbl.c > == > --- head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:22:53 2020 > (r367650) > +++ head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:47:16 2020 > (r367651) > @@ -51,6 +51,9 @@ __FBSDID("$FreeBSD$"); > > #define SMBIOS_BASE 0xF1000 > > +#define FIRMWARE_VERSION "13.0" > +#define FIRMWARE_RELEASE_DATE"11/10/2020" Style nit: shouldn't there be a tab between #define and the macro? Thanks, -- Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc signature.asc Description: PGP signature
svn commit: r367651 - head/usr.sbin/bhyve
Author: bcran Date: Fri Nov 13 19:47:16 2020 New Revision: 367651 URL: https://svnweb.freebsd.org/changeset/base/367651 Log: bhyve: update smbiostbl.c to bump the version and release date Since lots of work has been done on bhyve since 2014, increase the version to 13.0 to match 13-CURRENT, and update the release date. Reviewed by: grehan Differential Revision:https://reviews.freebsd.org/D27147 Modified: head/usr.sbin/bhyve/smbiostbl.c Modified: head/usr.sbin/bhyve/smbiostbl.c == --- head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:22:53 2020 (r367650) +++ head/usr.sbin/bhyve/smbiostbl.c Fri Nov 13 19:47:16 2020 (r367651) @@ -51,6 +51,9 @@ __FBSDID("$FreeBSD$"); #define SMBIOS_BASE0xF1000 +#define FIRMWARE_VERSION "13.0" +#define FIRMWARE_RELEASE_DATE "11/10/2020" + /* BHYVE_ACPI_BASE - SMBIOS_BASE) */ #defineSMBIOS_MAX_LENGTH (0xF2400 - 0xF1000) @@ -323,9 +326,9 @@ struct smbios_table_type0 smbios_type0_template = { }; const char *smbios_type0_strings[] = { - "BHYVE",/* vendor string */ - "1.00", /* bios version string */ - "03/14/2014", /* bios release date string */ + "BHYVE",/* vendor string */ + FIRMWARE_VERSION, /* bios version string */ + FIRMWARE_RELEASE_DATE, /* bios release date string */ NULL }; ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"