Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Luke Howard via swift-corelibs-dev 
Also, the NSData test is broken on Darwin when libdispatch is enabled – 
possibly the system DispatchData is being pulled in and something funny 
happens, this seems to work around it but I’m not sure if it is the correct fix:

+++ b/Foundation/NSData.swift
@@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, NSMutableCopying, 
NSSecureCoding {
 }
 
 open override func isEqual(_ value: Any?) -> Bool {
-#if DEPLOYMENT_ENABLE_LIBDISPATCH
+#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX)
 if let data = value as? DispatchData {
 if data.count != length {
 return false


> On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev 
>  wrote:
> 
> Enabling libdispatch seems to break the tests on Darwin because 
> DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags 
> (both for the C/Swift compilers).
> 
> --
> www.lukehoward.com 
> soundcloud.com/lukehoward
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

--
www.lukehoward.com
soundcloud.com/lukehoward

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Chris Bailey via swift-corelibs-dev 
We're currently making the last few changes which should mean that 
Dispatch always builds on Linux if your using Foundation, and as Dispatch 
is already there on Darwin, it should mean we can remove the condition 
statements entirely. 

Chris




From:   Luke Howard via swift-corelibs-dev 
To: Tony Parker via swift-corelibs-dev 
Date:   23/08/2016 08:55
Subject:        Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin
Sent by:swift-corelibs-dev-boun...@swift.org



Also, the NSData test is broken on Darwin when libdispatch is enabled – 
possibly the system DispatchData is being pulled in and something funny 
happens, this seems to work around it but I’m not sure if it is the 
correct fix:

+++ b/Foundation/NSData.swift
@@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, 
NSMutableCopying, NSSecureCoding {
 }
 
 open override func isEqual(_ value: Any?) -> Bool {
-#if DEPLOYMENT_ENABLE_LIBDISPATCH
+#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX)
 if let data = value as? DispatchData {
 if data.count != length {
 return false


On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev <
swift-corelibs-dev@swift.org> wrote:

Enabling libdispatch seems to break the tests on Darwin because 
DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build 
flags (both for the C/Swift compilers).

--
www.lukehoward.com
soundcloud.com/lukehoward
___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

--
www.lukehoward.com
soundcloud.com/lukehoward
___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev



___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev 
Tossed up a PR for correcting this uniformly without needing alteration of the 
#if statements

https://github.com/apple/swift-corelibs-foundation/pull/584

> On Aug 23, 2016, at 8:42 AM, Chris Bailey via swift-corelibs-dev 
>  wrote:
> 
> We're currently making the last few changes which should mean that Dispatch 
> always builds on Linux if your using Foundation, and as Dispatch is already 
> there on Darwin, it should mean we can remove the condition statements 
> entirely. 
> 
> Chris
> 
> 
> 
> 
> From:Luke Howard via swift-corelibs-dev 
>  
> To:Tony Parker via swift-corelibs-dev  
> Date:    23/08/2016 08:55 
> Subject:Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin 
> Sent by:swift-corelibs-dev-boun...@swift.org 
> 
> 
> 
> Also, the NSData test is broken on Darwin when libdispatch is enabled – 
> possibly the system DispatchData is being pulled in and something funny 
> happens, this seems to work around it but I’m not sure if it is the correct 
> fix: 
> 
> +++ b/Foundation/NSData.swift 
> @@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, 
> NSMutableCopying, NSSecureCoding { 
>  } 
>   
>  open override func isEqual(_ value: Any?) -> Bool { 
> -#if DEPLOYMENT_ENABLE_LIBDISPATCH 
> +#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX) 
>  if let data = value as? DispatchData { 
>  if data.count != length { 
>  return false 
> 
> 
> On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev 
> mailto:swift-corelibs-dev@swift.org>> wrote: 
> 
> Enabling libdispatch seems to break the tests on Darwin because 
> DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags 
> (both for the C/Swift compilers). 
> 
> -- 
> www.lukehoward.com <http://www.lukehoward.com/>
> soundcloud.com/lukehoward <http://soundcloud.com/lukehoward> 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev> 
> 
> -- 
> www.lukehoward.com <http://www.lukehoward.com/>
> soundcloud.com/lukehoward 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev>
> 
> 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Luke Howard via swift-corelibs-dev 
c26f465e breaks even further on Darwin – Xcode project not updated, after 
updating that:

/Users/lukeh/CVSRoot/apple/swift-corelibs-foundation/Foundation/NSURLSession/MultiHandle.swift:216:38:
 error: '_EasyHandle' is not a member type of 'URLSessionTask'
fileprivate extension URLSessionTask._EasyHandle {
  ~~ ^

> On 24 Aug 2016, at 1:50 AM, Philippe Hausler  wrote:
> 
> Tossed up a PR for correcting this uniformly without needing alteration of 
> the #if statements
> 
> https://github.com/apple/swift-corelibs-foundation/pull/584 
> <https://github.com/apple/swift-corelibs-foundation/pull/584>
>> On Aug 23, 2016, at 8:42 AM, Chris Bailey via swift-corelibs-dev 
>> mailto:swift-corelibs-dev@swift.org>> wrote:
>> 
>> We're currently making the last few changes which should mean that Dispatch 
>> always builds on Linux if your using Foundation, and as Dispatch is already 
>> there on Darwin, it should mean we can remove the condition statements 
>> entirely. 
>> 
>> Chris
>> 
>> 
>> 
>> 
>> From:Luke Howard via swift-corelibs-dev 
>> mailto:swift-corelibs-dev@swift.org>> 
>> To:    Tony Parker via swift-corelibs-dev > <mailto:swift-corelibs-dev@swift.org>> 
>> Date:23/08/2016 08:55 
>> Subject:Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin 
>> Sent by:swift-corelibs-dev-boun...@swift.org 
>> <mailto:swift-corelibs-dev-boun...@swift.org> 
>> 
>> 
>> 
>> Also, the NSData test is broken on Darwin when libdispatch is enabled – 
>> possibly the system DispatchData is being pulled in and something funny 
>> happens, this seems to work around it but I’m not sure if it is the correct 
>> fix: 
>> 
>> +++ b/Foundation/NSData.swift 
>> @@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, 
>> NSMutableCopying, NSSecureCoding { 
>>  } 
>>   
>>  open override func isEqual(_ value: Any?) -> Bool { 
>> -#if DEPLOYMENT_ENABLE_LIBDISPATCH 
>> +#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX) 
>>  if let data = value as? DispatchData { 
>>  if data.count != length { 
>>  return false 
>> 
>> 
>> On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev 
>> mailto:swift-corelibs-dev@swift.org>> wrote: 
>> 
>> Enabling libdispatch seems to break the tests on Darwin because 
>> DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags 
>> (both for the C/Swift compilers). 
>> 
>> -- 
>> www.lukehoward.com <http://www.lukehoward.com/>
>> soundcloud.com/lukehoward <http://soundcloud.com/lukehoward> 
>> ___
>> swift-corelibs-dev mailing list
>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
>> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev> 
>> 
>> -- 
>> www.lukehoward.com <http://www.lukehoward.com/>
>> soundcloud.com/lukehoward <http://soundcloud.com/lukehoward> 
>> ___
>> swift-corelibs-dev mailing list
>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
>> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev>
>> 
>> 
>> ___
>> swift-corelibs-dev mailing list
>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
> 

--
www.lukehoward.com
soundcloud.com/lukehoward

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev 
Looks like there was a merge done without the requirement that I set forth in 
the pull request. This means the Xcode project is properly broken now.

> On Aug 23, 2016, at 4:14 PM, Luke Howard via swift-corelibs-dev 
>  wrote:
> 
> c26f465e breaks even further on Darwin – Xcode project not updated, after 
> updating that:
> 
> /Users/lukeh/CVSRoot/apple/swift-corelibs-foundation/Foundation/NSURLSession/MultiHandle.swift:216:38:
>  error: '_EasyHandle' is not a member type of 'URLSessionTask'
> fileprivate extension URLSessionTask._EasyHandle {
>   ~~ ^
> 
>> On 24 Aug 2016, at 1:50 AM, Philippe Hausler > <mailto:phaus...@apple.com>> wrote:
>> 
>> Tossed up a PR for correcting this uniformly without needing alteration of 
>> the #if statements
>> 
>> https://github.com/apple/swift-corelibs-foundation/pull/584 
>> <https://github.com/apple/swift-corelibs-foundation/pull/584>
>>> On Aug 23, 2016, at 8:42 AM, Chris Bailey via swift-corelibs-dev 
>>> mailto:swift-corelibs-dev@swift.org>> wrote:
>>> 
>>> We're currently making the last few changes which should mean that Dispatch 
>>> always builds on Linux if your using Foundation, and as Dispatch is already 
>>> there on Darwin, it should mean we can remove the condition statements 
>>> entirely. 
>>> 
>>> Chris
>>> 
>>> 
>>> 
>>> 
>>> From:    Luke Howard via swift-corelibs-dev 
>>> mailto:swift-corelibs-dev@swift.org>> 
>>> To:Tony Parker via swift-corelibs-dev >> <mailto:swift-corelibs-dev@swift.org>> 
>>> Date:23/08/2016 08:55 
>>> Subject:Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin 
>>> Sent by:swift-corelibs-dev-boun...@swift.org 
>>> <mailto:swift-corelibs-dev-boun...@swift.org> 
>>> 
>>> 
>>> 
>>> Also, the NSData test is broken on Darwin when libdispatch is enabled – 
>>> possibly the system DispatchData is being pulled in and something funny 
>>> happens, this seems to work around it but I’m not sure if it is the correct 
>>> fix: 
>>> 
>>> +++ b/Foundation/NSData.swift 
>>> @@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying, 
>>> NSMutableCopying, NSSecureCoding { 
>>>  } 
>>>   
>>>  open override func isEqual(_ value: Any?) -> Bool { 
>>> -#if DEPLOYMENT_ENABLE_LIBDISPATCH 
>>> +#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX) 
>>>  if let data = value as? DispatchData { 
>>>  if data.count != length { 
>>>  return false 
>>> 
>>> 
>>> On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev 
>>> mailto:swift-corelibs-dev@swift.org>> wrote: 
>>> 
>>> Enabling libdispatch seems to break the tests on Darwin because 
>>> DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags 
>>> (both for the C/Swift compilers). 
>>> 
>>> -- 
>>> www.lukehoward.com <http://www.lukehoward.com/>
>>> soundcloud.com/lukehoward <http://soundcloud.com/lukehoward> 
>>> ___
>>> swift-corelibs-dev mailing list
>>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
>>> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev> 
>>> 
>>> -- 
>>> www.lukehoward.com <http://www.lukehoward.com/>
>>> soundcloud.com/lukehoward <http://soundcloud.com/lukehoward> 
>>> ___
>>> swift-corelibs-dev mailing list
>>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
>>> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev>
>>> 
>>> 
>>> ___
>>> swift-corelibs-dev mailing list
>>> swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
>>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
>>> <https://lists.swift.org/mailman/listinfo/swift-corelibs-dev>
>> 
> 
> --
> www.lukehoward.com <http://www.lukehoward.com/>
> soundcloud.com/lukehoward
> 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev