Re: [swift-evolution] [Review] SE-0043 Declare variables in 'case' labels with multiple patterns

2016-03-19 Thread Patrick Gili via swift-evolution

> 
>   • What is your evaluation of the proposal?

I think anything that improves pattern matching is a good thing for Swift.

>   • Is the problem being addressed significant enough to warrant a change 
> to Swift?

Yes.

>   • Does this proposal fit well with the feel and direction of Swift?

Yes.

>   • If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?

Haskell and ML have very flexible pattern matching capabilities.

>   • How much effort did you put into your review? A glance, a quick 
> reading, or an in-depth study?
> 
Quick read.
___
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


[swift-evolution] [Review] SE-0043 Declare variables in 'case' labels with multiple patterns

2016-03-19 Thread Chris Lattner via swift-evolution
Hello Swift community,

The review of “Declare variables in 'case' labels with multiple patterns” 
begins now and runs through March 21, 2016. The proposal is available here:


https://github.com/apple/swift-evolution/blob/master/proposals/0043-declare-variables-in-case-labels-with-multiple-patterns.md

Reviews are an important part of the Swift evolution process. All reviews 
should be sent to the swift-evolution mailing list at:
https://lists.swift.org/mailman/listinfo/swift-evolution 


or, if you would like to keep your feedback private, directly to the review 
manager. When replying, please try to keep the proposal link at the top of the 
message:

What goes into a review?

The goal of the review process is to improve the proposal under review through 
constructive criticism and, eventually, determine the direction of Swift. When 
writing your review, here are some questions you might want to answer in your 
review:

• What is your evaluation of the proposal?
• Is the problem being addressed significant enough to warrant a change 
to Swift?
• Does this proposal fit well with the feel and direction of Swift?
• If you have used other languages or libraries with a similar feature, 
how do you feel that this proposal compares to those?
• How much effort did you put into your review? A glance, a quick 
reading, or an in-depth study?

More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md 


Thank you,

-Chris
Review Manager___
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


Re: [swift-evolution] [Review] SE-0043 Declare variables in 'case' labels with multiple patterns

2016-03-19 Thread Juan Ignacio Laube via swift-evolution
• What is your evaluation of the proposal?
A strong +1.


• Is the problem being addressed significant enough to warrant a change to 
Swift?
Yes.


• Does this proposal fit well with the feel and direction of Swift?
Yes.


• If you have used other languages or libraries with a similar feature, how do 
you feel that this proposal compares to those?
Other functional programming languages like Haskell has strong pattern matching 
features. I think this get us a little closer to that.


• How much effort did you put into your review? A glance, a quick reading, or 
an in-depth study?
Quick reading of the proposal.



> On Mar 16, 2016, at 2:55 PM, Chris Lattner via swift-evolution 
>  wrote:
> 
> Hello Swift community,
> 
> The review of “Declare variables in 'case' labels with multiple patterns” 
> begins now and runs through March 21, 2016. The proposal is available here:
> 
>   
> https://github.com/apple/swift-evolution/blob/master/proposals/0043-declare-variables-in-case-labels-with-multiple-patterns.md
>  
> 
> 
> Reviews are an important part of the Swift evolution process. All reviews 
> should be sent to the swift-evolution mailing list at:
>   https://lists.swift.org/mailman/listinfo/swift-evolution 
> 
> 
> or, if you would like to keep your feedback private, directly to the review 
> manager. When replying, please try to keep the proposal link at the top of 
> the message:
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review 
> through constructive criticism and, eventually, determine the direction of 
> Swift. When writing your review, here are some questions you might want to 
> answer in your review:
> 
>   • What is your evaluation of the proposal?
>   • Is the problem being addressed significant enough to warrant a change 
> to Swift?
>   • Does this proposal fit well with the feel and direction of Swift?
>   • If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?
>   • How much effort did you put into your review? A glance, a quick 
> reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at:
> 
> https://github.com/apple/swift-evolution/blob/master/process.md 
> 
> 
> Thank you,
> 
> -Chris
> Review Manager
> ___
> swift-evolution mailing list
> swift-evolution@swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

___
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


Re: [swift-evolution] [Review] SE-0043 Declare variables in 'case' labels with multiple patterns

2016-03-19 Thread Greg Titus via swift-evolution

> On Mar 16, 2016, at 10:55 AM, Chris Lattner via swift-evolution 
>  wrote:
> 
> The review of “Declare variables in 'case' labels with multiple patterns” 
> begins now and runs through March 21, 2016. The proposal is available here:
> 
>   
> https://github.com/apple/swift-evolution/blob/master/proposals/0043-declare-variables-in-case-labels-with-multiple-patterns.md
>  
> 
> 
>   • What is your evaluation of the proposal?

+1!

>   • Is the problem being addressed significant enough to warrant a change 
> to Swift?

Absolutely. The lack of this feature causes a lot of extra boilerplate or 
workarounds when dealing with enums.

>   • Does this proposal fit well with the feel and direction of Swift?

Yes. I was surprised the language didn’t already include it. It seems natural.

>   • If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?

I’ve used pattern matching in Haskell quite a bit and this Swift feature serves 
the same purpose and is really almost a necessary removal of a pattern matching 
limitation.

>   • How much effort did you put into your review? A glance, a quick 
> reading, or an in-depth study?

I spent enough effort on it to implement most of it in the compiler. :-)

> More information about the Swift evolution process is available at:
> 
> https://github.com/apple/swift-evolution/blob/master/process.md 
> 
> 
> Thank you,
> 
> -Chris
> Review Manager
> ___
> swift-evolution mailing list
> swift-evolution@swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

___
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


Re: [swift-evolution] [Review] SE-0043 Declare variables in 'case' labels with multiple patterns

2016-03-18 Thread Sebastian Hagedorn via swift-evolution
> • What is your evaluation of the proposal?

+1

> • Is the problem being addressed significant enough to warrant a change to 
> Swift?

Yes, I’ve come across the issue a few times.

> • Does this proposal fit well with the feel and direction of Swift?

To me the solution seems a lot more intuitive than the proposed alternatives, 
so yes!

> • If you have used other languages or libraries with a similar feature, how 
> do you feel that this proposal compares to those?

–

> • How much effort did you put into your review? A glance, a quick reading, or 
> an in-depth study?

Read the proposal, and I’ve thought about the issue before when stumbling over 
this in my own code.


> On 16 Mar 2016, at 18:55, Chris Lattner via swift-evolution 
>  wrote:
> 
> Hello Swift community,
> 
> The review of “Declare variables in 'case' labels with multiple patterns” 
> begins now and runs through March 21, 2016. The proposal is available here:
> 
>   
> https://github.com/apple/swift-evolution/blob/master/proposals/0043-declare-variables-in-case-labels-with-multiple-patterns.md
>  
> 
> 
> Reviews are an important part of the Swift evolution process. All reviews 
> should be sent to the swift-evolution mailing list at:
>   https://lists.swift.org/mailman/listinfo/swift-evolution 
> 
> 
> or, if you would like to keep your feedback private, directly to the review 
> manager. When replying, please try to keep the proposal link at the top of 
> the message:
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review 
> through constructive criticism and, eventually, determine the direction of 
> Swift. When writing your review, here are some questions you might want to 
> answer in your review:
> 
>   • What is your evaluation of the proposal?
>   • Is the problem being addressed significant enough to warrant a change 
> to Swift?
>   • Does this proposal fit well with the feel and direction of Swift?
>   • If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?
>   • How much effort did you put into your review? A glance, a quick 
> reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at:
> 
> https://github.com/apple/swift-evolution/blob/master/process.md 
> 
> 
> Thank you,
> 
> -Chris
> Review Manager
> ___
> swift-evolution mailing list
> swift-evolution@swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

___
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution