Re: [9] Review request for JDK-7070795 High contrast colour scheme fails to be applied to JFormattedTextField
The fix looks fine. Note that in the test the count of characters for JFormattedTextFieldTest is set to 5, but 6 is used. On 19.05.16 18:25, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-7070795 Webrev : http://cr.openjdk.java.net/~rchamyal/7070795/webrev.00/ Issue: On changing the Windows theme to high contrast the high contrast color scheme is not getting applied to JFormattedTextFiled. Fix: Updated Formatted text field foreground and background properties. Regards, Rajeev Chamyal -- Best regards, Sergey.
[9] Review request for JDK-7070795 High contrast colour scheme fails to be applied to JFormattedTextField
Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-7070795 Webrev : http://cr.openjdk.java.net/~rchamyal/7070795/webrev.00/ Issue: On changing the Windows theme to high contrast the high contrast color scheme is not getting applied to JFormattedTextFiled. Fix: Updated Formatted text field foreground and background properties. Regards, Rajeev Chamyal
Re: [9] Review request for 8157322: Several typos in javadoc
Hi Sergey, Thank you for the review. I will update the fix based on your suggestion. Thanks, Dmitry On 19/05/2016 14:24, Sergey Bylokhov wrote: Hi, Dmitry. Looks fine, but can you please maintain 80 chars per line in the files where this rule was applied already(UnsupportedAudioFileException.java for example). It is not necessary to send a new webrev. On 19.05.16 13:35, dmitry markov wrote: Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8157322 webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/ Fixed several typos in client libraries javadoc. Thanks, Dmitry
Re: [9] Review request for 8157322: Several typos in javadoc
Hi, Dmitry. Looks fine, but can you please maintain 80 chars per line in the files where this rule was applied already(UnsupportedAudioFileException.java for example). It is not necessary to send a new webrev. On 19.05.16 13:35, dmitry markov wrote: Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8157322 webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/ Fixed several typos in client libraries javadoc. Thanks, Dmitry -- Best regards, Sergey.
Re: [9] Review request for 8157322: Several typos in javadoc
Hello Dmitry Looks just great! Thanks alexp On 5/19/2016 13:35, dmitry markov wrote: Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8157322 webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/ Fixed several typos in client libraries javadoc. Thanks, Dmitry
[9] Review request for 8157322: Several typos in javadoc
Hello, Could you review a simple fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8157322 webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/ Fixed several typos in client libraries javadoc. Thanks, Dmitry
Re: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked
Looks fine. On 19.05.16 8:31, Ajit Ghaisas wrote: Thanks for the review. I have corrected the test case to dispose the window if the test fails. Here is the updated webrev. http://cr.openjdk.java.net/~aghaisas/7172750/webrev.02/ Regards, Ajit -Original Message- From: Sergey Bylokhov Sent: Wednesday, May 18, 2016 10:30 PM To: Ajit Ghaisas; Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Hi, Ajit. The fix looks fine. one note about the test, please dispose the window if the test fails. Currently disposeTestUI() will be skipped in case of any exceptions. On 17.05.16 13:19, Ajit Ghaisas wrote: Thanks for the review. I have updated the test case to include suggested corrections. Please review : http://cr.openjdk.java.net/~aghaisas/7172750/webrev.01/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Tuesday, May 17, 2016 2:27 PM To: Ajit Ghaisas; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Hello Ajit, Fix looks fine to me. Few comments about test case. 1) @run main is missing in test. 2) JFrame dispose should be done in swing thread. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 06 May 2016 12:52 To: Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7172750 Issue : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Root Cause : There is no differentiation between 'MouseOver' and Mouse 'Pressed' in scroll thumb painting. Fix : 1. Used existing member boolean 'dragging' from BasicScrollBarUI class in SynthScrollBarUI class to differentiate between "mouse over" and "mouse pressed" state. 2. Added a test case - it passes on Windows, Linux and Mac. Please review the webrev : http://cr.openjdk.java.net/~aghaisas/7172750/webrev.00/ Regards, Ajit -- Best regards, Sergey. -- Best regards, Sergey.
