Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
The fix looks good to me. Thanks, Alexandr. On 7/21/2016 1:34 PM, Rajeev Chamyal wrote: Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 21 July 2016 15:13 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Fixed a typo in comment (from lable to label) http://cr.openjdk.java.net/~aghaisas/7096375/webrev.04/ Regards, Ajit -Original Message- From: Ajit Ghaisas Sent: Thursday, July 21, 2016 11:41 AM To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Good catch. I have corrected the test case. Please review. http://cr.openjdk.java.net/~aghaisas/7096375/webrev.03/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Thursday, July 21, 2016 11:16 AM To: Ajit Ghaisas; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hello Ajit, Frame dispose is called twice in case pass/fail button are pressed. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 20 July 2016 17:50 To: Alexander Scherbatiy; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: Hi, I have modified the test as per suggestion. Please review the updated webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Tuesday, July 19, 2016 2:33 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding mouse press events to handle multiClickThreshold. The condition to discard mouse press event is corrected. Webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ Request you to review. The template used for the test is rather old. It is better to use CountDownLatch for the manual test synchronization. Could you rewrite the test using the TitledBorderTest as a sample: http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/java x/swing/LookAndFeel/6439354/TitledBorderTest.java There can be added two simple changes. The thread creation is not necessary because the runnable can be directly executed by SwingUtilities.invokeAndWait(). The timeout can be added to the latch.await() call. Thanks, Alexandr. Regards, Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 21 July 2016 15:13 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Fixed a typo in comment (from lable to label) http://cr.openjdk.java.net/~aghaisas/7096375/webrev.04/ Regards, Ajit -Original Message- From: Ajit Ghaisas Sent: Thursday, July 21, 2016 11:41 AM To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Good catch. I have corrected the test case. Please review. http://cr.openjdk.java.net/~aghaisas/7096375/webrev.03/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Thursday, July 21, 2016 11:16 AM To: Ajit Ghaisas; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hello Ajit, Frame dispose is called twice in case pass/fail button are pressed. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 20 July 2016 17:50 To: Alexander Scherbatiy; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: > Hi, > > I have modified the test as per suggestion. > > Please review the updated webrev : > http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. > > Regards, > Ajit > > -Original Message- > From: Alexandr Scherbatiy > Sent: Tuesday, July 19, 2016 2:33 PM > To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal > Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after > decreasing system's time > > On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: >> Hi, >> >> Bug : >> https://bugs.openjdk.java.net/browse/JDK-7096375 >> Swing ignores first click after decreasing system's time. >> >> Fix : >> BasicButtonListener keeps track of the last time when a button is >> pressed. >> This is used while discarding mouse press events to handle >> multiClickThreshold. >> The condition to discard mouse press event is corrected. >> >> Webrev : >> http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ >> >> Request you to review. > The template used for the test is rather old. It is better to use > CountDownLatch for the manual test synchronization. > Could you rewrite the test using the TitledBorderTest as a sample: > http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/java > x/swing/LookAndFeel/6439354/TitledBorderTest.java > > There can be added two simple changes. The thread creation is not > necessary because the runnable can be directly executed by > SwingUtilities.invokeAndWait(). The timeout can be added to the > latch.await() call. > > Thanks, > Alexandr. >> Regards, >> Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Fixed a typo in comment (from lable to label) http://cr.openjdk.java.net/~aghaisas/7096375/webrev.04/ Regards, Ajit -Original Message- From: Ajit Ghaisas Sent: Thursday, July 21, 2016 11:41 AM To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Good catch. I have corrected the test case. Please review. http://cr.openjdk.java.net/~aghaisas/7096375/webrev.03/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Thursday, July 21, 2016 11:16 AM To: Ajit Ghaisas; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hello Ajit, Frame dispose is called twice in case pass/fail button are pressed. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 20 July 2016 17:50 To: Alexander Scherbatiy; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: > Hi, > > I have modified the test as per suggestion. > > Please review the updated webrev : > http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. > > Regards, > Ajit > > -Original Message- > From: Alexandr Scherbatiy > Sent: Tuesday, July 19, 2016 2:33 PM > To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal > Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after > decreasing system's time > > On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: >> Hi, >> >> Bug : >> https://bugs.openjdk.java.net/browse/JDK-7096375 >> Swing ignores first click after decreasing system's time. >> >> Fix : >> BasicButtonListener keeps track of the last time when a button is >> pressed. >> This is used while discarding mouse press events to handle >> multiClickThreshold. >> The condition to discard mouse press event is corrected. >> >> Webrev : >> http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ >> >> Request you to review. > The template used for the test is rather old. It is better to use > CountDownLatch for the manual test synchronization. > Could you rewrite the test using the TitledBorderTest as a sample: > http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/java > x/swing/LookAndFeel/6439354/TitledBorderTest.java > > There can be added two simple changes. The thread creation is not > necessary because the runnable can be directly executed by > SwingUtilities.invokeAndWait(). The timeout can be added to the > latch.await() call. > > Thanks, > Alexandr. >> Regards, >> Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Good catch. I have corrected the test case. Please review. http://cr.openjdk.java.net/~aghaisas/7096375/webrev.03/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Thursday, July 21, 2016 11:16 AM To: Ajit Ghaisas; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hello Ajit, Frame dispose is called twice in case pass/fail button are pressed. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 20 July 2016 17:50 To: Alexander Scherbatiy; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: > Hi, > > I have modified the test as per suggestion. > > Please review the updated webrev : > http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. > > Regards, > Ajit > > -Original Message- > From: Alexandr Scherbatiy > Sent: Tuesday, July 19, 2016 2:33 PM > To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal > Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after > decreasing system's time > > On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: >> Hi, >> >> Bug : >> https://bugs.openjdk.java.net/browse/JDK-7096375 >> Swing ignores first click after decreasing system's time. >> >> Fix : >> BasicButtonListener keeps track of the last time when a button is >> pressed. >> This is used while discarding mouse press events to handle >> multiClickThreshold. >> The condition to discard mouse press event is corrected. >> >> Webrev : >> http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ >> >> Request you to review. > The template used for the test is rather old. It is better to use > CountDownLatch for the manual test synchronization. > Could you rewrite the test using the TitledBorderTest as a sample: > http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/java > x/swing/LookAndFeel/6439354/TitledBorderTest.java > > There can be added two simple changes. The thread creation is not > necessary because the runnable can be directly executed by > SwingUtilities.invokeAndWait(). The timeout can be added to the > latch.await() call. > > Thanks, > Alexandr. >> Regards, >> Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Hi, Added throwing exception in case create UI or dispose UI fails. Here is the updated webrev: http://cr.openjdk.java.net/~aghaisas/7096375/webrev.02/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Wednesday, July 20, 2016 5:13 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: > Hi, > > I have modified the test as per suggestion. > > Please review the updated webrev : > http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. > > Regards, > Ajit > > -Original Message- > From: Alexandr Scherbatiy > Sent: Tuesday, July 19, 2016 2:33 PM > To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal > Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after > decreasing system's time > > On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: >> Hi, >> >> Bug : >> https://bugs.openjdk.java.net/browse/JDK-7096375 >> Swing ignores first click after decreasing system's time. >> >> Fix : >> BasicButtonListener keeps track of the last time when a button is >> pressed. >> This is used while discarding mouse press events to handle >> multiClickThreshold. >> The condition to discard mouse press event is corrected. >> >> Webrev : >> http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ >> >> Request you to review. > The template used for the test is rather old. It is better to use > CountDownLatch for the manual test synchronization. > Could you rewrite the test using the TitledBorderTest as a sample: > http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/java > x/swing/LookAndFeel/6439354/TitledBorderTest.java > > There can be added two simple changes. The thread creation is not > necessary because the runnable can be directly executed by > SwingUtilities.invokeAndWait(). The timeout can be added to the > latch.await() call. > > Thanks, > Alexandr. >> Regards, >> Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
On 7/20/2016 1:50 PM, Ajit Ghaisas wrote: Hi, I have modified the test as per suggestion. Please review the updated webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ It is better to rethrow the exceptions during UI creation and disposing because it also means some unexpected behavior. Thanks, Alexandr. Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Tuesday, July 19, 2016 2:33 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding mouse press events to handle multiClickThreshold. The condition to discard mouse press event is corrected. Webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ Request you to review. The template used for the test is rather old. It is better to use CountDownLatch for the manual test synchronization. Could you rewrite the test using the TitledBorderTest as a sample: http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/javax/swing/LookAndFeel/6439354/TitledBorderTest.java There can be added two simple changes. The thread creation is not necessary because the runnable can be directly executed by SwingUtilities.invokeAndWait(). The timeout can be added to the latch.await() call. Thanks, Alexandr. Regards, Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Hi, I have modified the test as per suggestion. Please review the updated webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.01/ Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Tuesday, July 19, 2016 2:33 PM To: Ajit Ghaisas; swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: > Hi, > > Bug : > https://bugs.openjdk.java.net/browse/JDK-7096375 > Swing ignores first click after decreasing system's time. > > Fix : > BasicButtonListener keeps track of the last time when a button is > pressed. > This is used while discarding mouse press events to handle > multiClickThreshold. > The condition to discard mouse press event is corrected. > > Webrev : > http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ > > Request you to review. The template used for the test is rather old. It is better to use CountDownLatch for the manual test synchronization. Could you rewrite the test using the TitledBorderTest as a sample: http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/javax/swing/LookAndFeel/6439354/TitledBorderTest.java There can be added two simple changes. The thread creation is not necessary because the runnable can be directly executed by SwingUtilities.invokeAndWait(). The timeout can be added to the latch.await() call. Thanks, Alexandr. > > Regards, > Ajit
Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
On 7/18/2016 3:27 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding mouse press events to handle multiClickThreshold. The condition to discard mouse press event is corrected. Webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ Request you to review. The template used for the test is rather old. It is better to use CountDownLatch for the manual test synchronization. Could you rewrite the test using the TitledBorderTest as a sample: http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/javax/swing/LookAndFeel/6439354/TitledBorderTest.java There can be added two simple changes. The thread creation is not necessary because the runnable can be directly executed by SwingUtilities.invokeAndWait(). The timeout can be added to the latch.await() call. Thanks, Alexandr. Regards, Ajit
[9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding mouse press events to handle multiClickThreshold. The condition to discard mouse press event is corrected. Webrev : http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/ Request you to review. Regards, Ajit
