Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-27 Thread Sergey Bylokhov 

On 27.10.16 11:54, Yuri Nesterenko wrote:

Oh yes, this fix does help.
My system is not particularly slow but it is dual-screen,
Ubuntu 16.10 -- timing may differ.


A few lines below the changed lines there is a delay for 1 seconds, does 
it meant that it is not enough on your system?

 111 robot.delay(1000);
 112
 113 // On Linux platforms realSync doesn't guaranties setSize 
completion

 114 Thread.sleep(1000);



Approved.

Thanks,
-yan

On 10/27/2016 11:34 AM, Avik Niyogi wrote:

It did not fail on my system but it probably failed for slow systems in
testing environment.
Similar cases raised by Yuri had happened for several other cases which
was confirmed to be fixed by the delay by him.

With Regards,
Avik Niyogi

On 27-Oct-2016, at 1:55 pm, Prasanta Sadhukhan
>
wrote:

Hi Avik,

Did the test fail for you? I ran with the launcher auto-hidden in
ubuntu14.04 but it passed for me with the original testcode.

Regards
Prasanta
On 10/26/2016 12:39 PM, Avik Niyogi wrote:

Hi All,

Kindly review the proposed fix for JDK9.

*Bug: https://bugs.openjdk.java.net/browse/JDK-8168540*
*
*
*Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/
*
*
*
*Issue:* Animation before screen capture causes mismatch.

*Cause: *Delay before screen capture albeit provided is not enough

*Fix: *Delay provided to test case

With Regards,
Avik Niyogi









--
Best regards, Sergey.

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-27 Thread Yuri Nesterenko 

Oh yes, this fix does help.
My system is not particularly slow but it is dual-screen,
Ubuntu 16.10 -- timing may differ.

Approved.

Thanks,
-yan

On 10/27/2016 11:34 AM, Avik Niyogi wrote:

It did not fail on my system but it probably failed for slow systems in
testing environment.
Similar cases raised by Yuri had happened for several other cases which
was confirmed to be fixed by the delay by him.

With Regards,
Avik Niyogi

On 27-Oct-2016, at 1:55 pm, Prasanta Sadhukhan
>
wrote:

Hi Avik,

Did the test fail for you? I ran with the launcher auto-hidden in
ubuntu14.04 but it passed for me with the original testcode.

Regards
Prasanta
On 10/26/2016 12:39 PM, Avik Niyogi wrote:

Hi All,

Kindly review the proposed fix for JDK9.

*Bug: https://bugs.openjdk.java.net/browse/JDK-8168540*
*
*
*Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/
*
*
*
*Issue:* Animation before screen capture causes mismatch.

*Cause: *Delay before screen capture albeit provided is not enough

*Fix: *Delay provided to test case

With Regards,
Avik Niyogi

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-27 Thread Avik Niyogi 
It did not fail on my system but it probably failed for slow systems in testing 
environment.
Similar cases raised by Yuri had happened for several other cases which was 
confirmed to be fixed by the delay by him.

With Regards,
Avik Niyogi
> On 27-Oct-2016, at 1:55 pm, Prasanta Sadhukhan 
>  wrote:
> 
> Hi Avik,
> Did the test fail for you? I ran with the launcher auto-hidden in ubuntu14.04 
> but it passed for me with the original testcode.
> 
> Regards
> Prasanta
> On 10/26/2016 12:39 PM, Avik Niyogi wrote:
>> Hi All,
>> 
>> Kindly review the proposed fix for JDK9.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8168540 
>> 
>> 
>> Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/ 
>> 
>> 
>> Issue: Animation before screen capture causes mismatch.
>> 
>> Cause: Delay before screen capture albeit provided is not enough
>> 
>> Fix: Delay provided to test case
>> 
>> With Regards,
>> Avik Niyogi
>

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-27 Thread Prasanta Sadhukhan 

Hi Avik,

Did the test fail for you? I ran with the launcher auto-hidden in 
ubuntu14.04 but it passed for me with the original testcode.


Regards
Prasanta
On 10/26/2016 12:39 PM, Avik Niyogi wrote:

Hi All,

Kindly review the proposed fix for JDK9.

*Bug: https://bugs.openjdk.java.net/browse/JDK-8168540*
*
*
*Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/ 
*

*
*
*Issue:* Animation before screen capture causes mismatch.

*Cause: *Delay before screen capture albeit provided is not enough

*Fix: *Delay provided to test case

With Regards,
Avik Niyogi

8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-26 Thread Avik Niyogi 
Hi All,

Kindly review the proposed fix for JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8168540 


Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/ 


Issue: Animation before screen capture causes mismatch.

Cause: Delay before screen capture albeit provided is not enough

Fix: Delay provided to test case

With Regards,
Avik Niyogi