Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-20 Thread Alexandr Scherbatiy 

The fix looks good to me.

Thanks,
Alexandr.

On 7/20/2016 9:34 AM, Rajeev Chamyal wrote:


Looks fine to me.

Regards,

Rajeev Chamyal

*From:*Avik Niyogi
*Sent:* 20 July 2016 11:52
*To:* Rajeev Chamyal
*Cc:* Praveen Srivastava; Alexander Scherbatiy; swing-dev@openjdk.java.net
*Subject:* Re:  8161470: [TEST_BUG] Failure 
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java


Hi Rajeev,

Updated on same webrev due to single line change.

On 20-Jul-2016, at 11:41 am, Rajeev Chamyal
mailto:rajeev.cham...@oracle.com>> wrote:

Hello Avik,

Line 67 can be removed from test.

Regards,

Rajeev Chamyal

*From:*Avik Niyogi
*Sent:*20 July 2016 11:30
*To:*Rajeev Chamyal
*Cc:*Praveen Srivastava; Alexandr Scherbatiy;
swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net>
*Subject:*Re:  8161470: [TEST_BUG] Failure
    javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

A gentle reminder, please review my code changes.

With Regards,

Avik Niyogi

On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy
mailto:alexandr.scherba...@oracle.com>> wrote:


The fix looks good to me.

Thanks,
Alexandr.

On 7/19/2016 9:45 AM, Avik Niyogi wrote:

Hi All,

Kindly review the fix for JDK9.

*Bug: https://bugs.openjdk.java.net/browse/JDK-8161470*

*Webrev:
http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/
<http://cr.openjdk.java.net/%7Eaniyogi/8161470/webrev.00/>*

*Issue: *This test consistently (12/12) fails on OS X
10.10 and also fails on Ubuntu 14.04.

*Cause: * Due to quirk in robot.delay the UI was not
getting appropriate behaviour response.

*Fix:* Appropriate Robot methods were used to fix this.

With Regards,

Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Rajeev Chamyal 
Looks fine to me.

 

Regards,

Rajeev Chamyal

 

From: Avik Niyogi 
Sent: 20 July 2016 11:52
To: Rajeev Chamyal
Cc: Praveen Srivastava; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re:  8161470: [TEST_BUG] Failure 
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

 

Hi Rajeev,

Updated on same webrev due to single line change.

 

On 20-Jul-2016, at 11:41 am, Rajeev Chamyal mailto:rajeev.cham...@oracle.com"rajeev.cham...@oracle.com> wrote:

 

Hello Avik,

 

Line 67 can be removed from test.

 

Regards,

Rajeev Chamyal

From: Avik Niyogi 
Sent: 20 July 2016 11:30
To: Rajeev Chamyal
Cc: Praveen Srivastava; Alexandr Scherbatiy; HYPERLINK 
"mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net
Subject: Re:  8161470: [TEST_BUG] Failure 
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

 

A gentle reminder, please review my code changes.

 

With Regards,

Avik Niyogi

On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy mailto:alexandr.scherba...@oracle.com"alexandr.scherba...@oracle.com> wrote:

 


The fix looks good to me.

Thanks,
Alexandr.

On 7/19/2016 9:45 AM, Avik Niyogi wrote:

Hi All, 

 

Kindly review the fix for JDK9. 

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8161470

 

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Eaniyogi/8161470/webrev.00/"http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/

 

Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
Ubuntu 14.04.

 

Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
behaviour response.

 

Fix: Appropriate Robot methods were used to fix this.

 

With Regards,

Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Avik Niyogi 
Hi Rajeev,
Updated on same webrev due to single line change.

> On 20-Jul-2016, at 11:41 am, Rajeev Chamyal  wrote:
> 
> Hello Avik,
>  
> Line 67 can be removed from test.
>  
> Regards,
> Rajeev Chamyal
> From: Avik Niyogi 
> Sent: 20 July 2016 11:30
> To: Rajeev Chamyal
> Cc: Praveen Srivastava; Alexandr Scherbatiy; swing-dev@openjdk.java.net
> Subject: Re:  8161470: [TEST_BUG] Failure 
> javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java
>  
> A gentle reminder, please review my code changes.
>  
> With Regards,
> Avik Niyogi
> On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy 
> mailto:alexandr.scherba...@oracle.com>> 
> wrote:
>  
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 7/19/2016 9:45 AM, Avik Niyogi wrote:
> Hi All, 
>  
> Kindly review the fix for JDK9. 
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8161470 
> <https://bugs.openjdk.java.net/browse/JDK-8161470>
>  
> Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eaniyogi/8161470/webrev.00/>
>  
> Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
> Ubuntu 14.04.
>  
> Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
> behaviour response.
>  
> Fix: Appropriate Robot methods were used to fix this.
>  
> With Regards,
> Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Avik Niyogi 
Updated on the same webrev due to one line change.
With Regards,
Avik Niyogi

> On 20-Jul-2016, at 11:41 am, Rajeev Chamyal  wrote:
> 
> Hello Avik,
>  
> Line 67 can be removed from test.
>  
> Regards,
> Rajeev Chamyal
> From: Avik Niyogi 
> Sent: 20 July 2016 11:30
> To: Rajeev Chamyal
> Cc: Praveen Srivastava; Alexandr Scherbatiy; swing-dev@openjdk.java.net
> Subject: Re:  8161470: [TEST_BUG] Failure 
> javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java
>  
> A gentle reminder, please review my code changes.
>  
> With Regards,
> Avik Niyogi
> On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy 
> mailto:alexandr.scherba...@oracle.com>> 
> wrote:
>  
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 7/19/2016 9:45 AM, Avik Niyogi wrote:
> Hi All, 
>  
> Kindly review the fix for JDK9. 
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8161470 
> <https://bugs.openjdk.java.net/browse/JDK-8161470>
>  
> Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eaniyogi/8161470/webrev.00/>
>  
> Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
> Ubuntu 14.04.
>  
> Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
> behaviour response.
>  
> Fix: Appropriate Robot methods were used to fix this.
>  
> With Regards,
> Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Rajeev Chamyal 
Hello Avik,

 

Line 67 can be removed from test.

 

Regards,

Rajeev Chamyal

From: Avik Niyogi 
Sent: 20 July 2016 11:30
To: Rajeev Chamyal
Cc: Praveen Srivastava; Alexandr Scherbatiy; swing-dev@openjdk.java.net
Subject: Re:  8161470: [TEST_BUG] Failure 
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

 

A gentle reminder, please review my code changes.

 

With Regards,

Avik Niyogi

On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy mailto:alexandr.scherba...@oracle.com"alexandr.scherba...@oracle.com> wrote:

 


The fix looks good to me.

Thanks,
Alexandr.

On 7/19/2016 9:45 AM, Avik Niyogi wrote:

Hi All, 

 

Kindly review the fix for JDK9. 

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8161470

 

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Eaniyogi/8161470/webrev.00/"http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/

 

Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
Ubuntu 14.04.

 

Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
behaviour response.

 

Fix: Appropriate Robot methods were used to fix this.

 

With Regards,

Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Avik Niyogi 
A gentle reminder, please review my code changes.

With Regards,
Avik Niyogi
> On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy 
>  wrote:
> 
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 7/19/2016 9:45 AM, Avik Niyogi wrote:
>> Hi All,
>> 
>> Kindly review the fix for JDK9.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8161470 
>> 
>> 
>> Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ 
>> 
>> 
>> Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
>> Ubuntu 14.04.
>> 
>> Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
>> behaviour response.
>> 
>> Fix: Appropriate Robot methods were used to fix this.
>> 
>> With Regards,
>> Avik Niyogi
>

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-19 Thread Alexandr Scherbatiy 


The fix looks good to me.

Thanks,
Alexandr.

On 7/19/2016 9:45 AM, Avik Niyogi wrote:

Hi All,

Kindly review the fix for JDK9.

*Bug: https://bugs.openjdk.java.net/browse/JDK-8161470*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ 
*


*Issue: *This test consistently (12/12) fails on OS X 10.10 and also 
fails on Ubuntu 14.04.


*Cause: * Due to quirk in robot.delay the UI was not getting 
appropriate behaviour response.


*Fix:* Appropriate Robot methods were used to fix this.

With Regards,
Avik Niyogi

8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

2016-07-18 Thread Avik Niyogi 
Hi All,

Kindly review the fix for JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8161470 


Webrev: http://cr.openjdk.java.net/~aniyogi/8161470/webrev.00/ 


Issue: This test consistently (12/12) fails on OS X 10.10 and also fails on 
Ubuntu 14.04.

Cause:  Due to quirk in robot.delay the UI was not getting appropriate 
behaviour response.

Fix: Appropriate Robot methods were used to fix this.

With Regards,
Avik Niyogi