Re: [sword-devel] [PATCH] Fix ICU checking without icu-config
On Sat, Jun 20, 2020 at 03:47:13PM -0400, Karl Kleinpaste wrote:
>...
> Fedora handles this problem /just fine/:
>
> $ grep libicu-devel /var/log/rpmpkgs
> libicu-devel-63.2-3.fc31.i686.rpm
> libicu-devel-63.2-3.fc31.x86_64.rpm
> $ ls -l /usr/bin/icu-config*
> -rwxr-xr-x 1 root root 205 May 28 2018 /usr/bin/icu-config
> -rwxr-xr-x 1 root root 22011 Jul 25 2019 /usr/bin/icu-config-32
> -rwxr-xr-x 1 root root 22019 Jul 25 2019 /usr/bin/icu-config-64
> $ rpm -qf /usr/bin/icu-config*
> libicu-devel-63.2-3.fc31.x86_64
> libicu-devel-63.2-3.fc31.i686
> libicu-devel-63.2-3.fc31.i686
> libicu-devel-63.2-3.fc31.x86_64
>
> The main script is a 32/64-bit selector script which then calls the
> right arch-specific binary, and the relevant symlinks are all correct in
> /usr/lib{,64}.
>...
What is "the right arch-specific binary" when I am building on x86_64?
icu-config automatically using icu-config-64 is right most of the time,
but not when building on x86_64 for i686.
On Debian/Ubuntu I can just install the i686 version of pkg-config,
and this will then give the correct i686 output.
Nowadays pkg-config is the standard tool for this kind of information,
the Fedora libicu-devel package is shipping a pkg-config file since 2006.
cu
Adrian
___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] [PATCH] Fix ICU checking without icu-config
On 6/20/20 3:35 PM, Adrian Bunk wrote:
> icu-config is no longer available on Debian/Ubuntu, for background
> see https://bugs.debian.org/898820
Is it worth pointing out that Debian/Ubuntu are becoming real PITAs?
>From the bug:
libicu-dev is not multi-arch aware, causing the i386 version to conflict
with the amd64 one which makes it impossible to install both. As a
result the /usr/lib/i386-linux-gnu/libicu*.so symbolic links are missing
so that developing 32 bit applications using this library is impossible
on a 64 bit system.
Fedora handles this problem /just fine/:
$ grep libicu-devel /var/log/rpmpkgs
libicu-devel-63.2-3.fc31.i686.rpm
libicu-devel-63.2-3.fc31.x86_64.rpm
$ ls -l /usr/bin/icu-config*
-rwxr-xr-x 1 root root 205 May 28 2018 /usr/bin/icu-config
-rwxr-xr-x 1 root root 22011 Jul 25 2019 /usr/bin/icu-config-32
-rwxr-xr-x 1 root root 22019 Jul 25 2019 /usr/bin/icu-config-64
$ rpm -qf /usr/bin/icu-config*
libicu-devel-63.2-3.fc31.x86_64
libicu-devel-63.2-3.fc31.i686
libicu-devel-63.2-3.fc31.i686
libicu-devel-63.2-3.fc31.x86_64
The main script is a 32/64-bit selector script which then calls the
right arch-specific binary, and the relevant symlinks are all correct in
/usr/lib{,64}.
Not that I'm interested in a distro war, but some of us are getting
darned tired of Debian/Ubuntu's high-handed /purity/ demands, virtually
demanding that everyone else fall over for them.
___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] [PATCH] Fix ICU checking without icu-config
On Sat, Jun 20, 2020 at 02:25:58PM -0500, Greg Hellings wrote: > What's wrong with using icu-config? I'm not sure what you're fixing with > this. Thanks for asking, I failed to mention the root problem. icu-config is no longer available on Debian/Ubuntu, for background see https://bugs.debian.org/898820 > Greg cu Adrian ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] [PATCH] Fix ICU checking without icu-config
What's wrong with using icu-config? I'm not sure what you're fixing with this. Greg On Sat, Jun 20, 2020, 11:56 Adrian Bunk wrote: > From: László Böszörményi > > Let still search for icu-config but use pkg-config method after that. > > https://bugs.debian.org/962265 > --- > configure.ac | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index cd587b41..b7cab681 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -240,9 +240,19 @@ if test x$with_icu = xyes; then >AM_CXXFLAGS="$AM_CXXFLAGS -D_ICU_" >AM_CFLAGS="$AM_CFLAGS -D_ICU_" > else > - echo "*** The icu-config script installed by icu could not be > found" > - echo "*** compiling without ICU support" > - with_icu=no > + PKG_CHECK_MODULES([ICU], [icu-i18n >= 63.1], [found_icu=yes]) > + if test "$found_icu" = "yes"; then > + PKG_CHECK_MODULES([ICU_IO], [icu-io >= 63.1]) > + ICU_IOLIBS="$ICU_IO_LIBS" > + with_icu=yes > + LIBS="$LIBS $ICU_LIBS $ICU_IOLIBS" > + AM_CXXFLAGS="$AM_CXXFLAGS -D_ICU_" > + AM_CFLAGS="$AM_CFLAGS -D_ICU_" > + else > + echo "*** The icu-config script installed by icu could not > be found" > + echo "*** compiling without ICU support" > + with_icu=no > + fi > fi > fi > > -- > 2.20.1 > > ___ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
[sword-devel] [PATCH] Fix ICU checking without icu-config
From: László Böszörményi Let still search for icu-config but use pkg-config method after that. https://bugs.debian.org/962265 --- configure.ac | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index cd587b41..b7cab681 100644 --- a/configure.ac +++ b/configure.ac @@ -240,9 +240,19 @@ if test x$with_icu = xyes; then AM_CXXFLAGS="$AM_CXXFLAGS -D_ICU_" AM_CFLAGS="$AM_CFLAGS -D_ICU_" else - echo "*** The icu-config script installed by icu could not be found" - echo "*** compiling without ICU support" - with_icu=no + PKG_CHECK_MODULES([ICU], [icu-i18n >= 63.1], [found_icu=yes]) + if test "$found_icu" = "yes"; then + PKG_CHECK_MODULES([ICU_IO], [icu-io >= 63.1]) + ICU_IOLIBS="$ICU_IO_LIBS" + with_icu=yes + LIBS="$LIBS $ICU_LIBS $ICU_IOLIBS" + AM_CXXFLAGS="$AM_CXXFLAGS -D_ICU_" + AM_CFLAGS="$AM_CFLAGS -D_ICU_" + else + echo "*** The icu-config script installed by icu could not be found" + echo "*** compiling without ICU support" + with_icu=no + fi fi fi -- 2.20.1 ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
