Re: [sword-devel] SWORD 1.9.0RC2 Available
Thanks, Troy! That resolved the issue for me. The "hanging" is not happening any longer now. The reason why I'm calling deleteModule is that the construction/initialization of SWMgr is taking some time (especially on less powerful CPUs). By calling deleteModule I can keep using the same instance of SWMgr after removing a module and it will still reflect current status in terms of what's in its "cache". Best regards, Tobias On 9/18/20 10:38 PM, Troy A. Griffitts wrote: I think Tobias is having trouble with SWMgr::deleteModule and not the uninstalling part. I don't think most of us actually call deleteModule on SWMgr. I usually just delete the SWMgr and make a new SWMgr after the user is done installing or uninstalling modules. That is new code and I see the bug. Let me commit a fix and see if it solved things for you. I am surprised it hangs though. Just committed. Give it a try and let me know. On 9/18/20 10:10 PM, Karl Kleinpaste wrote: FYI, I have no trouble uninstalling or re-installing modules in my newly-built RC2, not seeing the problem Tobias reports. ___ sword-devel mailing list:sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
I think Tobias is having trouble with SWMgr::deleteModule and not the uninstalling part. I don't think most of us actually call deleteModule on SWMgr. I usually just delete the SWMgr and make a new SWMgr after the user is done installing or uninstalling modules. That is new code and I see the bug. Let me commit a fix and see if it solved things for you. I am surprised it hangs though. Just committed. Give it a try and let me know. On 9/18/20 10:10 PM, Karl Kleinpaste wrote: FYI, I have no trouble uninstalling or re-installing modules in my newly-built RC2, not seeing the problem Tobias reports. ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
FYI, I have no trouble uninstalling or re-installing modules in my newly-built RC2, not seeing the problem Tobias reports. ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
I'v just isolated the calls in a test program and got this back trace after it hung. Does that help? #0 0x7fc2c851a237 in std::_Rb_tree_increment(std::_Rb_tree_node_base*) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6 #1 0x55c02f096465 in std::_Rb_tree_iteratorconst, sword::SWModule*> >::operator++() () #2 0x55c02f097917 in std::_Rb_treestd::pair, std::_Select1st >, std::less, std::allocatorsword::SWModule*> > >::erase[abi:cxx11](std::_Rb_tree_iteratorconst, sword::SWModule*> >) () #3 0x55c02f0964db in std::mapstd::less, std::allocatorsword::SWModule*> > >::erase[abi:cxx11](std::_Rb_tree_iteratorconst, sword::SWModule*> >) () #4 0x55c02f093fb7 in sword::SWMgr::deleteModule(char const*) () #5 0x55c02f070a2f in ModuleInstaller::uninstallModule (this=0x7fffbf1f9590, moduleName=...) at /home/tobi/dev/ezra_project/node-sword-interface-git/src/sword_backend/module_installer.cpp:103 #6 0x55c02f02d875 in main (argc=1, argv=0x7fffbf1f96f8) at /home/tobi/dev/ezra_project/node-sword-interface-git/src/node_sword_cli.cpp:182 Best regards, Tobias On 9/18/20 6:46 PM, Troy A. Griffitts wrote: Bummer. It shouldn't hang. Does the user running the action have sufficient privileges to uninstall the module? To repeat, it shouldn't hang, regardless of your answer. I'll have a look. In a bit of a panic because I just pushed Bishop 1.6.1 out built against SWORD 1.9.0RC2, I just tried deleting a module there and it worked. I've just uninstalled a module using: sword/utilities/installmgr -u AB and it also worked OK. Would love to get a gdb stack trace of where it's hanging for you. Troy On 9/18/20 4:48 PM, Tobias Klein wrote: Hi Troy, Thanks for your work on this new release of SWORD! I just gave it a try with Ezra Project and based on an automated end-to-end acceptance test I noticed that removal of a module did not work anymore (tested with the KJV). The test ran into a timeout. The SWORD revision that I was depending on lastly was SVN Rev 3747 from May 18th. I then tried this manually and found that when removing a module (tried with KJV) Ezra Project hangs endlessly at full cpu load. Next step was trying the module removal at API level with node-sword-interface. There it is also hanging in NodeSwordInterface.uninstallModule. This method invokes the CPP method ModuleInstaller::uninstallModule, which in turn does the following on the SWORD API: 1) InstallMgr::removeModule 2) InstallMgr::deleteModule (and this is where it hangs!!) Best regards, Tobias On 9/17/20 8:25 PM, Troy A. Griffitts wrote: RC2 is available. Small changes to accommodate a few lint warnings and updated java-jni bindings. Added Vietnamese [Pref Abbrevs] section (thanks Daniel Owens!) https://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC2.tar.gz Please let me know if you have positive or negative results. I would like to hear things are working in our mainstream frontends before pushing this out; it would give me happy thoughts. Hope everyone is having a good week, Troy On 9/11/20 6:57 PM, Troy A. Griffitts wrote: Give it a go and let me know. http://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC1.tar.gz Also, just to reiterate, if I've let anything out submitted by anyone, it isn't because I don't like you (probably), it's more likely that I'm old and forgetful. Please let me know if you don't notice something you've submitted in bundled up in the RC. Thanks for any feedback one way or another. Troy ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
Bummer. It shouldn't hang. Does the user running the action have sufficient privileges to uninstall the module? To repeat, it shouldn't hang, regardless of your answer. I'll have a look. In a bit of a panic because I just pushed Bishop 1.6.1 out built against SWORD 1.9.0RC2, I just tried deleting a module there and it worked. I've just uninstalled a module using: sword/utilities/installmgr -u AB and it also worked OK. Would love to get a gdb stack trace of where it's hanging for you. Troy On 9/18/20 4:48 PM, Tobias Klein wrote: Hi Troy, Thanks for your work on this new release of SWORD! I just gave it a try with Ezra Project and based on an automated end-to-end acceptance test I noticed that removal of a module did not work anymore (tested with the KJV). The test ran into a timeout. The SWORD revision that I was depending on lastly was SVN Rev 3747 from May 18th. I then tried this manually and found that when removing a module (tried with KJV) Ezra Project hangs endlessly at full cpu load. Next step was trying the module removal at API level with node-sword-interface. There it is also hanging in NodeSwordInterface.uninstallModule. This method invokes the CPP method ModuleInstaller::uninstallModule, which in turn does the following on the SWORD API: 1) InstallMgr::removeModule 2) InstallMgr::deleteModule (and this is where it hangs!!) Best regards, Tobias On 9/17/20 8:25 PM, Troy A. Griffitts wrote: RC2 is available. Small changes to accommodate a few lint warnings and updated java-jni bindings. Added Vietnamese [Pref Abbrevs] section (thanks Daniel Owens!) https://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC2.tar.gz Please let me know if you have positive or negative results. I would like to hear things are working in our mainstream frontends before pushing this out; it would give me happy thoughts. Hope everyone is having a good week, Troy On 9/11/20 6:57 PM, Troy A. Griffitts wrote: Give it a go and let me know. http://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC1.tar.gz Also, just to reiterate, if I've let anything out submitted by anyone, it isn't because I don't like you (probably), it's more likely that I'm old and forgetful. Please let me know if you don't notice something you've submitted in bundled up in the RC. Thanks for any feedback one way or another. Troy ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
Hi Troy, Thanks for your work on this new release of SWORD! I just gave it a try with Ezra Project and based on an automated end-to-end acceptance test I noticed that removal of a module did not work anymore (tested with the KJV). The test ran into a timeout. The SWORD revision that I was depending on lastly was SVN Rev 3747 from May 18th. I then tried this manually and found that when removing a module (tried with KJV) Ezra Project hangs endlessly at full cpu load. Next step was trying the module removal at API level with node-sword-interface. There it is also hanging in NodeSwordInterface.uninstallModule. This method invokes the CPP method ModuleInstaller::uninstallModule, which in turn does the following on the SWORD API: 1) InstallMgr::removeModule 2) InstallMgr::deleteModule (and this is where it hangs!!) Best regards, Tobias On 9/17/20 8:25 PM, Troy A. Griffitts wrote: RC2 is available. Small changes to accommodate a few lint warnings and updated java-jni bindings. Added Vietnamese [Pref Abbrevs] section (thanks Daniel Owens!) https://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC2.tar.gz Please let me know if you have positive or negative results. I would like to hear things are working in our mainstream frontends before pushing this out; it would give me happy thoughts. Hope everyone is having a good week, Troy On 9/11/20 6:57 PM, Troy A. Griffitts wrote: Give it a go and let me know. http://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC1.tar.gz Also, just to reiterate, if I've let anything out submitted by anyone, it isn't because I don't like you (probably), it's more likely that I'm old and forgetful. Please let me know if you don't notice something you've submitted in bundled up in the RC. Thanks for any feedback one way or another. Troy ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD 1.9.0RC2 Available
On 9/17/20 2:25 PM, Troy A. Griffitts wrote: > Please let me know if you have positive or negative results. I would > like to hear things are working in our mainstream frontends before > pushing this out; it would give me happy thoughts. Xiphos 4.2.1 builds fine against it. I don't know if I should be looking for anything in particular. ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
[sword-devel] SWORD 1.9.0RC2 Available
RC2 is available. Small changes to accommodate a few lint warnings and updated java-jni bindings. Added Vietnamese [Pref Abbrevs] section (thanks Daniel Owens!) https://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC2.tar.gz Please let me know if you have positive or negative results. I would like to hear things are working in our mainstream frontends before pushing this out; it would give me happy thoughts. Hope everyone is having a good week, Troy On 9/11/20 6:57 PM, Troy A. Griffitts wrote: Give it a go and let me know. http://crosswire.org/sword/ALPHAcckswwlkrfre22034820285912/sword-1.9.0RC1.tar.gz Also, just to reiterate, if I've let anything out submitted by anyone, it isn't because I don't like you (probably), it's more likely that I'm old and forgetful. Please let me know if you don't notice something you've submitted in bundled up in the RC. Thanks for any feedback one way or another. Troy ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
