[Synfig-devl] [ synfig-Patches-1852208 ] multibyte support for text layer
Patches item #1852208, was opened at 2007-12-17 11:17 Message generated for change (Comment added) made by dooglus You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Niki W. Waibel (nikiwaibel) Assigned to: Nobody/Anonymous (nobody) Summary: multibyte support for text layer Initial Comment: i recently stumbled upon synfig. amazing piece of software! i needed german umlauts in the text layer, which was not possible with synfig-0.61.07. created the attached patch. now it works fine. i am not a c++ expert, maybe you should have a quick check on the patch. it is pretty small anyway: 1 line is exchanged by 21 lines, 3 lines are added -- in only 1 file. please doublecheck line 21: (1) the "&(*iter)" thing. i did not know how to do that in a clean way in c++. (2) "text.end() - iter": not sure if this is the proper way to do it. (3) not sure if the error/warning stuff is 100% correct. -- >Comment By: dooglus (dooglus) Date: 2008-01-01 19:45 Message: Logged In: YES user_id=1546005 Originator: NO Sure. It turned out that your most recent fix was added as part of adding multi-lingual support to synfig, which will appear in the next version. -- Comment By: Niki W. Waibel (nikiwaibel) Date: 2008-01-01 19:35 Message: Logged In: YES user_id=1951 Originator: YES dooglus, thank you. i don't have enough time to get and test the latest code. this is the reason why you see a version# with my patches. sorry for creating some misunderstandings here. people who compile and use the released version can have multibyte support with the 2 patches... -- Comment By: dooglus (dooglus) Date: 2008-01-01 17:01 Message: Logged In: YES user_id=1546005 Originator: NO That last comment was from me. Seems sf.net won't keep me logged in any more like it used to. -- Comment By: Nobody/Anonymous (nobody) Date: 2008-01-01 17:00 Message: Logged In: NO Thanks for the patch Niki, but that setlocale() call has already been added to the code since the last release. When submitting patches for synfig, it's best to submit a patch against the current version of the code in subversion ( http://wiki.synfig.com/Subversion ) to avoid duplicating work. I just noticed that the call to setlocale() was conditional on gettext being available, which it needn't be, so I've changed that. -- Comment By: Niki W. Waibel (nikiwaibel) Date: 2008-01-01 02:53 Message: Logged In: YES user_id=1951 Originator: YES hmmm -- i reopened this issue... i found out that the synfig command does not set the locale when the program is started. attached a patch (synfig-0.61.07.nww.multibyte2.patch) that fixes it. (used only synfigstudio so far, which seems to set the locale correctly). File Added: synfig-0.61.07.nww.multibyte2.patch -- Comment By: dooglus (dooglus) Date: 2007-12-17 15:06 Message: Logged In: YES user_id=1546005 Originator: NO svn r1207 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] [ synfig-Patches-1852208 ] multibyte support for text layer
Patches item #1852208, was opened at 2007-12-17 11:17 Message generated for change (Comment added) made by nikiwaibel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Niki W. Waibel (nikiwaibel) Assigned to: Nobody/Anonymous (nobody) Summary: multibyte support for text layer Initial Comment: i recently stumbled upon synfig. amazing piece of software! i needed german umlauts in the text layer, which was not possible with synfig-0.61.07. created the attached patch. now it works fine. i am not a c++ expert, maybe you should have a quick check on the patch. it is pretty small anyway: 1 line is exchanged by 21 lines, 3 lines are added -- in only 1 file. please doublecheck line 21: (1) the "&(*iter)" thing. i did not know how to do that in a clean way in c++. (2) "text.end() - iter": not sure if this is the proper way to do it. (3) not sure if the error/warning stuff is 100% correct. -- >Comment By: Niki W. Waibel (nikiwaibel) Date: 2008-01-01 19:35 Message: Logged In: YES user_id=1951 Originator: YES dooglus, thank you. i don't have enough time to get and test the latest code. this is the reason why you see a version# with my patches. sorry for creating some misunderstandings here. people who compile and use the released version can have multibyte support with the 2 patches... -- Comment By: dooglus (dooglus) Date: 2008-01-01 17:01 Message: Logged In: YES user_id=1546005 Originator: NO That last comment was from me. Seems sf.net won't keep me logged in any more like it used to. -- Comment By: Nobody/Anonymous (nobody) Date: 2008-01-01 17:00 Message: Logged In: NO Thanks for the patch Niki, but that setlocale() call has already been added to the code since the last release. When submitting patches for synfig, it's best to submit a patch against the current version of the code in subversion ( http://wiki.synfig.com/Subversion ) to avoid duplicating work. I just noticed that the call to setlocale() was conditional on gettext being available, which it needn't be, so I've changed that. -- Comment By: Niki W. Waibel (nikiwaibel) Date: 2008-01-01 02:53 Message: Logged In: YES user_id=1951 Originator: YES hmmm -- i reopened this issue... i found out that the synfig command does not set the locale when the program is started. attached a patch (synfig-0.61.07.nww.multibyte2.patch) that fixes it. (used only synfigstudio so far, which seems to set the locale correctly). File Added: synfig-0.61.07.nww.multibyte2.patch -- Comment By: dooglus (dooglus) Date: 2007-12-17 15:06 Message: Logged In: YES user_id=1546005 Originator: NO svn r1207 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] [ synfig-Patches-1858904 ] ETL-configure-rev
Patches item #1858904, was opened at 2007-12-27 13:39 Message generated for change (Comment added) made by dooglus You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1858904&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 3 Private: No Submitted By: Atrus (gmatrus) Assigned to: Nobody/Anonymous (nobody) Summary: ETL-configure-rev Initial Comment: Since an old bootstrap script was removed, synfig does not added revision number to its version, which hardcoded into the configure.ac. This patch is get this ability back. -- >Comment By: dooglus (dooglus) Date: 2008-01-01 17:39 Message: Logged In: YES user_id=1546005 Originator: NO What about for released versions? We want those to use the release number, not the subversion revision number. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1858904&group_id=144022 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] [ synfig-Patches-1852208 ] multibyte support for text layer
Patches item #1852208, was opened at 2007-12-17 11:17 Message generated for change (Comment added) made by dooglus You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Niki W. Waibel (nikiwaibel) Assigned to: Nobody/Anonymous (nobody) Summary: multibyte support for text layer Initial Comment: i recently stumbled upon synfig. amazing piece of software! i needed german umlauts in the text layer, which was not possible with synfig-0.61.07. created the attached patch. now it works fine. i am not a c++ expert, maybe you should have a quick check on the patch. it is pretty small anyway: 1 line is exchanged by 21 lines, 3 lines are added -- in only 1 file. please doublecheck line 21: (1) the "&(*iter)" thing. i did not know how to do that in a clean way in c++. (2) "text.end() - iter": not sure if this is the proper way to do it. (3) not sure if the error/warning stuff is 100% correct. -- >Comment By: dooglus (dooglus) Date: 2008-01-01 17:01 Message: Logged In: YES user_id=1546005 Originator: NO That last comment was from me. Seems sf.net won't keep me logged in any more like it used to. -- Comment By: Nobody/Anonymous (nobody) Date: 2008-01-01 17:00 Message: Logged In: NO Thanks for the patch Niki, but that setlocale() call has already been added to the code since the last release. When submitting patches for synfig, it's best to submit a patch against the current version of the code in subversion ( http://wiki.synfig.com/Subversion ) to avoid duplicating work. I just noticed that the call to setlocale() was conditional on gettext being available, which it needn't be, so I've changed that. -- Comment By: Niki W. Waibel (nikiwaibel) Date: 2008-01-01 02:53 Message: Logged In: YES user_id=1951 Originator: YES hmmm -- i reopened this issue... i found out that the synfig command does not set the locale when the program is started. attached a patch (synfig-0.61.07.nww.multibyte2.patch) that fixes it. (used only synfigstudio so far, which seems to set the locale correctly). File Added: synfig-0.61.07.nww.multibyte2.patch -- Comment By: dooglus (dooglus) Date: 2007-12-17 15:06 Message: Logged In: YES user_id=1546005 Originator: NO svn r1207 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
[Synfig-devl] [ synfig-Patches-1852208 ] multibyte support for text layer
Patches item #1852208, was opened at 2007-12-17 02:17 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Private: No Submitted By: Niki W. Waibel (nikiwaibel) Assigned to: Nobody/Anonymous (nobody) Summary: multibyte support for text layer Initial Comment: i recently stumbled upon synfig. amazing piece of software! i needed german umlauts in the text layer, which was not possible with synfig-0.61.07. created the attached patch. now it works fine. i am not a c++ expert, maybe you should have a quick check on the patch. it is pretty small anyway: 1 line is exchanged by 21 lines, 3 lines are added -- in only 1 file. please doublecheck line 21: (1) the "&(*iter)" thing. i did not know how to do that in a clean way in c++. (2) "text.end() - iter": not sure if this is the proper way to do it. (3) not sure if the error/warning stuff is 100% correct. -- Comment By: Nobody/Anonymous (nobody) Date: 2008-01-01 08:00 Message: Logged In: NO Thanks for the patch Niki, but that setlocale() call has already been added to the code since the last release. When submitting patches for synfig, it's best to submit a patch against the current version of the code in subversion ( http://wiki.synfig.com/Subversion ) to avoid duplicating work. I just noticed that the call to setlocale() was conditional on gettext being available, which it needn't be, so I've changed that. -- Comment By: Niki W. Waibel (nikiwaibel) Date: 2007-12-31 17:53 Message: Logged In: YES user_id=1951 Originator: YES hmmm -- i reopened this issue... i found out that the synfig command does not set the locale when the program is started. attached a patch (synfig-0.61.07.nww.multibyte2.patch) that fixes it. (used only synfigstudio so far, which seems to set the locale correctly). File Added: synfig-0.61.07.nww.multibyte2.patch -- Comment By: dooglus (dooglus) Date: 2007-12-17 06:06 Message: Logged In: YES user_id=1546005 Originator: NO svn r1207 -- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=1852208&group_id=144022 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
