Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
On 20 Dec 2018, at 18:11, Kevin A. McGrail wrote: > Wouildn't an easier fix would be curl on the yesterday's update and > sa-update from a file? Well, yes. That would be easier and less error-prone...
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
Wouildn't an easier fix would be curl on the yesterday's update and sa-update from a file? -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171 On Thu, Dec 20, 2018 at 5:56 PM Bill Cole < sa-bugz-20080...@billmail.scconsult.com> wrote: > On 20 Dec 2018, at 17:04, Kevin A. McGrail wrote: > > > So this will resolve with the masscheck tonight and subsequent rule > build? > > Yes. Also see my latest post to the Users list for an immediate workaround. > >
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
On 20 Dec 2018, at 17:04, Kevin A. McGrail wrote: > So this will resolve with the masscheck tonight and subsequent rule build? Yes. Also see my latest post to the Users list for an immediate workaround.
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
So this will resolve with the masscheck tonight and subsequent rule build?
--
Kevin A. McGrail
VP Fundraising, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
On Thu, Dec 20, 2018 at 4:58 PM Bill Cole <
sa-bugz-20080...@billmail.scconsult.com> wrote:
> Fixed.
>
> It turns out that bug 7302 exists and I misinterpreted a response to the
> immediate case as an actual fix for the underlying flaw. I have now
> committed a real fix.
>
>
>
> On 20 Dec 2018, at 16:14, Kevin A. McGrail wrote:
>
> > +1
> > --
> > Kevin A. McGrail
> > VP Fundraising, Apache Software Foundation
> > Chair Emeritus Apache SpamAssassin Project
> > https://www.linkedin.com/in/kmcgrail - 703.798.0171
> >
> >
> > On Thu, Dec 20, 2018 at 4:04 PM Bill Cole <
> > sa-bugz-20080...@billmail.scconsult.com> wrote:
> >
> >> On 20 Dec 2018, at 15:53, Bill Cole wrote:
> >>
> >>> On 20 Dec 2018, at 14:25, Bill Cole wrote:
> >>>
> This caused a failure in the run_nightly script which apparently
> doesn't prevent a broken update from being built and distributed.
>
> I'm looking at run_nightly...
> >>>
> >>> It's a problem in the 'make' step: a lint failure emits a nice
> >>> obvious
> >>> error message:
> >>>
> >>> ERROR: LINT FAILED, suppressing output: rules/72_active.cf
> >>>
> >>> But then the make succeeds. Seems like a poor choice...
> >>>
> >>> Still working...
> >>
> >> It's a build/mkrules problem:
> >>
> >> if (lint_rule_text($text) != 0) {
> >>warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
> >>
> >># don't suppress entirely, otherwise 'make
> >> distcheck'/'disttest'
> >># will fail since the MANIFEST-listed output files will be
> >># empty.
> >>
> >># delete $output_file_text->{$file};
> >>$output_file_text->{$file} = '';
> >> }
> >>
> >> Seems like a poor choice. IMHO make dist* *SHOULD* fail if the rules
> >> can't pass lint.
> >>
>
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
Fixed.
It turns out that bug 7302 exists and I misinterpreted a response to the
immediate case as an actual fix for the underlying flaw. I have now
committed a real fix.
On 20 Dec 2018, at 16:14, Kevin A. McGrail wrote:
+1
--
Kevin A. McGrail
VP Fundraising, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
On Thu, Dec 20, 2018 at 4:04 PM Bill Cole <
sa-bugz-20080...@billmail.scconsult.com> wrote:
On 20 Dec 2018, at 15:53, Bill Cole wrote:
On 20 Dec 2018, at 14:25, Bill Cole wrote:
This caused a failure in the run_nightly script which apparently
doesn't prevent a broken update from being built and distributed.
I'm looking at run_nightly...
It's a problem in the 'make' step: a lint failure emits a nice
obvious
error message:
ERROR: LINT FAILED, suppressing output: rules/72_active.cf
But then the make succeeds. Seems like a poor choice...
Still working...
It's a build/mkrules problem:
if (lint_rule_text($text) != 0) {
warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
# don't suppress entirely, otherwise 'make
distcheck'/'disttest'
# will fail since the MANIFEST-listed output files will be
# empty.
# delete $output_file_text->{$file};
$output_file_text->{$file} = '';
}
Seems like a poor choice. IMHO make dist* *SHOULD* fail if the rules
can't pass lint.
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
+1
--
Kevin A. McGrail
VP Fundraising, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
On Thu, Dec 20, 2018 at 4:04 PM Bill Cole <
sa-bugz-20080...@billmail.scconsult.com> wrote:
> On 20 Dec 2018, at 15:53, Bill Cole wrote:
>
> > On 20 Dec 2018, at 14:25, Bill Cole wrote:
> >
> >> This caused a failure in the run_nightly script which apparently
> >> doesn't prevent a broken update from being built and distributed.
> >>
> >> I'm looking at run_nightly...
> >
> > It's a problem in the 'make' step: a lint failure emits a nice obvious
> > error message:
> >
> > ERROR: LINT FAILED, suppressing output: rules/72_active.cf
> >
> > But then the make succeeds. Seems like a poor choice...
> >
> > Still working...
>
> It's a build/mkrules problem:
>
> if (lint_rule_text($text) != 0) {
>warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
>
># don't suppress entirely, otherwise 'make distcheck'/'disttest'
># will fail since the MANIFEST-listed output files will be
># empty.
>
># delete $output_file_text->{$file};
>$output_file_text->{$file} = '';
> }
>
> Seems like a poor choice. IMHO make dist* *SHOULD* fail if the rules
> can't pass lint.
>
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
On 20 Dec 2018, at 15:53, Bill Cole wrote:
On 20 Dec 2018, at 14:25, Bill Cole wrote:
This caused a failure in the run_nightly script which apparently
doesn't prevent a broken update from being built and distributed.
I'm looking at run_nightly...
It's a problem in the 'make' step: a lint failure emits a nice obvious
error message:
ERROR: LINT FAILED, suppressing output: rules/72_active.cf
But then the make succeeds. Seems like a poor choice...
Still working...
It's a build/mkrules problem:
if (lint_rule_text($text) != 0) {
warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
# don't suppress entirely, otherwise 'make distcheck'/'disttest'
# will fail since the MANIFEST-listed output files will be
# empty.
# delete $output_file_text->{$file};
$output_file_text->{$file} = '';
}
Seems like a poor choice. IMHO make dist* *SHOULD* fail if the rules
can't pass lint.
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
On 20 Dec 2018, at 14:25, Bill Cole wrote: This caused a failure in the run_nightly script which apparently doesn't prevent a broken update from being built and distributed. I'm looking at run_nightly... It's a problem in the 'make' step: a lint failure emits a nice obvious error message: ERROR: LINT FAILED, suppressing output: rules/72_active.cf But then the make succeeds. Seems like a poor choice... Still working...
Re: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24]
On 20 Dec 2018, at 12:00, Kevin A. McGrail wrote: Interesting... Mea culpa. Sorta. My bit is fixed now. See http://svn.apache.org/viewvc/spamassassin/trunk/rulesrc/sandbox/billcole/24_mixed_es.cf?r1=1849420=1849419=1849420 This caused a failure in the run_nightly script which apparently doesn't prevent a broken update from being built and distributed. I'm looking at run_nightly... -- Forwarded message - From: Marcus Schopen Date: Thu, Dec 20, 2018, 11:55 Subject: sa-update is broken on updates.spamassassin.org channel [was: Re: config: warning: description exists for non-existent rule EXCUSE_24] To: Am Donnerstag, den 20.12.2018, 12:35 +0100 schrieb Marcus Schopen: Hi, I get a warning, when updating the channel: -- config: warning: description exists for non-existent rule EXCUSE_24 channel: lint check of update failed, channel failed sa-update failed for unknown reasons -- seems not to be a problem of the EXCUSE_24 rule, but a general problem with sa-update, as other users do have the same problem since today.
