[systemd-devel] [PATCH] gperf: Include missing.h.

2011-08-03 Thread Thierry Reding
Older GNU C libraries don't define RLIMIT_RTTIME, so including the
missing.h is required to fix the build.
---
 src/load-fragment-gperf.gperf.m4 |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/load-fragment-gperf.gperf.m4 b/src/load-fragment-gperf.gperf.m4
index 650f444..8e52890 100644
--- a/src/load-fragment-gperf.gperf.m4
+++ b/src/load-fragment-gperf.gperf.m4
@@ -2,6 +2,7 @@
 #include stddef.h
 #include conf-parser.h
 #include load-fragment.h
+#include missing.h
 %}
 struct ConfigPerfItem;
 %null_strings
-- 
1.7.6

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [ANNOUNCE] systemd 33

2011-08-03 Thread Andreas Jaeger
On Wednesday, August 03, 2011 05:24:33 Lennart Poettering wrote:
 Heya,
 
 http://www.freedesktop.org/software/systemd/systemd-33.tar.bz2

It does not build for me:

src/systemd_logind-logind.o: In function `manager_parse_config_file':
/usr/src/packages/BUILD/systemd-33/src/logind.c:1179: undefined reference to 
`logind_gperf_lookup'
collect2: ld returned 1 exit status
make[2]: *** [systemd-logind] Error 1

It worked after I added gperf to the build environment. Is gperf now required 
or is the check for existance of gperf ignored?

Andreas
-- 
 Andreas Jaeger, Program Manager openSUSE
  aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
 GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] environment/configuration in socket unit files

2011-08-03 Thread Honza Horak

On 08/02/2011 01:06 AM, Lennart Poettering wrote:

On Tue, 19.07.11 19:27, Honza Horak (hho...@redhat.com) wrote:


Hi,

I'm creating some systemd unit files for Fedora (currently myslq
just FYI), but I need to set a socket path in the mydaemon.socket
unit file according to user's configuration, which is provided by an
executable.


Hm, waht's the usecase here? Why is that path configurable?


mysql has a very specific way of handling configuration, there is a 
script which parses several files.. And user's socket path can be set 
differently in these files, so I just wanted to respect their settings.


However, we don't ship a socket file right now, so this issue isn't 
actual anymore.


Honza


My intention is to store the generated configuration into a
temporary file (/usr/lib/mydaemon/config in the following example),
which has new-line separated values and thus can be used in
EnvironmentFile.


I can't say I like this idea, but this should work.


Is it possible to use variables like EnvironmentFile in a socket
unit files somehow, e.g. like in the following example? systemd
doesn't complain, but I don't know if it is legal. And what do you
thing about using a temporary file for storing new-line separated
values? Do you have a better solution?


Yes, you may use EnvironmentFile, but they only have an effect on
ExecStartXX lines. You cannot resolve env vars in ListenStream=
directives with that.

Lennart



___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [ANNOUNCE] systemd 33

2011-08-03 Thread Lennart Poettering
On Wed, 03.08.11 09:29, Andreas Jaeger (a...@suse.com) wrote:

 
 On Wednesday, August 03, 2011 05:24:33 Lennart Poettering wrote:
  Heya,
  
  http://www.freedesktop.org/software/systemd/systemd-33.tar.bz2
 
 It does not build for me:
 
 src/systemd_logind-logind.o: In function `manager_parse_config_file':
 /usr/src/packages/BUILD/systemd-33/src/logind.c:1179: undefined reference to 
 `logind_gperf_lookup'
 collect2: ld returned 1 exit status
 make[2]: *** [systemd-logind] Error 1
 
 It worked after I added gperf to the build environment. Is gperf now required 
 or is the check for existance of gperf ignored?

gperf is required. The configure check is simply borked, and doesn't
fail if gperf isn't found.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] namespace: session dependant mtab

2011-08-03 Thread Kay Sievers
On Wed, Aug 3, 2011 at 16:07, Stef Bon stef...@gmail.com wrote:
 I've been looking into how namespaces work, shared mounted subtrees
 and user namespaces using PAM.

 My own construction is using a FUSE filesystem, some bind mounts of
 system directories and (still) pam_chroot.
 and looking to switch to use pam_namespace.

 Anyhowe, I see that with using different namespaces still the central
 managed (=system) mtab is used to lookup mounts.

 Isn't it a good idea to provide every different namespace a own mtab,
 containing only the mounts visible for that namespace?

You mean /etc/mtab? Systemd requires that to be symlink to
/proc/mounts, which is always namespace dependent.

We don't support any idea of a regular file called mtab. Systemd will
print errors at bootup.

Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] namespace: session dependant mtab

2011-08-03 Thread Stef Bon
2011/8/3 Kay Sievers kay.siev...@vrfy.org:
 On Wed, Aug 3, 2011 at 16:07, Stef Bon stef...@gmail.com wrote:

 Isn't it a good idea to provide every different namespace a own mtab,
 containing only the mounts visible for that namespace?

 You mean /etc/mtab? Systemd requires that to be symlink to
 /proc/mounts, which is always namespace dependent.
Hi,

Yes I mean a symlink to /proc/mounts.

OK! I did not know that.

Stef
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] namespace: session dependant mtab

2011-08-03 Thread Kay Sievers
On Wed, Aug 3, 2011 at 16:19, Stef Bon stef...@gmail.com wrote:
 2011/8/3 Kay Sievers kay.siev...@vrfy.org:
 On Wed, Aug 3, 2011 at 16:07, Stef Bon stef...@gmail.com wrote:

 Isn't it a good idea to provide every different namespace a own mtab,
 containing only the mounts visible for that namespace?

 You mean /etc/mtab? Systemd requires that to be symlink to
 /proc/mounts, which is always namespace dependent.
 Hi,

 Yes I mean a symlink to /proc/mounts.

/proc/mounts is itself a link to /proc/self/mounts, while /self/ is
your PID, and the stuff attached to a PID is always namespaced.

Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [ANNOUNCE] systemd 33

2011-08-03 Thread Michael Biebl
2011/8/3 Lennart Poettering lenn...@poettering.net:
 On Wed, 03.08.11 09:29, Andreas Jaeger (a...@suse.com) wrote:


 On Wednesday, August 03, 2011 05:24:33 Lennart Poettering wrote:
  Heya,
 
  http://www.freedesktop.org/software/systemd/systemd-33.tar.bz2

 It does not build for me:

 src/systemd_logind-logind.o: In function `manager_parse_config_file':
 /usr/src/packages/BUILD/systemd-33/src/logind.c:1179: undefined reference to
 `logind_gperf_lookup'
 collect2: ld returned 1 exit status
 make[2]: *** [systemd-logind] Error 1

 It worked after I added gperf to the build environment. Is gperf now required
 or is the check for existance of gperf ignored?

 gperf is required. The configure check is simply borked, and doesn't
 fail if gperf isn't found.


Fixed in 
http://cgit.freedesktop.org/systemd/commit/?id=b62cfcea00862ccbf0e5e297f8a339f70987edef


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] PATCH: detect SUSE initrd for fsck-root

2011-08-03 Thread Frederic Crozat
Hi,

currently fsck-root.service detects only dracut initrd to prevent
running fsck on / when it was mounted rw by initrd. Attached patch adds
detection for SUSE initrd.

-- 
Frederic Crozat fcro...@suse.com
SUSE
From 687d70cc43b34eb2359598d0ca0b69e996aa1b38 Mon Sep 17 00:00:00 2001
From: Frederic Crozat fcro...@suse.com
Date: Wed, 3 Aug 2011 16:46:52 +0200
Subject: [PATCH] units: detect SUSE initrd and do not run fsck on /.

---
 units/fsck-root.service.in |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/units/fsck-root.service.in b/units/fsck-root.service.in
index 7b3529d..2f8c8f5 100644
--- a/units/fsck-root.service.in
+++ b/units/fsck-root.service.in
@@ -13,6 +13,8 @@ Before=local-fs.target shutdown.target
 
 # Dracut informs us with this flag file if the root fsck was already run
 ConditionPathExists=!/run/initramfs/root-fsck
+# Detect SUSE initrd too
+ConditionPathExists=!/dev/shm/initrd_exports.sh
 
 [Service]
 Type=oneshot
-- 
1.7.3.4

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] PATCH: detect SUSE initrd for fsck-root

2011-08-03 Thread Lennart Poettering
On Wed, 03.08.11 18:35, Frederic Crozat (fcro...@suse.com) wrote:

Heya,

 currently fsck-root.service detects only dracut initrd to prevent
 running fsck on / when it was mounted rw by initrd. Attached patch adds
 detection for SUSE initrd.

Humm. /dev/shm is the place where POSIX shared memory should be
placed. It is not the place to put flag files.

I'd prefer if the suse initrd would just use the same flag files as
Dracut. On purpose we kept the names of these files generic
(i.e. initramfs instead of dracut). I am not particularly keen on
maintaining per distro checks like this where it would be very easy to
unify things.

Even better would be if Suse could adopt Dracut too...

  # Dracut informs us with this flag file if the root fsck was already run
  ConditionPathExists=!/run/initramfs/root-fsck
 +# Detect SUSE initrd too
 +ConditionPathExists=!/dev/shm/initrd_exports.sh

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] PATCH: detect SUSE initrd for fsck-root

2011-08-03 Thread Frederic Crozat
Le mercredi 03 août 2011 à 18:45 +0200, Lennart Poettering a écrit :
 On Wed, 03.08.11 18:35, Frederic Crozat (fcro...@suse.com) wrote:
 
 Heya,
 
  currently fsck-root.service detects only dracut initrd to prevent
  running fsck on / when it was mounted rw by initrd. Attached patch adds
  detection for SUSE initrd.
 
 Humm. /dev/shm is the place where POSIX shared memory should be
 placed. It is not the place to put flag files.
 
 I'd prefer if the suse initrd would just use the same flag files as
 Dracut. On purpose we kept the names of these files generic
 (i.e. initramfs instead of dracut). I am not particularly keen on
 maintaining per distro checks like this where it would be very easy to
 unify things.

I'll discuss with our mkinitrd guy to touch this file.

 Even better would be if Suse could adopt Dracut too...

Heh, we are trying to break one thing at a time ;)

-- 
Frederic Crozat fcro...@suse.com
SUSE

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH]: fix compile due to missing RLIMIT_RTTIME

2011-08-03 Thread Kelly Anderson

Hi,

The def for RLIMIT_RTTIME was not getting included in 
load-fragment-gperf.gperf.m4.


--- ./src/load-fragment-gperf.gperf.m4.orig2011-08-03 
18:19:11.0 -0600
+++ ./src/load-fragment-gperf.gperf.m42011-08-03 19:05:22.935134717 
-0600

@@ -2,6 +2,7 @@
 #include stddef.h
 #include conf-parser.h
 #include load-fragment.h
+#include missing.h
 %}
 struct ConfigPerfItem;
 %null_strings

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH]: fix compile due to missing RLIMIT_RTTIME

2011-08-03 Thread Lennart Poettering
On Wed, 03.08.11 19:13, Kelly Anderson (ke...@silka.with-linux.com) wrote:

 Hi,
 
 The def for RLIMIT_RTTIME was not getting included in
 load-fragment-gperf.gperf.m4.

Fixed with Koen's patch. Thanks!

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH] gperf: Include missing.h.

2011-08-03 Thread Thierry Reding
* Thierry Reding wrote:
 Older GNU C libraries don't define RLIMIT_RTTIME, so including the
 missing.h is required to fix the build.
[...]

So I just noticed that Koen already posted the same patch before. I should
have looked more carefully.

Thierry


pgpoCK1rD2KM6.pgp
Description: PGP signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel