Re: [systemd-devel] [PATCH] timedated: gather timezone from /etc/localtime sym target
Op 8 aug. 2012, om 18:51 heeft Lennart Poettering het volgende geschreven: > On Tue, 07.08.12 00:31, Shawn Landen (shawnland...@gmail.com) wrote: > >> keep other method for now, consider dropping later. >> >> Supporting relative links here could be problematic as timezones in >> /usr/share/zoneinfo are often themselves symlinks (and symlinks to >> symlinks), so this implamentation only only support absolute links. > > Hmm, I am not entirely sure this is really the best thing to do. Always > requiring a symlink for /etc/localtime breaks a couple of things: we > can't just bind mount things over in an nspawn container, embedded > devices have to ship /usr/share/zoneinfo/, which is probably something > they might want to avoid. For the embedded systems that need TZ support I ship a subset of timezones, it's not that much data. If you're worried about the TZ sizes you shouldn't enable TZ support :) regards, Koen ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [ANNOUNCE] systemd 188
On Thu, 09.08.12 21:59, Colin Guthrie (gm...@colin.guthr.ie) wrote: > > Hi, > > 'Twas brillig, and Lennart Poettering at 09/08/12 11:32 did gyre and gimble: > > http://www.freedesktop.org/software/systemd/systemd-188.tar.xz > > I seem to get logind/loginctl issues with this release. > > Just installing this and logging in with gdm means that my session (as > listed in loginctl) is not listed as active (which obviously breaks ACLs > etc). > > If I try and manually activate my session (as my user or root) I get: > > > $ loginctl activate 2 > Failed to issue method call: No such device or address Interesting. ENODEV is an interesting error here. Do you have anything in the logs? > This could indicate a problem with the dbus tidy ups perhaps? Didn't see > anything obvious when I looked at the logind related commits however. > > v187 is fine. I am aware of at least one breakage due to the clean-up. The reexec dbus call has special semantics since reexecing causes the bus connection to be terminated without a response, and the special client side handling of the reexec is hence gone, but all other stuff does work fine here. Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] List all available units
On Thu, 09.08.12 09:39, Václav Pavlín (vpav...@redhat.com) wrote: > > If we present the user with a list like this we probably should show a > > tree view of some kind since the unit file getty@.service might get > > instantiated a couple of times as "getty@tty1.service" and so on, and > > hence is in a tree-like relationship. > > I like the idea of the tree view, but I cannot imagine how it can help > to solve autocompletion problem. If I get it right, getty@.service is > template file, which cannot be manually instantiated, so it can be > omitted from the output (User cannot do anything with it, right?). On > the other hand, getty@tty1.service is an instance, which can be stopped, > restarted etc., and it will be listed in list-units output (and then in > merged output of new systemctl verb as well). OK, so, let's focus on the auto completion thing for noiw, and maybe revisit later if we want to have an additional verb to provide users with the "full" list of services and service files. I'd suggest implementing a new verb "complete" or so, that would work like this: systemctl complete enable foo invoking this would simply output a new-line separated lists of all unit files which can be enabled (i.e. excluding static ones, and so on) that begin with "foo". systemctl complete status would output the list of loaded units *and* files. Since only two params are specified it would show all those units/files, wouldn't do any prefix matching. And similar for the other commands. Then, we could update the completion logic for bash to just invoke the right call. I hope this makes sense? systemctl complete should probably be considered a hidden feature, so not show up in --help or in the man page. Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 1/2] shutdown: recursively mark root as private before pivot
Because root is now recursively marked as shared on bootup, we need to
recursively mark root as private. This prevents a pivot_root failure on
shutdown:
Cannot finalize remaining file systems and devices, giving up.
pivot failed: Invalid argument
---
src/core/shutdown.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/core/shutdown.c b/src/core/shutdown.c
index 105a604..0b7cbd8 100644
--- a/src/core/shutdown.c
+++ b/src/core/shutdown.c
@@ -109,7 +109,7 @@ static int pivot_to_new_root(void) {
It works for pivot_root, but the ref count for the root device
is not decreasing :-/
*/
-if (mount(NULL, "/", NULL, MS_PRIVATE, NULL) < 0) {
+if (mount(NULL, "/", NULL, MS_REC|MS_PRIVATE, NULL) < 0) {
log_error("Failed to make \"/\" private mount %m");
return -errno;
}
--
1.7.11.4
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH 2/2] shared/utf8: mark char* as const
Avoids compiler warning:
src/shared/utf8.c: In function 'ascii_filter':
src/shared/utf8.c:278:16: warning: assignment discards 'const' qualifier
from pointer target type [enabled by default]
---
src/shared/utf8.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/shared/utf8.c b/src/shared/utf8.c
index ea7483f..5f9f3c6 100644
--- a/src/shared/utf8.c
+++ b/src/shared/utf8.c
@@ -265,7 +265,8 @@ char *ascii_is_valid(const char *str) {
}
char *ascii_filter(const char *str) {
-char *r, *s, *d;
+const char *s;
+char *r, *d;
size_t l;
assert(str);
--
1.7.11.4
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH 2/2] shared/utf8: mark char* as const
On Fri, 10.08.12 11:02, Dave Reisner (dreis...@archlinux.org) wrote: > Avoids compiler warning: > > src/shared/utf8.c: In function 'ascii_filter': > src/shared/utf8.c:278:16: warning: assignment discards 'const' qualifier > from pointer target type [enabled by default] Applied both, even though we should get the kernelk fixed for good regarding that MS_SHARED issue. Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
