Re: [systemd-devel] [PATCH] hostnamed: add chassis type robot

[Noé RUBINSTEIN]

Yes,

In our use case (and prolly likewise in a lot of embedded use cases) there
is another layer that provides more info on what kind of robot it is.

So we are not using this variable for anything other than setting it right
now, and embedded sounds good indeed.

Thanks,
Noé.

2014-11-06 14:39 GMT+01:00 Lennart Poettering lenn...@poettering.net:

 On Thu, 06.11.14 14:34, Lennart Poettering (lenn...@poettering.net) wrote:

  On Thu, 06.11.14 06:34, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl)
 wrote:
 
   On Wed, Nov 05, 2014 at 06:40:51PM +0100, Noé Rubinstein wrote:
---
 man/hostnamectl.xml   | 3 ++-
 man/machine-info.xml  | 3 ++-
 shell-completion/bash/hostnamectl | 2 +-
 shell-completion/zsh/_hostnamectl | 2 +-
 src/hostname/hostnamed.c  | 3 ++-
 5 files changed, 8 insertions(+), 5 deletions(-)
   
diff --git a/man/hostnamectl.xml b/man/hostnamectl.xml
index 128d92f..0292bad 100644
--- a/man/hostnamectl.xml
+++ b/man/hostnamectl.xml
@@ -217,7 +217,8 @@
 literalserver/literal,
 literaltablet/literal,
 literalhandset/literal,
-literalwatch/literal, as well as
+literalwatch/literal,
+literalrobot/literal, as well as
 the special chassis types
 literalvm/literal and
 literalcontainer/literal for
  
   This is a nice fun patch. But I'm a bit concerned where this is
 going...
   Soon we'll have to add fridge, car, aircraft, ISS, extraterrestial
   rover, etc., since systmed is being used everywhere. I know that it's
   rather mundane, but would other work for you instead?
 
  Hmm, maybe embedded would be a good idea, to cover all those
  aircraft, ISS, car, fridge, robot things?

 I have added that now, to cut this short. Noé, does this work for you?

 Thanks,

 Lennart

 --
 Lennart Poettering, Red Hat
 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] hostnamed: add chassis type robot

[Noé Rubinstein]

---
 man/hostnamectl.xml   | 3 ++-
 man/machine-info.xml  | 3 ++-
 shell-completion/bash/hostnamectl | 2 +-
 shell-completion/zsh/_hostnamectl | 2 +-
 src/hostname/hostnamed.c  | 3 ++-
 5 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/man/hostnamectl.xml b/man/hostnamectl.xml
index 128d92f..0292bad 100644
--- a/man/hostnamectl.xml
+++ b/man/hostnamectl.xml
@@ -217,7 +217,8 @@
 literalserver/literal,
 literaltablet/literal,
 literalhandset/literal,
-literalwatch/literal, as well as
+literalwatch/literal,
+literalrobot/literal, as well as
 the special chassis types
 literalvm/literal and
 literalcontainer/literal for
diff --git a/man/machine-info.xml b/man/machine-info.xml
index c654daa..da728c1 100644
--- a/man/machine-info.xml
+++ b/man/machine-info.xml
@@ -139,7 +139,8 @@
 literalserver/literal,
 literaltablet/literal,
literalhandset/literal,
-   literalwatch/literal, as well as
+   literalwatch/literal,
+   literalrobot/literal, as well as
 the special chassis types
 literalvm/literal and
 literalcontainer/literal for
diff --git a/shell-completion/bash/hostnamectl 
b/shell-completion/bash/hostnamectl
index a5e3460..28fa42f 100644
--- a/shell-completion/bash/hostnamectl
+++ b/shell-completion/bash/hostnamectl
@@ -52,7 +52,7 @@ _hostnamectl() {
 if [[ -z $verb ]]; then
 comps=${VERBS[*]}
 elif __contains_word $verb ${VERBS[CHASSIS]}; then
-comps='desktop laptop server tablet handset watch vm container'
+comps='desktop laptop server tablet handset watch robot vm 
container'
 elif __contains_word $verb ${VERBS[STANDALONE]} ${VERBS[ICONS]} 
${VERBS[NAME]}; then
 comps=''
 fi
diff --git a/shell-completion/zsh/_hostnamectl 
b/shell-completion/zsh/_hostnamectl
index e02f6de..6b610b8 100644
--- a/shell-completion/zsh/_hostnamectl
+++ b/shell-completion/zsh/_hostnamectl
@@ -18,7 +18,7 @@ _hostnamectl_set-icon-name() {
 
 _hostnamectl_set-chassis() {
 if (( CURRENT = 3 )); then
-_chassis=( desktop laptop server tablet handset watch vm container )
+_chassis=( desktop laptop server tablet handset watch robot vm 
container )
 _describe chassis _chassis
 else
 _message no more options
diff --git a/src/hostname/hostnamed.c b/src/hostname/hostnamed.c
index a449610..cc8f48b 100644
--- a/src/hostname/hostnamed.c
+++ b/src/hostname/hostnamed.c
@@ -138,7 +138,8 @@ static bool valid_chassis(const char *chassis) {
 server\0
 tablet\0
 handset\0
-watch\0,
+watch\0
+robot\0,
 chassis);
 }
 
-- 
2.1.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel